Commit Graph

19237 Commits

Author SHA1 Message Date
Sander Steffann
a71ea964b6 Fix IPv6 in service check host (#13939)
* Add hostName cleaning to Clean

* Apply RFC 5952 formatting to Clean::hostName output

* Use more liberal cleaning for hostnames

* Remove unwanted whitespace

* Apply Clean::hostName() to all relevant fields

* Fix docstring

* Use IP::isValid inline

* Update Clean.php

* Update services.inc.php

Co-authored-by: Tony Murray <murraytony@gmail.com>
2022-04-22 10:09:45 -05:00
Tony Murray
15feac7297 Bump version to 22.4.0 2022-04-21 21:13:47 -05:00
Tony Murray
67a7aa932f Changelog for 22.4.0 2022-04-21 21:13:46 -05:00
Tony Murray
6ad5fdada5
Validate fixes (#13935)
* Fix version check abort when something goes wrong

* more generic message when failing to parse ajax
2022-04-20 23:10:36 -05:00
Tony Murray
8b82341cb7
Fix services command injection (#13932)
* fix services command injection

* Clean more variables

* Update services.inc.php

* Update services.inc.php
2022-04-20 21:32:36 -05:00
p4k8
3d0e095eb7
Ukrainian translation update (#13933)
* Ukrainian translation update

* whitespace fixes

Co-authored-by: Tony Murray <murraytony@gmail.com>
2022-04-20 21:23:25 -05:00
Tony Murray
cc6112b8fb
fix graylog xss (#13931) 2022-04-20 01:10:02 +02:00
Tony Murray
9c126572a2
Fix validation page (#13929)
* Validation web page fixes

* Validation web page fixes

* update baseline
2022-04-17 08:38:16 -05:00
Tony Murray
6410775bd5
Fix STP polling bug (#13924)
Column 'topChanges' cannot be null (SQL: update `stp` set `topChanges` ...
2022-04-15 19:33:49 -05:00
Fehler12
b093d8bd25
Remove non-working Dell specific alert rules from the collection (#13706)
* Removed non-working rules and conditions

Removed non-working Dell alert rules and removed constraints fo state_sensor_warning in order to make this rule working

* Update alert_rules.json

* Update alert_rules.json

Co-authored-by: Tony Murray <murraytony@gmail.com>
2022-04-15 16:59:59 -05:00
Tony Murray
849fa21ea0
Revert "Fiberstore Network Management Unit (#13813)" (#13925)
This reverts commit c5502789b9.
2022-04-15 12:22:36 -05:00
Jonathan J Davis
c5502789b9
Fiberstore Network Management Unit (#13813)
* FS OAP OEO and EDFA mibs

* definitions and discovery yaml

* current dbm state temperature and voltage updates

* update on poller and discovery modules

* test data

* removing unneeded pollers and discovery modules as requested

* update to os test data

test data now reflects fs-nmu details instead of module details as module may not be present at previous oid or module may not be present at all in the device

* OS update and Test Date Updates

* channels numbers

* removal of default true poller and discovery modules

* reintroduced previous OEO module data

* StyleCI fixes

* Update fs-nmu.inc.php

* Update fs-nmu.inc.php

* Update fs-nmu.inc.php

* Update fs-nmu.inc.php

* Update fs-nmu.inc.php

Co-authored-by: Neil Lathwood <gh+n@laf.io>
2022-04-15 10:30:41 -05:00
Tony Murray
4ccd6d3937
Handle bad uptime input (#13899)
* Handle bad uptime input
devices returning non-numeric strings or strings with garbage would cause an exception before

* Update Core.php

* Update Core.php
2022-04-15 10:19:54 -05:00
Simon Smith
68b49a0df1
support tplink routers (#13922)
* support tplink TD-W routers

* use sysDescr_regex instead

* Create tplink_dsl

* Rename tplink_dsl to tplink_dsl.snmprec

* add test tplink td-w9970

Co-authored-by: Tony Murray <murraytony@gmail.com>
2022-04-15 08:08:00 -05:00
Tony Murray
f024ce5405
Improve alert template saving (#13910)
Instead of checking if the result is empty to see if the template parses, just catch exceptions.
2022-04-14 18:29:29 +02:00
Tony Murray
0a84098211
Port Validation Page to Laravel (#13921)
* Revamp validate web page
 to load page then validate, instead of validate then load page

* style fixes

* lint cleanups

* fixes

* translations and a couple fixes

* style fixes

* move result serialization into the class.
2022-04-14 11:22:40 -05:00
ottorei
e495769f17
Add ISIS-details to alert details (#13920)
* Add ISIS-details to alert details

* Apply fixes from StyleCI

Co-authored-by: StyleCI Bot <bot@styleci.io>
2022-04-14 00:36:13 -05:00
Tony Murray
ac089745bc
lnms device:add handle snmp.community bad format (#13914)
handle badly formated snmp.community input.  Some may be a string or not an array of strings.  wrap the single string and discard the array of strings items.
2022-04-13 14:29:00 +02:00
TheMysteriousX
95aaa31dd9
Sensu: Correct type hint (#13915)
* Correct type annotation

Not 100% sure this is correct as I don't know what the previous change was trying to correct - but they're definitely not all strings.

* Correct the correction
2022-04-13 14:25:56 +02:00
Tony Murray
92354e0a12
Better device:add error output (#13913)
* Better device:add error output

* for addhost.php too
2022-04-12 22:07:01 -05:00
Tony Murray
5d0670cdf6
Fix port mini graphs (#13911)
* Fix port mini graphs

* fix whitespace

* taller
2022-04-12 16:30:22 -05:00
Tony Murray
10a25d709f
Fix Hytera error (#13909)
Divide by Zero
2022-04-12 08:27:31 -05:00
Santiago Z
02b5ef797b
Docs, fix code block in oxidized group (#13908) 2022-04-12 09:18:48 +02:00
Neil Lathwood
36ba278d1c
Added missing test files for Dell PowerVault ME4024 (#13884)
* Added missing test files for Dell PowerVault ME4024

* Updated files

* reverted yaml file

* Updated yaml file

* reverted yaml file

* Updated json test file

* Update dell-powervault_me4024.json

Co-authored-by: Tony Murray <murraytony@gmail.com>
2022-04-11 22:34:10 +01:00
Dan Kerse
128286a40b
PrimeKey Improvements (#13901)
* Use OID names for indexing

* Fewer, (mostly) longer walks

* Use bulkwalk
2022-04-11 22:25:20 +01:00
Santiago Z
712ba23657
[DOC] Fix Code blocks Step 2 Installing Network-WeatherMap (#13905) 2022-04-11 09:40:25 +02:00
Tony Murray
c8606aab6b
Fix install icons (#13904) 2022-04-09 15:05:09 -05:00
Tony Murray
acdf51deca
Print full error message in poller/discovery output (#13903)
It was previously missing the file and line number the error occurred on.  Only showing the error message and stack trace before.
2022-04-09 14:21:10 -05:00
William Irvine
5672d10a79
Add ISIS discovery and polling for iosxe devices (#13880)
* Add ISIS discovery and polling for iosxe devices

* remove ModuleModelObserver

* add php stan exclusions as they are already present for the base module

* change port_id to cached lookup

* Create model object instead of using arrays and set properties directly

* remove unneeded space...

* remove null from non nullable field

* revert to extending from ciscowlc rather than os

* remove OS module

* remove phpstan exclusions and fix errors

* add spacing...

* add spacing....

* add spacing

* again...

* Add tests

* Update Iosxe.php

* Update IsisAdjacency.php

* Create 2022_04_08_085504_isis_adjacencies_table_add_index.php

* Update db_schema.yaml

* Update iosxe_asr920.json

* Update Iosxe.php

* Update Iosxe.php

* Update junos_mx5t_isis.json

Co-authored-by: Tony Murray <murraytony@gmail.com>
2022-04-08 16:33:41 -05:00
Cliff Albert
4910761c25
Add MRV OptiDriver support in gen_rancid (#13900) 2022-04-08 13:37:20 +02:00
Dan Kerse
b33bbd472e
Add support for PrimeKey Hardware Appliance (#13806)
* Add support for PrimeKey Hardware Appliance

https://doc.primekey.com/ejbca-appliance
https://doc.primekey.com/signserver-appliance

https://doc.primekey.com/ejbca-appliance/operations/webconf-configurator-of-hardware-appliance/monitoring

* Correct off-by-one error for Galera states

* Add load multiplier

* Don't poll transaction ID, it's too messy

* Tabs -> spaces

* Don't modify system load. (Is this a %age or not?)

* CUP moves Load -> Count

* CPU moves Load -> Count

* Now I have MiBs. Attempts to use them are to date unsuccessful

* Removed numeric oids entirely

I'm not sure how easy it will be to conver this to YAML.

* Formatting

* More formatting

* Numeric it is

* Fix States

* Numeric oids

* Shorten Descriptions

* Add DB threshold

* Percent -> Yaml

* Temperature -> Yaml. Relaxed num_oid validation

* Fanspeed -> Yaml

* Volgate -> Yaml

* Count -> Yaml

* State -> Yaml

* Tweak snmp_flags

* minimize icon

* Check if first_word function is required

* Incorporate feedback

Co-authored-by: Tony Murray <murraytony@gmail.com>
2022-04-08 06:23:00 -05:00
Tony Murray
686a27f680
Fix custom error messages (#13898)
* Fix custom error messages
Laravel apparently wraps things in ViewException now and so does ignition.  Ideally, we would plug in the same way as ignition, but just fix the old code for now.

* Don't break the ViewException handling if we can't upgrade
2022-04-07 21:08:43 -05:00
James
b3019f7944
Enhancements for Zyxel OS (#13897)
* Add DBm and State Sensors

Added extra MIB files
Added Dbm levels on ports
Added Stacking State Sensors

* Added include for zynos.inc.php

File patch - includes/discovery/ports/zynos.inc.php

* Create ZYXEL-STACKING-MIB

Official Zyxel MIB

* Create ZYXEL-TRANSCEIVER-MIB

Official Zyxel MIB

* Added test file zynos_xgs4600.json

* Create zynos snmprec test file

* CENSORED zynos_xgs4600.json

* Created new polling file for Zynos ports

Converts zynos SWP port style to be 1/1 style

* Created new discovery for Zynos ports

Changes zynos SWP ports to be 1/1 style during discovery

* Fixing ci complaints in discovery/ports/zynos.inc.php

* Fixing ci complaints in polling/ports/os/zynos.inc.php

* fixing more ci complaints in discovery

* Updated Zynos.snmprec

* Updated zynos.json

* Updated zynos.json

* Removed ifDescr pre-cache

* Removed pre-cache from zynos.yaml

* Reverted zynos.snmprec

* Restored zynos.json

* Updated zynos polling to use zeropad

* Updated zynos discovery to use zeropad

* Updated zynos.yaml

Updated zynos.yaml to include ifname: true to change port names and added '/^ZyXEL/' to sysDescr_regex

* Update zynos.inc.php

* Update zynos.inc.php

* Update zynos_xgs4600.json

* Update zynos_xgs4600.snmprec

* Re-Generated Zynos.json

* Fixed ifOperStatus in Zynos.json

* Delete zynos.inc.php

* Update ports.inc.php

* Added new test data

* Updated zyxel test data and discovery

* Update ports.inc.php

* Update zynos.snmprec

* Updated zynos.json

* Update Zynos.json

* Fix StyleCI issues

* Update zynos.json

* Update zynos.json

* Update zynos.json

* Updated zynos mgs3712.json

* Update zynos_mgs3712.json

* Added back old SFP discovery

-SFP Temperature
-SFP Voltage
2022-04-07 20:49:03 -05:00
Tony Murray
75ba74fe5b
Migrate addhost.php to lnms device:add (#13870)
* Migrate addhost.php to lnms device:add
Have snmp-scan.py call lnms device:add (make exit codes line up so this works)
Fix issue with ping only devices trying to detect os via snmp
Reorder options in device:add help and improve formatting
Update docs to remove references to addhost.php
Fix a bit of code that was in functional code

* fixes

* fix snmp version message
2022-04-04 10:41:18 -05:00
Pierfrancesco Passerini
96b708a10e
Few more language (ITA) updates (#13890)
* Update it.json

Removed all  \'/  single quote, very common in italian , to avoid problem on page loading

* Update it.json

small fix

* Update it.json

Small updates

* Update it.json

* Add files via upload

* Delete modules.php

* Delete syslog.php

* Delete install.php

* Add files via upload

* Update plugins.php

* Update validation.php
2022-04-04 12:38:13 +02:00
Mark Westerterp
971404f416
Added "Ping Response" graph to "Ping Only" Device Overview page (#13886)
* Add Ping performance to Device Overview page

Only if device type is "Ping Only"

* Re-use $perf_url
2022-04-03 14:15:23 +01:00
James French
7e5641d4fe
Replaced OpenWRT icon with new logo (#13891)
* Added new OpenWRT icon to replace old logo

* New logo has an icon usable without text per look & feel of LibreNMS
* Compatible with OpenWRT usage guidelines refer:
    https://openwrt.org/docs/guide-graphic-designer/openwrt-logo

* Update openwrt.svg

Co-authored-by: Neil Lathwood <gh+n@laf.io>
2022-04-03 14:10:27 +01:00
Claude Brown
958556dc18
Ensure 'add_device' API returns indexed-array (as per documented behaviour) (#13887) 2022-04-03 14:03:03 +01:00
Santiago Z
bd1b0d1929
Stylize the word .env in documentation (#13889) 2022-04-03 14:01:41 +01:00
Andy Norwood
5c53f2984f
Added Cisco Err-Disable interface event trap handler (#13855)
* Add Cisco Err Disable Mib

* Add new trap handler class

* Add ErrDisabled event handler

* Add ErrDisalbed event test

* remove unused line

* no ifindex message change

* Update unknown ifIndex message

* Add bad IfIndex test

* update description text

* style fixes

* change param to True for toString

* Add return type to test function

* style fix

* remove toString() and explode()

* remove unused line
2022-04-01 21:02:51 +01:00
geg347
ef12e5f980
Added Basic authentication capability to Alertmanager Transport (#13867)
* Adding Basic authentication capability to Alertmanager's Transport

* Fix PHPStan linting error

* Fix StyleCI error

* Fix StyleCI error part 2
2022-03-31 21:45:44 +01:00
Mark Jeffery
ac11177beb
Fix for PFSense state table removals field (#13863) 2022-03-31 15:50:14 +02:00
Lucas Dousse
427438a08f
remove fixed size for vendor column (#13881)
* remove fix size for column mac adresse

* remove fix size for column mac adresse in port arp tab
2022-03-31 15:43:29 +02:00
Neil Lathwood
d2ef957fa8
Added support for Dell PowerVault ME4024 (#13883) 2022-03-31 15:41:52 +02:00
Tony Murray
6214157e9b
Docs, fix Linux SNMP example only listening on ::1 (#13882) 2022-03-30 22:24:21 +01:00
dependabot[bot]
1dde13a9aa
Bump guzzlehttp/psr7 from 2.1.0 to 2.2.1 (#13879)
Bumps [guzzlehttp/psr7](https://github.com/guzzle/psr7) from 2.1.0 to 2.2.1.
- [Release notes](https://github.com/guzzle/psr7/releases)
- [Changelog](https://github.com/guzzle/psr7/blob/master/CHANGELOG.md)
- [Commits](https://github.com/guzzle/psr7/compare/2.1.0...2.2.1)

---
updated-dependencies:
- dependency-name: guzzlehttp/psr7
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-03-30 09:55:12 +02:00
lucalo72
43232f30e2
Add support for Riello NetMan 204 (#13878)
Added support to Riello device oid .1.3.6.1.4.1.5491.314 NetMan 204
2022-03-29 18:31:40 +02:00
Fehler12
cc7345d54a
Fix usw flex switch hardware detection (#13877)
* Fixeed Hardware and Versiondetection for US-8 and USW-Switches with Version 5

It seems that the same model and same firmware version respond with different SNMP-records, depending on Hardware revision. This should be more general

* removed "linux" from version string in some cases

Changed regex for better version isolation and updated test data

* Update edgeswitch.yaml

Corrected the edgeswitch Test-Version detection. It seems that there are 4 cases :(:

USW GigaBit Ethernet Switch, firmware 5.76.7.13442
US-8, 5.76.7.13442, Linux 3.6.5
USW-Flex 5.76.7.13442
EdgeSwitch 24-Port 250W, 1.0.1.4720839, Linux 3.6.5-f4a26ed5

* Removed false change. Changed 8XP test data

Removed false change. Changed 8XP test data

* ' -> "

' -> "
2022-03-27 22:50:20 +02:00
ottorei
51a8646825
Bump jpgraph version to 4 (#13875)
* Bump jpgraph version to 4

* Update composer lock-file
2022-03-26 11:48:02 +01:00
Fehler12
9785522d13
Added Polycom Lens SNMP support. (#13876)
Added Polycom Lens SNMP support.
2022-03-25 23:54:06 +01:00