Commit Graph

19237 Commits

Author SHA1 Message Date
Jellyfrog
681c994ca1
Docs tweaking (#13792)
* Tweak updating page

* Cleanup docs
2022-02-16 02:43:48 +01:00
Jellyfrog
7c99599b2a
Set default DB_TEST_PORT (#13793) 2022-02-16 02:43:11 +01:00
Peca Nesovanovic
700c6ae9c3
[pbn] dropped dbfetch from discovery/sensors (#13789) 2022-02-15 22:39:23 +01:00
Peca Nesovanovic
8b831f5c6f
[junos] dropped dbfetch from discovery/sensors (#13784)
* [junos] dropped dbfetch from discovery/sensors

* ci
2022-02-14 23:06:34 +01:00
Knut Petter Ølberg
3926f1aaff
Update Switching.md (#13786)
Fix typo in example
2022-02-14 23:05:20 +01:00
PipoCanaja
f24bb42cb2
Hide community and make it XSS safer (#13783)
* sanitize message display

* sanitize message display

* safe display of community, and community hidden until focus occurs
2022-02-14 13:03:01 +00:00
Guilherme Poletto
18ca4566eb
New sensors for huawei vrp <tested on NE8000 platform> (#13352)
* Add EntityVoltage Sensors

* Add BoardPower Sensors

* Add Fanspeed Percent sensor

* Add Voltage_Status and Temperature_Status Normal|Minor|Major|Critical indicators, and internal Voltage and Temperature sensors

* set Minor alarm violations to warning status

* remove inconsistently applied empty lines between sections, and trailing newline that caused errors

* fetch thresholds for temperature.sensors and optical.RxPower from SNMP

* Added snmp testfiles for ne8000-m8 variant of VRP platform

* group sensors by card-identifier

* Regenerate testfiles for 5720-32x-ei

* Regenerate testfiles for the whole VRP family

* Optical Bias is reported as miliamps-mA, and not microamps-uA

* Implement divisor detection, VRP or NE8 prepended on sensor for debug-testing

* remove VRP or NE8 prependeds on sensors(put there for debug/testing only)

* use parent OIDs for walking and naming

* ignore per-slot power if unsupported

* regenerated snmp json testfiles

* sanitize bgp-peers value

* restore vrp.json test

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2022-02-14 10:05:18 +01:00
Neil Lathwood
95970af78e
Moved some pages to be within admin route (#13782)
* Moved plugin admin pages to be within admin route
* Wrap html transports page in admin check
* Moved Port group controller to be admin protected
* fixed tests
2022-02-14 08:40:30 +01:00
PipoCanaja
4c9d4eefd8
XSS fixes (#13780) 2022-02-13 20:54:58 +00:00
PipoCanaja
41ddce6377
XSS fix, cont. again (#13778)
* XSS in alert template creation

* XSS in alert rule name

* XSS in service name & desc

* style

* strip_tags in alert_notes

* strip_tags in create_alert_item

* strip_tags in addsrv page
2022-02-13 20:23:07 +01:00
Peca Nesovanovic
0029e9f161
[refactor] Eloquent for includes/html/pages/device/health.inc.php (#13777)
* [rewrite] includes/html/pages/device/health.inc.php
* translate sensor names
* ci
2022-02-13 19:20:47 +01:00
PipoCanaja
4f86915866
XSS fix, cont. (#13776)
https://huntr.dev/bounties/13951f51-deed-4a3d-8275-52306cc5a87d/
2022-02-13 19:07:37 +01:00
PipoCanaja
3ac0de16b2
STP - various fixes (#13773)
* Filter fix
* Add link to device for bridge address and designated root if available
2022-02-13 19:04:12 +01:00
dependabot[bot]
3fb4233c05
Bump follow-redirects from 1.14.7 to 1.14.8 (#13774)
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.7...v1.14.8)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-02-13 11:48:15 +01:00
PipoCanaja
135717a9a0
security - XSS Fix 01
fixing https://huntr.dev/bounties/114ba055-a2f0-4db9-aafb-95df944ba177/ (#13775)
2022-02-13 11:00:56 +01:00
Peca Nesovanovic
c7b63b574f
[widget] Top Devices (#13748)
* count only UP ports

* ci
2022-02-12 23:39:17 +01:00
Heath Barnhart
978cd75a32
SNMP Traps: Brocade login traps (#13770)
* initial push

* Some modifications for unit tests
2022-02-12 16:42:28 +01:00
Jellyfrog
67c68b5965
Bump test timeout to 2 hours (#13769) 2022-02-11 09:10:33 -06:00
Tony Murray
7f63737567
add missing icons for progressive web app notifications (#13771) 2022-02-11 16:06:20 +01:00
Tony Murray
b9f3646a2e
STP fix, only try contexts on Cisco (#13767)
* STP fix, only try contexts on Cisco
Only Cisco is known to support this type of polling

* merge, not push.

* Fix collection construction

* Fixed the function signature in Interface def

* fixed signature here as well

* Lighter code to return a collection of Stp instances

* Type enforced in signatures

* missing implement for Cisco Class

* style

* Collection methods are immutable indeed 😠

* nullable vlan

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2022-02-11 08:37:19 -06:00
Santiago Z
7d2ade71f1
[WebUI] Show selected selection option on graphs page (#13765) 2022-02-11 11:06:41 +01:00
Jellyfrog
af98992f9c
Upgrade to font awesome 6 (#13760) 2022-02-10 20:33:42 +01:00
flo
a49ee59c06
Fix links to connected devices in old style maps (#13762)
When using the old style maps when you click on one of the connected
devices (bubbles on the right side) the link points to
$HOSTNAME//device... looking at other examples base_url seems to
include the trailing slash. Removing the additional slash fixes the
links for me.
2022-02-10 00:41:47 +01:00
Jellyfrog
b9e55bc462
Upgrade to font awesome 5 (#13754)
* Upgrade to font awesome 5

* Update memory icon
2022-02-09 00:49:07 +01:00
Jellyfrog
f93f8a02e6
Add better default sensor alert template (#13703) 2022-02-08 23:18:13 +00:00
Jellyfrog
8f474dd4d4
Rework documentation (#13709)
* Rework documentation

* Slightly adjust theme

* wip

* fixes

* Remove unneeded header

* Re-added Acknowledgement.md file

* Added Acknowledgement.md to mkdocs.yml

Co-authored-by: Neil Lathwood <gh+n@laf.io>
2022-02-08 23:02:28 +00:00
Peca Nesovanovic
ee00f59ce6
[terra] support for sdi410c / sdi480 (#13759)
* [terra] support for sdi410c / sdi480

* remove debug
2022-02-08 23:27:40 +01:00
SourceDoctor
28567e1cf0
rename DHCP Stats to ISC DHCP Stats (#13756)
* rename DHCP Stats to ISC DHCP Stats

* .
2022-02-08 11:51:30 +01:00
Martin22
e88e53d1b0
Racom Ray: Added BER (#13758) 2022-02-08 11:32:49 +01:00
Heath Barnhart
a71feb1636
SNMP Traps: APC Overload Traps (#13726)
* push apc trap handlers

* added unit test

* removed CR and fixed test

* switch cr for lf

* fixing ci complaints

* fixing another ci error

* fixed unit test

* annotating test
2022-02-08 11:37:11 +02:00
Jellyfrog
f8fba91b83
Fixed settings array initial value (#13755) 2022-02-07 22:18:42 +00:00
Simon Smith
b2f8a53cab
Update install instructions to add pip3 package (#13746)
* Update Install-LibreNMS.md

include pip3

* Update Install-LibreNMS.md
2022-02-07 22:17:51 +00:00
Santiago Z
2e35844056
[WebUI] Show selected option of devices-graphs-select in Mono theme (#13752) 2022-02-06 23:13:27 +01:00
Tony Murray
d829dd4db8
Poll log poll complete (#13733)
* device:poll log poll complete
A bit awkward because it is info, but the default file log level is error, so log at alert level, but put "INFO" in the message to not alarm users.

* fix style
2022-02-06 21:56:51 +00:00
dfitton
722de2ebe5
Update dark.css to improve visibility (#13749)
Fixed certain colours to make them more readable against the dark background. Mainly the blue colour against the dark background I have changed to a lighter blue.
Some dark greys and blacks as well.
2022-02-04 15:35:51 +01:00
ilGino
58c88a6db3
[WebUI] Removing colon symbol from multiple dialogs (#13742)
* [WebUI] Removing the colon symbol from dialogs

In order to make multiple pages more visually consistent with other pages in the system, removed the colon simbol ":" to the very right of each control description, where present.

Regards
GG

* Update new_alert_rule.inc.php

* Update alert_schedule.inc.php

* Update alert_template.inc.php
2022-02-03 15:51:51 +01:00
Santiago Z
71bb7bd82f
[DOC] validate-config-icon better positioning in the text (#13744) 2022-02-03 11:30:46 +01:00
Neil Lathwood
e3bba1e53d
Added system temperature support including state (#13743) 2022-02-03 11:29:34 +01:00
Jellyfrog
fdebee86b4
Implement system for user packages in composer (#13718) 2022-02-02 17:33:23 +01:00
Tony Murray
2dcc70301c
Fix < 0 exception in ports poller (#13732) 2022-02-02 17:31:54 +01:00
Fehler12
6263a15315
Lenovo think station Support (#13617)
* Add initial support for Lenovo ThinkStation server

* Initial Support for Lenovo ThinkStation Server - detection rules

* Lenovo ThinkStation MMIB Files

* Added test data for Lenovo ThinkStation

Model SR250

* trying unit test fix

trying to correct unit test failures

* Revert "trying unit test fix"

This reverts commit 7f44689e8a.

* Create lenovoXClarityIMPI_lenovoxcc.snmprec

Added snmprec

* Update lenovoXClarityIMPI.yaml

Removed Null-Value (over) in yaml

* Update lenovoXClarityIMPI.yaml

Fixed typo

* Update lenovoXClarityIMPI.yaml

Fixed another typo in os yaml

* Update lenovoXClarityIMPI.yaml

Added {{ $index }} and removed skip_values

* Update lenovoXClarityIMPI.yaml

Added index in yaml

* Update lenovoXClarityIMPI.yaml

* Update lenovoXClarityIMPI_lenovoxcc.json

* Update lenovoXClarityIMPI_lenovoxcc.json

* Updated detection rule

Removed N/A skip, removed unecessary state_name.

Removed $index in oid, because otherwise the detection fails for some reason
Excluded num_oid because otherwise the poller fails to detect the values.

* Code improvements and test data

I've implemented what I've learned from my Fujitsu pull:
- added test data
- corrected MIB file names and folder

* Code improvements

Removed an empty array and two empty lines.

* Code improvements

* Delete LENOVO-SMI-MIB DEFINITIONS

This file is named wrong and we already have `LENOVO-SMI-MIB` so looks to be duplicated

* Changed OS name

Changed OS name

* Fixed test data for os name change

* Update LENOVO-PRODUCTS-MIB

Reupdated Lenovo-Products-MIB to 2017er Version

Co-authored-by: Neil Lathwood <gh+n@laf.io>
2022-02-02 07:53:32 -06:00
Jellyfrog
0da545740e
Use better filesystem functions (#13735)
* Use better filesystem functions

* Update DeviceObserver.php

* Update DeviceObserver.php

Co-authored-by: Tony Murray <murraytony@gmail.com>
2022-02-02 07:40:45 -06:00
Santiago Z
b93a892feb
[WebUI] Added the word Actions in the header of the oxidized-nodes table (#13741) 2022-02-02 02:07:35 +01:00
Peca Nesovanovic
a3bd1b9a69
[mikrotik] added ipv6 route discovery (#13737)
* [mikrotik] added ipv6 route discovery

* ci
2022-01-31 18:00:30 +01:00
PipoCanaja
c67850c782
doc - Typo in FAQ (#13736) 2022-01-31 15:06:42 +01:00
Tony Murray
29bd6789cb
Stp module rewrite (#13570)
* STP module rewrite WIP

* Finish rewrite

* Ignore disabled and log root/topology changes

* Remove interfaces for now

* fix style

* Lint fixes

* Document ResolvesPortIds and hide map functions

* whitespace fixes

* Revert to stpInstances in case someone writes mstp support

* missed one

* phpstan fixes

* Handle table and oids separately

* forgot to register observer

* Test data and correct non-table handling in SnmpResponse->table()

* update test

* test data

* revert aos7 silly things

* minimal polling

* Update test data

* order ports_ntp and rename new field to port_index

* forgot the db_schema

* revert ciena-sds port things

* MSTP support, maybe

* Adding test data

* Filter bad lines instead of discarding the entire snmp response
and capture fixes and test data

* fresh data

* add os data

* update data, ignore unfound ports, obviously bad device implementation.

* fixes

* Ignore context files in os detection test

* Remove empty table data

* add ciena-sds vlan

* designatedCost column is too small

* Update stp webui

* Refactor code to interfaces, to allow vendor mibs

* update schema

* fix issues added by abstraction

* STP fixes

* Default to no context for vlan 1

* never store vlan 1

* Update test data

* remove eltex brokenness

* fix style

* fix stan

* Fix Rewrite MAC to Hex padding with floats

* fix sqlite migration
2022-01-30 16:28:18 -06:00
Wheel
2dbfdda717
Ubiquiti Airfiber60 (#13680)
* Add ubiquiti Airfiber 60

* New AF60 data and MIB

* Stylci fix and small additions

* Update test data

* Stylefix

* Remove the weird ubiquity oids containing encoded mac addresses

* Updated test data

* Remove more complex sensors for now to be added after the conflict airos airos-af60 is solved

* Fix hardware and OS

* To be verified is this is the most practical / clean way of doing it

* Advanced wireless and MCS state sensor

* Fix link capacity multiplier and active link

* Test data update fix lint

* Maybe better
2022-01-29 21:10:45 -06:00
Tony Murray
b6a8b602b8
Oxidized update and Device remove (#13730)
* Oxidized + Device remove
Was just working on oxidized, but then to properly update nodes after delete, updated delete_device()

* revert dumb style changes

* baseline update and no DI there...

* Fix OS first load and device deletion missing tables
2022-01-29 21:09:05 -06:00
Tony Murray
29ff20d7eb
UBNT fixed airos temp in 8.7.7 (#13731)
* UBNT fixed airos temp in 8.7.7
restrict workaround to only versions 8.7.4-8.7.6
fixes: #13655

* remove extra character
2022-01-30 02:04:03 +01:00
Konstantin
e628bf5237
Added Volius (#13723) 2022-01-29 14:52:05 +01:00