Commit Graph

18952 Commits

Author SHA1 Message Date
Tony Murray
790c4b3402
Configurable device display name (#13528)
* Configurable device display name
You can just set the display name in device settings.

It also accepts simple template format with  the variables: hostname, sysName, sysName_fallback, ip

Default controlled by device_display_default, (set from old force_hostname_to_sysname and force_ip_to_sysname settings

* remove second argument to format_hostname()

* Style fixes

* Update schema

* update phpstan baseline

* Improved settings strings (and add for translation)
2021-11-18 15:46:22 -06:00
Tony Murray
69d0753ec4
lnms snmp:fetch query multiple devices (#13538)
* lnms snmp:fetch query multiple devices
Allows regex and all device spec input

* Fix lint

* fix regexp
2021-11-18 15:35:19 -06:00
Tony Murray
f12d1f98cb
Arista EOS, use sysObjectID for detection (to include vEOS) (#13534)
Also, simplify regex
2021-11-18 09:28:47 +01:00
Tony Murray
c79b187d72
Poller rewrite (Try 2) (#13525)
* core WIP

* try to finish up

* trim space too
and a couple of cleanups

* update test data

* put escapes back

* another net-snmp difference

* correct copy paste error

* WIP

* Use new code YAY

* a tiny bit more

* Kind of working

* Handle manual modules correctly

* convert core to modern module

* Only save metrics if modules is not overridden

* correct module exists check

* database error handling

* debug handling

* restore bad changes

* Introduce Actions
 RunAlertRulesAction
 UpdateDeviceGroupsAction

* tweaks to output

* Fix some issues in outside code

* Style fixes

* fixes to module status checks

* typehints!

* Use logger only and DI

* OS module not named correctly

* Work on quiet output a bit more

* generically don't change output when disabling debug if the driver is already stack

* Fix missing $device variable for legacy os polling
Fix missing dbFacile functions when no legacy modules polled in RunAlertRulesAction

* restore legacy os module shim

* use the new poller code for tests

* PollingDevice event

* Fix some issues and enable/disable error reporting around legacy modules

* typehints

* fully update baseline

* Use Process for version commands so we don't leak debug output.

* don't detect rrdtool version in ci every time

* style fixes

* Warning fixes

* more fixes

* re-update baseline

* remove diff noise

* fix up alerts

* Catch exceptions in device ip lookup

* Revert accidental snmp.inc.php poller target change
(should have been ?: not ??)
2021-11-17 19:23:55 -06:00
Tony Murray
7893b8bebe
OSPF issue when devices don't support OSPF-MIB::ospfIfTable (#13530)
* OSPF devices return wrong ospfIfTable index

* Handle "End of MIB" string
2021-11-17 16:26:50 -06:00
Tony Murray
c05a7a57a0
Remove unused buggy arp_discovery code (#13529) 2021-11-17 22:10:54 +01:00
Tony Murray
562af58c7f
Fix plugin_active check when plugin is not found (#13531)
* Fix plugin_active check when plugin is not found

* update baseline

* revert incorrect commit
2021-11-17 22:08:56 +01:00
Tony Murray
31c9d9c307
Link for can't check Python dependencies validation (#13520)
* Link for can't check Python dependencies validation
Hopefully gives the user some direction

* Fix style
2021-11-17 17:23:37 +01:00
Tony Murray
2f478d04cb
Oxidized: elaborate on feeding Oxidized (#13514) 2021-11-17 15:31:37 +01:00
hjcday
6d3382b1c4
RUTX fix sensor limits (#13526)
* fix sensor limits

* test data

* test data fixes

* try fix rut360 json
2021-11-17 15:30:54 +01:00
Tony Murray
f8764ddcb5
Revert "Poller command rewrite (#13414)" (#13524)
This reverts commit 1752d1efd4.
2021-11-16 21:40:29 -06:00
Tony Murray
1752d1efd4
Poller command rewrite (#13414)
* core WIP

* try to finish up

* trim space too
and a couple of cleanups

* update test data

* put escapes back

* another net-snmp difference

* correct copy paste error

* WIP

* Use new code YAY

* a tiny bit more

* Kind of working

* Handle manual modules correctly

* convert core to modern module

* Only save metrics if modules is not overridden

* correct module exists check

* database error handling

* debug handling

* restore bad changes

* Introduce Actions
 RunAlertRulesAction
 UpdateDeviceGroupsAction

* tweaks to output

* Fix some issues in outside code

* Style fixes

* fixes to module status checks

* typehints!

* Use logger only and DI

* OS module not named correctly

* Work on quiet output a bit more

* generically don't change output when disabling debug if the driver is already stack

* Fix missing $device variable for legacy os polling
Fix missing dbFacile functions when no legacy modules polled in RunAlertRulesAction

* restore legacy os module shim

* use the new poller code for tests

* PollingDevice event

* Fix some issues and enable/disable error reporting around legacy modules

* typehints

* fully update baseline

* Use Process for version commands so we don't leak debug output.

* don't detect rrdtool version in ci every time

* style fixes

* Warning fixes

* more fixes

* re-update baseline

* remove diff noise

* fix up alerts
2021-11-16 16:59:46 -06:00
djamp42
c61ccf5c48
Change text to show alert termplate msg (#13521)
In the initial pull request this was brought up but never addressed, https://github.com/librenms/librenms/pull/9305#issuecomment-427930650  The only reason i can think of is due to SMS message length, but you could be mindful of that with a alert template.  Submitting this to see if anyone objects to changing it.
2021-11-16 17:48:01 +01:00
Tony Murray
b6240254b4
Billing fix a couple divide by zero errors (#13517)
* Billing fix a couple divide by zero errors
In probably an ocean.

* add missing space
2021-11-15 10:31:52 +01:00
PipoCanaja
193535871f
Allow LegacyPlugin Pages to receive all parameters (#13519) 2021-11-15 09:30:50 +01:00
Tony Murray
7e98e03338
Polling cleanup, fix PHP warnings (#13460)
* Fix warnings up to Arbos

* fixes a-c

* a-r

* a-vrp

* There and back again

* Update test data, couple fixes

* PHPSStan fixes

* style fixes, and fix Asyncos, whoops

* flip serial back.......

* less bogus data

* Poweralert sysName during polling too

* make sure things are calculated in the correct order

* fix style and bad nullables

* update test data

* A comple more conversions

* cambium ptp, misc, and hardware_mib

* remaining except vmware-esxi

* Fixes

* Update baseline

* fixes and fix up baseline

* adjust SnmpQueryMock to upstream options change

* data corrections

* restore slashes

* correctly handle all options input in SnmpQueryMock

* undo ftos changes

* restore vccodec sysDescr
2021-11-14 14:58:13 -06:00
Tony Murray
bef021b158
Default session lifetime 24 days
32bit is the reason we can't have nice things.
2021-11-14 08:01:57 -06:00
Jellyfrog
d409643d68
Revert "Increase session lifetime to one month (#13505)" (#13515)
This reverts commit 8ccf72ffdd.
2021-11-14 14:15:45 +01:00
A. Manual Goldstein
4d79ffe3bb
PHP8 compatibility for ntp-server polling app (#13513)
It appears that the ntp-server application script uses an undefined constant when initializing its data array. The use of undefined constants previously generated a warning, and since PHP 8.0 generates an error instead.
2021-11-13 17:20:30 +01:00
pepperoni-pi
4b572b9b31
Added migration file to change cpwVcID to unsigned integer (#13510) 2021-11-12 14:15:50 -06:00
Tony Murray
0adf37b4e1
OSPF port module (#13498)
* OSPF to module

* Update mock

* lint and style fixes

* enums as strings
2021-11-12 13:49:09 -06:00
Tony Murray
666638eeaa
Fix bad snmp context option (#13497)
* Fix bad snmp context option
Just port queries to SnmpQuery and remove bad code to prevent new usages

* Allow unordered

* add stub on Mock
2021-11-12 12:40:37 -06:00
Tony Murray
6b41c29f5f Bump version to 21.11.0 2021-11-12 11:03:39 -06:00
Tony Murray
4c948691be Changelog for 21.11.0 2021-11-12 11:03:28 -06:00
martinberg
20da6eedd9
Add support for Teltonika RUT360 (#13375)
* Init work on rutos-3xx

* Add RUT360 support in rutos-rutx

* Testdata

* Removed old files

* Removed unused pre-caching

* Undo changes to mib

* Modified rutx11 test data

* Changed state_name

* Revert "Changed state_name"

This reverts commit fb61f8df67.

* Changed state_name

* Changed state_name

* Changed state_name and hopefully fixes tests

* Changed rutx11 test data

* Changed state_name back

* Revert

* Fixed state_name to avoid collision

* Updated rut360 test data

* Modified rutx11 test data

* Fixed typo

* Updated test data for rutx11
2021-11-12 10:43:06 -06:00
Jonathan Smith
5b7aff1995
Update apc.inc.php (#13506)
Fixed the OID for the non HighPrec Load, which should be 4.2.3.
2021-11-12 10:37:17 -06:00
RobJE
97340c5fd5
add missing graph definition for pf_matches (pfSense firewall) (#13507)
* add missing graph definition for pf_matches (pfSense firewall)

* update unit_text
2021-11-12 10:35:54 -06:00
Tony Murray
3fe083eed6
Fix PyMySQL upstream dependency bug (#13508)
PyMySQL 1.0.0 requires Python 3.6, but they did not specify that in their setup files.
Block that version so we don't break users on Python 3.5.  (Also, please update your Python)
2021-11-12 09:58:17 -06:00
Tony Murray
8ccf72ffdd
Increase session lifetime to one month (#13505)
Because we know authenticate cookies, remember me is tied to the session lifetime now in addition to the cookie lifetime. Increase the lifetime to one month instead of two hours.
2021-11-12 09:32:58 -06:00
Lee Keitel
19217e8dfc
Fix maintenance mode button in Firefox (#13500) 2021-11-12 08:22:57 -06:00
Maikel de Boer
f1e768a4ae
Nokia SAR HMC (#13503)
* Added wireless MSE

* Add SAR HMC support

* add test data

* cleanup

* fixed style
2021-11-12 07:18:56 -06:00
Tony Murray
0f8862a747
Attempt to fix dispatcher stats thread exception (#13478)
* Attempt to fix dispatcher stats thread exception

* catch both exceptions

* Make it work when redis module does not exist

* fix style
2021-11-11 22:20:36 -06:00
Daniel Romero
ef4654d304
Support for PDUMNV30HVLX with PADM 20 (#13473)
* Test 4 for PowerAlert - TRIPPLITE PDUMNV30HVLX

* Modifying poweralert_3

* Remove test 4

* Delete duplicate sensors
2021-11-11 23:26:07 +01:00
PipoCanaja
29f1cb53ab
Added TOS support for fping (#13496)
* TOS support for fping in LibreNMS/Data/Source/Fping.php

* TOS support for fping in app/Jobs/PingCheck.php

* Doc

* Improve doc
2021-11-11 22:33:01 +01:00
Jellyfrog
18992df7b0
Bump psutil=>5.6.0 to satifsy command_runner (#13501) 2021-11-11 20:52:27 +01:00
TheGreatDoc
63b174595f
SNMP Trap handler: UpsTrapOnBattery (#13482)
* SNMP Trap handler: upsTrapOnBattery

* Forgot to add the config

* Fixed handler name

* Fix test
2021-11-11 10:08:36 -06:00
Tony Murray
06701870cd
Change how options are handled for SnmpQuery (#13488)
* Change how options are handled for SnmpQuery
Fix added backslashes when collecting snmp data.

* fix lint
2021-11-10 20:49:06 -06:00
Tony Murray
15632bb875
Fix net-snmp unformatted strings (#13486)
* Fix net-snmp unformatted strings
When net-snmp returns an unformatted string (with quotes around it), it also has backslashes to escape certain characters.  Remove those.

* Clean up sysDescr and sysName when setting to Device model.

* Lint fixes

* Hmm, additional formatting spots
2021-11-10 20:48:22 -06:00
Deltawings
905918f2e5
Update Applications.md (#13495)
Adding a line telling how to configure the snmp extend for MySQL
2021-11-10 23:39:37 +01:00
Federico Cuello
5aa69d3250
Update Ports.md (#13493)
Fix ports_with_associated_mac output block (missing closing)
2021-11-10 19:23:21 +01:00
Orsiris de Jong
e57ec782f4
Install new python dependencies during daily maintenance (#13186)
* Improve check_requirements script to dynamically read requirements.txt

* Don't dynamically load requirements for python2

* Make sure we check python3 dependencies with python3 binary

* Quote variable to fix SC2086

* Add dynamic_check_requirements.py

* Use dynamic_check_requirements.py for python3

* Revert "Don't dynamically load requirements for python2"

This reverts commit 4485c8fcf9e0075fcf212e4f8bbc59ed75e144b5.

* Revert "Improve check_requirements script to dynamically read requirements.txt"

This reverts commit a9c83350d9de6b1b3b0a313dca23af749a08300a.

* Add LIBRENMS_DIR variable to exec, check for permission errors

* Make sure we check for permission errors on pip install

* Fix shellcheck SC2046 missing quotations

* Make sure we install pip packages as librenms user for Python3

* revert daily.sh, update dependencies in composer

* And in the validation

* should be executable

Co-authored-by: Tony Murray <murraytony@gmail.com>
2021-11-10 10:38:50 -06:00
Maikel de Boer
c37a5ad61e
Ciena 2 (#13491)
* Added wireless MSE

* new test data + small tweak in the Ciena support

* removed files

* removed files

* bit more tweaking

* test data
2021-11-10 15:23:53 +01:00
Tony Murray
6b9482aa43
Only call htmlentities on port ifAlias,ifName, and ifDescr (#13489)
Allows more accurate display
2021-11-09 22:06:32 +01:00
Peca Nesovanovic
9f2de7d605
Added initial IPv6 Address discovery for TP-LINK Jetstream (#13484)
* Added initial IPv6 Address discovery for TP-LINK Jetstream

* styleci cleanup

* styleci cleanup

* styleci cleanup

* split OS specific code in separate file

* styleci cleanup
2021-11-09 20:40:48 +01:00
Tony Murray
3fbe1c9aa1
Merchandise shop link in about (#13485) 2021-11-09 20:37:42 +01:00
PipoCanaja
9eb3950546
[bug] Fix & extend MAC OUI table updates (#13479)
* get the OUIs from Wireshark CSV instead of macaddress.io which is not free anymore

* style

* optimize

* master wireshark repo

* fix Cache::get prefix ordering

* fix double cache get

Co-authored-by: Tony Murray <murraytony@gmail.com>

Co-authored-by: Tony Murray <murraytony@gmail.com>
2021-11-09 07:47:38 -06:00
Tony Murray
1ff48018fa
Fix slack errors when variables are not set (#13476) 2021-11-05 22:30:30 -05:00
Tony Murray
e7a26e8faf
Tweak new notification appearance (#13477) 2021-11-05 22:20:00 -05:00
Denny Friebe
f23c5c0e7b
Raspberry Pi: Add SNMP extend to monitor IO pins or sensor modules connected to the GPIO header (#12749)
* Raspberry Pi: Add SNMP extend to monitor IO pins or sensor modules connected to the GPIO header

* Raspberry Pi: Add new test data

* Raspberry Pi: Make styleci happy

* Raspberry Pi: Fix some more style issues

* Raspberry Pi: Use d_echo for array debug

* Raspberry Pi: Prevent processing if the extension is not present

* Raspberry Pi: Make styleci happy

* Raspberry Pi: Update test data

* Raspberry Pi: Remove debugging
2021-11-04 21:38:15 -05:00
Tony Murray
90e2570d38
Fix SnmpQuery mibdir from os group (#13475) 2021-11-04 22:58:36 +01:00