Commit Graph

20933 Commits

Author SHA1 Message Date
Tony Murray
3da691277a
Sensor: Only post to eventlog when specific columns change (#16370) 2024-09-06 20:49:56 -05:00
Tony Murray
f54e38f4fe
More cisco state fixes (#16369)
* More cisco state fixes
Turns out it was fetching values as strings.  Swap to SnmpQuery and fetch the data numeric as expected

* Apply fixes from StyleCI

* update MIB too

---------

Co-authored-by: Tony Murray <murrant@users.noreply.github.com>
2024-09-06 18:49:55 -05:00
Ervin S.
81d6eb57e6
device - infortrend - add temperature sensor (#16316)
* Adding support to Infortrend DS3016

* Adding snmprec for Infortrend DS3016

* Delete tests/snmpsim/DS_3016.snmprec

* change of the infortrend logo

* change of the infortrend logo

* add the infortrend logo

* Delete tests/snmpsim/infortrend_test.snmprec

* again another logo replacment

* again another logo replacment

* again another logo replacment

* update yaml file to display sensor state

* Delete includes/definitions/discovery/infortrend_orig

* typo missed the . at start of oid

* change logo based on req. from PipoCanaja

* on req of PipoCanaja to fix the structure of the folder

* replacing the logo as req. from PipoCanaja

* adding temperature sensor and serial number

* improving sensors

* removed wrongly added chars

* removed MIB from wrong place

* Murrant's request for snmprec file

* adding Voltage sensor monitoring

* Skipped the value that are irrelevant. Yay!

* Update .gitignore

* Fix infortrend.yaml

* Create infortrend_ds3016.json

* fix infortrend.yaml

* Update infortrend_ds3016.json

* Update infortrend.yaml

* Update infortrend_ds3016.json

---------

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2024-09-06 14:22:31 -05:00
Tony Murray
674bb7e9f8
save-test-data.php improvements (#16367)
* save-test-data.php improvements
Message when snmprec data is not found
Output when venv setup fails

* Apply fixes from StyleCI

---------

Co-authored-by: Tony Murray <murrant@users.noreply.github.com>
2024-09-06 13:28:23 -05:00
Tony Murray
fc9b77c672
Availability calculations, handle bad data (#16368)
* Availability calculations, handle bad data
Add some unit tests as well

* whitespace
2024-09-06 13:27:39 -05:00
Andy Norwood
0ae58d1883
Fix ignore check for F5 component polling and Web UI (#16329)
* Update f5-ltm.inc.php

Remove filter for ignore = 0

* Update f5-ltm-currconns.inc.php

Remove filter for ignore = 0

* Update f5-gtm.inc.php

Remove filter for ignore = 0

* Update ltm_vs.inc.php

Change component filter from 'ignore' to 'disabled'

* Update ltm_pool.inc.php

Change component filter from 'ignore' to 'disabled'

* Update ltm_bwc.inc.php

Change component filter from 'ignore' to 'disabled'

* Update gtm_wide.inc.php

Change component filter from 'ignore' to 'disabled'

* Update f5-cert.inc.php

Change component filter from 'ignore' to 'disabled'

* Update gtm_pool.inc.php

Change component filter from 'ignore' to 'disabled'
2024-09-06 10:50:13 -05:00
Tony Murray
0b9312a77a
Fix some issues with cisco entity sensors (#16365) 2024-09-06 10:46:52 -05:00
jayceeemperador
2ba6f164f2
Cisco C9800 Wireless Controller AP Count Support (#16342)
* Update CISCO-LWAPP-TC-MIB

Uploaded latest version from Cisco Feature Navigator

From the original Cisco MIB:
Deleted duplicate END in line 868
Change the names “dot11_6ghz” and “dot11_xor_5_6ghz” by removing the underscore (example: “dot11-6ghz” “dot11-xor-5-6ghz”)

* Update Iosxe.php

Added Wireless Controller module

* Update iosxe.yaml

Added AP count and Wireless Client

Credit to @AllanHahn

* Create iosxewlc.yaml

Added IOS-XE WLC. Need to add sysObjectID for the future devices beyond WLC9800.

System description has IOS-XE in it

* Update iosxe.yaml

* Update iosxe.yaml

WLC 9800 not included, have own YAML file

* Create iosxewlc.php

* Update Iosxe.php

Remove WLC Module

* Rename iosxewlc.php to Iosxewlc.php

* C9800 WLC detection

* Update iosxewlc.yaml

* Remove CiscoWLC notes

* Remove ISIS

* Update Iosxewlc.php

* Fix syntax

* Remove Cisco WLC notes

Need some cleanup since already created new PHP file for Cisco IOS-XE WLC

* Update Iosxewlc.php

* Update CISCO-LWAPP-AP-MIB

Downloaded the latest from Cisco MIBS to support AP count for Cisco WLC C9800 models.

* Update Copyright

* Change type from network to wireless

* Patterned with AirOS Cisco WLC

* Create iosxewlc_c9800.snmprec

Added test file

* styleci compliance

* styleci compliance

* styleci compliance

* Uploaded data from actual device

* styleci compliance

* styleci compliance - remove space

* Merge iosxe and iosxewlc 

As discussed

* Merhe iosxewlc.yaml to iosxe.yaml

No over graphs for Number of Clients and AP Count or IOSXE WLCs but still can view via Tabs

* remove iosxewlc.yaml

Covered by iosxe.yaml

* Delete iosxewlc.php

Covered by iosxe.php

* Rename iosxewlc_c9800.snmprec to iosxe_c9800.snmprec

due to removal of iosxewlc template which was merged.

* styleci compliance

* styleci compliance

* Update iosxe_c9800.snmprec

* Update iosxe_c9800.snmprec

* rerun-tests

* Remove pollOS block from Iosxe

* Check before polling and add additional IP discovery

* lint fix

* Added raw data from actual device

Convert sensitive data to <private>

* Create iosxe_c9800.json

---------

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
Co-authored-by: Tony Murray <murraytony@gmail.com>
2024-09-06 10:36:44 -05:00
Tony Murray
c561efdc8f
Fix sensor custom limits being reverted (#16364) 2024-09-05 20:07:30 -05:00
Steve Calvário
40b629011f
Fix alert -1 count (#16359) 2024-09-04 16:04:06 -05:00
Tony Murray
8aab71a947
Fix phpstan ignore (#16360) 2024-09-04 15:58:50 -05:00
Tony Murray
40d0f68e3a
Add full python dependencies to Ubuntu 22.04 and 24.04 install docs (#16354) 2024-09-04 09:55:39 -05:00
Tony Murray
dc2f70592b
Fix rrd show command (#16357)
buildCommand needs to be public access for show command, reverted to protected because I thought it was only for tests, and that doesn't require it to be public anymore.
2024-09-04 09:53:04 -05:00
Tony Murray
f15f8fa63a
Sensors remove reliance on global variable (#16344)
* Sensors remove reliance on global variable

* Apply fixes from StyleCI

* Clear the instance instead of reset.
Remove $valid['sensors'] from docs

---------

Co-authored-by: Tony Murray <murrant@users.noreply.github.com>
2024-09-03 21:04:34 -05:00
makriska
4efad1ae69
Fix handling of zero value for entSensorThresholdValue for dbm cisco sensor (#16336)
* add handling of zero value for entSensorThresholdValue for dbm sensor type

this addresses https://github.com/librenms/librenms/issues/16335
* Update cisco-entity-sensor.inc.php
* safe check for $key['entSensorThresholdValue']
* style
---------

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2024-09-03 21:39:05 +02:00
Tony Murray
f89ed301d7
Improve Rrd datastore test (#16353)
* Improve Rrd datastore test
Don't start rrdtool process to test buildCommand

* lint fixes
2024-09-03 13:18:38 -05:00
Tony Murray
cc22a74503
Remove global $var access functions (#16345)
* Proxmox remove global access functions

* Apply fixes from StyleCI

---------

Co-authored-by: Tony Murray <murrant@users.noreply.github.com>
2024-09-03 19:41:13 +02:00
Tony Murray
c6cac9d90b
Fix bad health sensor labels in the ui (#16350) 2024-09-03 11:49:47 -05:00
Steve Calvário
4fd528c95d
Update RRDCached Tune version (#16352) 2024-09-03 17:05:59 +02:00
Tony Murray
03d3660dfa
Fix Cisco entity-sensor (#16351)
* Fix Cisco entity-sensor
make mw_to_dbm and uw_to_dbm handle negative numbers

* fixes and update test data
2024-09-03 09:02:02 -05:00
Tony Murray
d8097b0c21
awplus sensor fixes (#16348)
* awplus sensor fixes

* Update test data
2024-09-02 22:26:02 -05:00
Tony Murray
64c0d6ff7f
Ignore entity-sensor invalid values (#16347) 2024-09-02 21:44:29 -05:00
eskyuu
0cbf37ef86
Updated ping command to explicitly use sync when dispatching job (#16346) 2024-09-02 20:45:57 -05:00
Tony Murray
b096ff86fc
OcNOS Add AS7712-32X port mapping (#16332)
Fix walking ifName multiple times
Add EdgeCore test data
2024-09-02 11:43:34 -05:00
Jellyfrog
58ccccce29
use the already installed chromedriver (#16341) 2024-09-02 09:36:41 -05:00
dependabot[bot]
32993a37d9
Bump webpack from 5.91.0 to 5.94.0 (#16338)
Bumps [webpack](https://github.com/webpack/webpack) from 5.91.0 to 5.94.0.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](https://github.com/webpack/webpack/compare/v5.91.0...v5.94.0)

---
updated-dependencies:
- dependency-name: webpack
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-01 13:01:13 +02:00
mehdiMj
02a40ebfd5
feat: add Ubuntu 24.04 installation method (#16334) 2024-08-30 08:11:27 -05:00
Justin Lentz
cdc360dcdb
Use Device Displayname for AlertRules (#16322)
* Use Displayname for AlertRules

---------

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2024-08-28 21:35:20 +02:00
Tony Murray
7b767dd7cc
Fix setting the device wrong field in module tests (#16296) 2024-08-27 17:03:41 -05:00
Gilles Depeyrot
e10443864d
Fix commit 'Update styles.css (#16138)' which disaligns Leaflet Awesome marker icons (#16321) 2024-08-27 16:58:56 -05:00
Steve Calvário
a961323113
Fix numeric value out of range for _rate (#16325)
* Fix numeric value out of range for _rate

* Fix style
2024-08-27 22:15:33 +02:00
Tony Murray
9e4b2fa3a3
Reject API device_add that are missing snmp info (#16314) 2024-08-27 07:08:19 -05:00
Tony Murray
3e3d09bb26
OcNOS Inventory support (#16320)
* IP Infusion OcNOS inventory

* Hide strings that say item is missing
Handle more sfp ethernet types

* Add Edgecore models AS5912 & AS7316 port mapping

* Test data

* Apply fixes from StyleCI

---------

Co-authored-by: Tony Murray <murrant@users.noreply.github.com>
2024-08-27 07:06:47 -05:00
Tony Murray
e875461846
cli show string enums in snmp commands (#16317) 2024-08-26 23:06:25 -05:00
PipoCanaja
61ad4bfbbf
Plugins v2 cleanup (#16298)
* cleanup

* use Illuminate\Support\Facades\Auth;

* style

* add route:cache and revert

* add route:cache and revert

* fix   in pluginExample

* fix Example plugin

* style

* fix other Hooks with Illuminate\Contracts\Auth\Authenticatable

* style

* whitespace

* whitespace2

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2024-08-26 19:45:12 +02:00
MarlinMr
a412845b22
VisJS: fix link (#16315) 2024-08-26 15:57:21 +02:00
Tony Murray
db5fdf705d
Poll device job (#16306)
* Split out single device polling to a Laravel Job
Probably totally broken :)

* Add dispatch option to device:poll

* Fix up submodules

* Add missing logger parameter

* Apply fixes from StyleCI

* Update module format in test helper

* Apply fixes from StyleCI

* Use Log facade to match other code

---------

Co-authored-by: Tony Murray <murrant@users.noreply.github.com>
2024-08-25 19:56:50 -05:00
PipoCanaja
2face4bc4a
bug - Component "error" length issue (#15918)
* truncate component error in F5 LTM code

* sanity check in COmponent

* style

* mutators

* mutators moved

* moving

* Mutators OK, removing check from F5

* style

* fix LibreNMS/Component.php

* remove protected and see if it fixes issues

* nullable

* nullable

* nullable
2024-08-25 16:32:59 -05:00
Tony Murray
3dd4084404
Replace echo with Log calls in OS code (#16310) 2024-08-22 17:23:09 +02:00
Tony Murray
89d70bd48e
Fix alert detail count missing (try2) (#16309) 2024-08-21 21:41:22 -05:00
Tony Murray
35967dc98d
Remove CIMC custom inventory code (#16305)
No test data and it is too complex and strange to update without data.
If someone wants to update and re-submit it, they are welcome to.
2024-08-21 12:24:30 +02:00
Tony Murray
3c67de2311
Fix misc Cisco polling errors (#16307)
* Fix misc Cisco polling errors

* Apply fixes from StyleCI

---------

Co-authored-by: Tony Murray <murrant@users.noreply.github.com>
2024-08-21 12:22:37 +02:00
Tony Murray
46396a9393
Remove echo from modern modules (#16308)
* Remove echo from modern modules
Still used many other places, further PRs will follow

* Apply fixes from StyleCI

---------

Co-authored-by: Tony Murray <murrant@users.noreply.github.com>
2024-08-21 12:20:45 +02:00
Simon Wüllhorst
d2df5ac9d7
Updated nvidia poller app: handle slightly changed nvidia-smi output formatting properly (#16158) 2024-08-21 01:28:18 -05:00
Zane C. Bowers-Hadley
7b98721e32
Poudriere support (#16229)
* add the poller

* save text status stuff

* add initial app page stuff

* add history table and start work on graphs

* checkpoint

* re-work the poudriere graph bits a bit more

* fix the poller and start work on the graphs

* polling fix

* more work on the poudriere stuff

* poke stuff with php-cs-fix

* add some more graphs

* more style fixes

* another style fix

* add more graphs

* add Poudriere docs

* add tests data

* some minor tests fixes

* a test tweak

* more test tweaks

* some more test tweaks

* tweak .data.build_info data .data.build_info to make the app data test saner

* derp... missed a item

* add app data
2024-08-21 01:27:26 -05:00
PipoCanaja
7aeb540e5a
Bug - VRP - fix OutOfRange QueryException + missing key (#16290)
* fix OutOfRange QueryException

* move up

* missing key

* another

* another
2024-08-21 01:26:48 -05:00
Tony Murray
9d35fbc6a7
Entity Physical discovery: Rewrite to modern style (#16289)
* Initial entity-physical code

* Split out Entity-MIB trait

* Cisco Cellular inventory

* Fix bad test data

* alfo80hd - we now include all entPhysical entries

* Correct aos7 test data

* Add entPhysicalClass as last resort for label in ui

* aos add previously filtered data

* Fixup arista-eos data

* Update ariast_eos data

* Arris, clean garbage in Rev fields

* Aruba Instant custom inventory ported

* ArubaOS CX add vendor type mib

* aviat-wtm test data refresh

* axos add shelf fix data fields a bit

* ciena-rls

* ciena-sds

* Skip cimc for now... no test data

* Cisco updates

* Comware data update

* Update dnos

* Clean Edgeos garbage, make code from Arris shareable

* Relaxed ifIndex match, some devices cheat and send back static strings instead of formatted OIDs

* Regex refinement and updated edgeos with new clean data

* Update edgeswitch data

* Update eltex-mes21xx data

* eltex-mes23xx

* Guess at eltex-mes24xx since there is no test data

* Update eurostor, fix firmware version

* Apply fixes from StyleCI

* fixes

* Update fortigate data

* Update fortiweb, ftd, and fusion

* Update linux LSI

* Fix hexToAscii null removal with different seperator handling

* icotera add final snmprec data to avoid snmpsim bug

* Update IOS data

* Update mrv-od

* Add junos translation

* Generic data updates n-r

* ruijie workaround snmpsim bug

* Port saf-cfm

* Recode Schleifenbauer, and fix entPhysicalIndex values

* SmartAX fixes

* sm-os and tait-infra93

* timos inventory was not right, fix it up

* ubiquoss-pon

* VRP, has custom data collection on top of normal
adapt port ifIndex lookup to handle it

* VRP exceeded the string length specified in ENTITY-MIB...

* data updates

* Final data update and code cleanup

* Apply fixes from StyleCI

* Lint fixes

* Add missing SnmpResponse->pluck() code

* Update db_schema.yaml

* Fix bad test data

* Another instant-on update

* oops

* Remove some unused code

# Conflicts:
#	includes/html/pages/device/overview.inc.php

---------

Co-authored-by: Tony Murray <murrant@users.noreply.github.com>
2024-08-21 01:12:09 -05:00
Tony Murray
343a979f5c
Remove c3kxbar (#16304)
it is very old and there is no test data for it
Could be easily added back if someone still uses it
2024-08-20 09:01:07 -05:00
Tony Murray
39ca9eb25c
Fix sodium_compat 32bit (#16303)
Fix upstream stupidity.  They required 32bit in 2.0.0, but didn't mark it then released 2.0.1 to fix that, but didn't pull 2.0.0.
Add explicit requirement for <2.0 to avoid the whole mess for now.  But that means we'll have to fix it down the road again.
2024-08-20 01:33:52 -05:00
Tony Murray
5748ada02d
Allow syslog hooks to be set by lnms config:set (#16302)
Also allow --ignore-checks to work for os settings
2024-08-19 19:52:49 +02:00