From edcf84f77fa66ca3707d6258136dd56e63a4f7e2 Mon Sep 17 00:00:00 2001 From: d Date: Sun, 24 Mar 2024 00:37:08 +0100 Subject: [PATCH] codefactor.io cleaning --- src/downloadcty.h | 3 +-- src/inputwidgets/mainwindowinputcomment.h | 1 - src/inputwidgets/mainwindowinputeqsl.h | 3 +-- src/inputwidgets/mainwindowinputqsl.h | 1 + src/inputwidgets/mainwindowmydatatab.h | 1 + src/inputwidgets/mainwindowsattab.h | 1 + src/locator.h | 5 ++--- src/setuppages/hamlibnetworkconfigwidget.h | 1 + src/setuppages/setupentitydialog.h | 2 -- src/setuppages/setuppagebandmode.h | 2 +- src/setuppages/setuppagecolors.h | 2 -- src/setuppages/setuppagedxcluster.h | 1 - src/setuppages/setuppagehamlib.h | 1 + src/setuppages/setuppagelogsnew.h | 1 - src/setuppages/setuppagelogview.h | 1 + src/setuppages/setuppagemisc.h | 1 - src/setuppages/setuppagesats.h | 3 --- src/setuppages/setuppagesatsnew.h | 1 - src/setuppages/setuppagesubdivisionnew.h | 1 - src/setuppages/setuppagesubdivisions.h | 2 -- src/setuppages/setuppageworldeditor.h | 1 - src/startwizard.h | 4 ---- 22 files changed, 11 insertions(+), 28 deletions(-) diff --git a/src/downloadcty.h b/src/downloadcty.h index 42c65027..2a92dea8 100644 --- a/src/downloadcty.h +++ b/src/downloadcty.h @@ -43,6 +43,7 @@ class QSslError; class DownLoadCTY : public QObject { Q_OBJECT + public: explicit DownLoadCTY(const QString &_klogDir, const QString &_klogVersion); ~DownLoadCTY(); @@ -70,8 +71,6 @@ private slots: void slotDownloadProgress(qint64 received, qint64 total); void slotErrorManagement(QNetworkReply::NetworkError networkError); - - signals: void actionReturnDownload(const int _i); void done(bool _success); diff --git a/src/inputwidgets/mainwindowinputcomment.h b/src/inputwidgets/mainwindowinputcomment.h index 2c94b14f..993de190 100644 --- a/src/inputwidgets/mainwindowinputcomment.h +++ b/src/inputwidgets/mainwindowinputcomment.h @@ -49,7 +49,6 @@ private: QString comment; QLineEdit *commentLineEdit; QCheckBox *keepThisDataForNextQSOQCheckbox; - }; #endif // MAINWINDOWINPUTCOMMENT_H diff --git a/src/inputwidgets/mainwindowinputeqsl.h b/src/inputwidgets/mainwindowinputeqsl.h index e9cd6731..0e9e8be1 100644 --- a/src/inputwidgets/mainwindowinputeqsl.h +++ b/src/inputwidgets/mainwindowinputeqsl.h @@ -37,6 +37,7 @@ class MainWindowInputEQSL : public QWidget { Q_OBJECT + public: explicit MainWindowInputEQSL(DataProxy_SQLite *dp, QWidget *parent = nullptr); ~MainWindowInputEQSL(); @@ -76,7 +77,6 @@ public: void setQueueSentByDefault(const bool _b); - signals: private slots: @@ -100,7 +100,6 @@ private: QStringList qslSentStatusList, qslRcvdStatusList, clubLogStatusList; bool queueSentByDefault; - }; #endif // MAINWINDOWINPUTEQSL_H diff --git a/src/inputwidgets/mainwindowinputqsl.h b/src/inputwidgets/mainwindowinputqsl.h index 3cbc547c..ec29d861 100644 --- a/src/inputwidgets/mainwindowinputqsl.h +++ b/src/inputwidgets/mainwindowinputqsl.h @@ -38,6 +38,7 @@ class MainWindowInputQSL : public QWidget { Q_OBJECT + public: explicit MainWindowInputQSL(DataProxy_SQLite *dp, QWidget *parent = nullptr); ~MainWindowInputQSL(); diff --git a/src/inputwidgets/mainwindowmydatatab.h b/src/inputwidgets/mainwindowmydatatab.h index 541b0425..970b4661 100644 --- a/src/inputwidgets/mainwindowmydatatab.h +++ b/src/inputwidgets/mainwindowmydatatab.h @@ -41,6 +41,7 @@ class MainWindowMyDataTab : public QWidget { Q_OBJECT + public: explicit MainWindowMyDataTab(DataProxy_SQLite *dp, QWidget *parent = nullptr); ~MainWindowMyDataTab(); diff --git a/src/inputwidgets/mainwindowsattab.h b/src/inputwidgets/mainwindowsattab.h index 10caf54f..a6589517 100644 --- a/src/inputwidgets/mainwindowsattab.h +++ b/src/inputwidgets/mainwindowsattab.h @@ -39,6 +39,7 @@ class MainWindowSatTab : public QWidget { Q_OBJECT friend class tst_MainWindowSatTab; + public: explicit MainWindowSatTab(DataProxy_SQLite *dp, QWidget *parent = nullptr); ~MainWindowSatTab(); diff --git a/src/locator.h b/src/locator.h index 2ccf81ef..e0f02541 100644 --- a/src/locator.h +++ b/src/locator.h @@ -39,9 +39,8 @@ const double RADIAN = 180.0/PI; const double DEG_TO_RAD = PI/180.0; const double KM_IN_A_MILE = 1.609344; - - -class Locator{ +class Locator +{ public: Locator(); diff --git a/src/setuppages/hamlibnetworkconfigwidget.h b/src/setuppages/hamlibnetworkconfigwidget.h index c9218030..19eb4e73 100644 --- a/src/setuppages/hamlibnetworkconfigwidget.h +++ b/src/setuppages/hamlibnetworkconfigwidget.h @@ -8,6 +8,7 @@ class HamLibNetworkConfigWidget : public QWidget { Q_OBJECT + public: explicit HamLibNetworkConfigWidget(QWidget *parent = nullptr); void createUI(); diff --git a/src/setuppages/setupentitydialog.h b/src/setuppages/setupentitydialog.h index 1f5682cd..ad729c2e 100644 --- a/src/setuppages/setupentitydialog.h +++ b/src/setuppages/setupentitydialog.h @@ -61,7 +61,6 @@ private slots: void slotCheckDeletedDate(); void slotCheckPrefixes(); - signals: void entityAdded(const QStringList _qs); // entity @@ -93,7 +92,6 @@ private: //QPalette *paletteOrig, *paletteWrong; //QColor color; QPalette pal, palw; - }; diff --git a/src/setuppages/setuppagebandmode.h b/src/setuppages/setuppagebandmode.h index 2ac8bd50..9770aa49 100644 --- a/src/setuppages/setuppagebandmode.h +++ b/src/setuppages/setuppagebandmode.h @@ -36,6 +36,7 @@ class SetupPageBandMode : public QWidget { Q_OBJECT + public: SetupPageBandMode(DataProxy_SQLite *dp, QWidget *parent=nullptr); ~SetupPageBandMode(); @@ -60,7 +61,6 @@ private: DataProxy_SQLite *dataProxy; Utilities *util; - }; #endif // SETUPPAGEBANDMODE_H diff --git a/src/setuppages/setuppagecolors.h b/src/setuppages/setuppagecolors.h index edf269c5..93bc9678 100644 --- a/src/setuppages/setuppagecolors.h +++ b/src/setuppages/setuppagecolors.h @@ -55,7 +55,6 @@ public: void loadSettings(); void loadDarkMode(); // Reads the config to setup the DarkMode - private slots: void slotNewOneColorButtonClicked(); void slotConfirmedColorButtonClicked(); @@ -66,7 +65,6 @@ private slots: void slotKLogButtonClicked(); void slotSetDarkMode(); - private: Utilities *util; bool darkMode; diff --git a/src/setuppages/setuppagedxcluster.h b/src/setuppages/setuppagedxcluster.h index 41f4e106..0f89a43d 100644 --- a/src/setuppages/setuppagedxcluster.h +++ b/src/setuppages/setuppagedxcluster.h @@ -50,7 +50,6 @@ private slots: void slotDeleteButtonClicked(); private: - void createActions(); bool checkIfValidDXCluster (const QString &tdxcluster); bool checkIfNewDXCluster (const QString &tdxcluster); diff --git a/src/setuppages/setuppagehamlib.h b/src/setuppages/setuppagehamlib.h index c49419b7..ab54b3ea 100644 --- a/src/setuppages/setuppagehamlib.h +++ b/src/setuppages/setuppagehamlib.h @@ -40,6 +40,7 @@ class SetupPageHamLib : public QWidget { Q_OBJECT + public: explicit SetupPageHamLib(DataProxy_SQLite *dp, QWidget *parent = nullptr); //QString getData(); diff --git a/src/setuppages/setuppagelogsnew.h b/src/setuppages/setuppagelogsnew.h index 1c3ec43f..5419d011 100644 --- a/src/setuppages/setuppagelogsnew.h +++ b/src/setuppages/setuppagelogsnew.h @@ -89,7 +89,6 @@ private: QLabel *stationCallsignLabel, *operatorsLabel, *commentLabel, *dateLabel; bool checking; //, bCass, bCOp, bCMo, bCPo, bCBa, bCOv, bCTy; - }; #endif // SETUPPAGELOGSNEW_H diff --git a/src/setuppages/setuppagelogview.h b/src/setuppages/setuppagelogview.h index 6a306e1e..6bbf34bb 100644 --- a/src/setuppages/setuppagelogview.h +++ b/src/setuppages/setuppagelogview.h @@ -36,6 +36,7 @@ class SetupPageLogView : public QWidget { Q_OBJECT + public: SetupPageLogView(DataProxy_SQLite *dp, QWidget *parent=nullptr); ~SetupPageLogView(); diff --git a/src/setuppages/setuppagemisc.h b/src/setuppages/setuppagemisc.h index 864db8c2..ea07b7b4 100644 --- a/src/setuppages/setuppagemisc.h +++ b/src/setuppages/setuppagemisc.h @@ -120,7 +120,6 @@ private: bool dbPathApplied; QComboBox *debugLogLevelCombo; - //QWidget *bandsWidget; }; diff --git a/src/setuppages/setuppagesats.h b/src/setuppages/setuppagesats.h index 21142d17..39169851 100644 --- a/src/setuppages/setuppagesats.h +++ b/src/setuppages/setuppagesats.h @@ -35,8 +35,6 @@ #include "../utilities.h" #include "../setuppages/setuppagesatsnew.h" - - class SetupPageSats : public QWidget { Q_OBJECT @@ -49,7 +47,6 @@ public: void setDefaultStationCallsign (const QString &_p); void setDefaultOperators(const QString &_p); - private slots: void slotImportButtonClicked(); void slotExportButtonClicked(); diff --git a/src/setuppages/setuppagesatsnew.h b/src/setuppages/setuppagesatsnew.h index 488a1698..7bdcf9fe 100644 --- a/src/setuppages/setuppagesatsnew.h +++ b/src/setuppages/setuppagesatsnew.h @@ -102,7 +102,6 @@ private: QStringList satData; bool editing; - }; #endif // SETUPPAGESATSNEW_H diff --git a/src/setuppages/setuppagesubdivisionnew.h b/src/setuppages/setuppagesubdivisionnew.h index 44644bc9..63adeece 100644 --- a/src/setuppages/setuppagesubdivisionnew.h +++ b/src/setuppages/setuppagesubdivisionnew.h @@ -102,7 +102,6 @@ private: //nameLabel->setBuddy(); bool checking; //, bCass, bCOp, bCMo, bCPo, bCBa, bCOv, bCTy; - }; #endif // SETUPPAGEREGIONALAWARDSNEW_H diff --git a/src/setuppages/setuppagesubdivisions.h b/src/setuppages/setuppagesubdivisions.h index b3783a64..84e8b353 100644 --- a/src/setuppages/setuppagesubdivisions.h +++ b/src/setuppages/setuppagesubdivisions.h @@ -117,8 +117,6 @@ private: int selectedLog; //QString defaultStationCallSign, defaultOperators; - - }; #endif // SETUPPAGEREGIONALAWARDS_H diff --git a/src/setuppages/setuppageworldeditor.h b/src/setuppages/setuppageworldeditor.h index e04e4fbd..0faa3ce8 100644 --- a/src/setuppages/setuppageworldeditor.h +++ b/src/setuppages/setuppageworldeditor.h @@ -63,7 +63,6 @@ private slots: void slotImportWorldButtonClicked(); private: - World *world; Utilities *util; DataProxy_SQLite *dataProxy; diff --git a/src/startwizard.h b/src/startwizard.h index 7c9cda71..55a25c6c 100644 --- a/src/startwizard.h +++ b/src/startwizard.h @@ -53,13 +53,11 @@ class CTYPage; //~StartWizard(); protected: - private slots: void slotCancelWizard(); //void slotRunInMemory(bool checked); void slotButtonFinishedClicked(); - private: //FileOrMemoryPage *fileOrMemoryPage; @@ -67,7 +65,6 @@ class CTYPage; QString version; //bool inMemory; QString klogDir; - }; class IntroPage : public QWizardPage @@ -153,7 +150,6 @@ private slots: signals: void downloadTheFileSignal(const bool mem); - private: //bool prepareTheDownload(); //bool doTheDownload();