Codefactor.io cleaning

This commit is contained in:
d 2024-03-24 00:28:19 +01:00
parent 72170df1e3
commit d05c0aacde
30 changed files with 25 additions and 49 deletions

View File

@ -111,9 +111,7 @@ public:
6 - Default: Not applicable 6 - Default: Not applicable
*/ */
private: private:
void setAwardDXCC(const int _qsoId); void setAwardDXCC(const int _qsoId);
//bool setAwardDXCC(const int _dxcc, const int _band, const int _mode, const QString &_workedOrConfirmed, const int _logNumber, const int _qsoId); //bool setAwardDXCC(const int _dxcc, const int _band, const int _mode, const QString &_workedOrConfirmed, const int _logNumber, const int _qsoId);
int setAwardDXCCst(const int _dxcc, const int _band, const int _mode, const bool _confirmed, const int _logNumber, const int _qsoId); int setAwardDXCCst(const int _dxcc, const int _band, const int _mode, const bool _confirmed, const int _logNumber, const int _qsoId);
@ -156,7 +154,6 @@ private:
DXMarathon *dxMarathon; DXMarathon *dxMarathon;
Utilities *util; Utilities *util;
typedef QMultiHash<int, int> DXStatus; typedef QMultiHash<int, int> DXStatus;
DXStatus dxccWorked, dxccConfirmed, wazWorked, wazConfirmed; DXStatus dxccWorked, dxccConfirmed, wazWorked, wazConfirmed;

View File

@ -39,6 +39,7 @@
class StatsCQZPerYearBarChartWidget : public StatsGeneralChartWidget class StatsCQZPerYearBarChartWidget : public StatsGeneralChartWidget
{ {
Q_OBJECT Q_OBJECT
public: public:
StatsCQZPerYearBarChartWidget(DataProxy_SQLite *dp, QWidget *parent = nullptr); StatsCQZPerYearBarChartWidget(DataProxy_SQLite *dp, QWidget *parent = nullptr);
~StatsCQZPerYearBarChartWidget(); ~StatsCQZPerYearBarChartWidget();
@ -55,7 +56,6 @@ private:
//QChart *chart; //QChart *chart;
QChartView *chartView; QChartView *chartView;
}; };
#endif // QSOSPERYEARBARCHARTWIDGET_H #endif // QSOSPERYEARBARCHARTWIDGET_H

View File

@ -39,12 +39,12 @@
class StatsDXCCOnSatsWidget : public StatsGeneralChartWidget class StatsDXCCOnSatsWidget : public StatsGeneralChartWidget
{ {
Q_OBJECT Q_OBJECT
public: public:
StatsDXCCOnSatsWidget(DataProxy_SQLite *dp, QWidget *parent = nullptr); StatsDXCCOnSatsWidget(DataProxy_SQLite *dp, QWidget *parent = nullptr);
~StatsDXCCOnSatsWidget(); ~StatsDXCCOnSatsWidget();
void prepareChart(const int _log=-1) override; void prepareChart(const int _log=-1) override;
signals: signals:
private slots: private slots:
@ -58,6 +58,5 @@ private:
QCheckBox *confirmedOnlyCheckBox, *onlyLEOSatCheckBox; QCheckBox *confirmedOnlyCheckBox, *onlyLEOSatCheckBox;
QLabel *numberLabel; QLabel *numberLabel;
int log; int log;
}; };
#endif // STATSGRIDSONSATSWIDGET_H #endif // STATSGRIDSONSATSWIDGET_H

View File

@ -38,6 +38,7 @@
class StatsEntitiesPerYearBarChartWidget : public StatsGeneralChartWidget class StatsEntitiesPerYearBarChartWidget : public StatsGeneralChartWidget
{ {
Q_OBJECT Q_OBJECT
public: public:
StatsEntitiesPerYearBarChartWidget(DataProxy_SQLite *dp, QWidget *parent = nullptr); StatsEntitiesPerYearBarChartWidget(DataProxy_SQLite *dp, QWidget *parent = nullptr);
~StatsEntitiesPerYearBarChartWidget(); ~StatsEntitiesPerYearBarChartWidget();
@ -53,7 +54,6 @@ private:
//QChart *chart; //QChart *chart;
QChartView *chartView; QChartView *chartView;
}; };
#endif // QSOSPERYEARBARCHARTWIDGET_H #endif // QSOSPERYEARBARCHARTWIDGET_H

View File

@ -145,6 +145,5 @@ void StatsFieldPerBandWidget::slotModeComboBoxChanged()
{ {
modeInUse = modeComboBox->currentText (); modeInUse = modeComboBox->currentText ();
} }
prepareChart (log); prepareChart (log);
} }

View File

@ -42,12 +42,12 @@
class StatsFieldPerBandWidget : public StatsGeneralChartWidget class StatsFieldPerBandWidget : public StatsGeneralChartWidget
{ {
Q_OBJECT Q_OBJECT
public: public:
StatsFieldPerBandWidget(DataProxy_SQLite *dp, ValidFieldsForStats _field, QWidget *parent = nullptr); StatsFieldPerBandWidget(DataProxy_SQLite *dp, ValidFieldsForStats _field, QWidget *parent = nullptr);
~StatsFieldPerBandWidget(); ~StatsFieldPerBandWidget();
void prepareChart(const int _log=-1); void prepareChart(const int _log=-1);
signals: signals:
private slots: private slots:
@ -64,6 +64,5 @@ private:
QComboBox *modeComboBox; QComboBox *modeComboBox;
QString modeInUse; QString modeInUse;
int log; int log;
}; };
#endif // STATSFIELDPERBANDWIDGET_H #endif // STATSFIELDPERBANDWIDGET_H

View File

@ -33,6 +33,7 @@
class StatsGeneralChartWidget : public QWidget class StatsGeneralChartWidget : public QWidget
{ {
Q_OBJECT Q_OBJECT
public: public:
StatsGeneralChartWidget(); StatsGeneralChartWidget();
StatsGeneralChartWidget(DataProxy_SQLite *dp, QWidget *parent = nullptr); StatsGeneralChartWidget(DataProxy_SQLite *dp, QWidget *parent = nullptr);
@ -40,7 +41,6 @@ public:
private: private:
virtual void createUI(); virtual void createUI();
}; };
#endif // GENERALCHARTWIDGET_H #endif // GENERALCHARTWIDGET_H

View File

@ -39,6 +39,7 @@
class StatsGridsOnSatsWidget : public StatsGeneralChartWidget class StatsGridsOnSatsWidget : public StatsGeneralChartWidget
{ {
Q_OBJECT Q_OBJECT
public: public:
StatsGridsOnSatsWidget(DataProxy_SQLite *dp, QWidget *parent = nullptr); StatsGridsOnSatsWidget(DataProxy_SQLite *dp, QWidget *parent = nullptr);
~StatsGridsOnSatsWidget(); ~StatsGridsOnSatsWidget();
@ -58,6 +59,5 @@ private:
QCheckBox *confirmedOnlyCheckBox, *onlyLEOSatCheckBox; QCheckBox *confirmedOnlyCheckBox, *onlyLEOSatCheckBox;
QLabel *numberLabel; QLabel *numberLabel;
int log; int log;
}; };
#endif // STATSGRIDSONSATSWIDGET_H #endif // STATSGRIDSONSATSWIDGET_H

View File

@ -39,6 +39,7 @@
class StatsQSOsPerBandBarChartWidget : public StatsGeneralChartWidget class StatsQSOsPerBandBarChartWidget : public StatsGeneralChartWidget
{ {
Q_OBJECT Q_OBJECT
public: public:
StatsQSOsPerBandBarChartWidget(DataProxy_SQLite *dp, QWidget *parent = nullptr); StatsQSOsPerBandBarChartWidget(DataProxy_SQLite *dp, QWidget *parent = nullptr);
~StatsQSOsPerBandBarChartWidget(); ~StatsQSOsPerBandBarChartWidget();
@ -54,7 +55,6 @@ private:
//QChart *chart; //QChart *chart;
QChartView *chartView; QChartView *chartView;
}; };
#endif // QSOSPERBANDBARCHARTWIDGET_H #endif // QSOSPERBANDBARCHARTWIDGET_H

View File

@ -39,6 +39,7 @@
class StatsQSOsPerContinentBarChartWidget : public StatsGeneralChartWidget class StatsQSOsPerContinentBarChartWidget : public StatsGeneralChartWidget
{ {
Q_OBJECT Q_OBJECT
public: public:
StatsQSOsPerContinentBarChartWidget(DataProxy_SQLite *dp, QWidget *parent = nullptr); StatsQSOsPerContinentBarChartWidget(DataProxy_SQLite *dp, QWidget *parent = nullptr);
~StatsQSOsPerContinentBarChartWidget(); ~StatsQSOsPerContinentBarChartWidget();
@ -54,7 +55,6 @@ private:
//QChart *chart; //QChart *chart;
QChartView *chartView; QChartView *chartView;
}; };
#endif // QSOSPERBANDBARCHARTWIDGET_H #endif // QSOSPERBANDBARCHARTWIDGET_H

View File

@ -39,6 +39,7 @@
class StatsQSOsPerDXCCBarChartWidget : public StatsGeneralChartWidget class StatsQSOsPerDXCCBarChartWidget : public StatsGeneralChartWidget
{ {
Q_OBJECT Q_OBJECT
public: public:
StatsQSOsPerDXCCBarChartWidget(DataProxy_SQLite *dp, QWidget *parent = nullptr); StatsQSOsPerDXCCBarChartWidget(DataProxy_SQLite *dp, QWidget *parent = nullptr);
~StatsQSOsPerDXCCBarChartWidget(); ~StatsQSOsPerDXCCBarChartWidget();
@ -54,7 +55,6 @@ private:
//QChart *chart; //QChart *chart;
QChartView *chartView; QChartView *chartView;
}; };
#endif // QSOSPERBANDBARCHARTWIDGET_H #endif // QSOSPERBANDBARCHARTWIDGET_H

View File

@ -39,6 +39,7 @@
class StatsQSOsPerHourBarChartWidget : public StatsGeneralChartWidget class StatsQSOsPerHourBarChartWidget : public StatsGeneralChartWidget
{ {
Q_OBJECT Q_OBJECT
public: public:
StatsQSOsPerHourBarChartWidget(DataProxy_SQLite *dp, QWidget *parent = nullptr); StatsQSOsPerHourBarChartWidget(DataProxy_SQLite *dp, QWidget *parent = nullptr);
~StatsQSOsPerHourBarChartWidget(); ~StatsQSOsPerHourBarChartWidget();
@ -54,7 +55,6 @@ private:
//QChart *chart; //QChart *chart;
QChartView *chartView; QChartView *chartView;
}; };
#endif // QSOSPERBANDBARCHARTWIDGET_H #endif // QSOSPERBANDBARCHARTWIDGET_H

View File

@ -39,6 +39,7 @@
class StatsQSOsPerModeBarChartWidget : public StatsGeneralChartWidget class StatsQSOsPerModeBarChartWidget : public StatsGeneralChartWidget
{ {
Q_OBJECT Q_OBJECT
public: public:
StatsQSOsPerModeBarChartWidget(DataProxy_SQLite *dp, QWidget *parent = nullptr); StatsQSOsPerModeBarChartWidget(DataProxy_SQLite *dp, QWidget *parent = nullptr);
~StatsQSOsPerModeBarChartWidget(); ~StatsQSOsPerModeBarChartWidget();
@ -54,7 +55,6 @@ private:
//QChart *chart; //QChart *chart;
QChartView *chartView; QChartView *chartView;
}; };
#endif // QSOSPERMODEBARCHARTWIDGET_H #endif // QSOSPERMODEBARCHARTWIDGET_H

View File

@ -39,6 +39,7 @@
class StatsQSOsPerMonthBarChartWidget : public StatsGeneralChartWidget class StatsQSOsPerMonthBarChartWidget : public StatsGeneralChartWidget
{ {
Q_OBJECT Q_OBJECT
public: public:
StatsQSOsPerMonthBarChartWidget(DataProxy_SQLite *dp, QWidget *parent = nullptr); StatsQSOsPerMonthBarChartWidget(DataProxy_SQLite *dp, QWidget *parent = nullptr);
~StatsQSOsPerMonthBarChartWidget(); ~StatsQSOsPerMonthBarChartWidget();
@ -54,7 +55,6 @@ private:
//QChart *chart; //QChart *chart;
QChartView *chartView; QChartView *chartView;
}; };
#endif // QSOSPERMONTHBARCHARTWIDGET_H #endif // QSOSPERMONTHBARCHARTWIDGET_H

View File

@ -39,6 +39,7 @@
class StatsQSOsPerYearBarChartWidget : public StatsGeneralChartWidget class StatsQSOsPerYearBarChartWidget : public StatsGeneralChartWidget
{ {
Q_OBJECT Q_OBJECT
public: public:
StatsQSOsPerYearBarChartWidget(DataProxy_SQLite *dp, QWidget *parent = nullptr); StatsQSOsPerYearBarChartWidget(DataProxy_SQLite *dp, QWidget *parent = nullptr);
~StatsQSOsPerYearBarChartWidget(); ~StatsQSOsPerYearBarChartWidget();
@ -54,7 +55,6 @@ private:
//QChart *chart; //QChart *chart;
QChartView *chartView; QChartView *chartView;
}; };
#endif // QSOSPERYEARBARCHARTWIDGET_H #endif // QSOSPERYEARBARCHARTWIDGET_H

View File

@ -39,6 +39,7 @@
class StatsSentConfirmedPieChartWidget : public StatsGeneralChartWidget class StatsSentConfirmedPieChartWidget : public StatsGeneralChartWidget
{ {
Q_OBJECT Q_OBJECT
public: public:
StatsSentConfirmedPieChartWidget(DataProxy_SQLite *dp, QWidget *parent = nullptr); StatsSentConfirmedPieChartWidget(DataProxy_SQLite *dp, QWidget *parent = nullptr);
~StatsSentConfirmedPieChartWidget(); ~StatsSentConfirmedPieChartWidget();
@ -54,7 +55,6 @@ private:
//QChart *chart; //QChart *chart;
QChartView *chartView; QChartView *chartView;
}; };
#endif // QSOSPERBANDBARCHARTWIDGET_H #endif // QSOSPERBANDBARCHARTWIDGET_H

View File

@ -39,6 +39,7 @@
class StatsWorkedConfirmedPieChartWidget : public StatsGeneralChartWidget class StatsWorkedConfirmedPieChartWidget : public StatsGeneralChartWidget
{ {
Q_OBJECT Q_OBJECT
public: public:
StatsWorkedConfirmedPieChartWidget(DataProxy_SQLite *dp, QWidget *parent = nullptr); StatsWorkedConfirmedPieChartWidget(DataProxy_SQLite *dp, QWidget *parent = nullptr);
~StatsWorkedConfirmedPieChartWidget(); ~StatsWorkedConfirmedPieChartWidget();
@ -54,7 +55,6 @@ private:
//QChart *chart; //QChart *chart;
QChartView *chartView; QChartView *chartView;
}; };
#endif // QSOSPERBANDBARCHARTWIDGET_H #endif // QSOSPERBANDBARCHARTWIDGET_H

View File

@ -39,6 +39,7 @@
class StatsWorkedSentPieChartWidget : public StatsGeneralChartWidget class StatsWorkedSentPieChartWidget : public StatsGeneralChartWidget
{ {
Q_OBJECT Q_OBJECT
public: public:
StatsWorkedSentPieChartWidget(DataProxy_SQLite *dp, QWidget *parent = nullptr); StatsWorkedSentPieChartWidget(DataProxy_SQLite *dp, QWidget *parent = nullptr);
~StatsWorkedSentPieChartWidget(); ~StatsWorkedSentPieChartWidget();
@ -54,7 +55,6 @@ private:
//QChart *chart; //QChart *chart;
QChartView *chartView; QChartView *chartView;
}; };
#endif // QSOSPERBANDBARCHARTWIDGET_H #endif // QSOSPERBANDBARCHARTWIDGET_H

View File

@ -39,6 +39,7 @@
class eLogClubLog : public QObject { class eLogClubLog : public QObject {
Q_OBJECT Q_OBJECT
public: public:
explicit eLogClubLog(); explicit eLogClubLog();
~eLogClubLog(); ~eLogClubLog();

View File

@ -45,6 +45,7 @@
class eLogQrzLog : public QObject { class eLogQrzLog : public QObject {
Q_OBJECT Q_OBJECT
public: public:
explicit eLogQrzLog(DataProxy_SQLite *dp, const QString &_parentFunction, const QString &_klogVersion); explicit eLogQrzLog(DataProxy_SQLite *dp, const QString &_parentFunction, const QString &_klogVersion);
~eLogQrzLog(); ~eLogQrzLog();
@ -70,7 +71,6 @@ private slots:
void downloadProgress(qint64 received, qint64 total); void downloadProgress(qint64 received, qint64 total);
void slotErrorManagement(QNetworkReply::NetworkError networkError); void slotErrorManagement(QNetworkReply::NetworkError networkError);
signals: signals:
void actionReturnDownload(const int _i, const int _qsoId); void actionReturnDownload(const int _i, const int _qsoId);
void done(); void done();

View File

@ -40,6 +40,7 @@
// https://www.eqsl.cc/qslcard/Programming.cfm // https://www.eqsl.cc/qslcard/Programming.cfm
class eQSLUtilities : public QObject { class eQSLUtilities : public QObject {
Q_OBJECT Q_OBJECT
public: public:
explicit eQSLUtilities(const QString &_parentFunction); explicit eQSLUtilities(const QString &_parentFunction);
~eQSLUtilities(); ~eQSLUtilities();
@ -52,7 +53,6 @@ public:
void sendLogFile(const QString &_file, QList<int> _qso); void sendLogFile(const QString &_file, QList<int> _qso);
private: private:
//QString geteQSLAdif(const QStringList _q); //QString geteQSLAdif(const QStringList _q);
//int sendData(const QString &_eQSLUser, const QString &_q); // Sends the data (http post) to eQSL //int sendData(const QString &_eQSLUser, const QString &_q); // Sends the data (http post) to eQSL

View File

@ -44,7 +44,6 @@ const double KM_IN_A_MILE = 1.609344;
class Locator{ class Locator{
public: public:
Locator(); Locator();
~Locator(); ~Locator();

View File

@ -39,7 +39,6 @@ LogModel::LogModel(DataProxy_SQLite *dp, QObject *parent):QSqlRelationalTableMod
//qDebug() << Q_FUNC_INFO << " - END"; //qDebug() << Q_FUNC_INFO << " - END";
} }
void LogModel::createlogModel(const int _i) void LogModel::createlogModel(const int _i)
{ {
/* /*
@ -78,7 +77,7 @@ This should be coherent with the logview
} }
void LogModel::setColumns(const QStringList &_columns) void LogModel::setColumns(const QStringList &_columns)
{ {
//qDebug() << Q_FUNC_INFO ; //qDebug() << Q_FUNC_INFO ;
//QString auxt; //QString auxt;
//foreach(auxt, _columns) //foreach(auxt, _columns)
@ -99,7 +98,6 @@ This should be coherent with the logview
if (!sqlOK) if (!sqlOK)
{ {
emit queryError(Q_FUNC_INFO, q.lastError().databaseText(), q.lastError().nativeErrorCode(), q.lastQuery()); emit queryError(Q_FUNC_INFO, q.lastError().databaseText(), q.lastError().nativeErrorCode(), q.lastQuery());
} }
q.next(); q.next();
rec = q.record(); // Number of columns rec = q.record(); // Number of columns

View File

@ -220,7 +220,6 @@ void SearchWidget::createUI()
connect(searchWindow, SIGNAL( actionDeleteQSO(int)), this, SLOT( slotQsoDeleteFromSearch(int) )); connect(searchWindow, SIGNAL( actionDeleteQSO(int)), this, SLOT( slotQsoDeleteFromSearch(int) ));
connect(searchWindow, SIGNAL( updateSearchLineEdit()), this, SLOT( slotSearchBoxTextChanged() )); connect(searchWindow, SIGNAL( updateSearchLineEdit()), this, SLOT( slotSearchBoxTextChanged() ));
connect(searchWindow, SIGNAL( requestFocus()), this, SLOT( slotRequestFocus() )); connect(searchWindow, SIGNAL( requestFocus()), this, SLOT( slotRequestFocus() ));
} }

View File

@ -9,6 +9,7 @@
class HamLibSerialConfigWidget : public QWidget class HamLibSerialConfigWidget : public QWidget
{ {
Q_OBJECT Q_OBJECT
public: public:
explicit HamLibSerialConfigWidget(QWidget *parent = nullptr); explicit HamLibSerialConfigWidget(QWidget *parent = nullptr);
void createUI(); void createUI();
@ -31,7 +32,6 @@ private slots:
void slotScanPorts(); void slotScanPorts();
private: private:
QStringList getAvailableSerialPorts(); QStringList getAvailableSerialPorts();
void fillSerialPortsComboBox(); void fillSerialPortsComboBox();

View File

@ -74,7 +74,6 @@ private:
Utilities *util; Utilities *util;
//QStringList dxClusterServers; //QStringList dxClusterServers;
}; };
#endif // SETUPPAGEDXCLUSTER_H #endif // SETUPPAGEDXCLUSTER_H

View File

@ -107,7 +107,6 @@ private:
DataProxy_SQLite *dataProxy; DataProxy_SQLite *dataProxy;
int selectedLog; int selectedLog;
QString defaultStationCallSign, defaultOperators; QString defaultStationCallSign, defaultOperators;
}; };

View File

@ -31,10 +31,10 @@
#include <QNetworkInterface> #include <QNetworkInterface>
#include "../utilities.h" #include "../utilities.h"
class SetupPageUDP : public QWidget class SetupPageUDP : public QWidget
{ {
Q_OBJECT Q_OBJECT
public: public:
SetupPageUDP(QWidget *parent = nullptr); SetupPageUDP(QWidget *parent = nullptr);
~SetupPageUDP(); ~SetupPageUDP();
@ -80,8 +80,6 @@ public slots:
//void slotAutoLogFromWSJTCheckBoxClicked(); //void slotAutoLogFromWSJTCheckBoxClicked();
//void slotRealFromWSJTCheckBoxClicked(); //void slotRealFromWSJTCheckBoxClicked();
void slotUDPServerCheckBoxClicked(); void slotUDPServerCheckBoxClicked();
}; };
#endif // SETUPPAGEUDP_H #endif // SETUPPAGEUDP_H

View File

@ -53,7 +53,6 @@ private slots:
private: private:
DataProxy_SQLite *dataProxy; DataProxy_SQLite *dataProxy;
MainQSOEntryWidget *mainQSOEntryWidget; MainQSOEntryWidget *mainQSOEntryWidget;
}; };
tst_MainQSOEntryWidget::tst_MainQSOEntryWidget() tst_MainQSOEntryWidget::tst_MainQSOEntryWidget()

View File

@ -66,10 +66,8 @@ private slots:
*/ */
private: private:
HamLibSerialConfigWidget *serialHamLibWidget; HamLibSerialConfigWidget *serialHamLibWidget;
}; };
tst_SetupHamLibSerialWidget::tst_SetupHamLibSerialWidget() tst_SetupHamLibSerialWidget::tst_SetupHamLibSerialWidget()
@ -82,16 +80,9 @@ tst_SetupHamLibSerialWidget::~tst_SetupHamLibSerialWidget(){}
void tst_SetupHamLibSerialWidget::initTestCase(){} void tst_SetupHamLibSerialWidget::initTestCase(){}
void tst_SetupHamLibSerialWidget::cleanupTestCase() void tst_SetupHamLibSerialWidget::cleanupTestCase(){}
{
} void tst_SetupHamLibSerialWidget::test_Constructor(){}
void tst_SetupHamLibSerialWidget::test_Constructor()
{
}
void tst_SetupHamLibSerialWidget::test_DataBits() void tst_SetupHamLibSerialWidget::test_DataBits()
{ {
@ -161,8 +152,7 @@ void tst_SetupHamLibSerialWidget::test_SerialSpeed()
QVERIFY2(serialHamLibWidget->getSerialBauds() == 1200, qPrintable(QString("Serial Speed default not OK"))); QVERIFY2(serialHamLibWidget->getSerialBauds() == 1200, qPrintable(QString("Serial Speed default not OK")));
} }
void tst_SetupHamLibSerialWidget::test_SerialPort() void tst_SetupHamLibSerialWidget::test_SerialPort(){}
{}
QTEST_MAIN(tst_SetupHamLibSerialWidget) QTEST_MAIN(tst_SetupHamLibSerialWidget)