hamradio/cqrlog
1
0
Fork 0
mirror of https://github.com/ok2cqr/cqrlog.git synced 2024-09-21 10:27:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix for RBNMonitor

Browse Source 
During high traffic (IARU HF contest) it suddenly showed up
	that either editing filter or disconnecting monitor caused
	error message (Abort/Ok).
	By debug assembler the error happens in thread close section.

	Found out that RBNThread has FreeOnTerminate set True and
	procedure acTerminate first terminates thread and then tries to
	FreeAndNil it.
	This looks like double free for me and tried to set
	FreeOnTerminate :=False and problem disappeared.
	I am not quite sure is this true effect or just some other
	thing changed.
	Anyhow it should not do any harm this way, I think.

	When this kind of problem apperars it also (but random) leads
	to Cqrlog starting problem when it dies at start.
	This happens at NewQSO/FormShow where ShowMOdal (of DBconnect) seems
	to produce mrOK:=false condition.
	After several start attempts it suddenly clears and program opens.
	Looks like mysterious thread/memory leak or something.
This commit is contained in:
OH1KH 2022-07-09 19:34:55 +03:00
parent f4d5d1e48d
commit 401a5beebd
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/fRbnMonitor.pas
View File

@ -475,8 +475,8 @@ var
user : String;
begin
RbnMonThread := TRBNThread.Create(True);
RbnMonThread.FreeOnTerminate := True;
RbnMonThread.OnShowSpot := @SynRbnMonitor;
RbnMonThread.FreeOnTerminate := False;// True; I think this causes abrt in terminate (TfrmRbnMonitor.acDisconnectExecute) because procedure has freeAndNil (does free twice)
RbnMonThread.OnShowSpot := @SynRbnMonitor; //shows up when RBN traffic is high like IARU HF contest and connect is tried to close or filter adjusted
RbnMonThread.Start;
LoadConfigToThread;