This was largely designed to work on python3 natively, so no big
surprise that it basically works. Fixed a couple logging issues
and added a test to exercise the cloning routines enough to consider
it unit tested.
This has not been tested with a real radio, but the cloning routines
are straightforward and a simple test is added to exercise them to
confirm they do the right thing.
This has not been tested with a real radio, but the cloning routines
are straightforward and a simple test is added to exercise them to
confirm they do the right thing.
The FT60 driver is heavily used and extremely simple in its clone
routines. As such, this adds a unit test to exercise that part, which
along with the regular driver tests, should mean this is pretty high
confidence (although not nearly as good as a real test of course).
The 2730 should be good now that I've done more testing on the 5100.
Update the 5100 date after the recent fix, and mark the 4100 as
implied from the 5100 instead of tested directly.
This is for drivers that share a cloning protocol module with other
tested drivers *and* are tested on a static image in the tree. For
example, all the kenwood live drivers use the same few routines for
communicating with the radio. Icom clone-mode radios (with one
exception) use the icf module for cloning and thus there's really
nothing to convert in the drivers themselves.
This PR introduces the following changes:
- The base class of the Alinco driver is modified to hopefully work with
Python 3; the str-based approach is kept.
- The AlincoDJG7EG class is further modified to be byte-clean. This
required a bunch of overries that can be moved to the base class once
the other drivers become byte-clean. A possible strategy for this is
documented in the PR thread on github.
- The changes for the DJ-G7 were tested with a real radio; the code
submitted passes all unit tests.
- Modification of `py3_driver_testers.txt` and re-running `tox` for an
updated .md file.
- A small bug in the debug log is also fixed (payload was not printed).
Also tighten up the cloning routines to be less fragile and less
dependent on timing. I have never been able to get this driver to
work on any platform, and with this change, it works on all platforms
for me.
Clean up style and other stuff while I'm here.
This also rewrites the cloning routines to be less fragile and less
dependent on timing. I have never been able to get this driver to
work on any platform, and with this change it works on all platforms
for me.
Spelling and grammar is also tweaked for correctness while I'm here.
These differ from the already-tested base radio by very little, so I
am going to mark them as implied. The 51Plus2 is slightly different
in that it uses raw mode, so I will leave that one until someone can
test it for real.
