From f5776129c40dddccd0de816beec7d7c61bc63e1c Mon Sep 17 00:00:00 2001 From: Christopher Hoover Date: Sun, 19 Nov 2017 11:51:17 -0800 Subject: [PATCH] Fixes case where column order setting parsing was calling split on None. #5355 --- chirp/ui/memedit.py | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/chirp/ui/memedit.py b/chirp/ui/memedit.py index 724ef036..df1f9da9 100644 --- a/chirp/ui/memedit.py +++ b/chirp/ui/memedit.py @@ -961,15 +961,19 @@ class MemoryEditor(common.Editor): default_col_order = [x for x, y, z in self.cols if z] try: - col_order = self._config.get("column_order_%s" % - self.__class__.__name__).split(",") - if len(col_order) != len(default_col_order): - raise Exception() - for i in col_order: - if i not in default_col_order: + config_setting = self._config.get("column_order_%s" % + self.__class__.__name__) + if config_setting is None: + col_order = default_col_order + else: + col_order = config_setting.split(",") + if len(col_order) != len(default_col_order): raise Exception() + for i in col_order: + if i not in default_col_order: + raise Exception() except Exception, e: - LOG.error(e) + LOG.error("column order setting: %s", e) col_order = default_col_order non_editable = [_("Loc")]