hamradio/chirp
1
0
Fork 0
mirror of https://github.com/kk7ds/chirp.git synced 2024-09-21 02:27:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix removing immutable settings for lists

Browse Source 
Settings can have multiple values, although this is not often used and
the UI has places where this is not properly honored. Fix the case
where we look for and prune uninitialized/immutable settings and
be sure to iterate over all the values to avoid a crash.

Fixes #11549
This commit is contained in:
Dan Smith 2024-09-19 16:41:57 -07:00 committed by Dan Smith
parent 673dcb4eef
commit 786e37ce26
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
chirp/wxui/settingsedit.py
View File

@ -164,12 +164,13 @@ class ChirpSettingsEdit(common.ChirpEditor):
if isinstance(e, settings.RadioSetting):
# Immutable and uninitialized settings don't get sent to the
# radio
if not e.value.get_mutable():
LOG.debug('Skipping immutable %s', e.get_name())
del root[e]
elif not e.value.initialized:
LOG.debug('Skipping uninitialized %s', e.get_name())
del root[e]
for value in e:
if not value.get_mutable():
LOG.debug('Skipping immutable %s', e.get_name())
del root[e]
elif not value.initialized:
LOG.debug('Skipping uninitialized %s', e.get_name())
del root[e]
elif isinstance(e, settings.RadioSettingGroup):
self._remove_dead_settings(e)