mirror of
https://github.com/kk7ds/chirp.git
synced 2024-09-21 10:37:15 +00:00
Add a PR template with requirements
This commit is contained in:
parent
37c8b0e3c7
commit
0234f6a316
17
.github/pull_request_template.md
vendored
Normal file
17
.github/pull_request_template.md
vendored
Normal file
@ -0,0 +1,17 @@
|
||||
# CHIRP PR Checklist
|
||||
|
||||
The following must be true before PRs can be merged:
|
||||
|
||||
* All tests must be passing.
|
||||
* Commits should be squashed into logical units.
|
||||
* Commits in a single PR should be related.
|
||||
* Major new features or bug fixes should reference a [CHIRP issue](https://chirp.danplanet.com/projects/chirp/issues).
|
||||
* New drivers should be accompanied by a test image in `tests/images` (except for thin aliases where the driver is sufficiently tested already).
|
||||
|
||||
Please also follow these guidelines:
|
||||
|
||||
* Keep cleanups in separate commits from functional changes.
|
||||
* Please write a reasonable commit message, especially if making some change that isn't totally obvious (such as adding a new model, adding a feature, etc).
|
||||
* Do not add new py2-compatibility code (No new uses of `six`, `future`, etc).
|
||||
* All new drivers should set `NEEDS_COMPAT_SERIAL=False` and use `MemoryMapBytes`.
|
||||
* New drivers and radio models will affect the Python3 test matrix. You should regenerate this file with `tox -emakesupported` and include it in your commit.
|
Loading…
Reference in New Issue
Block a user