Commit Graph

549 Commits

Author SHA1 Message Date
Michael Black
00d578074e
Remove Recommend statment from rigctl.c 2019-12-19 09:38:50 -06:00
Michael Black
eac8077c60
Fix possible buf overrun in rigctl_parse.c 2019-12-17 08:08:39 -06:00
Michael Black
f9bed84d8e
Got the w and W commands working much better
ICOM test via rigctl
Rig command: w \0xfe\0xfe\0x58\0xe0\0x03\0xfd
Reply:\0xFE\0xFE\0x58\0xE0\0x03\0xFD\0xFE\0xFE\0xE0\0x58\0x03\0x00\0x50\0x09\0x14\0x00\0xFD 17
Rig command: W \0xfe\0xfe\0x58\0xe0\0x03\0xfd 17
Reply:\0xFE\0xFE\0x58\0xE0\0x03\0xFD\0xFE\0xFE\0xE0\0x58\0x03\0x00\0x50\0x09\0x14\0x00\0xFD 17

Rig command: w FA;
send_cmd: error = Invalid parameter
Rig command: W FA; 14
send_cmd_rx: error = Invalid parameter

ICOM test via rigctld
Rig command: w \0xfe\0xfe\0x58\0xe0\0x03\0xfd
Reply:\0xFE\0xFE\0x58\0xE0\0x03\0xFD\0xFE\0xFE\0xE0\0x58\0x03\0x00\0x50\0x09\0x14\0x00\0xFD 17
Rig command: W \0xfe\0xfe\0x58\0xe0\0x03\0xfd 17
Reply:\0xFE\0xFE\0x58\0xE0\0x03\0xFD\0xFE\0xFE\0xE0\0x58\0x03\0x00\0x50\0x09\0x14\0x00\0xFD 17

Rig command: w FA;
Reply:RPRT -1
Rig command: W FA; 14
Reply:RPRT -1

Kenwood test via rigctl
Rig command: w FA;
Reply:FA00014074000;
Rig command: W FA; 14
Reply:FA00014074000;

Rig command: w \0x46\0x41\0x3b
Reply:FA00014074000;
Rig command: W \0x46\0x41\0x3b 14
Reply:FA00014074000;

Kenwood test via rigctld
Rig command: w FA;
Reply:FA00014074000;
Rig command: W FA; 14
Reply:FA00014074000;

Rig command: w \0x46\0x41\0x3b
Reply:FA00014074000;

Rig command: W \0x46\0x41\0x3b 14
Reply:FA00014074000;
2019-12-12 22:29:13 -06:00
Michael Black
011efe0452
Merge branch 'master' of https://github.com/Hamlib/Hamlib 2019-12-11 07:47:24 -06:00
Nate Bargmann
2c884a970a
Change ampctld default TCP port to 4531 2019-12-11 06:28:17 -06:00
Michael Black
9eae761579
Added 'W' command for reading a fixed number of bytes
So we can now do this...write once to see how many bytes you get back
Rig command: w \0xfe\0xfe\0x58\0xe0\0x03\0xfd
Cmd:\0xFE\0xFE\0x58\0xE0\0x03\0xFD\0xFE\0xFE\0xE0\0x58\0x03\0x00\0x00\0x09\0x14\0x00\0xFD 17

Then use 'W' to write the command with the # of bytes to expect -- no timeout this way
Rig command: W \0xfe\0xfe\0x58\0xe0\0x03\0xfd 17
Cmd:\0xFE\0xFE\0x58\0xE0\0x03\0xFD\0xFE\0xFE\0xE0\0x58\0x03\0x00\0x00\0x09\0x14\0x00\0xFD 17
2019-12-09 23:37:14 -06:00
Michael Black
fb73e5abd7
Fix some cppcheck warnings
Fix declarations after statements
Remove some !rig checks...we either don't need them or need them everywhere with a new error code
If you pass a NULL rig you get what you deserve :-)
2019-12-09 17:12:13 -06:00
Michael Black
8e0ddf743c
Fix cppcheck warnings in ampctl_parse.c 2019-12-08 23:43:01 -06:00
Michael Black
646900862b
Fix cppcheck warnings in dumpmem.c 2019-12-08 23:42:47 -06:00
Michael Black
ddd5c43a71
Fix cppcheck warnings in rigmem.c 2019-12-08 23:42:32 -06:00
Michael Black
0207b45ff8
Fix cppcheck warnings in rigctlcom.c 2019-12-08 23:39:56 -06:00
Michael Black
2d94431848
Fix cppcheck warnings in rigctl_parse.c 2019-12-08 23:37:46 -06:00
Michael Black
e56db8c985
Fix cppcheck warnings in rigctl.c 2019-12-08 23:33:51 -06:00
Michael Black
f7399eb8df
Fix cppcheck warnings in example.c 2019-12-08 23:30:23 -06:00
Michael Black
8a3df9735e
Fix cppcheck warnings for ampctl_parse.c and redef amp_set_powerstat 2019-12-08 23:13:33 -06:00
Michael Black
c9ace18daa
Fix hash sort comparison for models 2019-12-06 12:13:38 -06:00
Michael Black
68f5a7edd7
Fix cppcheck error in ampctl_parse.c 2019-12-06 10:25:28 -06:00
Michael Black
1e889006b4
Minor change to rigctl_parse.c for ASCII print 2019-12-06 08:34:31 -06:00
Michael Black
9531f730b1
Change behavior of 'w' command in rigctld for binary commands
Now responds with hex string just like the input and the # of bytes
Will get hex string response for any binary data from rig from any command
Next step is to implement W command for known # of bytes in response to avoid the timeout
2019-12-06 07:58:19 -06:00
Michael Black
60cfecd5b4
Hopefully suppress arm compilation warning 2019-12-03 16:15:33 -06:00
Michael Black
5a9ab0b76d
Add retry to rigctl open 2019-12-03 08:22:35 -06:00
Michael Black
a7335595de
Add az and el offset to rotctl & rotctld 2019-12-02 23:30:08 -06:00
Michael Black
72565fe621
Fix ic7300 VFOs and sprintflst to be more generic 2019-12-02 14:46:41 -06:00
Michael Black
e6264c4f6f
Add PKT mode translations to rigctlcom 2019-12-02 12:23:04 -06:00
Michael Black
12494c92d5
Add MainA, MainB, SubA, and SubB vfo choices for icom rigs with SATMODE
Clean up debug statements in icom.c
2019-12-02 07:50:05 -06:00
Michael Black
1ceae3a3f3
Remove debug from rigctlcom.c 2019-12-01 09:13:35 -06:00
Michael Black
dc3f33bc11
Change %z to %d with casts for portability 2019-11-30 13:05:21 -06:00
Michael Black
c69502e11c
Fix rigctld for win32 build 2019-11-30 10:27:49 -06:00
Michael Black
6bf3b00c4f
astyle all files 2019-11-30 10:19:08 -06:00
Michael Black
2f4d62709e
Added a dummy snprintf to rig_debug to allow gcc to check format strings
This found tons of errors in rig_debug statements
So this patch cleans up all the files that were producing warnings or errors
This should fix a few segfaults when running with debug turned on
2019-11-30 10:04:31 -06:00
Michael Black
46a9fff6ad
Fix rotctl C command 2019-11-23 23:11:27 -06:00
Michael Black
ca034f4c93
Fix rigctl_parse to allow NULL in binary data the right way 2019-10-21 16:00:41 -05:00
Michael Black
99945e87cf
Fix rigctl_parse to allow NULL in binary data 2019-10-21 15:41:38 -05:00
Michael Black
44a20c6a1e
Fix chk_vfo response 2019-09-09 22:45:55 -05:00
Bill Somerville
8028663ef9
Simplify unnecessary persistence of extended response state
The \chk_vfo  command to  rigctl_parse() accepts an  extended response
prefix but  does not act  upon it, instead it  is held over  until the
next command.  This seems unnecessary  as an extended  response prefix
can just as  easily be added to the following  command if required. By
removing this  carried over  state the processing  of commands  can be
greatly simplified as per this commit.
2019-08-29 14:27:22 +01:00
Bill Somerville
d931bd4e18
Move unnecessary global and file static variables to the stack 2019-08-29 00:39:39 +01:00
Michael Black
5d16de90ee
Fix start/end names 2019-08-23 22:53:25 -05:00
Michael Black
63fc56e9c8
Fix dumpmem.c channel structure 2019-08-23 08:16:51 -05:00
Michael Black
73c1ecd165
Change freq & chan struct start/end to avoid colliding with LUA SWIG start/end 2019-08-17 23:20:48 -05:00
Michael Black
3dce8b01d1
Make rigctld thread safe for vfo_mode and ext_resp and change other globals to thread_local for future reference 2019-07-31 16:03:46 -05:00
Michael Black
12fd5100d5
Adding amptest.sh 2019-07-31 15:47:50 -05:00
Michael Black
d6a72d15bf
Remove redundant check in dumpcaps.c 2019-07-31 15:13:34 -05:00
Michael Black
436449211f
Make rigctld_vfo_mode a stack variable for threading 2019-07-31 10:56:21 -05:00
Nate Bargmann
cf75f3fdf7
Merge branch 'master' of https://github.com/mdblack98/Hamlib into mdblack98-master 2019-06-25 18:59:21 -05:00
Bill Somerville
8465a76fd2
Ensure compilation works with a pre C11 compiler 2019-06-16 23:14:46 +01:00
Michael Black
7d8ad6f47c
Fix dumpcaps.c prntbuf warning 2019-06-12 16:25:13 -05:00
Michael Black
b23734fb5b
Fix rig.h for merge 2019-06-12 16:13:56 -05:00
Michael Black
7e9c566944
Add first cut at amplifier control 2019-06-12 15:52:35 -05:00
Mikael Nousiainen
3dbbe02b78 Add new levels: RFPOWER_METER, COMP_METER, VD_METER and ID_METER, supported at least by most of recent Icom rigs. Add level NOTCHF_RAW for manual notch frequency without specified unit for Icom rigs. Add level MONITOR_GAIN. Add functions DUAL_WATCH and DIVERSITY, supported now by K3/K3S. Fix VOXDELAY level commands for many Icom rigs. Add MONITOR_GAIN level for Icom rigs. Fix and add many K3 commands and add specific rig models for K3S, KX2 and KX3 -- they are very similar to K3, but have slight differences. Extend dump_caps output for rigctl: add complete details of ext levels and frequency ranges. Tests have been performed on IC-7000, IC-756ProIII, IC-7300, IC-7600 and K3. 2019-05-30 09:37:49 +03:00
Michael Black
ab7527d95a Fix compile warning in rotctl_parse.c 2019-05-22 11:15:30 -05:00