mirror of
https://github.com/php/php-src.git
synced 2024-09-23 02:47:26 +00:00
5582490bf2
mb_ereg()/mb_eregi() currently have an inconsistent return value based on whether the $matches parameter is passed or not: > Returns the byte length of the matched string if a match for > pattern was found in string, or FALSE if no matches were found > or an error occurred. > > If the optional parameter regs was not passed or the length of > the matched string is 0, this function returns 1. Coupling this behavior to the $matches parameter doesn't make sense -- we know the match length either way, there is no technical reason to distinguish them. However, returning the match length is not particularly useful either, especially due to the need to convert 0-length into 1-length to satisfy "truthy" checks. We could always return 1, which would kind of match the behavior of preg_match() -- however, preg_match() actually returns the number of matches, which is 0 or 1 for preg_match(), while false signals an error. However, mb_ereg() returns false both for no match and for an error. This would result in an odd 1|false return value. The patch canonicalizes mb_ereg() to always return a boolean, where true indicates a match and false indicates no match or error. This also matches the behavior of the mb_ereg_match() and mb_ereg_search() functions. This fixes the default value integrity violation in PHP 8. Closes GH-6331. |
||
|---|---|---|
| .. | ||
| libmbfl | ||
| tests | ||
| ucgendat | ||
| config.m4 | ||
| config.w32 | ||
| CREDITS | ||
| mb_gpc.c | ||
| mb_gpc.h | ||
| mbstring_arginfo.h | ||
| mbstring.c | ||
| mbstring.h | ||
| mbstring.stub.php | ||
| php_mbregex.c | ||
| php_mbregex.h | ||
| php_onig_compat.h | ||
| php_unicode.c | ||
| php_unicode.h | ||
| unicode_data.h | ||