mirror of
https://github.com/php/php-src.git
synced 2024-09-21 18:07:23 +00:00
7b9519a792
This addresses an issue introduced by #4996 and reported in https://bugs.php.net/bug.php?id=80260. Now that PDO::inTransaction() reports the real transaction state of the connection, there may be a mismatch with PDOs internal transaction state (in_tcx). This is compounded by the fact that MySQL performs implicit commits for DDL queries. This patch fixes the issue by making beginTransaction/commit/rollBack work on the real transaction state provided by the driver as well (or falling back to in_tcx if the driver does not support it). This does mean that writing something like $pdo->beginTransaction(); $pdo->exec('CREATE DATABASE ...'); $pdo->rollBack(); // <- illegal will now result in an error, because the CREATE DATABASE already committed the transaction. I believe this behavior is both correct and desired -- otherwise, there is no indication that the code did not behave correctly and the rollBack() was effectively ignored. However, this is also a BC break. Closes GH-6355.
100 lines
2.9 KiB
PHP
100 lines
2.9 KiB
PHP
--TEST--
|
|
PDO::rollBack()
|
|
--SKIPIF--
|
|
<?php
|
|
require_once(__DIR__ . DIRECTORY_SEPARATOR . 'skipif.inc');
|
|
require_once(__DIR__ . DIRECTORY_SEPARATOR . 'mysql_pdo_test.inc');
|
|
MySQLPDOTest::skip();
|
|
$db = MySQLPDOTest::factory();
|
|
if (false == MySQLPDOTest::detect_transactional_mysql_engine($db))
|
|
die("skip Transactional engine not found");
|
|
?>
|
|
--FILE--
|
|
<?php
|
|
require_once(__DIR__ . DIRECTORY_SEPARATOR . 'mysql_pdo_test.inc');
|
|
$db = MySQLPDOTest::factory();
|
|
MySQLPDOTest::createTestTable($db, MySQLPDOTest::detect_transactional_mysql_engine($db));
|
|
|
|
$db->beginTransaction();
|
|
|
|
$row = $db->query('SELECT COUNT(*) AS _num FROM test')->fetch(PDO::FETCH_ASSOC);
|
|
$num = $row['_num'];
|
|
|
|
$db->query("INSERT INTO test(id, label) VALUES (100, 'z')");
|
|
$num++;
|
|
$row = $db->query('SELECT COUNT(*) AS _num FROM test')->fetch(PDO::FETCH_ASSOC);
|
|
if ($row['_num'] != $num)
|
|
printf("[001] INSERT has failed, test will fail\n");
|
|
|
|
$db->rollBack();
|
|
$num--;
|
|
$row = $db->query('SELECT COUNT(*) AS _num FROM test')->fetch(PDO::FETCH_ASSOC);
|
|
if ($row['_num'] != $num)
|
|
printf("[002] ROLLBACK has failed\n");
|
|
|
|
$db->beginTransaction();
|
|
$db->query("INSERT INTO test(id, label) VALUES (100, 'z')");
|
|
$db->query('DROP TABLE IF EXISTS test2');
|
|
$db->query('CREATE TABLE test2(id INT)');
|
|
$num++;
|
|
try {
|
|
$db->rollBack();
|
|
$failed = false;
|
|
} catch (PDOException $e) {
|
|
$failed = true;
|
|
}
|
|
if (!$failed) {
|
|
printf("[003] Rollback should have failed\n");
|
|
}
|
|
|
|
$db->query('DROP TABLE IF EXISTS test2');
|
|
$db->query('CREATE TABLE test2(id INT) ENGINE=MyISAM');
|
|
$db->beginTransaction();
|
|
$db->query('INSERT INTO test2(id) VALUES (1)');
|
|
$db->rollBack();
|
|
$row = $db->query('SELECT COUNT(*) AS _num FROM test2')->fetch(PDO::FETCH_ASSOC);
|
|
if ($row['_num'] != 1)
|
|
printf("[003] ROLLBACK should have no effect\n");
|
|
|
|
$db->query('DROP TABLE IF EXISTS test2');
|
|
|
|
$db->setAttribute(PDO::ATTR_AUTOCOMMIT, 1);
|
|
$db->beginTransaction();
|
|
$db->query('DELETE FROM test');
|
|
$db->rollBack();
|
|
var_dump($db->getAttribute(PDO::ATTR_AUTOCOMMIT));
|
|
|
|
$db->setAttribute(PDO::ATTR_AUTOCOMMIT, 0);
|
|
$db->beginTransaction();
|
|
$db->query('DELETE FROM test');
|
|
$db->rollBack();
|
|
var_dump($db->getAttribute(PDO::ATTR_AUTOCOMMIT));
|
|
|
|
$db->setAttribute(PDO::ATTR_AUTOCOMMIT, 1);
|
|
$db->beginTransaction();
|
|
$db->query('DELETE FROM test');
|
|
$db->commit();
|
|
var_dump($db->getAttribute(PDO::ATTR_AUTOCOMMIT));
|
|
|
|
$db->setAttribute(PDO::ATTR_AUTOCOMMIT, 0);
|
|
$db->beginTransaction();
|
|
$db->query('DELETE FROM test');
|
|
$db->commit();
|
|
var_dump($db->getAttribute(PDO::ATTR_AUTOCOMMIT));
|
|
|
|
print "done!";
|
|
?>
|
|
--CLEAN--
|
|
<?php
|
|
require __DIR__ . '/mysql_pdo_test.inc';
|
|
$db = MySQLPDOTest::factory();
|
|
$db->exec('DROP TABLE IF EXISTS test');
|
|
$db->exec('DROP TABLE IF EXISTS test2');
|
|
?>
|
|
--EXPECT--
|
|
int(1)
|
|
int(0)
|
|
int(1)
|
|
int(0)
|
|
done!
|