mirror of
https://github.com/php/php-src.git
synced 2024-09-21 18:07:23 +00:00
d11734b4b0
TLS is already used in TSRM, the way exporting the tsrm cache through a thread local variable is not portable. Additionally, the current patch suffers from bugs which are hard to find, but prevent it to be worky with apache. What is done here is mainly uses the idea from the RFC patch, but - __thread variable is removed - offset math and declarations are removed - extra macros and definitions are removed What is done merely is - use an inline function to access the tsrm cache. The function uses the portable tsrm_tls_get macro which is cheap - all the TSRM_* macros are set to placebo. Thus this opens the way remove them later Except that, the logic is old. TSRMLS_FETCH will have to be done once per thread, then tsrm_get_ls_cache() can be used. Things seeming to be worky are cli, cli server and apache. I also tried to enable bz2 shared and it has worked out of the box. The change is yet minimal diffing to the current master bus is a worky start, IMHO. Though will have to recheck the other previously done SAPIs - embed and cgi. The offsets can be added to the tsrm_resource_type struct, then it'll not be needed to declare them in the userspace. Even the "done" member type can be changed to int16 or smaller, then adding the offset as int16 will not change the struct size. As well on the todo might be removing the hashed storage, thread_id != thread_id and linked list logic in favour of the explicit TLS operations.
52 lines
1.9 KiB
C
52 lines
1.9 KiB
C
/*
|
|
+----------------------------------------------------------------------+
|
|
| PHP Version 7 |
|
|
+----------------------------------------------------------------------+
|
|
| Copyright (c) 1997-2014 The PHP Group |
|
|
+----------------------------------------------------------------------+
|
|
| This source file is subject to version 3.01 of the PHP license, |
|
|
| that is bundled with this package in the file LICENSE, and is |
|
|
| available through the world-wide-web at the following url: |
|
|
| http://www.php.net/license/3_01.txt |
|
|
| If you did not receive a copy of the PHP license and are unable to |
|
|
| obtain it through the world-wide-web, please send a note to |
|
|
| license@php.net so we can mail you a copy immediately. |
|
|
+----------------------------------------------------------------------+
|
|
| Author: Wez Furlong <wez@php.net> |
|
|
+----------------------------------------------------------------------+
|
|
*/
|
|
|
|
/* $Id$ */
|
|
|
|
#ifndef PHP_WIN32_GLOBALS_H
|
|
#define PHP_WIN32_GLOBALS_H
|
|
|
|
/* misc globals for thread-safety under win32 */
|
|
|
|
typedef struct _php_win32_core_globals php_win32_core_globals;
|
|
|
|
#ifdef ZTS
|
|
# define PW32G(v) TSRMG(php_win32_core_globals_id, php_win32_core_globals*, v)
|
|
extern PHPAPI int php_win32_core_globals_id;
|
|
#else
|
|
# define PW32G(v) (the_php_win32_core_globals.v)
|
|
extern PHPAPI struct _php_win32_core_globals the_php_win32_core_globals;
|
|
#endif
|
|
|
|
struct _php_win32_core_globals {
|
|
/* syslog */
|
|
char *log_header;
|
|
HANDLE log_source;
|
|
|
|
HKEY registry_key;
|
|
HANDLE registry_event;
|
|
HashTable *registry_directories;
|
|
};
|
|
|
|
void php_win32_core_globals_ctor(void *vg TSRMLS_DC);
|
|
void php_win32_core_globals_dtor(void *vg TSRMLS_DC);
|
|
PHP_RSHUTDOWN_FUNCTION(win32_core_globals);
|
|
|
|
#endif
|
|
|