mirror of
https://github.com/php/php-src.git
synced 2024-09-21 18:07:23 +00:00
47a2e5c785
Currently, dynamically declared functions and closures are inserted into the function table under a runtime definition key, and then later possibly renamed. When opcache is not used and a file containing a closure is repeatedly included, this leads to a very large memory leak, as the no longer needed closure declarations will never be freed (https://bugs.php.net/bug.php?id=76982). With this patch, dynamic functions are instead stored in a dynamic_func_defs member on the op_array, which opcodes reference by index. When the parent op_array is destroyed, the dynamic_func_defs it contains are also destroyed (unless they are stilled used elsewhere, e.g. because they have been bound, or are used by a live closure). This resolves the fundamental part of the leak, though doesn't completely fix it yet due to some arena allocations. The main non-obvious change here is to static variable handling: We can't destroy static_variables_ptr in destroy_op_array, as e.g. that would clear the static variables in a dynamic function when the op_array containing it is destroyed. Static variable destruction is separated out for this reason (we already do static variable destruction separately for normal functions, so we only need to handle main scripts). Closes GH-5595.
22 lines
283 B
PHP
22 lines
283 B
PHP
--TEST--
|
|
Static variables in dynamically declared function (first use before dynamic def dtor)
|
|
--FILE--
|
|
<?php
|
|
|
|
$code = <<<'CODE'
|
|
if (1) {
|
|
function test() {
|
|
static $x = 0;
|
|
var_dump(++$x);
|
|
}
|
|
test();
|
|
}
|
|
CODE;
|
|
eval($code);
|
|
test();
|
|
|
|
?>
|
|
--EXPECT--
|
|
int(1)
|
|
int(2)
|