mirror of
https://github.com/php/php-src.git
synced 2024-09-29 05:46:06 +00:00
3d3f11ede4
Since long the default PHP charset is UTF-8, however the Windows part is out of step with this important point. The current implementation in PHP doesn't technically permit to handle UTF-8 filepath and several other things. Till now, only the ANSI compatible APIs are being used. Here is more about it https://msdn.microsoft.com/en-us/library/windows/desktop/dd317752%28v=vs.85%29.aspx The patch fixes not only issues with multibyte filenames under incompatible codepages, but indirectly also issues with some other multibyte encodings like BIG5, Shift-JIS, etc. by providing a clean way to access filenames in UTF-8. Below is a small list of issues from the bug tracker, that are getting fixed: https://bugs.php.net/63401 https://bugs.php.net/41199 https://bugs.php.net/50203 https://bugs.php.net/71509 https://bugs.php.net/64699 https://bugs.php.net/64506 https://bugs.php.net/30195 https://bugs.php.net/65358 https://bugs.php.net/61315 https://bugs.php.net/70943 https://bugs.php.net/70903 https://bugs.php.net/63593 https://bugs.php.net/54977 https://bugs.php.net/54028 https://bugs.php.net/43148 https://bugs.php.net/30730 https://bugs.php.net/33350 https://bugs.php.net/35300 https://bugs.php.net/46990 https://bugs.php.net/61309 https://bugs.php.net/69333 https://bugs.php.net/45517 https://bugs.php.net/70551 https://bugs.php.net/50197 https://bugs.php.net/72200 https://bugs.php.net/37672 Yet more related tickets can for sure be found - on bugs.php.net, Stackoverflow and Github. Some of the bugs are pretty recent, some descend to early 2000th, but the user comments in there last even till today. Just for example, bug #30195 was opened in 2004, the latest comment in there was made in 2014. It is certain, that these bugs descend not only to pure PHP use cases, but get also redirected from the popular PHP based projects. Given the modern systems (and those supported by PHP) are always based on NTFS, there is no excuse to keep these issues unresolved. The internalization approach on Windows is in many ways different from UNIX and Linux, while it supports and is based on Unicode. It depends on the current system code page, APIs used and exact kind how the binary was compiled The locale doesn't affect the way Unicode or ANSI API work. PHP in particular is being compiled without _UNICODE defined and this is conditioned by the way we handle strings. Here is more about it https://msdn.microsoft.com/en-us/library/tsbaswba.aspx However, with any system code page ANSI functions automatically convert paths to UTF-16. Paths in some encodings incompatible with the current system code page, won't work correctly with ANSI APIs. PHP till now only uses the ANSI Windows APIs. For example, on a system with the current code page 1252, the paths in cp1252 are supported and transparently converted to UTF-16 by the ANSI functions. Once one wants to handle a filepath encoded with cp932 on that particular system, an ANSI or a POSIX compatible function used in PHP will produce an erroneous result. When trying to convert that cp932 path to UTF-8 and passing to the ANSI functions, an ANSI function would likely interpret the UTF-8 string as some string in the current code page and create a filepath that represents every single byte of the UTF-8 string. These behaviors are not only broken but also disregard the documented INI settings. This patch solves the issies with the multibyte paths on Windows by intelligently enforcing the usage of the Unicode aware APIs. For functions expect Unicode (fe CreateFileW, FindFirstFileW, etc.), arguments will be converted to UTF-16 wide chars. For functions returning Unicode aware data (fe GetCurrentDirectoryW, etc.), resulting wide string is converted back to char's depending on the current PHP charset settings, either to the current ANSI codepage (this is the behavior prior to this patch) or to UTF-8 (the default behavior). In a particular case, users might have to explicitly set internal_encoding or default_charset, if filenames in ANSI codepage are necessary. Current tests show no regressions and witness that this will be an exotic case, the current default UTF-8 encoding is compatible with any supported system. The dependency libraries are long switching to Unicode APIs, so some tests were also added for extensions not directly related to streams. At large, the patch brings over 150 related tests into the core. Those target and was run on various environments with European, Asian, etc. codepages. General PHP frameworks was tested and showed no regressions. The impact on the current C code base is low, the most places affected are the Windows only places in the three files tsrm_win32.c, zend_virtual_cwd.c and plain_wrapper.c. The actual implementation of the most of the wide char supporting functionality is in win32/ioutil.* and win32/codepage.*, several low level functionsare extended in place to avoid reimplementation for now. No performance impact was sighted. As previously mentioned, the ANSI APIs used prior the patch perform Unicode conversions internally. Using the Unicode APIs directly while doing custom conversions just retains the status quo. The ways to optimize it are open (fe. by implementing caching for the strings converted to wide variants). The long path implementation is user transparent. If a path exceeds the length of _MAX_PATH, it'll be automatically prefixed with \\?\. The MAXPATHLEN is set to 2048 bytes. Appreciation to Pierre Joye, Matt Ficken, @algo13 and others for tips, ideas and testing. Thanks. |
||
|---|---|---|
| .. | ||
| 001.phpt | ||
| 002.phpt | ||
| 003.phpt | ||
| 004-mb.phpt | ||
| 004.phpt | ||
| 004.txt.gz | ||
| 004私はガラスを食べられます.txt.gz | ||
| 005.phpt | ||
| 006.phpt | ||
| 007.phpt | ||
| 008.phpt | ||
| bug51269.phpt | ||
| bug55544-win.phpt | ||
| bug55544.phpt | ||
| bug60761.phpt | ||
| bug61139.phpt | ||
| bug61287.phpt | ||
| bug61443.phpt | ||
| bug61820.phpt | ||
| bug65391.phpt | ||
| bug67724.gz.gz | ||
| bug67724.phpt | ||
| bug_34821.phpt | ||
| bug_40189.phpt | ||
| bug_52944_corrupted_data.inc | ||
| bug_52944.phpt | ||
| compress_zlib_wrapper.phpt | ||
| data.inc | ||
| deflate_add_basic.phpt | ||
| deflate_add_block_v123.phpt | ||
| deflate_add_error.phpt | ||
| deflate_init_error.phpt | ||
| deflate_init_reuse.phpt | ||
| dictionary_usage.phpt | ||
| func.inc | ||
| gzclose_basic.phpt | ||
| gzclose_error.phpt | ||
| gzcompress_basic1.phpt | ||
| gzcompress_error1.phpt | ||
| gzcompress_variation1.phpt | ||
| gzdeflate_basic1.phpt | ||
| gzdeflate_error1.phpt | ||
| gzdeflate_variation1.phpt | ||
| gzencode_basic1.phpt | ||
| gzencode_error1.phpt | ||
| gzencode_variation1-win32.phpt | ||
| gzencode_variation1.phpt | ||
| gzencode_variation2-win32.phpt | ||
| gzencode_variation2.phpt | ||
| gzeof_basic.phpt | ||
| gzeof_error.phpt | ||
| gzeof_variation1.phpt | ||
| gzfile_basic2.phpt | ||
| gzfile_basic.phpt | ||
| gzfile_error.phpt | ||
| gzfile_variation1.phpt | ||
| gzfile_variation2.phpt | ||
| gzfile_variation3.phpt | ||
| gzfile_variation4.phpt | ||
| gzfile_variation5.phpt | ||
| gzfile_variation6.phpt | ||
| gzfile_variation7.phpt | ||
| gzfile_variation8.phpt | ||
| gzfile_variation9.phpt | ||
| gzfile_variation10.phpt | ||
| gzfile_variation11.phpt | ||
| gzfile_variation12.phpt | ||
| gzfile_variation13.phpt | ||
| gzfile_variation14.phpt | ||
| gzfile_variation15.phpt | ||
| gzfilegzreadfile.phpt | ||
| gzgetc_basic_1.phpt | ||
| gzgetc_basic.phpt | ||
| gzgetc_error.phpt | ||
| gzgets_basic.phpt | ||
| gzgets_error.phpt | ||
| gzgetss.gz | ||
| gzgetss.phpt | ||
| gzgetss.test | ||
| gzinflate_error1.phpt | ||
| gzinflate_length.phpt | ||
| gzinflate-bug42663.phpt | ||
| gzopen_basic2.phpt | ||
| gzopen_basic.phpt | ||
| gzopen_error.phpt | ||
| gzopen_include_path.inc | ||
| gzopen_variation1.phpt | ||
| gzopen_variation2.phpt | ||
| gzopen_variation3.phpt | ||
| gzopen_variation4.phpt | ||
| gzopen_variation5.phpt | ||
| gzopen_variation6.phpt | ||
| gzopen_variation7.phpt | ||
| gzopen_variation8.phpt | ||
| gzopen_variation9.phpt | ||
| gzpassthru_basic.phpt | ||
| gzpassthru_error.phpt | ||
| gzputs_basic.phpt | ||
| gzread_basic.phpt | ||
| gzread_error2.phpt | ||
| gzread_error.phpt | ||
| gzread_variation1.phpt | ||
| gzreadgzwrite.phpt | ||
| gzreadgzwriteplain.phpt | ||
| gzrewind_basic2.phpt | ||
| gzrewind_basic.phpt | ||
| gzrewind_error.phpt | ||
| gzrewind_variation1.phpt | ||
| gzseek_basic2.phpt | ||
| gzseek_basic.phpt | ||
| gzseek_error.phpt | ||
| gzseek_variation1.phpt | ||
| gzseek_variation2.phpt | ||
| gzseek_variation3.phpt | ||
| gzseek_variation4.phpt | ||
| gzseek_variation5.phpt | ||
| gzseek_variation6.phpt | ||
| gzseek_variation7.phpt | ||
| gztell_basic2.phpt | ||
| gztell_basic.phpt | ||
| gztell_error.phpt | ||
| gzuncompress_basic1.phpt | ||
| gzuncompress_error1.phpt | ||
| gzwrite_basic.phpt | ||
| gzwrite_error2.phpt | ||
| gzwrite_error.phpt | ||
| gzwrite_variation1.phpt | ||
| inflate_add_basic.phpt | ||
| inflate_add_error.phpt | ||
| inflate_init_error.phpt | ||
| inflate_init_reuse.phpt | ||
| ob_001.phpt | ||
| ob_002.phpt | ||
| ob_003.phpt | ||
| ob_004.phpt | ||
| ob_005.phpt | ||
| ob_gzhandler_legacy_002.phpt | ||
| readgzfile_basic2.phpt | ||
| readgzfile_basic.phpt | ||
| readgzfile_error.phpt | ||
| readgzfile_variation1.phpt | ||
| readgzfile_variation2.phpt | ||
| readgzfile_variation3.phpt | ||
| readgzfile_variation4.phpt | ||
| readgzfile_variation5.phpt | ||
| readgzfile_variation6.phpt | ||
| readgzfile_variation7.phpt | ||
| readgzfile_variation8.phpt | ||
| readgzfile_variation9.phpt | ||
| readgzfile_variation10.phpt | ||
| readgzfile_variation11.phpt | ||
| readgzfile_variation12.phpt | ||
| readgzfile_variation13.phpt | ||
| readgzfile_variation14.phpt | ||
| readgzfile_variation15.phpt | ||
| reading_include_path.inc | ||
| zlib_filter_deflate2.phpt | ||
| zlib_filter_deflate.phpt | ||
| zlib_filter_inflate2.phpt | ||
| zlib_filter_inflate.phpt | ||
| zlib_scheme_copy_basic.phpt | ||
| zlib_scheme_copy_variation1.phpt | ||
| zlib_scheme_copy_variation2.phpt | ||
| zlib_scheme_dir_basic.phpt | ||
| zlib_scheme_file_basic.phpt | ||
| zlib_scheme_file_get_contents_basic.phpt | ||
| zlib_scheme_file_put_contents_basic.phpt | ||
| zlib_scheme_file_read_file_basic.phpt | ||
| zlib_scheme_fopen_basic.phpt | ||
| zlib_scheme_fopen_variation1.phpt | ||
| zlib_scheme_rename_basic.phpt | ||
| zlib_scheme_stat_basic2.phpt | ||
| zlib_scheme_stat_basic.phpt | ||
| zlib_scheme_unlink_basic.phpt | ||
| zlib_wrapper_fflush_basic.phpt | ||
| zlib_wrapper_flock_basic.phpt | ||
| zlib_wrapper_fstat_basic.phpt | ||
| zlib_wrapper_ftruncate_basic.phpt | ||
| zlib_wrapper_meta_data_basic.phpt | ||