mirror of
https://github.com/php/php-src.git
synced 2024-09-21 18:07:23 +00:00
b10416a652
This deprecates passing null to non-nullable scale arguments of internal functions, with the eventual goal of making the behavior consistent with userland functions, where null is never accepted for non-nullable arguments. This change is expected to cause quite a lot of fallout. In most cases, calling code should be adjusted to avoid passing null. In some cases, PHP should be adjusted to make some function arguments nullable. I have already fixed a number of functions before landing this, but feel free to file a bug if you encounter a function that doesn't accept null, but probably should. (The rule of thumb for this to be applicable is that the function must have special behavior for 0 or "", which is distinct from the natural behavior of the parameter.) RFC: https://wiki.php.net/rfc/deprecate_null_to_scalar_internal_arg Closes GH-6475.
22 lines
559 B
PHP
22 lines
559 B
PHP
--TEST--
|
|
Bug #64677 (execution operator `` stealing surrounding arguments)
|
|
--FILE--
|
|
<?PHP
|
|
class cat {
|
|
public function show_output($prepend, $output = '') {
|
|
}
|
|
}
|
|
$cat = new cat();
|
|
$cat->show_output('Files: ', trim((string) `cd .`)); // this gives invalid args to shell_exec
|
|
$cat->show_output('Files: ', `cd .`); // this causes a segmentation fault
|
|
$cat->show_output(`cd .`); // this causes a segmentation fault
|
|
|
|
function show_outputa($prepend, $output) {
|
|
echo "Okey";
|
|
}
|
|
show_outputa('Files: ', `cd .`); // this works as expected
|
|
|
|
?>
|
|
--EXPECT--
|
|
Okey
|