mirror of
https://github.com/php/php-src.git
synced 2024-09-22 18:37:25 +00:00
7b9519a792
This addresses an issue introduced by #4996 and reported in https://bugs.php.net/bug.php?id=80260. Now that PDO::inTransaction() reports the real transaction state of the connection, there may be a mismatch with PDOs internal transaction state (in_tcx). This is compounded by the fact that MySQL performs implicit commits for DDL queries. This patch fixes the issue by making beginTransaction/commit/rollBack work on the real transaction state provided by the driver as well (or falling back to in_tcx if the driver does not support it). This does mean that writing something like $pdo->beginTransaction(); $pdo->exec('CREATE DATABASE ...'); $pdo->rollBack(); // <- illegal will now result in an error, because the CREATE DATABASE already committed the transaction. I believe this behavior is both correct and desired -- otherwise, there is no indication that the code did not behave correctly and the rollBack() was effectively ignored. However, this is also a BC break. Closes GH-6355.
113 lines
2.4 KiB
PHP
113 lines
2.4 KiB
PHP
--TEST--
|
|
MySQL PDO class inTransaction
|
|
--SKIPIF--
|
|
<?php
|
|
require_once(__DIR__ . DIRECTORY_SEPARATOR . 'skipif.inc');
|
|
require_once(__DIR__ . DIRECTORY_SEPARATOR . 'mysql_pdo_test.inc');
|
|
MySQLPDOTest::skip();
|
|
?>
|
|
--FILE--
|
|
<?php
|
|
require_once(__DIR__ . DIRECTORY_SEPARATOR . 'mysql_pdo_test.inc');
|
|
|
|
const BEGIN = ['BEGIN', 'START TRANSACTION'];
|
|
const END = ['COMMIT', 'ROLLBACK'];
|
|
|
|
$db = MySQLPDOTest::factory();
|
|
// $db->setAttribute(PDO::ATTR_EMULATE_PREPARES, false); // mysql does not support
|
|
foreach (BEGIN as $begin) {
|
|
foreach (END as $end) {
|
|
foreach (['exec', 'query', 'execute'] as $w) {
|
|
foreach ([$begin, $end] as $command) {
|
|
switch ($w) {
|
|
case 'exec':
|
|
$db->exec($command);
|
|
break;
|
|
case'query':
|
|
$db->query($command)->execute();
|
|
break;
|
|
case 'execute':
|
|
/* EMULATE_PREPARES = QUERY */
|
|
$db->prepare($command)->execute();
|
|
break;
|
|
default:
|
|
assert(0);
|
|
}
|
|
var_dump($db->inTransaction());
|
|
}
|
|
}
|
|
}
|
|
}
|
|
echo "\n";
|
|
|
|
// Mixing PDO transaction API and explicit queries.
|
|
foreach (END as $end) {
|
|
$db->beginTransaction();
|
|
var_dump($db->inTransaction());
|
|
$db->exec($end);
|
|
var_dump($db->inTransaction());
|
|
}
|
|
|
|
$db->exec('START TRANSACTION');
|
|
var_dump($db->inTransaction());
|
|
$db->rollBack();
|
|
var_dump($db->inTransaction());
|
|
$db->exec('START TRANSACTION');
|
|
var_dump($db->inTransaction());
|
|
$db->commit();
|
|
var_dump($db->inTransaction());
|
|
echo "\n";
|
|
|
|
// DDL query causes an implicit commit.
|
|
$db->beginTransaction();
|
|
var_dump($db->inTransaction());
|
|
$db->exec('DROP TABLE IF EXISTS test');
|
|
var_dump($db->inTransaction());
|
|
|
|
// We should be able to start a new transaction after the implicit commit.
|
|
$db->beginTransaction();
|
|
var_dump($db->inTransaction());
|
|
$db->commit();
|
|
var_dump($db->inTransaction());
|
|
|
|
?>
|
|
--EXPECT--
|
|
bool(true)
|
|
bool(false)
|
|
bool(true)
|
|
bool(false)
|
|
bool(true)
|
|
bool(false)
|
|
bool(true)
|
|
bool(false)
|
|
bool(true)
|
|
bool(false)
|
|
bool(true)
|
|
bool(false)
|
|
bool(true)
|
|
bool(false)
|
|
bool(true)
|
|
bool(false)
|
|
bool(true)
|
|
bool(false)
|
|
bool(true)
|
|
bool(false)
|
|
bool(true)
|
|
bool(false)
|
|
bool(true)
|
|
bool(false)
|
|
|
|
bool(true)
|
|
bool(false)
|
|
bool(true)
|
|
bool(false)
|
|
bool(true)
|
|
bool(false)
|
|
bool(true)
|
|
bool(false)
|
|
|
|
bool(true)
|
|
bool(false)
|
|
bool(true)
|
|
bool(false)
|