Commit Graph

1506 Commits

Author SHA1 Message Date
Greg Beaver
49a2893adb simple fix for core bug #362 - raiseError() doesn't return a reference, why should throwError()? 2003-12-06 02:00:33 +00:00
Andrei Zmievski
a3d2fd336c MFB 2003-12-05 22:02:48 +00:00
Greg Beaver
5252f3faa9 merge downloader code into HEAD - it works
fix bug found in uninstall
2003-12-04 02:11:40 +00:00
Greg Beaver
d2ad2841bd unit test for new code - proves it works 2003-12-04 02:01:46 +00:00
Greg Beaver
07a0281d00 add helper methods needed - now it is 100% unit tested 2003-12-04 02:00:39 +00:00
Greg Beaver
e8468911ed fixed minor bug 2003-12-04 01:35:45 +00:00
Greg Beaver
ad9629d2bf finished unit test 2003-12-04 01:35:27 +00:00
Greg Beaver
1558f748e3 fix bugs found in unit-testing, one BC issue also 2003-12-04 01:22:50 +00:00
Greg Beaver
2ab2d8263c fix notice 2003-12-04 01:22:12 +00:00
Greg Beaver
dba21314ce another segment working 2003-12-04 01:22:00 +00:00
Greg Beaver
172bf25830 another test case, small fix for XML_RPC caching borking working tests 2003-12-03 23:46:10 +00:00
Greg Beaver
ed3167eada another tgz for test case comparison 2003-12-03 23:36:00 +00:00
Greg Beaver
604dcdd256 add part of a test case 2003-12-03 23:24:47 +00:00
Greg Beaver
577cf36f91 remove unnecessary notice generator in certain cases 2003-12-03 23:00:05 +00:00
Greg Beaver
4e5e628637 new unit test for downloader - incomplete.
WARNING: this test requires a fully functional pearweb server at address pear.Chiara, with several packages available for download.  This one will fail until Martin has time to set up test.pear.php.net as the server.
2003-12-03 22:53:58 +00:00
Greg Beaver
35bdc2f7eb duhhh... 2003-12-03 22:39:55 +00:00
Greg Beaver
036ac99eef new test case and supporting files - incomplete, but works as it is 2003-12-01 04:51:21 +00:00
Greg Beaver
cd4baaf654 potential major booboo in unit test, probably won't affect this one 2003-12-01 04:04:07 +00:00
Greg Beaver
cde3509868 2 bugs found here, added deprecation warning for those who have written their own PEAR application 2003-12-01 01:02:40 +00:00
Greg Beaver
3e60df640e 2 bugs found here 2003-12-01 01:00:57 +00:00
Greg Beaver
1b95c31c77 2 bugs found 2003-12-01 00:59:14 +00:00
Greg Beaver
b27f71ca58 fclose() might be needed 2003-12-01 00:43:34 +00:00
Greg Beaver
87365b0149 new unit test 2003-12-01 00:36:47 +00:00
Greg Beaver
2939c3539d fix bug found by unit testing in package ordering 2003-12-01 00:15:53 +00:00
Greg Beaver
21714261a6 fix unit test 2003-12-01 00:14:37 +00:00
Greg Beaver
3db2e9bdcc minor booboo 2003-12-01 00:14:16 +00:00
Greg Beaver
df5317e336 new unit test - test works, but there is a serious bug in sortPkgDeps to be fixed, as unearthed by this test 2003-11-30 23:43:19 +00:00
Greg Beaver
bfc02f7223 finish unit test with non-working download test with callback 2003-11-30 22:51:17 +00:00
Greg Beaver
398dec718a add in skip condition for internet offline, and callback test 2003-11-30 22:49:33 +00:00
Greg Beaver
685e7a365a first unsuccessful test works 2003-11-30 22:39:24 +00:00
Greg Beaver
2276704637 first successful download test works :) 2003-11-30 22:37:47 +00:00
Greg Beaver
a7d7f311f0 beginning framework for PEAR_Common::downloadHttp test - binary test file 2003-11-30 22:31:35 +00:00
Greg Beaver
5c60fe3a0e beginning framework for PEAR_Common::downloadHttp test 2003-11-30 22:31:00 +00:00
Greg Beaver
44e2b42692 tweak tests 2003-11-30 22:24:14 +00:00
Greg Beaver
0b24e0a404 remove old holdover code that has no purpose 2003-11-30 22:01:22 +00:00
Greg Beaver
76e83f576c ...and with these changes, 100% BC is maintained. 2003-11-30 22:00:59 +00:00
Greg Beaver
c7c5d7689d experimental code shuffling, moved download() into a new class, PEAR_Downloader.
Reasons:
- 7 parameters for a method with lots of pass by reference
  implies the need to save state, i.e. use an object
- cleaner code.  download() can be easily split into 4 separate but related methods
- Installer.php is now exclusively used for installation
- future extensibility: switching to channels or local package repositories from
  using PEAR_Remote is easy.  Simply extend the API for PEAR_Downloader:
  no changes needed to the installer at all

to install for testing purposes, use

pear upgrade --force package-PEAR-new-Downloader.xml

to uninstall, use

pear upgrade --force package-PEAR.xml
2003-11-30 05:39:02 +00:00
Greg Beaver
cc27a3f03d got it - the pattern ONLY needs addslashes for windows paths 2003-11-30 00:14:22 +00:00
Greg Beaver
6f1625d29b fix one part - can't get the ereg() to match on windows, will fix when I figure out why 2003-11-29 23:37:56 +00:00
Greg Beaver
2c4e1f1d4a fix up unit tests - registry was ridiculously out of date. Guess nobody ever runs these... 2003-11-29 23:36:46 +00:00
Greg Beaver
e882ab4817 new test case 2003-11-29 20:45:09 +00:00
Greg Beaver
154db581ae finish unit test 2003-11-29 20:35:43 +00:00
Greg Beaver
e39e452e30 add in environment variable for easy non-skipping 2003-11-29 19:43:05 +00:00
Greg Beaver
24409dc035 fix some bugs found in the unit test 2003-11-29 19:42:19 +00:00
Greg Beaver
595b433b25 start on a new unit test 2003-11-29 19:39:51 +00:00
Greg Beaver
56908214ab add dependency on xml extension - we need it for every installation/package function 2003-11-29 17:56:36 +00:00
Greg Beaver
e57b75eff4 fix Bug #324 pear -G gives Fatal Error (PHP-GTK not installed, but error is at engine level) 2003-11-29 16:33:54 +00:00
Greg Beaver
6c9fa67eca fix Bug #293 [Patch] PEAR_Error not calling static method callbacks for error-handler 2003-11-26 15:08:42 +00:00
Martin Jansen
6ff584e2fb * Fix potential warning 2003-11-17 09:15:28 +00:00
Greg Beaver
137adbb708 necessary refinement 2003-11-17 06:07:15 +00:00
Greg Beaver
82bd0915f5 fix bug #248, --force does not work as expected 2003-11-17 05:56:50 +00:00
Greg Beaver
c05dfddda4 fix bug #249 2003-11-17 05:45:49 +00:00
Stig Bakken
c67848319a * "chmod +x" when extracting archived executable files 2003-11-17 02:27:23 +00:00
Greg Beaver
997db6551a checkExtension() was a complete disaster, can't believe it didn't cause any problems before. 2003-11-01 05:06:27 +00:00
Greg Beaver
1e2a437c0c new unit test 2003-11-01 05:05:34 +00:00
Greg Beaver
43d1ad8372 new unit test 2003-11-01 03:32:15 +00:00
Greg Beaver
48bca64444 fix bug found by unit test 2003-11-01 03:31:52 +00:00
Greg Beaver
014d039459 add optional dependencies to test 2003-10-31 22:53:31 +00:00
Greg Beaver
6d0360204d better error messages, fix potential problems in the future 2003-10-31 22:53:20 +00:00
Greg Beaver
5d0cc08805 fix warning 2003-10-31 22:52:33 +00:00
Greg Beaver
70a852ebdc fix test 2003-10-31 22:51:43 +00:00
Greg Beaver
d4150d6095 add fancy SKIPIF code, fix test 2003-10-31 22:46:57 +00:00
Greg Beaver
6c403c7794 add fancy SKIPIF code 2003-10-31 22:39:43 +00:00
Greg Beaver
f51b3c0cb1 fix test 1, add in nifty SKIPIF code 2003-10-31 22:30:37 +00:00
Greg Beaver
5754cfe68c deleted code says it all 2003-10-31 22:22:17 +00:00
Greg Beaver
3caf118763 add in skip to match other tests 2003-10-31 17:41:57 +00:00
Greg Beaver
4da5da699e new test case 2003-10-31 17:39:59 +00:00
Greg Beaver
25e1f920d1 major bug - "not" dependency check would completely fail. Guess nobody ever tried it before :) 2003-10-31 17:22:15 +00:00
Greg Beaver
f3102f9d6b was checking the wrong parameter for a v. - should be checking version 2003-10-31 17:01:39 +00:00
Greg Beaver
8c77fbe743 phpdoc fix 2003-10-31 16:50:56 +00:00
Greg Beaver
899432fac8 finished unit test 2003-10-31 05:14:32 +00:00
Greg Beaver
9ed1956bfa bump to 1.3b4, add note about fix for #171 2003-10-31 04:56:08 +00:00
Greg Beaver
5c76e88d0e fix #171, --alldeps with a rel="eq" should install the required version, if possible 2003-10-31 04:52:00 +00:00
Greg Beaver
76d66203f4 add some error control to analyzeSourceCode() for really rare cases - invalid PHP 2003-10-31 01:17:47 +00:00
Greg Beaver
f244e77f6b start on unit test for PEAR_Common 2003-10-31 01:17:04 +00:00
Stig Bakken
5b89e67334 * array_merge is more ticklish in php5 2003-10-27 06:52:14 +00:00
Greg Beaver
663b12796b add #25174 note 2003-10-24 05:34:59 +00:00
Greg Beaver
01a3fdbb3a fixed #25174 Wrong handling of readlink() in OS/Guess.php 2003-10-24 05:33:37 +00:00
Tomas V.V.Cox
f811341773 go with 1.3b3 (will shipped with PHP4.3.4RC2) 2003-10-20 15:33:54 +00:00
Pierre Joye
64e499aaef - Fix RPC call without proxy (silence warnings&notices)
nota bene: the proxy codes should be cleaned, one day ;)
2003-10-16 18:16:38 +00:00
Tomas V.V.Cox
32bf69ea7a Fix Bug #23221 Pear installer - extension re-install segfault 2003-10-10 17:13:37 +00:00
Tomas V.V.Cox
0e128d52bc Partial rewrite of dowload() method:
- Full error checking and reporting
- Avoid downloads as possible
- Made the "force" option work correctly

# Please report any problem with pear install/upgrade
2003-10-10 16:55:38 +00:00
Tomas V.V.Cox
5ab54854a1 avoid chdir() calls
remove duplicated validation checks
(fix bug #66 contributed by Roman)
2003-10-10 12:22:59 +00:00
Tomas V.V.Cox
164b593d23 better version checks (contributed by Roman) 2003-10-06 15:15:56 +00:00
Tomas V.V.Cox
f46b5641b7 use realpath instead of chdir
(Roman Neuhauser <neuhauser@bellavista.cz>)
2003-10-05 19:10:56 +00:00
Martin Jansen
dd66cd587f * Fixing #64 2003-10-05 16:42:18 +00:00
Tomas V.V.Cox
4da2fbe6f0 Don't reapply the error_message_prefix if an error
object is passed to raiseError()
2003-10-05 15:22:21 +00:00
Tomas V.V.Cox
0c9f669cc5 Better fix #61 2003-10-04 17:16:35 +00:00
Tomas V.V.Cox
7630f962f1 Fix: #61 [NEW]: error with pear install in pear 1.3b1
by outputting a full error message plus some help
2003-10-04 16:17:31 +00:00
Tomas V.V.Cox
82e655537e notes++
Bug #25413 Add local installed packages to list-all
  (thanks to Christian DickMann)
2003-10-04 13:02:58 +00:00
Tomas V.V.Cox
349c8a5581 Bug #25413 Add local installed packages to list-all
(thanks to Christian DickMann)
2003-10-04 12:57:34 +00:00
Greg Beaver
77c0beb143 fix warning in rare case (file doesn't exist in package.xml) 2003-10-04 03:58:00 +00:00
Tomas V.V.Cox
faa5ab3f2b starting b3 (hope this could be 1.3 final) 2003-10-02 11:58:29 +00:00
Tomas V.V.Cox
8d1dcefc3d Go with 1.3b2 2003-10-02 11:54:00 +00:00
Tomas V.V.Cox
8b6d6cdc6e Give more info about release states in list-upgrades 2003-09-30 15:22:42 +00:00
Greg Beaver
e898d7c25a better fix for #45.
Now, it will install the newest version that is preferred_state or stabler.
to request a specific state, append -state like pear install Net_NNTP-beta
2003-09-30 02:56:42 +00:00
Tomas V.V.Cox
86bf200e92 preparing 1.3b2 2003-09-29 19:39:18 +00:00
Greg Beaver
dbbc1d2c8c " => &quot;, take 2 2003-09-29 17:44:20 +00:00
Greg Beaver
8ba1dea0ab noted fixed #45, also " => &quot; 2003-09-29 17:42:16 +00:00
Greg Beaver
f688e33454 Bug #45 preferred_state works incorrectly 2003-09-29 17:36:00 +00:00
Tomas V.V.Cox
2a82a826ac Ready for 1.3b1
Removed Changelog
2003-09-29 13:18:48 +00:00
Greg Beaver
0c9a167bea fixed #39 commands that need LOCK_SH fail as non-root 2003-09-28 05:07:27 +00:00
Greg Beaver
b1094807f8 remove dependency on PHP 5 - it works just fine in PHP 4.3 2003-09-24 13:11:52 +00:00
Tomas V.V.Cox
926cfa307c RFC about PECL binary creation and distribution 2003-09-19 16:50:17 +00:00
Greg Beaver
1433d789a5 add rollback for installed_as 2003-09-18 04:32:56 +00:00
Greg Beaver
d560e49713 add rollback test for installed_as 2003-09-18 04:32:46 +00:00
Greg Beaver
c6d102bfe4 finished transaction tests 2003-09-18 04:24:25 +00:00
Greg Beaver
103bab81a3 unit testing finds another bug :)
another case that would cause an endless loop in installed_as file transaction
2003-09-18 03:59:22 +00:00
Greg Beaver
0e957bedc8 add rmdir test, add comment to remind me to finish installed_as test before moving on to next one 2003-09-17 03:44:25 +00:00
Greg Beaver
9a4453ee62 modify chmod test to be truly permissions-filesystem-based-specific 2003-09-17 03:31:59 +00:00
Greg Beaver
5e63a153c8 more file transaction tests 2003-09-17 03:29:55 +00:00
Greg Beaver
c71d1bc43d oops - params are reversed, my bad 2003-09-17 03:22:55 +00:00
Greg Beaver
1b47706fff bug in chmod file transaction operation error message
bug in chmod file transaction test - was testing the perms to see if they were a writable file
2003-09-17 03:19:47 +00:00
Greg Beaver
15c04ee52a phpdoc error 2003-09-17 03:13:56 +00:00
Greg Beaver
e91c4067e4 cut-and-paste error 2003-09-17 00:02:45 +00:00
Greg Beaver
13bf53b658 correct typo "committed"
add error checking to commitFileTransaction()
2003-09-17 00:00:40 +00:00
Greg Beaver
7a0fcc45a8 some beginning tests for commitFileTransaction() 2003-09-17 00:00:21 +00:00
Greg Beaver
1b76db05e7 adding transaction test file (unfinished) 2003-09-16 23:43:47 +00:00
Greg Beaver
a5b67714ae Document addFileOperation()
Add basic test for invalid input, since it is a public method
2003-09-16 23:42:16 +00:00
Tomas V.V.Cox
4920ac3362 more debug code removed *sigh* 2003-09-16 16:53:11 +00:00
Tomas V.V.Cox
cdcc98141e removed debug code 2003-09-16 16:49:26 +00:00
Greg Beaver
f4aaa7c4f0 tweak Tomas's patch for
$ pear install Package-v.tgz

which should work for local files first before checking to see if it can be downloaded
2003-09-16 03:27:55 +00:00
Greg Beaver
4f7eb73e87 fix regexps for package detection and download - should be case-insensitive 2003-09-16 03:26:05 +00:00
Greg Beaver
c65683653c fix invalid replacements - add tests for bad pear-config/package-info replacements 2003-09-16 03:17:08 +00:00
Greg Beaver
896254c71e add tests for invalid replacements 2003-09-16 03:16:46 +00:00
Greg Beaver
9850aae5f3 file transactions used - but startFileTransaction() was never used
inline docs for install() were out of date
2003-09-16 02:42:44 +00:00
Tomas V.V.Cox
d8de1165f9 - Added new notes and split them
- Upgraded me as <lead>

# Greg, advice me when finish with the tests
# then we could fire 1.3b1
2003-09-15 20:32:40 +00:00
Tomas V.V.Cox
e76de52de7 * Implemented the find command (currently supported args:
-type f, -type d, -maxdepth, -name)
* Fixed recursion deep level in _dirToStruct()
2003-09-15 20:17:34 +00:00
Greg Beaver
7811c07e23 pear install net_socket will work now - before it would only work with pear install Net_socket 2003-09-15 13:11:57 +00:00
Greg Beaver
3008135b91 Now empty directories are removed on uninstall, so uninstallation is complete and correct 2003-09-15 05:10:51 +00:00
Greg Beaver
4245451ccd mistaken include_once 'Remote.php' - not sure why it worked at all 2003-09-15 03:36:02 +00:00
Greg Beaver
e4b848d766 move registration of installed location to post-commit 2003-09-15 03:29:12 +00:00
Greg Beaver
8014d0dfac add testing for baseinstalldir attribute 2003-09-15 03:14:12 +00:00
Greg Beaver
88fc290887 add testing for install-as attribute 2003-09-15 03:07:53 +00:00
Greg Beaver
8254b8f49e add testing for md5sum 2003-09-14 20:19:59 +00:00
Greg Beaver
8c3b78aa1c found bug in _installFile() thanks to unit testing.
- if a bad md5sum was found, and --force wasn't specified, the temporary file was never deleted
2003-09-14 20:17:24 +00:00
Greg Beaver
c4e5fed89f adding test for non-existing file 2003-09-14 20:02:07 +00:00
Greg Beaver
3901da3a1d adding test for invalid role 2003-09-14 19:59:06 +00:00
Greg Beaver
0225844ac1 adding replacements section for _installFile() 2003-09-14 19:53:37 +00:00
Greg Beaver
cb5b1690ac new test for _installFile() - not yet complete, but what's there works 2003-09-14 04:24:21 +00:00
Greg Beaver
272c0aaec8 simplify test, split into two 2003-09-14 04:24:05 +00:00
Greg Beaver
dcd7f23e6c verified unit test pear2.phpt works with changes, removing old code 2003-09-11 16:45:03 +00:00
Tomas V.V.Cox
7c9e926f10 "pear -v install" is now more usefull 2003-09-11 14:57:10 +00:00
Tomas V.V.Cox
7d96f7884e Be more nice when downloading files 2003-09-11 14:47:03 +00:00
Tomas V.V.Cox
dfcd61cef7 Fix bug of download tries when a local file is given
to install
2003-09-11 13:36:59 +00:00
Greg Beaver
a344aabb19 missed one segment to comment out 2003-09-11 13:21:07 +00:00
Greg Beaver
140ec7f354 use is_callable() - what a great function! 2003-09-11 13:16:13 +00:00
Greg Beaver
546663f7cd phpdoc correction (kind of serious error :) 2003-09-10 01:40:48 +00:00
Greg Beaver
1465e10781 test for checkDeps 2003-09-10 00:03:12 +00:00
Greg Beaver
79852dfa55 first step in unit testing the installer - tests the download PREG function 2003-09-09 23:40:39 +00:00