Commit Graph

627 Commits

Author SHA1 Message Date
Ilia Alshanetsky
204f9e1a74 Adjusted fix for bug #42978 2007-11-20 23:12:17 +00:00
Ilia Alshanetsky
48878f2ecd Fixed bug #42978 (mismatch between number of bound params and values causes
a crash in pdo_pgsql)
2007-11-20 14:22:27 +00:00
Antony Dovgal
379e8a5970 fix test 2007-11-08 12:40:43 +00:00
Ilia Alshanetsky
d689a10f3a Fixed test 2007-11-04 16:12:13 +00:00
Ilia Alshanetsky
548c25ef1c Fixed bug #43139 PDO ignores ATTR_DEFAULT_FETCH_MODE in some cases with fetchAll() 2007-10-31 12:57:51 +00:00
Ilia Alshanetsky
84f0fba1a5 Test not relavent for sqlite that uses built-in bound syntax 2007-10-30 23:03:23 +00:00
Ilia Alshanetsky
c27a8a41c2 Fixed bug #43130 (Bound parameters cannot have - in their name) 2007-10-29 22:36:26 +00:00
Ilia Alshanetsky
3762dfc09f Fixed bug #42917 (PDO::FETCH_KEY_PAIR doesn't work with setFetchMode) 2007-10-11 20:54:41 +00:00
Yiduo (David) Wang
104290130e MFH: stmt->fetch.func.values is not a zval and should not be freed with FREE_ZVAL 2007-10-08 04:06:15 +00:00
Yiduo (David) Wang
4b4d634cb9 MFH: Added macros for managing zval refcounts and is_ref statuses 2007-10-07 05:22:07 +00:00
Dmitry Stogov
6c810b0d4c Improved memory usage by movig constants to read only memory. (Dmitry, Pierre) 2007-09-27 18:00:48 +00:00
Stanislav Malyshev
1f45d49a0c fix crash if stream is empty and reader function sets buffer as null 2007-09-12 21:21:18 +00:00
Ilia Alshanetsky
910850be51 Fixed bug #42643 (CLI segfaults if using ATTR_PERSISTENT). 2007-09-12 18:26:49 +00:00
Hannes Magnusson
2fc92c9172 - Fixed bug #42452 (PDO classes do not expose Reflection API information)
- Fixed tests
2007-08-30 14:06:12 +00:00
Ilia Alshanetsky
c72d39f763 Fixed bug #41971 (PDOStatement::fetch and PDOStatement::setFetchMode causes
unexpected behavior).
2007-07-31 22:48:42 +00:00
Ilia Alshanetsky
2600cf9c20 Already exists in PECL 2007-07-25 22:26:14 +00:00
Dmitry Stogov
7ec48cb37f Fixed bug #40757 (get_object_vars get nothing in child class)
Fixed bug #41929 (Foreach on object does not iterate over all visible properties)
2007-07-24 11:39:56 +00:00
Antony Dovgal
fe25997d44 fix test 2007-07-23 22:46:03 +00:00
Jani Taskinen
5b71d45eff MFH: sync 2007-07-23 11:53:58 +00:00
Ilia Alshanetsky
20c4198341 Added test for KEY_PAIR code and fixed KEY_PAIR detection code 2007-07-22 15:50:17 +00:00
Ilia Alshanetsky
285316fcff Fixed PDO_FETCH_KEY_PAIR implementation for fetchAll() 2007-07-22 15:14:21 +00:00
Ilia Alshanetsky
39c1705848 Fixed a possible crash inside the constructor 2007-07-16 18:00:18 +00:00
Ilia Alshanetsky
d34bfe5c37 When working with persistent connections re-initialize options on each
connection. Flags like error reporting may differ.
2007-06-28 19:22:52 +00:00
Ilia Alshanetsky
37d1bfed25 Added support for ATTR_TIMEOUT inside pdo_pgsql driver.
Fixed a bug inside PDO's "use persistent" connection detection mechanism
that would trigger connections on "" and "0" values
2007-06-28 03:13:29 +00:00
Ilia Alshanetsky
abffe87d42 Fixed a crash inside PDO when there is more then one instance of a
persistent connection inside a script and PDO object is extended by class
with a destructor
2007-06-27 02:02:18 +00:00
Ilia Alshanetsky
dc1c6f74c8 Fixed bug #41698 (float parameters truncated to integer in prepared
statements).
2007-06-26 01:24:10 +00:00
Ilia Alshanetsky
c084d1c829 Fixed bug #41596 (Fixed a crash inside pdo_pgsql on some non-well-formed
SQL queries).
2007-06-05 22:55:27 +00:00
Ilia Alshanetsky
489c2d739a Fixed test for PostgreSQL 2007-06-03 17:41:21 +00:00
Ilia Alshanetsky
2a6442190c Fixed test to work with postgresql 2007-05-19 15:28:37 +00:00
Hannes Magnusson
4ad45f6566 Fix paths for ext/sqlite 2007-05-17 13:40:12 +00:00
Ilia Alshanetsky
67032ecdf0 Make test work in sqlite 2007-05-16 21:03:46 +00:00
Antony Dovgal
5e7b464517 typofix 2007-05-16 20:04:32 +00:00
Ilia Alshanetsky
efd7846d34 [DOC] Added PDO::FETCH_KEY_PAIR mode that will fetch a 2 column result set
into an associated array.
2007-05-16 19:33:57 +00:00
Antony Dovgal
1f65545121 fix test names 2007-05-07 18:03:01 +00:00
Ilia Alshanetsky
7810fc89fa Fixed bug #41215 (setAttribute return code reversed). 2007-04-29 14:47:34 +00:00
Antony Dovgal
9ab23a7e53 fix leaks in row_get_properties()
thanks to Kellen Bombardier for noticing
2007-04-17 17:00:16 +00:00
Antony Dovgal
c73225ab61 MFH: fix #40727 (segfault in PDO when failed to bind parameters) 2007-03-07 09:03:07 +00:00
Ilia Alshanetsky
ff3e825083 Fixed bug #40417 (Allow multiple instances of the same named PDO token in
prepared statement emulation code).
2007-03-06 00:52:55 +00:00
Ilia Alshanetsky
a8c006235c Better generated parser 2007-02-02 00:03:33 +00:00
Ilia Alshanetsky
79dfb302b1 Fixed test mixup 2007-02-02 00:00:33 +00:00
Ilia Alshanetsky
c219c6f4a8 Fixed bug #40285 (The PDO prepare parser goes into an infinite loop in
some instances).
2007-02-01 00:12:39 +00:00
Antony Dovgal
58e96c4c10 nullify param.parameter and avoid destroying it twice 2007-01-27 21:53:26 +00:00
Nuno Lopes
b6dff166bf MFH: fix infinite cycle
#this was the infinite cycle that was bugging me in the gcov machine...
2007-01-03 22:05:24 +00:00
Sebastian Bergmann
4223aa4d5e MFH: Bump year. 2007-01-01 09:36:18 +00:00
Ilia Alshanetsky
b8590f954d Fixed test 2006-12-09 16:41:24 +00:00
Ilia Alshanetsky
b7b0f4d988 Fixed bug #39759 (Can't use stored procedures fetching multiple result
sets in pdo_mysql).
2006-12-08 19:50:40 +00:00
Ilia Alshanetsky
e5ad7bf299 Fixed bug #36798 (Error parsing named parameters with queries containing
high-ascii chars).
2006-12-05 18:04:59 +00:00
Hannes Magnusson
a41e70782b Fix test 2006-12-05 15:55:55 +00:00
Ilia Alshanetsky
8e907392b3 Fixed test (user is a reserved keyword in pgsql) 2006-12-04 17:55:46 +00:00
Ilia Alshanetsky
7fb3715d43 Fixed bug #38319 (Remove bogus warnings from persistent PDO connections). 2006-12-04 03:07:44 +00:00
Ilia Alshanetsky
44045f8cb1 Fixed bug #38252 (Incorrect PDO error message on invalid default fetch mode). 2006-12-04 02:40:08 +00:00
Ilia Alshanetsky
4356aad0ae Fixed bug #39483 (Problem with handling of \ char in prepared statements). 2006-12-04 00:38:46 +00:00
Ilia Alshanetsky
44baca5aed Added missing check for mismatching number of tokens & bound params in
prepared statement emulation.
2006-12-03 23:27:44 +00:00
Ilia Alshanetsky
916673a345 Fixed bug #39527 (Failure to retrieve results when multiple unbuffered,
prepared statements are used in pdo_mysql).
2006-12-02 17:53:44 +00:00
Antony Dovgal
bb30875db6 add test 2006-11-28 16:55:05 +00:00
Ilia Alshanetsky
2d4b8e19e2 Fixed bug #39656 (crash when calling fetch() on a PDO statment object
after closeCursor()).
2006-11-28 16:27:53 +00:00
Ilia Alshanetsky
af16066603 Fixed a possible crash 2006-11-23 14:41:35 +00:00
Ilia Alshanetsky
6e9c7c4aa9 Fixed generated file 2006-11-12 17:55:44 +00:00
Ilia Alshanetsky
c32ed59e4e Fixed a memory leak when named & positional params are being used in the
same query.
2006-11-12 17:49:19 +00:00
Ilia Alshanetsky
887b3484f7 Fixed bug #39398 (Booleans are not automatically translated to integers). 2006-11-07 17:57:17 +00:00
Hannes Magnusson
8104df0547 Remove bogus ini entry 2006-10-14 15:06:11 +00:00
Antony Dovgal
5e34f6cf9e MFH 2006-09-28 23:27:59 +00:00
Antony Dovgal
d6eb64344d MFH 2006-09-28 23:03:56 +00:00
Ilia Alshanetsky
2332e4f9fc Fixed bug #37870 (pgo_pgsql tries to de-allocate unused statements).
Fixed bug #36681 (pdo_pgsql driver incorrectly ignored some errors).
Fixed test for bug #38253 not to use faulty SQL that generates errors in
PostgreSQL
2006-09-19 15:45:22 +00:00
Antony Dovgal
a5bb290f28 it's not a PEAR only issue 2006-08-24 16:00:43 +00:00
Antony Dovgal
b7f2d8f17e MFH: fix possible crash in free_statement() 2006-08-23 19:15:57 +00:00
Antony Dovgal
36dffb8e3b typo 2006-08-21 17:12:02 +00:00
Ilia Alshanetsky
8d770ee2ef Fixed bug #38535 (memory corruption in pdo_pgsql driver on error retrieval
inside a failed query executed via query() method).
2006-08-21 16:53:50 +00:00
Ilia Alshanetsky
3d87be2674 Added skip condition for sqlite2 driver, that uses more forgiving emulated
prepared statements.
2006-08-16 14:09:56 +00:00
Ilia Alshanetsky
43fca8a3f8 Fixed bug #38394 (PDO fails to recover from failed prepared statement
execution).
2006-08-09 14:45:00 +00:00
Ilia Alshanetsky
194b309d2d Fixed memory leak with persistent connections 2006-08-07 17:32:13 +00:00
Ilia Alshanetsky
2b5a53d6b6 Fixed memory leak on unused bound name parameters. 2006-08-01 15:06:01 +00:00
Ilia Alshanetsky
c6ace95236 Fixed bug #37445 (Fixed crash in pdo_mysql resulting from premature object
destruction).
2006-07-31 20:18:11 +00:00
Antony Dovgal
168f53b72b fix bug #38253 (PDO produces segfault with default fetch mode)
add test
2006-07-30 11:19:56 +00:00
Antony Dovgal
97ef557b97 initialize var 2006-07-27 08:00:54 +00:00
Dmitry Stogov
b6d2c54059 Destructors call order is changed (Fixed bug #36759 - Objects destructors are invoked in wrong order when script is finished) 2006-07-12 07:55:17 +00:00
Antony Dovgal
3aaf62d159 there is no Unicode in 5_2 2006-07-11 12:15:11 +00:00
Hartmut Holzgraefe
c1b67d83cc (MFH) "transaction" tests should test commit, too, not only rollback 2006-07-10 16:29:50 +00:00
Hartmut Holzgraefe
836e74ebee MFH 2006-07-10 14:06:13 +00:00
Hartmut Holzgraefe
098d3d2b02 MFH 2006-07-10 07:39:35 +00:00
Antony Dovgal
3ff986ecf7 init vatiables 2006-06-20 13:26:01 +00:00
Dmitry Stogov
1dbaae2795 Added automatic module globals management 2006-06-15 18:33:09 +00:00
Rasmus Lerdorf
76bff5194c Put the TODO back 2006-06-07 21:14:04 +00:00
Rasmus Lerdorf
658762a0b5 Get rid of useless function calls 2006-06-07 21:09:52 +00:00
Ilia Alshanetsky
a9c6e4be1e Fixed bug #37709 (Possible crash in PDO::errorCode()). 2006-06-07 03:33:16 +00:00
Antony Dovgal
e5c8f8c59b yet another dummy clone_obj handler to fix problems created by ze1 compat mode 2006-06-06 22:05:56 +00:00
Antony Dovgal
1b602e85d1 fix leak appearing on phpinfo() when there are no PDO modules available 2006-06-05 22:08:16 +00:00
Antony Dovgal
e4a3732c91 no need to call zend_is_callable() if callable is known to be invalid
free fname on failure and plug possible leak
2006-05-30 09:46:59 +00:00
Antony Dovgal
e2afb33e87 fix skip reason 2006-05-17 10:12:36 +00:00
Marcus Boerger
7bbab02633 - MFH
. Fix iterator based access
  . Add new attribute ATTR_DEFAULT_FETCH_MODE: $bdh->setAttribute()
  . Add new fetch mode: FETCH_PROPS_LATE, this fills object member
    variables after calling the constructor (fixes #36428).
2006-05-11 22:43:44 +00:00
Marcus Boerger
bf9f762b4d - MFH: add new test 2006-05-11 22:17:42 +00:00
Marcus Boerger
11f26c2c2a - Tweak version check 2006-05-09 23:54:48 +00:00
Sara Golemon
7e6beb9f28 Note addition of new class constants 2006-05-04 00:21:51 +00:00
Sara Golemon
91999f1175 mfh(r-1.129) Expose PARAM_EVT_* constants 2006-05-03 21:58:38 +00:00
Wez Furlong
7614368f8a prep for pecl release 2006-05-02 02:32:40 +00:00
Antony Dovgal
ea53739d30 MFB: don't segfault if an exception has been thrown from the fetch handler 2006-04-22 19:10:53 +00:00
Wez Furlong
687e6ffc58 Add "ATTR_EMULATE_PREPARES" general attribute to replace the custom
attributes employed by mysql and postgres drivers.
No functional change.
2006-04-09 08:05:01 +00:00
Antony Dovgal
08e6fded56 prevent possible NULL dereference 2006-03-28 20:19:44 +00:00
Wez Furlong
6387d83a05 add a test case for bug 35671 2006-03-28 16:47:35 +00:00
Wez Furlong
fb7d5bd780 The fix for #35332 caused #35671 (and thus PECL #6504).
Partially back out that fix and introduce an extra optional step for drivers to
canonicalize the "name" that is used for registering parameters.
2006-03-27 20:51:01 +00:00
Antony Dovgal
1ad4dd8795 return FALSE if driver doesn't support quoting (this is what docu says)
also fixed PECL bug #6365
2006-03-23 19:01:46 +00:00
Ilia Alshanetsky
3b1cb0e500 Added myself to PDO and PDO_MySQL credits
Added Wez to PDO_MySQL credits
Added Tony to Q&A team credits
Regenerated the credits file
2006-03-23 18:36:47 +00:00
Ilia Alshanetsky
4ccd89d147 Properly calculate the size of the result array. 2006-03-19 17:35:36 +00:00
Antony Dovgal
5c7c11c41d MFH: check stream for NULL before writing to it
remove unnecessary semicolons
2006-03-18 22:24:05 +00:00
Ilia Alshanetsky
92ba7cccad Fixed memory leak on unused bind var. 2006-03-15 15:25:50 +00:00
Marcus Boerger
6e93f3eb8f - MFH Proto fixes 2006-03-06 10:00:59 +00:00
Ilia Alshanetsky
6f66a63cda Fixed bug #36222 (errorInfo in PDOException is always NULL). 2006-01-31 17:20:32 +00:00
Ilia Alshanetsky
8fde2249c3 Properly rewrite queries where a bound parameter appears more then once. 2006-01-25 16:35:23 +00:00
Marcus Boerger
1d461a6bcc - MFH 2006-01-22 23:57:41 +00:00
Marcus Boerger
813a5651c1 - MFH Update test 2006-01-22 22:07:43 +00:00
Ilia Alshanetsky
64a7e46506 Fixed bug #35797 (segfault on PDOStatement::execute() with
zend.ze1_compatibility_mode = On).
2006-01-01 20:07:41 +00:00
foobar
5bd93221a8 bump year and license version 2006-01-01 12:51:34 +00:00
foobar
e3fd31503b bump the year and license version 2006-01-01 12:26:08 +00:00
Ilia Alshanetsky
2e50763315 Fixed memory corruption that affected pdo_sqlite2. 2005-12-24 17:41:04 +00:00
foobar
93d339bede touch with re2c 0.9.11 2005-12-18 20:01:22 +00:00
Ilia Alshanetsky
b83a0eb10c Fixed memory corruption when FETCH_LAZY mode is being used. 2005-12-17 20:00:00 +00:00
Ilia Alshanetsky
bdf9c4d15c Fixed bug #35694 (Improved error message for invalid fetch mode). 2005-12-15 22:33:02 +00:00
Marcus Boerger
9bb52c750c - MFH 2005-12-11 15:29:14 +00:00
Ilia Alshanetsky
24af85dfe9 Fixed memory leak 2005-12-07 01:29:14 +00:00
foobar
3e669bc950 MFH: nuke php3 legacy 2005-12-06 02:28:41 +00:00
foobar
f58f7f4e67 MFH: fix typo 2005-12-05 22:41:10 +00:00
foobar
66832decc5 MFH 2005-12-05 22:39:03 +00:00
Wez Furlong
17683295e4 switch to package2.xml 2005-12-04 22:34:26 +00:00
Antony Dovgal
d72347f7bc MFH: fix #35543 (php crash when calling non existing method of a class that extends PDO) 2005-12-04 11:41:13 +00:00
Antony Dovgal
06c57b7d55 tweak fix a bit
(by request of Wez)
2005-12-01 20:39:12 +00:00
foobar
b935f6f13a - Fix paths for --enable-gcov usage
# re2c -b -o ext/pdo/pdo_sql_parser.c ext/pdo/pdo_sql_parser.re
2005-12-01 20:28:27 +00:00
Antony Dovgal
59087fee52 MFH: fix #35508 (PDO fails when unknown fetch mode specified) 2005-12-01 19:59:58 +00:00
Wez Furlong
b15e33f85a prep for release 2005-11-28 06:39:53 +00:00
Wez Furlong
d0ea27b802 API for connection dependent objects to add/del refs to dbh's. 2005-11-28 05:23:22 +00:00
Wez Furlong
b4dd85ff46 update changelog here too 2005-11-27 21:18:24 +00:00
Wez Furlong
63dae4ee74 Fix #35431; LAZY fetch and fetchAll == crash.
Lazy makes no sense with fetchAll; disallow it.
2005-11-27 21:01:58 +00:00
Antony Dovgal
6543134dea MFH: fix #35430 (PDO crashes on incorrect FETCH_FUNC use) 2005-11-27 21:01:02 +00:00
Wez Furlong
ef08c58664 update the todo list 2005-11-26 21:29:31 +00:00
Wez Furlong
ab6a675131 going to release 1.0.1 2005-11-26 21:22:49 +00:00
Wez Furlong
426fb96cc9 Doh, need to canonicalize parameter names (by prefixing with :) before
attempting to remap them to positional args.
2005-11-26 21:20:52 +00:00
Wez Furlong
85ad81736c set to 1.0 stable. 2005-11-26 20:50:08 +00:00
foobar
366832fbd2 MFH: Fixed wrong usage of ZEND_EXTENSION_API_NO (these are not Zend exts :) 2005-11-25 16:01:41 +00:00
Wez Furlong
7107105429 Update the TODO list. 2005-11-25 07:23:55 +00:00
Wez Furlong
17f504a0ec actually, bytea is not required for LOBs in postgres; good! 2005-11-25 03:37:01 +00:00
Wez Furlong
2256ec00ef PDO support for LOBs in the postgres driver currently assumes bytea columns. 2005-11-25 03:24:32 +00:00
Wez Furlong
2618322506 Bug: when stringify fetch mode is on, and the driver returns a string instead
of a stream for a LOB parameter, PDO would incorrectly return NULL for that
column.
2005-11-25 03:23:17 +00:00
Wez Furlong
c2d53719c2 Fix for #35332.
The problem is caused by the user mixing positional and named parameters.
PDO was blindly adding the parameters, unaware that the same parameters were
already allocated by position.

What we do now is register the parameter with the driver before adding it to
any hash.  This gives the driver an opportunity to normalize the name and
parameter number.  PDO can then ensure that only one entry is occupied in the
hash for a given parameter.
2005-11-25 00:29:04 +00:00
Wez Furlong
bb2f034eff well, what do you know, it does do something. 2005-11-25 00:20:12 +00:00
Wez Furlong
94ab6069b8 prep for release 2005-11-24 22:25:37 +00:00
Wez Furlong
dfdd1e4caf CLASSTYPE is an internal flag.
Closes PECL #5640.
2005-11-24 21:46:56 +00:00
Wez Furlong
2814b749ec Fix PECL Bug #6014; config fails on PHP 5.0.3 2005-11-24 21:38:09 +00:00
Ilia Alshanetsky
8e49bacf95 Fixed bug #35358 (Incorrect error messages for PDO class constants). 2005-11-24 16:21:43 +00:00
Ilia Alshanetsky
4020933726 Fixed bug #35303 (PDO prepare() crashes with invalid parameters). 2005-11-20 20:06:28 +00:00
Antony Dovgal
493c9fcf93 MFH: fix #35293 (PDO segfaults when using persistent connections) 2005-11-19 16:41:08 +00:00
Wez Furlong
0bd9518f8c Closes PECL #5944; binding an invalid parameter can lead to segfaults.
Modified patch provided by curt@php.net.
2005-11-16 06:32:33 +00:00