Greg Beaver
e6558c56a3
increase code coverage to test mounting of phar URLs to internal file, and fix odd semi-race condition
...
where stream resources were not properly freed at script end
2008-05-12 00:16:59 +00:00
Greg Beaver
b3bab5022a
increase code coverage
2008-05-11 23:07:12 +00:00
Greg Beaver
24efbb759b
simplify phar_get_link_location and increase its coverage to 100%
2008-05-11 23:03:56 +00:00
Greg Beaver
70d0a4c045
increase code coverage and fix tiny bug in handling of absolute links
2008-05-11 22:59:16 +00:00
Greg Beaver
ad1be25d8c
don't copy contents of linked/mounted files when converting an archive, and be sure to dupe mounted value
2008-05-11 22:45:03 +00:00
Greg Beaver
92f0dc842f
fix test
2008-05-11 22:44:33 +00:00
Greg Beaver
4ccf0b846e
slightly increase efficiency of function interception, and ensure that nothing fails even if the archive is unlinked mid-process
2008-05-11 21:30:05 +00:00
Greg Beaver
7149523766
add safety check to prevent unlinkArchive() from being called by a file within the archive
2008-05-11 21:15:47 +00:00
Greg Beaver
5d168ad544
fix memleak
2008-05-11 20:53:38 +00:00
Greg Beaver
376deb39d6
split test into two versions for differences in parameter parsing in PHP 5.3+
2008-05-11 19:41:45 +00:00
Greg Beaver
a0969ed78f
make test version-agnostic
2008-05-11 19:37:43 +00:00
Greg Beaver
38d5943ee6
increase code coverage of funcinterceptors to 90%+, fix many bugs, fix errant wrong test condition in fgc_edgecases
2008-05-11 19:17:51 +00:00
Greg Beaver
25a6be6cde
fix windows build
2008-05-08 03:10:18 +00:00
Greg Beaver
53e02373d0
fix handling of mounted entries when flushing in all phars, and of deleted entries with open references in tar-based phars, do not extract mounted entries, add to test
2008-05-08 02:58:45 +00:00
Greg Beaver
a919e2f858
fix serious logic error and potential security issue with phar_compiled_file and
...
phar_find_in_include_path. We were allowing data-based phars to be executed, and actually marking phar-based phar archives
without '.phar' in the name as data-based phars, which would allow modifying them even if phar.readonly=0. Add test for this sinister case
2008-05-08 00:49:37 +00:00
Greg Beaver
0773c7f6a2
fix tar extension detection in open code
2008-05-07 17:35:20 +00:00
Greg Beaver
f134a909c3
optimize phar filename extension detection to first search through known phars. This eliminates several stat/realpath calls for archives with lots of files
2008-05-07 17:24:22 +00:00
Greg Beaver
0f5f61c071
prepare for 2.0.0b1 release, pending review (finally)
2008-05-07 06:43:07 +00:00
Greg Beaver
e765e8f6ca
remove files created
2008-05-07 06:39:05 +00:00
Greg Beaver
eda25ddb34
validate user-supplied aliases when converting archives to other formats
2008-05-07 06:36:24 +00:00
Greg Beaver
549bf83bd1
[DOC]
...
remove phar.extract_list
remove Phar::getExtractList()
2008-05-07 05:38:31 +00:00
Greg Beaver
f8db86b008
remove APC fanciness - this was causing non-caching of some files include()d inside a phar archive
2008-05-07 05:13:41 +00:00
Greg Beaver
96d4c2b62f
fix zip metadata for archive/fix perms for file in zip/all.phpt test
2008-05-06 21:46:26 +00:00
Greg Beaver
04735b675d
new failing test for testing all zip creation facets
2008-05-06 21:34:19 +00:00
Greg Beaver
196f0ef42b
fix segfault in buildfromdirectory2 test and potential segfault
2008-05-06 21:23:48 +00:00
Greg Beaver
5ba8ca70a4
fix alias overloading handling for archives that are not in use
2008-05-06 21:14:53 +00:00
Greg Beaver
3d388e71d2
new test for unset behavior
2008-05-06 18:25:33 +00:00
Steph Fox
21460875fc
- Some tests for buildFromDirectory()
2008-05-04 20:58:43 +00:00
Steph Fox
c322c1a94a
- Kill Windows warning when int meets short
...
- All tests still pass
2008-05-03 21:09:56 +00:00
Greg Beaver
a180fcc9bc
add Phar::unlinkArchive() to allow complete removal of a parsed phar archive from memory and disk
2008-05-03 02:04:24 +00:00
Greg Beaver
bfbe53eeb2
refactor isTar/isZip/isPhar into isFileFormat(int format) where format is one of Phar::TAR,, Phar::ZIP, Phar::PHAR
...
[DOC]
2008-05-02 05:05:56 +00:00
Greg Beaver
e0bc2b2be1
update TODO, re-order methods to be alphabetical, tweak extractTo to set permissions and handle NULL for files
...
# this also matches the docs I just committed :)
2008-05-02 04:44:39 +00:00
Greg Beaver
93fd16ef4d
fix possible read past end of buffer by ridiculously stupid convoluted logic (I wrote it, I can call it that) reported by valgrind
2008-04-30 23:49:09 +00:00
Greg Beaver
0a3fc4faba
fix unix-only valgrind issue by initializing arch
2008-04-30 23:44:30 +00:00
Greg Beaver
2b8a56779b
fix cwd test in php 5.2, now all tests pass in 5.2 on unix
2008-04-30 23:06:57 +00:00
Greg Beaver
c3816a2aa0
fix test to be truly path-agnostic
2008-04-30 23:06:04 +00:00
Greg Beaver
d16f86f528
fix Bug #13786 on unix (Steph can you verify?)
2008-04-30 22:16:25 +00:00
Greg Beaver
791bb5db46
fix test (passes in PHP_5_3 on my 64-bit machine, have not yet tested in 5_2)
2008-04-30 22:12:21 +00:00
Greg Beaver
4b1409fef7
add helper file I use for debugging the front controller tests
2008-04-30 22:10:56 +00:00
Greg Beaver
73830f751f
add missing file for test
2008-04-30 22:09:18 +00:00
Greg Beaver
5f4c42d301
fix double free
2008-04-30 20:17:27 +00:00
Greg Beaver
aeefda4a50
stupid cut/paste error
2008-04-30 20:14:54 +00:00
Greg Beaver
9d27fab9c4
increase code coverage to test cwd stuffs
2008-04-30 20:14:15 +00:00
Greg Beaver
483018e170
remove unneeded exception handling (webPhar is always within an outer zend_execute block which handles exceptions for us, this is unnecessary)
2008-04-30 02:20:48 +00:00
Steph Fox
8a970147ad
- Allow setStub() to continue working
...
- Fix tests broken by earlier commit
2008-04-29 12:26:58 +00:00
Steph Fox
8559a2dbde
- Prevent phars with empty manifests flushing to disk
...
- This would've fixed that test... removing clean section
@Greg: I commented out the call that breaks the Windows build, pending a decision about its future.
2008-04-29 12:06:54 +00:00
Steph Fox
7d3e9ef952
- Fix paths in test
2008-04-29 11:37:33 +00:00
Steph Fox
7762c5d204
- Add test for bug #13786
2008-04-29 10:45:23 +00:00
Greg Beaver
984ea1f437
fix segfault (now all tests pass here)
2008-04-28 23:00:46 +00:00
Greg Beaver
a78fd15fae
fix double free and broken stat.phpt
2008-04-28 22:57:21 +00:00
Greg Beaver
ee1273af7a
remove hack introduced because of broken usage of php_resolve_path instead of zend_resolve_path
2008-04-28 22:41:20 +00:00
Greg Beaver
18f221c61d
it's a bit cheesy, but make this test 5.2/5.3 agnostic :)
2008-04-28 22:32:15 +00:00
Greg Beaver
7220c19556
fix tar generation - we were subtly corrupting the header with \0 because of use of strcpy
2008-04-28 16:44:53 +00:00
Greg Beaver
ff90f59ea9
fix off-by-one for writing of timestamp and file modes in tar files
2008-04-28 06:49:56 +00:00
Greg Beaver
fbb2e8ce60
more fixes for PHAR_G(cwd)
2008-04-28 06:03:33 +00:00
Greg Beaver
62f824b6e1
fix crash (this area really needs code coverage)
2008-04-28 04:38:07 +00:00
Greg Beaver
5da6c48f7d
add open_basedir/safe_mode checks for files in Phar::addFile()
2008-04-27 23:59:41 +00:00
Greg Beaver
e2660a692b
fix test
2008-04-27 23:59:14 +00:00
Steph Fox
bcd2ddd018
- Kill another one from the gcov site's parameter parsing report
2008-04-27 16:42:03 +00:00
Steph Fox
51459aade4
- Another test that gives completely different results if readonly=0
2008-04-27 12:22:36 +00:00
Steph Fox
473abd4e2b
- Deleting files we cannot see...
2008-04-27 11:36:22 +00:00
Steph Fox
37a8782f0c
- Fix a couple of failing tests/bad cleanup
...
@Greg: the phpinfo() ones assumed no php.ini - this isn't always the case, even if it should be
2008-04-27 11:31:27 +00:00
Steph Fox
2ea698eae7
- Make it possible to extract all *and* overwrite
2008-04-27 11:26:15 +00:00
Steph Fox
9e8c3ea9a7
- Always give reasons for skipped tests
2008-04-27 10:18:35 +00:00
Steph Fox
77dcb8cffd
- Kill a few uninitialized vars (thanks gcov)
2008-04-27 10:14:00 +00:00
Greg Beaver
fd9bf92ac6
fix out-of-bounds read potential by replacing strstr with a custom strnstr
2008-04-27 07:20:02 +00:00
Greg Beaver
5bf3d1d362
fix invalid free
2008-04-27 07:04:56 +00:00
Greg Beaver
94846549f5
fix APC compile hook interception, now APC actually caches files
2008-04-26 23:16:49 +00:00
Greg Beaver
fade22bfd8
fix ridiculously critical omission in zip flush - we never set compressed file size! Augment zip test for bz2/zlib-compressed alias files to increase code coverage
2008-04-26 23:02:51 +00:00
Greg Beaver
11c93b8494
add checking for invalid alias on opening tar, and test
2008-04-26 22:31:44 +00:00
Greg Beaver
ad6e7fc667
add screening of alias to reading of zip archives, and test for bad aliases
2008-04-26 22:04:04 +00:00
Greg Beaver
5b85b2074b
new test/updated test to ensure stub integrity (I was wrong, zip is fine)
2008-04-26 17:47:31 +00:00
Greg Beaver
489fe0331f
add logic test to ensure stub is not overwritten when adding a file (zip currently does this - bad zip)
2008-04-26 17:43:53 +00:00
Greg Beaver
52f5a0f2ac
increase code coverage
2008-04-26 17:34:14 +00:00
Greg Beaver
15f9f20c3c
really fix test by fixing the regex
2008-04-26 17:32:18 +00:00
Greg Beaver
76c78a480e
increase code coverage (and magically, mysteriously this tests passes with no other changes - weird)
2008-04-26 17:29:55 +00:00
Greg Beaver
eb6b941d2a
fix clean
2008-04-26 17:28:28 +00:00
Greg Beaver
f37605ec0c
increase code coverage
2008-04-26 17:27:47 +00:00
Greg Beaver
b22cc67e6b
new test increases code coverage
2008-04-26 17:20:50 +00:00
Greg Beaver
2227f10f3e
add failing portion of test for compressed alias read
2008-04-26 17:18:15 +00:00
Greg Beaver
8e7f6d6662
add failing portion of test for bz2 compressed file on open
2008-04-26 17:14:27 +00:00
Greg Beaver
79a45a9666
fix buildfromiterator base to exclude directory separator on unix or windows, fix 10 test to have new tests
2008-04-26 17:09:58 +00:00
Greg Beaver
c6b617eca8
fix cleanup
2008-04-26 16:57:14 +00:00
Steph Fox
cf7f50e42c
- Added a RecursiveIterator/buildFromIterator test
...
- Fixed up bug13727.phpt to take < 15 minutes :\\ and clean up after itself
- Cleaned up protos/reflection data
- Added myself to package.xml credits
2008-04-26 13:22:38 +00:00
Greg Beaver
0c2f3b760a
add Phar::extractTo(dest_directory[, mixed files[, bool overwrite]])
...
this is very similar to ext/zip's extractTo and is based on that code, with the addition of the third parameter, which
is used to allow overwriting existing files (disallowed by default, unlike ext/zip's implementation)
[DOC]
2008-04-26 05:31:00 +00:00
Greg Beaver
c5fc383cb7
finish code coverage work (whew)
2008-04-26 05:28:56 +00:00
Steph Fox
dbb4618bd5
- cs
2008-04-26 02:04:09 +00:00
Steph Fox
f040cb6492
- fixed those pesky memleaks
2008-04-26 01:52:22 +00:00
Steph Fox
9bf8d7429e
- implemented Phar::buildFromDirectory
...
@Greg: There are two (identical) recurring memleaks I can't seem to kill, both marked FIXME. Would you please take a look?
[DOC] $phar->buildFromDirectory(dirname[, regex]). Return value is an array pairing each file in the archive index with the original path on the filesystem.
2008-04-25 21:37:41 +00:00
Greg Beaver
68dc76a9ab
make dang sure this ridiculous test cleans up after itself
2008-04-25 16:54:37 +00:00
Greg Beaver
8657ab7e5a
add test for bug #13727 , fix bug #13727
2008-04-25 16:50:22 +00:00
Greg Beaver
2bf5042d74
finish code coverage testing of phar_object.c (except for iterator building, which Steph is doing) and fix segfault in error message for directory getcontent if it is a temp directory
2008-04-25 16:10:59 +00:00
Greg Beaver
84004bf248
new test with code coverage for PharFileInfo::setMetadata/delMetadata, improve error messages
2008-04-25 16:05:05 +00:00
Greg Beaver
3864211c00
remove unneeded skipif conditions
2008-04-25 15:56:20 +00:00
Greg Beaver
13dc477de2
new code coverage test, improve clarity of error message when chmod is used on a temp directory
2008-04-25 15:53:02 +00:00
Greg Beaver
7c7b387cc3
fix potentially serious security issue: buffer overrun if the tar filename > 101 characters in length. This fixes tests/tar/bignames.phpt
2008-04-25 04:35:10 +00:00
Greg Beaver
efe519c194
fix access fault on windows, fix memleak on all platforms when accessing a temp directory via offsetGet
2008-04-25 04:34:03 +00:00
Greg Beaver
6036559d35
fix tests on windows
2008-04-25 04:31:44 +00:00
Greg Beaver
fc9aba79f5
add missing file (Steph: this fixes tests/tar/truncated.phpt, sorry :)
2008-04-25 04:29:08 +00:00
Greg Beaver
218b975485
fix test (except for memleaks)
2008-04-24 20:02:04 +00:00
Greg Beaver
0db641af3e
rework PharFileInfo->decompress and add failing test
2008-04-24 19:57:22 +00:00
Greg Beaver
d28dcfaf60
new test
2008-04-24 17:25:23 +00:00
Greg Beaver
84c622c2ab
new test for PharFileInfo::__destruct
2008-04-24 17:19:01 +00:00
Steph Fox
aaf5498ff4
- clean the right file :)
2008-04-24 17:02:27 +00:00
Steph Fox
21584ed029
- kill a couple of (release build) MS compiler warnings
2008-04-24 16:59:23 +00:00
Steph Fox
28459132cb
- Fix Windows build
2008-04-24 16:03:40 +00:00
Greg Beaver
91e67a4fbd
test PharFileInfo::__construct, fix potential segfault, and bad logic in phar detection
2008-04-24 05:18:50 +00:00
Greg Beaver
1f98c6526b
increase code coverage
2008-04-24 05:03:12 +00:00
Greg Beaver
24d83fa7f8
fix break when uncompressed files are re-saved, fixes phar_copy.phpt test
2008-04-24 04:56:22 +00:00
Greg Beaver
8f0c9caac5
remove redundant unreachable code in Phar::copy, augment test, and add failing condition that needs to be fixed
2008-04-24 04:14:05 +00:00
Greg Beaver
696dafa370
new test for Phar::decompress()
2008-04-24 04:05:20 +00:00
Greg Beaver
b721660ec7
increase code coverage
2008-04-23 19:01:52 +00:00
Greg Beaver
9c60d2dcaf
increase code coverage
2008-04-23 19:00:42 +00:00
Greg Beaver
207a093186
increase code coverage
2008-04-23 18:59:41 +00:00
Greg Beaver
3190bd0884
increase code coverage, fix minor memleak
2008-04-23 18:54:09 +00:00
Greg Beaver
cebd8a5864
increase code coverage
2008-04-23 18:46:48 +00:00
Greg Beaver
ba2182d795
increase code coverage
2008-04-23 18:46:21 +00:00
Greg Beaver
e5309e4aad
increase code coverage
2008-04-23 18:45:42 +00:00
Greg Beaver
ab1d8adb96
fix default format conversion, increase code coverage
2008-04-23 18:44:43 +00:00
Greg Beaver
26d2062305
increase code coverage slightly
2008-04-23 18:32:59 +00:00
Greg Beaver
3b8fc7309f
new test increases code coverage, fix memleak found by test
2008-04-23 18:30:53 +00:00
Greg Beaver
4a0b06af82
increase code coverage
2008-04-23 18:22:55 +00:00
Greg Beaver
3d890f09a8
fix extension detection for executable=2
2008-04-23 18:22:09 +00:00
Greg Beaver
c034683550
new test for Phar::isValidPharFilename. Fix Phar::isValidPharFilename. Fix extension detection for all cases
2008-04-23 18:11:20 +00:00
Greg Beaver
faaa9261e5
new test for Phar::loadPhar with phar.extract_list
2008-04-23 17:27:31 +00:00
Greg Beaver
d3689baf53
new test for Phar::mapPhar with phar.extract_list
2008-04-23 17:25:52 +00:00
Greg Beaver
19088c1930
remove/move unreachable code
2008-04-23 17:23:32 +00:00
Greg Beaver
1dc190e680
improve rewrite callback support, add test for callback that does not return string/false
2008-04-23 17:18:28 +00:00
Greg Beaver
22878f0ea2
new test for valid callback that fails for rewrite callback
2008-04-23 16:50:19 +00:00
Greg Beaver
ce5732112e
new test for invalid rewrite callback
2008-04-23 16:47:12 +00:00
Greg Beaver
50835e4bb7
new test for SCRIPT_NAME not containing the filename
2008-04-23 16:06:59 +00:00
Greg Beaver
2aa87329db
new test for webPhar failure on opening file
2008-04-23 16:03:08 +00:00
Greg Beaver
76b8f30659
new test for webPhar with phar.extract_list
2008-04-23 16:00:06 +00:00
Greg Beaver
5224d341b6
ensure freeing of cwd/name happens in all cases
2008-04-22 17:34:00 +00:00
Greg Beaver
af3dfa23f6
fix headers in test
2008-04-22 17:29:11 +00:00
Greg Beaver
3330c16967
new test for fatal error in php file executed by front controller
2008-04-22 17:28:50 +00:00
Greg Beaver
0338b28939
re-enable disabled cwd code
2008-04-22 17:19:06 +00:00
Greg Beaver
d8b4c2795e
remove unreachable code, add test for large non-php file
2008-04-22 17:17:29 +00:00
Greg Beaver
379bcf1f14
remove unreachable code
2008-04-22 17:13:07 +00:00
Greg Beaver
cb8f158cd5
fix PATH_INFO munging, add to test case
2008-04-22 17:11:30 +00:00
Greg Beaver
5ac9c1f23e
remove unreachable code, add test for no file extension and unknown file extension with Phar::webPhar
2008-04-22 17:03:10 +00:00
Greg Beaver
4e5fc75977
big ol code coverage test for bad parameters to Phar methods
2008-04-22 05:17:04 +00:00
Greg Beaver
4388a65aa8
fix Phar::mount() to also allow running externally with full phar:// path, add test
2008-04-21 18:21:54 +00:00
Greg Beaver
e0873a380d
fix Phar::running()
2008-04-21 18:06:20 +00:00
Greg Beaver
25cdc7de2b
fix discovery of files hidden in a URL - makes using any regular front controller possible
2008-04-21 17:59:28 +00:00
Greg Beaver
2f56c7f343
new test for custom 404 handler, fix segfault found by test
2008-04-21 17:46:24 +00:00
Greg Beaver
cfc12b2afe
increase code coverage of phar.c significantly by ensuring signature algorithm test is actually run (duh)
2008-04-21 17:04:15 +00:00
Greg Beaver
7ee3597851
increase code coverage
2008-04-21 16:56:45 +00:00
Greg Beaver
5a4a54f64b
remove unused code
2008-04-21 16:51:26 +00:00
Greg Beaver
aaf6101928
another refactoring to combine an error and improve code coverage as a side effect
2008-04-21 16:50:18 +00:00