Commit Graph

43141 Commits

Author SHA1 Message Date
Dmitry Stogov
7bfe056174 Fixed tests 2009-09-21 09:52:19 +00:00
Ulf Wendel
a0a8c5832f Fixing mysqli_get_client_stats.phpt. More testing for MYSQLI_INIT_COMMAND 2009-09-21 09:35:23 +00:00
Ulf Wendel
025e670f54 Fixing test: references has to be collected even if the users disables the collection of statistics. It is needed for memory management. 2009-09-21 08:59:00 +00:00
Ulf Wendel
a77ee71cf0 Fixing test - the standard test table will not accept NULL values for column id 2009-09-21 08:36:14 +00:00
Dmitry Stogov
acc71e71bc Fixed tests 2009-09-21 08:28:53 +00:00
Kalle Sommer Nielsen
1dfc3ac4a4 Fix NEWS 2009-09-21 03:20:31 +00:00
Pierre Joye
6711276b3c - fix ACL cache for read check 2009-09-19 20:54:34 +00:00
Hannes Magnusson
f7096da972 And now use proper colspanning 2009-09-18 23:06:21 +00:00
Hannes Magnusson
07618b1edd Fix typo in comment (danbrown) 2009-09-18 22:26:44 +00:00
Hannes Magnusson
e3134c3139 Throw some credit around 2009-09-18 22:01:58 +00:00
Andrey Hristov
967239727e MFH:Fix for bug#48909 Segmentation fault in mysqli_stmt_execute 2009-09-18 14:33:08 +00:00
Andrey Hristov
8aae3baa45 MFH:Fix for bug#48754 mysql_close() crash php when no handle specified 2009-09-18 10:49:31 +00:00
Andrey Hristov
c2e66884e1 MFH, a fix not included by the fix committed by Ulf.
pemalloc and then efree - too bad!
Sorry for committing in two passes, my big tree is already patched
with compressed.
2009-09-17 15:13:14 +00:00
Ulf Wendel
1388912ded better coverage for mysqli_info 2009-09-17 07:11:25 +00:00
Sriram Natarajan
fbc335e5d1 - Fixed bug #49572 (use of C++ style comments causes build failure) 2009-09-17 02:45:25 +00:00
Felipe Pena
fff0a24656 - Fixed ZTS build 2009-09-16 18:01:10 +00:00
Sebastian Bergmann
ceaf590530 Merge ReflectionMethod::setAccessible() to PHP 5.3.2, approved by Johannes. 2009-09-16 17:24:46 +00:00
Ulf Wendel
e6cf6693e6 Fix (by Andrey) and test for bug #49442 . Don't use efree() for memory allocated with malloc()... If a connection gets created by mysqli_init(), mysqlnd makes it 'persistent'. 'Persistent' means that mysqlnd uses malloc(). mysqlnd does use malloc() instead of ealloc() because it is unknown if the connection will become a true persistent connection in the sense of ext/mysqli. It is unknown if the user wants a persistent connection or not until the user calls mysqli_real_connect(). To avoid tricky conversions mysqlnd uses malloc(), which sets a private persistent flag in the mysqlnd structures. A precondition for the crash to happen was that the private persistent flag is set. The flag is also set when creating a real persistent connection (in the sense of ext/mysqli) and so the bug can happen with mysql_init()/mysqli_real_connect() and mysql_connect('p:<host>', ...). Therefore we test both cases. Note the (tricky?) difference between the implementation detail'mysqlnd private persistent flag = use malloc()' and persistent connections from a user perspective. Although mysqlnd will always set its private persistent flag and use malloc() for connections created with mysqli_init() it is still up to the user to decide in mysqli_real_connect() if the connection shall become a (true) persistent connection or not. 2009-09-16 17:03:44 +00:00
Ulf Wendel
20005db2a0 Fix and tests for bug #49511 . mysqlnd and the MySQL Client Library (libmysql) use different networking APIs. mysqlnd does use PHP streams whereas libmysql uses its own wrapper of the operating level network calls. PHP sets by default a read timeout of 60s for streams - php.ini, default_socket_timeout. This default applies to all streams that set no other timeout value. mysqlnd has not set any other value and therefore it connections of long running queries can have been cut off after default_socket_timeout seconds resulting in a 2006 - MySQL Server has gone away error message. The MySQL Client Library sets a default timeout of 365 * 24 * 3600 seconds (1year) and waits for other timeouts to happen, e.g. TCP/IP timeouts. mysqlnd now uses the same very long timeout. The value is configurable through a new php.ini setting: mysqlnd.net_read_timeout. mysqlnd.net_read_timeout gets used by any extension (ext/mysql, ext/mysqli, PDO_MySQL) that uses mysqlnd. mysqlnd tells PHP Streams to use mysqlnd.net_read_timeout. Please note that there may be subtle differences between MYSQL_OPT_READ_TIMEOUT from the MySQL Client Library and PHP Streams. E.g. MYSQL_OPT_READ_TIMEOUT is documented to work only for TCP/IP connections and, prior to MySQL 5.1.2, only for Windows. PHP streams may not have this limitation. Please check the streams documentation, if in doubt. 2009-09-16 15:00:54 +00:00
Jani Taskinen
fb9c4bd709 - What a mess.. 2009-09-16 06:56:37 +00:00
andy wharmby
e509cc4283 Fix SKIPIF sections 2009-09-15 21:44:08 +00:00
Rasmus Lerdorf
d032060ea8 Fix bug #49558
And as Colin mentioned in the bug report, this means date_sunrise()
and date_sunset() have been off by 26 seconds in most cases until now.
2009-09-15 20:28:42 +00:00
Ilia Alshanetsky
f611b66025 Upgraded bundled sqlite to version 3.6.18. 2009-09-15 16:54:11 +00:00
Pierre Joye
15398c4ed5 - #49253, add support for libcurl's CERTINFO option 2009-09-15 15:47:06 +00:00
Moriyoshi Koizumi
b91e3db105 - WS fix (spaces to tabs) 2009-09-15 00:09:13 +00:00
Pierre Joye
ada5eb95ad - Fix #48746, improve fix to support all possible cases (see latest comment in the report) 2009-09-14 18:46:56 +00:00
Ilia Alshanetsky
62d78d7ccc Fixed certificate validation inside php_openssl_apply_verification_policy 2009-09-14 12:50:30 +00:00
Moriyoshi Koizumi
6a0402413d - Looks like bug #48697 has already been fixed in RC1. 2009-09-14 04:11:29 +00:00
Felipe Pena
2c388a4eaa - Fixed warnings (Kalle) 2009-09-13 14:42:36 +00:00
Ilia Alshanetsky
9e76501f1e Fixed test 2009-09-13 13:14:11 +00:00
andy wharmby
e4c38fc1f0 Add missing SKIPIF 2009-09-11 21:57:04 +00:00
Moriyoshi Koizumi
8f9acfedb3 - Fix bug #49536 (mb_detect_encoding() returns incorrect results when strict_mode is turned on.)
(patch by komura, thanks!)
2009-09-11 21:26:18 +00:00
Ulf Wendel
617b4e9bd1 Fix for bug #49357 (MySQLi extension fails to recognize POINT (spatial) colums).
Do yourself a favour and use mysqlnd. mysqlnd has no isuses here.

If you insist on using the MySQL Client Library (libmysql) I strongly recommend to use mysqli_stmt_store_result() when fetching geometry data using prepared statements. When streaming data, which is the default for prepared statements, ext/mysqli will have to make a guess on the size of the result buffer it needs. The guess is based on a length reported by the MySQL CLient Library (libmysql). The MySQL Client Library reports 4GB (!) for a POINT - a conservative and safe guess. Consequently, ext/mysqli will try to allocate 4GB of RAM. The true (maximum) size of the column is not available before buffering the result on the client using mysqli_stmt_store_result(). If you call mysqli_stmt_store_result(), the result buffers will not get bigger than needed. However, store_result()/buffering is usually not what you want when you ask for prepared statements.
2009-09-11 13:38:47 +00:00
Ulf Wendel
5dfd12ddb7 Stepping back to PHP 5.2.x and earlier logic of allocating even huge pieces of memory for large BLOB types to avoid data truncation. This fixes the test failure of 005.phpt when using MySQL Client
Library (libmysql). The test does pass with mysqlnd because mysqlnd does not have any issues here.
2009-09-11 12:28:47 +00:00
Ulf Wendel
c4c11fd38a Fixing a crash which must have existed since PHP 5.0. At least the crash can be reproduced with PHP 5.0.6. The crash happens only when using the MySQL Client Library (libmysql) - it does not happen
when using mysqlnd.
2009-09-11 12:16:56 +00:00
Moriyoshi Koizumi
b39126de9a - Fix bug #49528 (UTF-16 strings prefixed by BOM wrongly converted). 2009-09-11 08:22:19 +00:00
Jani Taskinen
ccd6e501d1 - Simplified a bit and fixed possible memory corruption and definate leak. 2009-09-10 16:19:42 +00:00
Jani Taskinen
0f1b93a1ca - Fix skips 2009-09-10 15:05:34 +00:00
Ilia Alshanetsky
f0c6eaa024 Fixed test 2009-09-10 02:15:08 +00:00
Felipe Pena
8c74835795 - Possible fix for bug #49344 on Windows (pdo_mssql fails to connect,throws PDOException SQLSTATE[] (null) (severity 0)) 2009-09-10 01:20:42 +00:00
Ulf Wendel
416ff5872d Andrey fixed the bug but the test was somewhat borked. Fixing test. 2009-09-09 18:31:00 +00:00
Ulf Wendel
31573498d8 Some extra test coverage for http://bugs.php.net/bug.php?id=48754 . 2009-09-09 17:16:24 +00:00
Ulf Wendel
f51e935e96 Tests for http://bugs.php.net/bug.php?id=49357 (libmysql only) . The simple fix suggested in the bug system is not good enough, therefore no fix yet. 2009-09-09 17:10:29 +00:00
Ulf Wendel
5f260e14b2 Next attempt to fix http://bugs.php.net/bug.php?id=48745. Patch by Andrey. 2009-09-09 17:03:03 +00:00
Derick Rethans
95b3863579 - Updated to version 2009.13 (2009m) 2009-09-08 14:03:53 +00:00
Ilia Alshanetsky
62557f1d81 Fixed tests 2009-09-07 14:18:46 +00:00
Ilia Alshanetsky
6d0b9484d9 Fixed bug #49470 (FILTER_SANITIZE_EMAIL allows disallowed characters). 2009-09-07 02:35:25 +00:00
Pierre Joye
3e359ee5b4 - fix #40013, php_uname() doesnt return nodename (MFH) 2009-09-06 22:01:18 +00:00
Felipe Pena
b4ee727353 - Fixed bug #49483 (preg_replace 'subject' parameter listed as optional) 2009-09-06 17:41:34 +00:00
Pierre Joye
d198853416 - revert last commit, breaks the build and needs test case(s) 2009-09-06 15:56:58 +00:00