Rasmus Lerdorf
2449c41698
Not an issue here, but a good habit to follow consistently. Never use strcpy/strcat.
2011-08-07 15:45:18 +00:00
Rasmus Lerdorf
bcf8485ef5
Make static analyzers happy
2011-08-07 15:38:36 +00:00
Xinchen Hui
57ec3758b7
revert -r314422
...
No need to check erealloc's return
2011-08-07 14:25:30 +00:00
Xinchen Hui
b2110c3eea
Fixed bug that may dereferenced NULL pointer before checking
2011-08-07 13:19:04 +00:00
Xinchen Hui
4c2e6c1cf6
Initialize variable with fixed value for avoiding compile warnings
2011-08-07 11:13:27 +00:00
Pierrick Charron
029d7f4c6c
class entry is never used
2011-08-07 06:04:11 +00:00
Pierrick Charron
757a32cd0c
Pointer returned is never used
2011-08-07 05:46:31 +00:00
Rasmus Lerdorf
f2bc53b88b
Oops
2011-08-07 05:08:08 +00:00
Rasmus Lerdorf
b61c50a004
These naked strcpy()s scare me
2011-08-07 00:18:38 +00:00
Rasmus Lerdorf
636c61c1d5
Not our issue, but fixing here for now and reporting upstream
2011-08-06 23:34:13 +00:00
Felipe Pena
997f323e3a
- Added ZEND_MOD_END macro to use in the end of zend_module_dep[]
2011-08-06 14:47:44 +00:00
Felipe Pena
13eb47a8bc
- Added missing PHP_FE_END/ZEND_FE_END
2011-08-06 01:22:27 +00:00
Felipe Pena
edfa1988fc
- Fixed bug #55313 (Number of retries not set when params specified)
...
patch by: kevin at kevinlocke dot name
2011-08-06 00:59:21 +00:00
Rasmus Lerdorf
741f41ff18
efree match_sets on an error here - found by Coverity
2011-08-05 22:39:40 +00:00
Christopher Jones
ae1baaa592
Improve test portabilty
2011-08-05 22:18:50 +00:00
Andrey Hristov
8a929d8942
Fix for bug #55283 SSL options set by mysqli_ssl_set ignored for MySQLi persistent connections
2011-08-05 13:39:30 +00:00
Felipe Pena
32319a142f
- Added missing check (thanks neweracracker at gmail dot com)
2011-08-04 10:56:59 +00:00
Felipe Pena
8b27b6d559
- Fixed possible efree(NULL) (bug #55296 )
2011-08-04 00:59:43 +00:00
Andrey Hristov
395ebb5c8b
Remove a warning by explicitly compiling out a non-used variable
2011-08-02 15:30:58 +00:00
Andrey Hristov
4a7bf95c90
completely compile out a currently non-needed function
2011-08-02 14:18:56 +00:00
Andrey Hristov
66bba32627
compile out both parts of the code that are currently unused - fixes a compilation warning
2011-08-02 14:02:21 +00:00
Stanislav Malyshev
44add6d195
fix termination in sha-512 too
2011-07-31 23:14:04 +00:00
Stanislav Malyshev
6e246ad0d5
fix salt truncation bug in sha256
2011-07-31 21:47:03 +00:00
Pierre Joye
caf6a6dc7a
- blowfish 1.2 update, 2nd part
2011-07-31 20:50:09 +00:00
Pierre Joye
673fe19b39
- add test for blowfish 1.2 (Solar Designer)
2011-07-31 10:11:20 +00:00
Pierre Joye
363b56f261
- Fix #55301 (sybase part, take #2 ) check if malloc succeded
2011-07-28 21:16:51 +00:00
Pierre Joye
a3796f27fb
- Fix #55301 (mssql part) check if malloc succeded
2011-07-28 11:01:04 +00:00
Pierre Joye
c8a621b191
- Fix #55301 (sybase part) check if malloc succeded
2011-07-28 10:57:31 +00:00
Pierre Joye
b3ccd26eb4
- Fix #55301 (url scanner part) check if malloc succeded
2011-07-28 10:52:45 +00:00
Pierre Joye
d3fd31b6dd
- Fix #55301 (readline part) check if malloc succeded
2011-07-28 10:42:45 +00:00
Pierre Joye
7ec6d3ae47
- Fix #55301 (interbase part) check if malloc succeded
2011-07-28 10:39:19 +00:00
Pierre Joye
a20deb1607
- Fix #55301 (pdo_odbc part) check if malloc succeded
2011-07-28 10:37:04 +00:00
Pierre Joye
8535adfb31
- Fix #55301 (com_dotnet part) check if malloc succeded
2011-07-28 10:34:16 +00:00
Pierre Joye
42c4b86c88
- Fix #55301 (curl part) check if malloc succeded
2011-07-28 10:31:34 +00:00
Andrey Hristov
94ccf70c77
longer error messages, don't cut them
2011-07-27 10:26:59 +00:00
Christopher Jones
cf8bf9f2f0
Add explicit casts to remove some of Pierre's snapshot build warnings
2011-07-27 00:04:23 +00:00
Ulf Wendel
e2ad8e9c1c
Double check if line is sill usable and connected to last successfully selected db.
2011-07-26 16:14:59 +00:00
Ulf Wendel
823de19461
Check what happens if switching DB via API fails. Expected: no change of current DB/schema.
2011-07-26 15:37:59 +00:00
Ulf Wendel
61b2568310
Would be nice if tests get updated whenever a feature is added by the person adding the feature...
2011-07-26 09:33:01 +00:00
Ulf Wendel
ac9708ccf2
Fix mysqlnd detection
2011-07-26 09:30:49 +00:00
Christopher Jones
987db5f747
Fix cast warning seen on some platforms
2011-07-25 23:40:57 +00:00
Felipe Pena
2df7afeb1c
- Revert accidental change
2011-07-25 21:39:53 +00:00
Christopher Jones
fc83d523b8
Patch r313663 and r313665 to allow PECL builds to work with earlier releases
2011-07-25 17:30:09 +00:00
Christopher Jones
99049e2fdd
Update skipif
2011-07-25 17:22:48 +00:00
Felipe Pena
23e438594d
- Make usage of new PHP_FE_END macro
2011-07-25 11:42:53 +00:00
Scott MacVicar
04c2df66a3
When we have a blocking SSL socket, respect the timeout option.
...
reading from SSL sockets could block indefinitely due to the lack
of timeout
2011-07-23 01:29:44 +00:00
Felipe Pena
fcb9e4b2b3
- Disable __sync_fetch_and_add for HPUX for now, gcc seems not provide __sync_fetch_and_add_4 for all targets
2011-07-23 01:08:24 +00:00
Daniel Convissor
3c63a836cf
Fix spelling error.
2011-07-21 19:56:54 +00:00
Daniel Convissor
22710d1c44
Have test for add/sub/diff one second during ST/DST transition in spring.
2011-07-21 15:35:06 +00:00
Pierre Joye
83b69f4034
- Fixed bug #55258 (Windows Version Detecting Error) (already fixed in trunk/5.4)
2011-07-21 14:49:55 +00:00
Ryan Biesemeyer
5dc5c26a5f
removing openssl test for bug #55169 per Scott MacVicar's request; duplicate coverage of opensssl_random_pseudo_bytes.phpt
2011-07-20 21:25:39 +00:00
Ryan Biesemeyer
7acdad749c
update test for bug #55169 , fix skipif
2011-07-20 21:13:03 +00:00
Ryan Biesemeyer
74d6fe4f00
update test for bug #55169 , don't require the extension in INI
2011-07-20 20:57:17 +00:00
Ryan Biesemeyer
292abd1240
tests for bug #55169 (mcrypt and openssl)
2011-07-20 18:59:05 +00:00
Daniel Convissor
d31c5e8a4d
Rename and enhance test for bug 55253 now that bugs web is up.
2011-07-20 18:24:14 +00:00
Scott MacVicar
946456425e
openssl_encrypt() / openssl_decrypt() were flawed and truncated the key to the default size for the case of a variable key length cipher.
...
The result is a key of 448 bits being passed to the blowfish algorithm would be truncated to 128 bit.
Also fixed an error in the zend_parse_parameters() having an invalid character being used.
2011-07-19 22:15:56 +00:00
Felipe Pena
c3c761ffeb
- Fixed bug #55231 (Unsatisfied symbols __sync_fetch_and_add_4)
2011-07-19 22:12:13 +00:00
Popa Adrian Marius
23e564762a
Fix for bug http://bugs.php.net/54426
...
Checks for NULL are wrong as the values can be provided by the triggers
2011-07-19 20:25:51 +00:00
Pierre Joye
8280b0a710
- update blowfish to 1.2 (Solar Designer)
2011-07-18 21:26:29 +00:00
Philip Olson
0b9be2918d
Updated is_a() and is_subclass_of() tests as per the removed E_WARNING from r313162 which was inspired by discussion after r312904 and PHP Bug #53727
2011-07-15 19:17:22 +00:00
Daniel Convissor
6672b31c45
Have test for add/sub/diff one second during DST/ST transition.
2011-07-13 16:22:58 +00:00
Daniel Convissor
cafb45221f
Add test for constructing times during the dst/st conversion.
2011-07-13 16:21:10 +00:00
Pierre Joye
3be1f24fba
- Fixed bug #55187 , readlink returns weird characters when false result
2011-07-12 15:15:17 +00:00
Dmitry Stogov
7d1eef4aa7
Fixed bug #54332 (Crash in zend_mm_check_ptr // Heap corruption)
2011-07-11 09:47:59 +00:00
Pierre Joye
8ec6ada087
- use warning here to match unix behavior
2011-07-10 14:19:51 +00:00
Andrey Hristov
774e127a00
free data in case of failure in the callee not in the caller
2011-07-05 20:31:53 +00:00
Ilia Alshanetsky
43edfb2710
Fixed bug relating to un-initialized memory access
2011-07-05 20:10:45 +00:00
Stanislav Malyshev
5bd0be8a15
fix crypt() issue with overlong salt
2011-07-04 23:38:09 +00:00
Dmitry Stogov
293f710827
Fixed bug #53727 (Inconsistent behavior of is_subclass_of with interfaces)
2011-07-04 14:55:39 +00:00
Felipe Pena
37dab6afee
- Fixed bug #54329 (MSSql extension memory leak)
...
patch by: dotslashpok at gmail dot com
2011-07-03 19:01:42 +00:00
Gustavo André dos Santos Lopes
3dafd9549d
- Fixed bug #55082 (var_export() doesn't escape properties properly).
2011-06-30 09:26:35 +00:00
Ilia Alshanetsky
aa2ec7517e
Fixed test
2011-06-28 23:47:05 +00:00
Knut Urdalen
819be8a3b2
working on test coverage for ext/dom, here's 17 more tests
2011-06-28 20:17:15 +00:00
Pierrick Charron
1b416caeb1
Fixed bug #54971 (Wrong result when using iterator_to_array with use_keys on true)
2011-06-28 11:09:06 +00:00
Christopher Jones
0c2ee427d7
Keep the DBA DB4 test status quo after Berkeley DB 5.2 introduced error message prefixes
2011-06-27 22:58:59 +00:00
Hannes Magnusson
e788932a91
Fix 5.1 detection on ubuntu natty
2011-06-27 20:28:30 +00:00
Christopher Jones
cf6b208cab
missed version sync with 5.4
2011-06-27 17:24:55 +00:00
Derick Rethans
93fcf04fc1
- Updated to version 2011.8 (2011h)
2011-06-27 11:47:43 +00:00
Felipe Pena
92ef080a2e
- Fixed data type usage in 64bit
...
Reported by: Leonildo Costa
2011-06-27 01:36:39 +00:00
Knut Urdalen
778edca904
fixed temp directory names in spl tests
2011-06-25 07:45:41 +00:00
Knut Urdalen
f8e21c395b
fixed/refactored some spl tests related to owner/group retrieval
2011-06-25 04:50:42 +00:00
Felipe Pena
10c20ceaf4
- Added SKIPIF
2011-06-24 19:18:06 +00:00
Felipe Pena
08ddf683fc
- Fixed crash in error_log() (strlen(NULL)) reported by: shm, Maksymilian Arciemowicz
2011-06-23 21:48:15 +00:00
Hannes Magnusson
71a5c3d7ec
These are annoyingly slow
2011-06-23 21:27:42 +00:00
Hannes Magnusson
12081f5659
Add charset, fixes the validate_on_parse test (confik)
2011-06-22 14:59:20 +00:00
Shein Alexey
113e304dcf
Fixed dom tests.
2011-06-22 09:28:14 +00:00
Daniel Convissor
887f30dc61
Make xfail text not reference a particular version now that 5.4 branch exists.
2011-06-19 16:46:32 +00:00
Felipe Pena
8d6e997315
- Opss, restore old behavior
2011-06-19 14:50:44 +00:00
Felipe Pena
0806f78f77
- Added missing void param check in sys_get_temp_dir
...
- Fixed param check of umask()
2011-06-19 14:27:33 +00:00
Felipe Pena
f4554096e1
- New tests (code coverage++)
2011-06-19 12:33:49 +00:00
Felipe Pena
3964ddd1c4
- Added missing void param checks, and fix arginfo
2011-06-18 22:48:31 +00:00
Felipe Pena
2b309c8f9e
- Added missing arginfos for void params and void param checks
2011-06-18 15:56:14 +00:00
Daniel Convissor
370d483bcb
Provide test for DateTime::add() issue (for discussion on internals, bugs.php.net is down).
2011-06-18 01:00:56 +00:00
Daniel Convissor
249667f9e3
Split DateTime diff/add/sub tests into separate files to make things easier to see, test and (one hopes) fix.
2011-06-18 00:29:52 +00:00
Christopher Jones
52cc62d825
Remove duplicate lines present in PHP_5_3's .phpt (dtajchreber)
2011-06-17 21:42:40 +00:00
Christopher Jones
21abc2f1c1
Fix skipif to resolve the common reason this test fails
2011-06-17 18:28:34 +00:00
Derick Rethans
4b9857e7a4
- Fixed bug where the DateTime object got changed while using date_diff().
2011-06-17 16:38:23 +00:00
Felipe Pena
f7ee12e928
- Fixed two "jump or move depends on uninitialised value"
2011-06-17 02:00:20 +00:00
Pierre Joye
ccae79a2c3
- did I not kill that already? (do not use rand_screen, pointless on server and not TS)
2011-06-16 13:06:41 +00:00
Pierre Joye
b498b5dfe5
- install extra headers
2011-06-16 01:21:01 +00:00
Scott MacVicar
c2ca352598
Upgrade SQLite to 3.7.6.3
2011-06-14 17:00:49 +00:00
Timm Friebe
6210bf0dba
- MFH suppression of compiler warning noted in bug #55009
2011-06-13 08:45:21 +00:00
Felipe Pena
0ec1758381
- Fixed bug #54680 (missing TRACK_VARS_SERVER check)
2011-06-12 02:47:48 +00:00
Gustavo André dos Santos Lopes
a54847a0fb
- Reverted r301991, which is a (partial) fix to bug #52550 , addressing an
...
overflow in a signed subtraction. This fixes the overflow without
changing the algorithm.
2011-06-12 00:56:18 +00:00
Timm Friebe
55aab4e6de
- MFH Bugfix for bug #53540
2011-06-11 18:55:15 +00:00
Felipe Pena
9b1ba00a1e
- Missing fix for bug #54347
2011-06-11 15:11:49 +00:00
Felipe Pena
a76f790b58
- Possible fix for bug #55022 (memory_limit exhausted when set charset in sybase_connect)
2011-06-11 01:15:14 +00:00
Christopher Jones
17af8b0179
Fix TSRMLS for Windows build
2011-06-11 00:24:26 +00:00
Felipe Pena
c776180f6e
- Drop C++ style comments
2011-06-10 23:14:15 +00:00
Felipe Pena
0e37aa144f
- Fixed bug #55028 (// is abad comment)
2011-06-10 22:48:36 +00:00
Christopher Jones
c7a8bd6a4c
Add new OCI8 tests. Refactor skipifs. Sync 5.3/5.4/trunk branches
2011-06-10 19:16:35 +00:00
Christopher Jones
f4009b52a3
Add oci_client_version() returning the runtime Oracle client library version - predominantly useful for the test suite
2011-06-10 17:38:07 +00:00
Christopher Jones
bc0d535f5a
Missed trivial comment sync with PHP_5_4 and trunk
2011-06-10 17:16:00 +00:00
Felipe Pena
60857e013b
- Fixed bug #54347 (reflection_extension does not lowercase module function name)
...
patch by: laruence at yahoo dot com dot cn
2011-06-09 22:45:35 +00:00
Shein Alexey
ae2e75a657
Fixed test.
2011-06-09 13:09:25 +00:00
Shein Alexey
21fb2a42cc
Changed session.save_path to /tmp to make test run.
2011-06-09 08:24:12 +00:00
Shein Alexey
3b37e152c3
Skip reason is now printed if session.save_path is not writable.
2011-06-09 08:18:49 +00:00
Shein Alexey
25adf56921
Fixed session test breakage due to serialize precision issue.
2011-06-09 07:44:10 +00:00
Ilia Alshanetsky
cca899148a
Fixed test
2011-06-08 23:30:02 +00:00
Ilia Alshanetsky
9277da7d9d
Fixed test to account for smaller default floating point # precision
2011-06-08 02:03:14 +00:00
Gustavo André dos Santos Lopes
cd7681d273
- Fixed bug #54992 : Stream not closed and error not returned when SSL CN_match
...
fails.
2011-06-08 00:23:02 +00:00
Christopher Jones
031085e0a9
Sync OCI8 branches. Allow 'pecl install' to work on both PHP 5.3 & 5.4
2011-06-07 23:53:02 +00:00
Ilia Alshanetsky
14ed144318
Fixed test 008
2011-06-07 01:40:54 +00:00
Ilia Alshanetsky
d846d0e80a
Fixed bug #51997 (SEEK_CUR with 0 value, returns a warning).
2011-06-05 21:57:01 +00:00
Hannes Magnusson
10da251565
Fixed bug#51819 (Case discrepancy in timezone names cause Uncaught exception and fatal error)
2011-06-05 13:30:01 +00:00
Philip Olson
f472141549
Updated the note maintainers credits
2011-06-05 06:57:13 +00:00
Felipe Pena
0afd4bd18b
- Possible fix for bug #54609 (Certain implementation(s) of SplFixedArray cause hard crash)
2011-06-05 01:38:12 +00:00
Felipe Pena
087a134b50
- Fixed bug #54929 (Parse error with single quote in sql comment)
2011-06-04 22:54:40 +00:00
Ilia Alshanetsky
00a6dd29b7
Show ICU Data version inside phpinfo()
2011-06-03 18:14:36 +00:00
Gustavo André dos Santos Lopes
479a47d8af
Merge of fix for bug #54918 (r311745, scottmac) to 5.3.
2011-06-03 09:39:45 +00:00
Gustavo André dos Santos Lopes
7af15a41d9
- Fixed double registering of browscap ini directive. See bug #54896 .
2011-06-02 08:46:40 +00:00
Felipe Pena
47315dfdf6
- Fixed bug #54970 (SplFixedArray::setSize() isn't resizing)
2011-06-02 00:40:27 +00:00
Ilia Alshanetsky
f7cdabd118
More tests
2011-06-01 16:59:23 +00:00
Ilia Alshanetsky
e6c9a31c54
Implemented FR #54561 (Expose ICU Version & ICU Data Version info).
2011-06-01 16:26:21 +00:00
Ilia Alshanetsky
83d01bd81b
Fixed bug #52104 (bindColumn creates Warning regardless of ATTR_ERRMODE settings).
2011-06-01 13:23:25 +00:00
Ilia Alshanetsky
f4f2aa7583
Fixed bug #54484 (Empty string in json_decode doesn't reset json_last_error()).
2011-06-01 09:44:38 +00:00
Rafael Machado Dohms
b903587268
Adding testcases to validate imageloadfont input parameter validation, tests were developed at #tek11 testfest
2011-05-31 21:24:10 +00:00
Andrey Hristov
b97e76d512
reuse code
2011-05-31 20:42:44 +00:00
Shein Alexey
e69b73e0b8
Fixed notice breaking the test.
2011-05-31 12:57:40 +00:00
Andrey Hristov
e2ac61225f
fix macros
2011-05-31 10:35:07 +00:00
Ilia Alshanetsky
3d7a201eb4
Removed test for functionality available in 5.4+
2011-05-31 09:01:44 +00:00
Ilia Alshanetsky
e91cecb1d3
Removed unnecessary rinit/rshutdown
2011-05-31 08:59:32 +00:00
Hannes Magnusson
3b030ec75f
Fixed bug #54946 (stream_get_contents infinite loop)
2011-05-29 12:29:19 +00:00
Hannes Magnusson
07bcf1080d
Fixed bug #54601 (Removing the doctype node segfaults)
2011-05-29 11:39:49 +00:00
Ilia Alshanetsky
69a12bfb3f
Fixed bug #53848 (fgetcsv() ignores spaces at beginnings of fields).
2011-05-29 10:23:06 +00:00
Ilia Alshanetsky
ef74038d1d
Fixed bug #54137 (file_get_contents POST request sends additional line break).
2011-05-29 09:23:08 +00:00
Felipe Pena
490b75d170
- Fixed bug #54934 (Unresolved symbol strtoull in HP-UX 11.11)
2011-05-27 23:31:30 +00:00
Ilia Alshanetsky
8267eaf1bf
Fixed bug #54924 (assert.* is not being reset upon request shutdown).
2011-05-26 18:17:43 +00:00
Pierre Joye
885357a711
-fix bug 54935, php_win_err can lead to crash
2011-05-26 14:37:13 +00:00
Philip Olson
983cedfd94
Fixed test, as per r311323
2011-05-25 00:02:05 +00:00