Commit Graph

1160 Commits

Author SHA1 Message Date
Greg Beaver
fbb2e8ce60 more fixes for PHAR_G(cwd) 2008-04-28 06:03:33 +00:00
Greg Beaver
62f824b6e1 fix crash (this area really needs code coverage) 2008-04-28 04:38:07 +00:00
Greg Beaver
5da6c48f7d add open_basedir/safe_mode checks for files in Phar::addFile() 2008-04-27 23:59:41 +00:00
Greg Beaver
e2660a692b fix test 2008-04-27 23:59:14 +00:00
Steph Fox
bcd2ddd018 - Kill another one from the gcov site's parameter parsing report 2008-04-27 16:42:03 +00:00
Steph Fox
51459aade4 - Another test that gives completely different results if readonly=0 2008-04-27 12:22:36 +00:00
Steph Fox
473abd4e2b - Deleting files we cannot see... 2008-04-27 11:36:22 +00:00
Steph Fox
37a8782f0c - Fix a couple of failing tests/bad cleanup
@Greg: the phpinfo() ones assumed no php.ini - this isn't always the case, even if it should be
2008-04-27 11:31:27 +00:00
Steph Fox
2ea698eae7 - Make it possible to extract all *and* overwrite 2008-04-27 11:26:15 +00:00
Steph Fox
9e8c3ea9a7 - Always give reasons for skipped tests 2008-04-27 10:18:35 +00:00
Steph Fox
77dcb8cffd - Kill a few uninitialized vars (thanks gcov) 2008-04-27 10:14:00 +00:00
Greg Beaver
fd9bf92ac6 fix out-of-bounds read potential by replacing strstr with a custom strnstr 2008-04-27 07:20:02 +00:00
Greg Beaver
5bf3d1d362 fix invalid free 2008-04-27 07:04:56 +00:00
Greg Beaver
94846549f5 fix APC compile hook interception, now APC actually caches files 2008-04-26 23:16:49 +00:00
Greg Beaver
fade22bfd8 fix ridiculously critical omission in zip flush - we never set compressed file size! Augment zip test for bz2/zlib-compressed alias files to increase code coverage 2008-04-26 23:02:51 +00:00
Greg Beaver
11c93b8494 add checking for invalid alias on opening tar, and test 2008-04-26 22:31:44 +00:00
Greg Beaver
ad6e7fc667 add screening of alias to reading of zip archives, and test for bad aliases 2008-04-26 22:04:04 +00:00
Greg Beaver
5b85b2074b new test/updated test to ensure stub integrity (I was wrong, zip is fine) 2008-04-26 17:47:31 +00:00
Greg Beaver
489fe0331f add logic test to ensure stub is not overwritten when adding a file (zip currently does this - bad zip) 2008-04-26 17:43:53 +00:00
Greg Beaver
52f5a0f2ac increase code coverage 2008-04-26 17:34:14 +00:00
Greg Beaver
15f9f20c3c really fix test by fixing the regex 2008-04-26 17:32:18 +00:00
Greg Beaver
76c78a480e increase code coverage (and magically, mysteriously this tests passes with no other changes - weird) 2008-04-26 17:29:55 +00:00
Greg Beaver
eb6b941d2a fix clean 2008-04-26 17:28:28 +00:00
Greg Beaver
f37605ec0c increase code coverage 2008-04-26 17:27:47 +00:00
Greg Beaver
b22cc67e6b new test increases code coverage 2008-04-26 17:20:50 +00:00
Greg Beaver
2227f10f3e add failing portion of test for compressed alias read 2008-04-26 17:18:15 +00:00
Greg Beaver
8e7f6d6662 add failing portion of test for bz2 compressed file on open 2008-04-26 17:14:27 +00:00
Greg Beaver
79a45a9666 fix buildfromiterator base to exclude directory separator on unix or windows, fix 10 test to have new tests 2008-04-26 17:09:58 +00:00
Greg Beaver
c6b617eca8 fix cleanup 2008-04-26 16:57:14 +00:00
Steph Fox
cf7f50e42c - Added a RecursiveIterator/buildFromIterator test
- Fixed up bug13727.phpt to take < 15 minutes :\\ and clean up after itself
- Cleaned up protos/reflection data
- Added myself to package.xml credits
2008-04-26 13:22:38 +00:00
Greg Beaver
0c2f3b760a add Phar::extractTo(dest_directory[, mixed files[, bool overwrite]])
this is very similar to ext/zip's extractTo and is based on that code, with the addition of the third parameter, which
is used to allow overwriting existing files (disallowed by default, unlike ext/zip's implementation)
[DOC]
2008-04-26 05:31:00 +00:00
Greg Beaver
c5fc383cb7 finish code coverage work (whew) 2008-04-26 05:28:56 +00:00
Steph Fox
dbb4618bd5 - cs 2008-04-26 02:04:09 +00:00
Steph Fox
f040cb6492 - fixed those pesky memleaks 2008-04-26 01:52:22 +00:00
Steph Fox
9bf8d7429e - implemented Phar::buildFromDirectory
@Greg: There are two (identical) recurring memleaks I can't seem to kill, both marked FIXME. Would you please take a look?

[DOC] $phar->buildFromDirectory(dirname[, regex]). Return value is an array pairing each file in the archive index with the original path on the filesystem.
2008-04-25 21:37:41 +00:00
Greg Beaver
68dc76a9ab make dang sure this ridiculous test cleans up after itself 2008-04-25 16:54:37 +00:00
Greg Beaver
8657ab7e5a add test for bug #13727, fix bug #13727 2008-04-25 16:50:22 +00:00
Greg Beaver
2bf5042d74 finish code coverage testing of phar_object.c (except for iterator building, which Steph is doing) and fix segfault in error message for directory getcontent if it is a temp directory 2008-04-25 16:10:59 +00:00
Greg Beaver
84004bf248 new test with code coverage for PharFileInfo::setMetadata/delMetadata, improve error messages 2008-04-25 16:05:05 +00:00
Greg Beaver
3864211c00 remove unneeded skipif conditions 2008-04-25 15:56:20 +00:00
Greg Beaver
13dc477de2 new code coverage test, improve clarity of error message when chmod is used on a temp directory 2008-04-25 15:53:02 +00:00
Greg Beaver
7c7b387cc3 fix potentially serious security issue: buffer overrun if the tar filename > 101 characters in length. This fixes tests/tar/bignames.phpt 2008-04-25 04:35:10 +00:00
Greg Beaver
efe519c194 fix access fault on windows, fix memleak on all platforms when accessing a temp directory via offsetGet 2008-04-25 04:34:03 +00:00
Greg Beaver
6036559d35 fix tests on windows 2008-04-25 04:31:44 +00:00
Greg Beaver
fc9aba79f5 add missing file (Steph: this fixes tests/tar/truncated.phpt, sorry :) 2008-04-25 04:29:08 +00:00
Greg Beaver
218b975485 fix test (except for memleaks) 2008-04-24 20:02:04 +00:00
Greg Beaver
0db641af3e rework PharFileInfo->decompress and add failing test 2008-04-24 19:57:22 +00:00
Greg Beaver
d28dcfaf60 new test 2008-04-24 17:25:23 +00:00
Greg Beaver
84c622c2ab new test for PharFileInfo::__destruct 2008-04-24 17:19:01 +00:00
Steph Fox
aaf5498ff4 - clean the right file :) 2008-04-24 17:02:27 +00:00
Steph Fox
21584ed029 - kill a couple of (release build) MS compiler warnings 2008-04-24 16:59:23 +00:00
Steph Fox
28459132cb - Fix Windows build 2008-04-24 16:03:40 +00:00
Greg Beaver
91e67a4fbd test PharFileInfo::__construct, fix potential segfault, and bad logic in phar detection 2008-04-24 05:18:50 +00:00
Greg Beaver
1f98c6526b increase code coverage 2008-04-24 05:03:12 +00:00
Greg Beaver
24d83fa7f8 fix break when uncompressed files are re-saved, fixes phar_copy.phpt test 2008-04-24 04:56:22 +00:00
Greg Beaver
8f0c9caac5 remove redundant unreachable code in Phar::copy, augment test, and add failing condition that needs to be fixed 2008-04-24 04:14:05 +00:00
Greg Beaver
696dafa370 new test for Phar::decompress() 2008-04-24 04:05:20 +00:00
Greg Beaver
b721660ec7 increase code coverage 2008-04-23 19:01:52 +00:00
Greg Beaver
9c60d2dcaf increase code coverage 2008-04-23 19:00:42 +00:00
Greg Beaver
207a093186 increase code coverage 2008-04-23 18:59:41 +00:00
Greg Beaver
3190bd0884 increase code coverage, fix minor memleak 2008-04-23 18:54:09 +00:00
Greg Beaver
cebd8a5864 increase code coverage 2008-04-23 18:46:48 +00:00
Greg Beaver
ba2182d795 increase code coverage 2008-04-23 18:46:21 +00:00
Greg Beaver
e5309e4aad increase code coverage 2008-04-23 18:45:42 +00:00
Greg Beaver
ab1d8adb96 fix default format conversion, increase code coverage 2008-04-23 18:44:43 +00:00
Greg Beaver
26d2062305 increase code coverage slightly 2008-04-23 18:32:59 +00:00
Greg Beaver
3b8fc7309f new test increases code coverage, fix memleak found by test 2008-04-23 18:30:53 +00:00
Greg Beaver
4a0b06af82 increase code coverage 2008-04-23 18:22:55 +00:00
Greg Beaver
3d890f09a8 fix extension detection for executable=2 2008-04-23 18:22:09 +00:00
Greg Beaver
c034683550 new test for Phar::isValidPharFilename. Fix Phar::isValidPharFilename. Fix extension detection for all cases 2008-04-23 18:11:20 +00:00
Greg Beaver
faaa9261e5 new test for Phar::loadPhar with phar.extract_list 2008-04-23 17:27:31 +00:00
Greg Beaver
d3689baf53 new test for Phar::mapPhar with phar.extract_list 2008-04-23 17:25:52 +00:00
Greg Beaver
19088c1930 remove/move unreachable code 2008-04-23 17:23:32 +00:00
Greg Beaver
1dc190e680 improve rewrite callback support, add test for callback that does not return string/false 2008-04-23 17:18:28 +00:00
Greg Beaver
22878f0ea2 new test for valid callback that fails for rewrite callback 2008-04-23 16:50:19 +00:00
Greg Beaver
ce5732112e new test for invalid rewrite callback 2008-04-23 16:47:12 +00:00
Greg Beaver
50835e4bb7 new test for SCRIPT_NAME not containing the filename 2008-04-23 16:06:59 +00:00
Greg Beaver
2aa87329db new test for webPhar failure on opening file 2008-04-23 16:03:08 +00:00
Greg Beaver
76b8f30659 new test for webPhar with phar.extract_list 2008-04-23 16:00:06 +00:00
Greg Beaver
5224d341b6 ensure freeing of cwd/name happens in all cases 2008-04-22 17:34:00 +00:00
Greg Beaver
af3dfa23f6 fix headers in test 2008-04-22 17:29:11 +00:00
Greg Beaver
3330c16967 new test for fatal error in php file executed by front controller 2008-04-22 17:28:50 +00:00
Greg Beaver
0338b28939 re-enable disabled cwd code 2008-04-22 17:19:06 +00:00
Greg Beaver
d8b4c2795e remove unreachable code, add test for large non-php file 2008-04-22 17:17:29 +00:00
Greg Beaver
379bcf1f14 remove unreachable code 2008-04-22 17:13:07 +00:00
Greg Beaver
cb8f158cd5 fix PATH_INFO munging, add to test case 2008-04-22 17:11:30 +00:00
Greg Beaver
5ac9c1f23e remove unreachable code, add test for no file extension and unknown file extension with Phar::webPhar 2008-04-22 17:03:10 +00:00
Greg Beaver
4e5fc75977 big ol code coverage test for bad parameters to Phar methods 2008-04-22 05:17:04 +00:00
Greg Beaver
4388a65aa8 fix Phar::mount() to also allow running externally with full phar:// path, add test 2008-04-21 18:21:54 +00:00
Greg Beaver
e0873a380d fix Phar::running() 2008-04-21 18:06:20 +00:00
Greg Beaver
25cdc7de2b fix discovery of files hidden in a URL - makes using any regular front controller possible 2008-04-21 17:59:28 +00:00
Greg Beaver
2f56c7f343 new test for custom 404 handler, fix segfault found by test 2008-04-21 17:46:24 +00:00
Greg Beaver
cfc12b2afe increase code coverage of phar.c significantly by ensuring signature algorithm test is actually run (duh) 2008-04-21 17:04:15 +00:00
Greg Beaver
7ee3597851 increase code coverage 2008-04-21 16:56:45 +00:00
Greg Beaver
5a4a54f64b remove unused code 2008-04-21 16:51:26 +00:00
Greg Beaver
aaf6101928 another refactoring to combine an error and improve code coverage as a side effect 2008-04-21 16:50:18 +00:00
Greg Beaver
32f2eeea47 minor re-factoring reduces code lines for an error (and evilly increases code coverage at gcov ;) 2008-04-21 16:46:01 +00:00
Greg Beaver
69f74c5c80 minor re-factoring reduces code lines for an error (and evilly increases code coverage at gcov ;) 2008-04-21 16:42:53 +00:00
Greg Beaver
7d218cab35 cosmetics: same case as other tests 2008-04-21 16:42:24 +00:00
Greg Beaver
44358edd8d new test for non-executable zip named as phar 2008-04-21 16:39:11 +00:00
Greg Beaver
779fec2278 implement opendir for mounted directories - much simpler to do than I initially thought 2008-04-21 16:29:09 +00:00
Greg Beaver
afa1439304 finish code coverage for tar file format 2008-04-21 06:46:40 +00:00
Greg Beaver
c4315bfb2b add test for huge filenames, fix huge filename reading 2008-04-21 06:33:49 +00:00
Greg Beaver
1f6292e91d new test for corrupted tar with hard link to nowhere 2008-04-21 06:21:09 +00:00
Greg Beaver
3d858f4aa9 implement symbolic link support within a tar-based phar archive
this also resulted in a major fix for mounted directories, which were recycling the 'link' field which
could cause stupid conflicts with actual links, so move that to new 'tmp' field.
2008-04-21 06:17:51 +00:00
Greg Beaver
f70d527661 use a tar generated by the tar command to test links. Test still fails 2008-04-20 21:48:30 +00:00
Greg Beaver
ca6f70c8a3 add test for symbolic and hard links 2008-04-20 17:59:14 +00:00
Greg Beaver
027180d6ee new test for bad checksum, fix tar.c to catch tar archives with a corrupted first entry, fix memleak on bad checksum 2008-04-20 17:28:54 +00:00
Greg Beaver
4abe1a0978 fix tests to match CVS 2008-04-20 17:19:24 +00:00
Greg Beaver
6d421e13b0 fix truncation test 2008-04-20 16:58:08 +00:00
Greg Beaver
f5dbaf64fc add failing test for truncated tar archive 2008-04-20 15:12:09 +00:00
Greg Beaver
8001dfd8d0 new test, increases code coverage slightly 2008-04-20 14:54:05 +00:00
Greg Beaver
5e5dd15d52 fix test to be OS-agnostic 2008-04-20 05:50:40 +00:00
Greg Beaver
41d9dde1df re-adding as binary 2008-04-20 05:49:06 +00:00
Greg Beaver
7cc7bdded7 added as text, removing in order to re-add 2008-04-20 05:48:52 +00:00
Greg Beaver
56650fa4cd amend zip test to actually test file perms creation/reading and fix severely broken permissions creation 2008-04-20 05:41:41 +00:00
Greg Beaver
4336865bb4 add new test for openoffice-created zip 2008-04-20 05:22:02 +00:00
Greg Beaver
0cf701fe4e new test for unix 'zip' command-created zip archives 2008-04-20 05:19:20 +00:00
Greg Beaver
50962003e0 fix fopen test problem - behavior is slightly different from PHP 5.2 -> PHP 5.3
now all tests pass on windows on my box
2008-04-20 04:35:14 +00:00
Greg Beaver
ab45c16a61 fix all but 1 test on windows (yay) 2008-04-20 04:19:13 +00:00
Greg Beaver
54540385b8 fix a couple more tests on windows 2008-04-20 04:10:51 +00:00
Greg Beaver
95fc6451f0 fix 98 of 105 failing tests on windows (real progress now) 2008-04-20 00:24:01 +00:00
Greg Beaver
9035dc059a fix 3 failing tests out of 108 on windows (whoop-de-doo) 2008-04-19 17:57:24 +00:00
Greg Beaver
ef0139c866 fix ZTS build 2008-04-19 17:24:41 +00:00
Greg Beaver
f870b8ae74 fix ZTS build and Phar::isValidPharFilename 2008-04-19 17:24:26 +00:00
Greg Beaver
e94aaeada9 new test for unsupported compression versions, vastly enhance error messages on unsupported compression methods, fix memleak 2008-04-19 06:18:13 +00:00
Greg Beaver
aa61e6066c new tests for corrupted zips 2008-04-19 05:58:40 +00:00
Greg Beaver
0d1e0b4311 new test for zip archives with files created from stdin 2008-04-19 05:53:57 +00:00
Greg Beaver
78c55d2f6d new test for encrypted zips 2008-04-19 05:51:10 +00:00
Greg Beaver
d3a4ecf5ab new test for central directory offset being wrong 2008-04-19 05:45:10 +00:00
Greg Beaver
bd3ddde29f new test for truncated file comment, fix memleak found by test 2008-04-19 05:39:42 +00:00
Greg Beaver
4e98585ff7 new corrupt zip test 2008-04-19 05:35:03 +00:00
Greg Beaver
531caa6393 new test for corrupted zip with mis-matched entry counts, and fix memleaks in this test case 2008-04-19 05:30:48 +00:00
Greg Beaver
410ce457ab add utility for creating corrupted zip archives for testing purposes 2008-04-19 05:15:24 +00:00
Greg Beaver
c4f502fae0 COMPLETELY rework filename extension detection. Now the only requirements are:
1 - executable phars must contain '.phar' in the filename
2 - non-executable phars must not contain '.phar' and must have an extension of at least 1 character

In addition, phar filenames must exist if opened for read, and the directory containing the phar must exist if opened for creation
if opened for creation, the file must not already exist
[DOC]
2008-04-18 04:13:13 +00:00
Greg Beaver
26e10f8cca fix compression zip tests 2008-04-16 20:26:22 +00:00
Greg Beaver
a3e723b935 add failing tests for compression of zip files internally 2008-04-16 20:15:19 +00:00
Greg Beaver
31e6629895 fix large zip test 2008-04-16 20:08:02 +00:00
Greg Beaver
159e39d81d load entire end of zip instead of weird 8k looping, logic is much simpler, and it's only 65k instead of 8k 2008-04-16 19:48:31 +00:00
Greg Beaver
8bc9ec5466 make test OS-agnostic 2008-04-16 19:47:41 +00:00
Greg Beaver
4e584728e5 fix end of directory locator detection code, add failing test for large zips 2008-04-16 04:34:25 +00:00
Greg Beaver
398bcf4dd0 fix test - metadata works now 2008-04-16 04:16:20 +00:00
Greg Beaver
8c4477cde5 fix segfault in meta-data parsing of zip archives 2008-04-16 04:15:08 +00:00
Greg Beaver
f513caa0a6 add failing test for metadata support in zip archives 2008-04-16 04:11:14 +00:00
Greg Beaver
dc837b5f53 rename is_zip parameter of phar_parse_metadata to more accurately reflect what it is 2008-04-16 04:01:33 +00:00
Greg Beaver
6eabae560b increase code coverage 2008-04-16 03:55:13 +00:00
Greg Beaver
21b84bb728 forgot F in EXPECTF 2008-04-16 03:54:06 +00:00
Greg Beaver
cd9ecb53ae increase code coverage 2008-04-16 03:54:05 +00:00
Greg Beaver
6387155b3d add another test for alias overloading and make sure we disallow it when passed in constructor 2008-04-16 03:42:29 +00:00
Greg Beaver
ae3837851a fix tests so $Revision$ does not screw with things 2008-04-16 03:27:45 +00:00