foobar
3ca8ad73a4
- Missing $Id$ tags
2005-02-13 17:54:04 +00:00
foobar
7281cd8082
MFB_4_3: cvs diff -r1.84.2.5 -r1.84.2.6 php_session.h
2005-02-13 07:55:27 +00:00
Antony Dovgal
5b78e4c025
hm..
...
fix #28324 _properly_
2005-02-10 20:22:07 +00:00
Antony Dovgal
94982058b6
fix bug #28324 (HTTP_SESSION_VARS appear when register_long_arrays is Off)
2005-02-10 19:38:11 +00:00
Stefan Esser
581265f4d1
Correctly initialize ZVAL
2005-01-21 16:03:47 +00:00
foobar
64e40c2271
- Make sure FD_CLOEXEC is always defined.
2005-01-18 15:44:33 +00:00
Antony Dovgal
37d3ea836e
add skipif section
2005-01-09 18:22:12 +00:00
Antony Dovgal
68d73f8cf9
add test for bug #31454
2005-01-09 18:15:49 +00:00
Antony Dovgal
d7072f8a9d
efree(name)
2005-01-09 17:49:51 +00:00
Antony Dovgal
c644b2a5a1
fix bug #31454 (session_set_save_handler crashes PHP when supplied non-existent object ref)
2005-01-09 17:42:02 +00:00
Antony Dovgal
ad76be844b
CS changes (as suggested by Ilia)
2004-12-09 17:15:52 +00:00
Antony Dovgal
e76824c91f
fix segfault in session_module_name() when session.save_handler is empty
2004-12-09 14:14:21 +00:00
Dmitry Stogov
a22fa4d109
Fixed crash in phpinfo() after graceful Apache restart.
2004-12-07 18:02:25 +00:00
Joe Orton
2685ca935f
Update extensions to use /path/to/$PHP_LIBDIR rather than /path/to/lib
...
to support multi-ABI platforms.
2004-11-03 14:32:52 +00:00
Andi Gutmans
11bcaedfc8
- Rename delete_global_variable() to zend_delete_global_variable()
2004-10-04 20:17:06 +00:00
Andi Gutmans
db507dd153
- Commit the variable fetch optimization.
...
- Extensions which delete global variables need to use new special function
- delete_global_variable() (I'm about to rename it) to remove them.
- Will post to internals@ or via commit messages if there's anything else.
2004-10-04 19:54:35 +00:00
Anantha Kesari H Y
47e4f575c2
modified to 3rd argument of fcntl to FD_CLOEXEC
2004-10-04 08:52:53 +00:00
Anantha Kesari H Y
142e92bb70
NetWare specific stat structure access incorporated
2004-09-30 14:31:30 +00:00
Anantha Kesari H Y
ccbeace1ff
handled NetWare F_SETFD and stat differences
2004-09-30 14:23:51 +00:00
Antony Dovgal
0ea23249da
fix error message
2004-09-30 14:20:02 +00:00
Antony Dovgal
fcd702efe4
fix segfault when using unknown/unsupported save_handler and/or serialize_handler (bug #30282 )
2004-09-30 12:19:59 +00:00
Ilia Alshanetsky
6784176b9c
Fixed compiler warnings.
2004-09-14 23:57:53 +00:00
Ilia Alshanetsky
197d65770a
Fixed bug #29925 (Added a check to prevent illegal characters in session
...
key).
2004-09-02 02:44:04 +00:00
Sascha Schumann
5890197024
fix empty_string issue
...
Patch submitted by Antony Dovgal <tony2001@phpclub.net>
2004-08-02 08:27:46 +00:00
Sascha Schumann
26cb5355e0
don't read empty files
...
0 malloc noticed by Antony Dovgal <tony2001@phpclub.net>
2004-08-02 08:27:24 +00:00
Andi Gutmans
56f8195fe5
- Nuke empty_string. It is a reminanent from the time where RETURN_FALSE()
...
used to return "" and not bool(false). It's not worth keeping it because
STR_FREE() and zval_dtor() always have to check for it and it slows down
the general case. In addition, it seems that empty_string has been abused
quite a lot, and was used not only for setting zval's but generally in
PHP code instead of "", which wasn't the intention. Last but not least,
nuking empty_string should improve stability as I doubt every place
correctly checked if they are not mistakenly erealloc()'ing it or
calling efree() on it.
NOTE: Some code is probably broken. Each extension maintainer should
check and see that my changes are OK. Also, I haven't had time to touch
PECL yet. Will try and do it tomorrow.
2004-07-19 07:19:50 +00:00
Andi Gutmans
e5cfb1d05c
- Better stability during premature shutdown of request startup
2004-07-10 07:46:17 +00:00
Ilia Alshanetsky
690ca62dd3
Do not use alloca() where it can be abused through user input.
2004-06-30 01:12:06 +00:00
Ilia Alshanetsky
df71910d0e
Better skip condition check for session tests.
2004-05-27 20:53:26 +00:00
Marcus Boerger
29cfd6d24f
- Remove unused blocks
2004-05-19 08:56:50 +00:00
Ilia Alshanetsky
f7f966f96f
Skip session tests if session.save_path is not writable.
2004-05-13 12:53:47 +00:00
Sara Golemon
96132bf4fe
if statement logic would never eval to false.
2004-05-08 05:58:18 +00:00
Ilia Alshanetsky
dda0dd4825
Fixed test failure if session.use_trans_sid is enabled.
2004-04-15 13:37:50 +00:00
Ilia Alshanetsky
793140873b
Another setting leak in session code (bug #27963 ).
2004-04-13 18:18:22 +00:00
Ilia Alshanetsky
254c8d6ce9
Fixed bug #27963 (Session lifetime setting may leak between requests).
2004-04-13 00:39:05 +00:00
Wez Furlong
32be6f268b
Fix for Bug #26757 : session.save_path defaults to bogus value on win32
...
Merge from branch with one main difference: the default save_path is
set to the empty string on all platforms, whereas the code in the
branch only does so for win32.
2004-03-29 21:44:07 +00:00
Hartmut Holzgraefe
cc0894b788
more visa to sibira ;)
2004-03-24 18:43:23 +00:00
Moriyoshi Koizumi
75f83f7bb4
- Fix segfaults on deserialisation of referenced variables.
...
# ALLOC_INIT_ZVAL() initialises the type field to IS_NULL, while
# MAKE_STD_ZVAL() doesn't. This caused a kind of random crash
# when zval_ptr_dtor() was applied on an intact zval created by
# the latter method.
#
# Please check relevant bugs again. There should be some that
# have already been marked as bogus.
2004-02-29 00:26:36 +00:00
foobar
ac92c47b84
Fix bug #26005 (Random "cannot change the session ini settings" errors)
2004-02-24 08:47:35 +00:00
foobar
4441da2754
Improve error messages
2004-02-19 01:54:21 +00:00
Zeev Suraski
7c710a9f9b
Use zval_ptr_dtor() to free variables as soon as they hit refcount of 0.
...
Note: You should not be using ZVAL_DELREF() in day to day usage. Instead,
you should use zval_ptr_dtor(). Use ZVAL_DELREF() only if you're
messing with the refcount directly and know what you're doing.
Note #2 : For clarity, if you want to initialize a new zval with a refcount
of 0, it's best to do that directly, instead of using ZVAL_DELREF
after allocating the zval...
2004-02-15 12:58:19 +00:00
Ilia Alshanetsky
0fc2bb9d49
Fixed bug #26862 (ob_flush() followed by output_reset_rewrite_vars() may
...
result in data loss).
2004-02-11 17:00:48 +00:00
Stanislav Malyshev
8487383ede
fix test - remove warning
2004-02-05 09:03:37 +00:00
foobar
6a1d0114a7
Silence some compile warnings
2004-01-23 03:28:59 +00:00
Wez Furlong
6ac364048b
export tsrm id for session globals.
2004-01-09 15:30:07 +00:00
foobar
ccfc46b0aa
- Happy new year and PHP 5 for rest of the files too..
...
# Should the LICENSE and Zend/LICENSE dates be updated too?
2004-01-08 17:33:29 +00:00
Andi Gutmans
dbeb4158d2
- A belated happy holidays and PHP 5
2004-01-08 08:18:22 +00:00
Marcus Boerger
45277ec5d7
Preserve casing
2003-12-22 23:17:17 +00:00
Dmitry Stogov
fca9c0c669
Incorrect test file was fixed. (Use pattern insted of absolute filename)
2003-12-16 11:19:20 +00:00
Ilia Alshanetsky
5264d34578
Update test to reflect new functionality.
2003-12-14 23:27:32 +00:00
Ilia Alshanetsky
d3639b1aa7
Fixed bug #24693 (Allow session.use_trans_sid to be enabled/disabled from
...
inside the script).
2003-12-14 23:24:50 +00:00
Derick Rethans
71f9227cc5
- Fixed bug #26548 (Malformed HTTP dates in headers).
2003-12-07 14:29:43 +00:00
Wez Furlong
98f1021dd8
Make these tests work under win32
2003-12-05 13:42:04 +00:00
Wez Furlong
05b9b20ed8
Add new (optional!) win32 build infrastructure.
...
Will follow up to internals@ shortly.
2003-12-02 23:17:04 +00:00
Wez Furlong
30b631d9f6
Export this so that shared session modules can use it under win32.
2003-12-02 23:14:31 +00:00
Marcus Boerger
c3fddcab62
Fix tests for E_STRICT and check for E_STRICT in run-tests.php.
2003-11-30 13:57:20 +00:00
foobar
e85a4cdbd2
- Fixed bug #25780 (ext/session: invalid session.cookie_lifetime causes crash in win32).
2003-10-08 10:22:51 +00:00
foobar
dc080a5db6
- Always look into /usr/local before /usr
...
- Added breaks to make sure the preferred value is used.
2003-10-01 02:53:23 +00:00
Ilia Alshanetsky
526a3d9ce2
Always prefer user specified paths over the default /usr /usr/local.
...
This may fix compilation problems with on systems with multiple copies of
the same library.
2003-09-30 22:36:43 +00:00
foobar
72de75c99a
This is only needed for Windows.
2003-09-25 14:53:41 +00:00
Ilia Alshanetsky
569bd005d2
Fixed bug #25070 (Don't forget to unlock session files on win32 before
...
closing them).
Regions should be locked only briefly and should be unlocked before
closing a file or exiting the program. On Win32 locked files that are
closed without being explicitly unlocked will be unlocked only when "system
resources become avaliable".
2003-09-24 23:39:14 +00:00
Sascha Schumann
394d3b82b0
Alias session_commit to session_write_close, a more intuitive name
...
for the functionality.
2003-09-21 11:53:12 +00:00
Sascha Schumann
a3c89a2e8f
Fix a segfault which occured when using a storage format not capable
...
of expressing references (e.g. WDDX) and deserializing a session variable
whose name conflicted with an existing symbol in the global scope.
PR: #25307
Submitted by: Jani Taskinen
Speling fixes: me
2003-08-29 12:33:47 +00:00
Andrey Hristov
20383f9080
\n at the end of the message is not needed
2003-08-28 20:43:18 +00:00
Sascha Schumann
237da469d7
format string fix
2003-08-28 17:34:33 +00:00
foobar
625600af30
- Prevent crash if non-existing save/serializer handler is tried to be used
...
- Added the registered serializers information to MINFO.
2003-08-26 02:03:41 +00:00
Ilia Alshanetsky
b9b75991e3
Fixed bug #25084 (Make refer check not dependant on register_globals)
2003-08-14 01:30:06 +00:00
Ilia Alshanetsky
5eb23bf01e
Added missing skip condition
2003-08-14 00:54:28 +00:00
Ilia Alshanetsky
93bcd55eaf
emalloc -> safe_emalloc
2003-08-12 00:58:52 +00:00
Ilia Alshanetsky
22c3346967
Fixed bug #22245 (References inside $_SESSION not being handled).
2003-08-11 19:20:44 +00:00
Sascha Schumann
5978734f30
MFB proper fix for #24592
2003-07-22 01:11:07 +00:00
Ilia Alshanetsky
f9a8fc0c09
Fixed bug #24592 (Possible crash in session extnsion, with NULL values)
2003-07-21 21:47:52 +00:00
Sterling Hughes
7da8fbd7ef
fix this test when using a save_handler other than files...
2003-07-02 04:34:18 +00:00
Sascha Schumann
f25ff93cc6
MFB
2003-06-13 09:19:52 +00:00
foobar
9706fcd17f
Fix the test. (second session init call produces a notice)
2003-06-13 09:15:56 +00:00
James Cox
f68c7ff249
updating license information in the headers.
2003-06-10 20:04:29 +00:00
Sascha Schumann
3c58f69fc4
Print NOTICE upon session_start being called while another session is
...
active
2003-06-10 03:56:23 +00:00
Marcus Boerger
d1c19eb5a1
Fix tests
2003-05-31 13:10:00 +00:00
foobar
bfe9e39673
MFB: fix proto
2003-05-31 02:33:55 +00:00
foobar
ed1378a975
MFB: Always send a new session cookie upon regenerating id
2003-05-31 02:33:21 +00:00
Sascha Schumann
289ad3960e
Fix the way we create references to (sometimes non-)existing
...
variables.
Credits go to Rob Richards <rrichards@digarc.com> and Zeev
2003-05-15 13:33:18 +00:00
Sascha Schumann
ed68ca44ec
Fix types of bug_compat entries
...
PR: #21312
Submitted by: Rob Richards <rrichards@ctindustries.net>
2003-05-10 16:49:21 +00:00
Stanislav Malyshev
cddface7f1
fix TSRM
2003-04-27 16:18:43 +00:00
Stanislav Malyshev
cad71d8c92
MFB 4_3:
...
Fix very nasty bug - session cookie kills one of the cookies
set before it on certain non-Apache SAPIs.
# for example, this code:
# <?
# setcookie("abc", 1);
# setcookie("def", 2);
# session_start();
# ?>
# would output only 'def' cookie on CGI and ISAPI
2003-04-27 16:04:53 +00:00
Sascha Schumann
4226fe67d1
dividend -> divisor
...
Submitted by: Jesus M. Castagnetto <jmcastagnetto@yahoo.com>
2003-04-05 11:22:15 +00:00
Sebastian Bergmann
5ca078779a
Eliminate some TSRMLS_FETCH() calls. Tested with Win32 build of SAPI/CGI and SAPI/CLI on Win32.
2003-03-25 08:07:13 +00:00
foobar
3c9155e0cb
Renamed OnUpdateInt -> OnUpdateLong to prevent further misunderstandings.
...
# Intentionally left out any 'alias' for it, this way 3rd party extension
# maintainers will really NOTICE the change.
2003-03-07 05:15:28 +00:00
Zeev Suraski
4e55747a2b
Add JIT initialization for _SERVER and _ENV
...
(it's less important for the others, even though it should be fairly
easy now too)
2003-03-02 10:19:15 +00:00
Sascha Schumann
6f5b46c118
generally urlencode parameters
2003-02-20 06:18:16 +00:00
Sascha Schumann
4ec77cfbb5
Refactor new-session-id code
2003-02-18 19:29:38 +00:00
Sascha Schumann
2699c26f42
Remember whether to send a cookie, so that we send out the correct
...
session id. Also improve check for active session
2003-02-18 19:13:49 +00:00
Sascha Schumann
32e0c8161c
add session_regenerate_id()
2003-02-18 18:50:44 +00:00
Sascha Schumann
a10f0830e6
support setting the filemode using session.save_path
2003-02-11 00:42:54 +00:00
Sascha Schumann
5e601732a3
use appropiate prefixes in the ps_module structure so we don't clash
...
with syscalls
2003-02-11 00:42:14 +00:00
Ilia Alshanetsky
242a9a47c7
Fix compiler warning.
2003-01-30 22:37:50 +00:00
Sascha Schumann
330740f7cd
Remove ugly netware hacks from the code
2003-01-24 23:57:32 +00:00
Ilia Alshanetsky
3d8e54f3a2
Changed php_error to php_error_docref.
2003-01-19 00:45:53 +00:00
Ilia Alshanetsky
72b356c1bc
Removed pointless memory allocation checks.
2003-01-18 19:28:10 +00:00
Sascha Schumann
db8b4c6762
Add INI setting session.hash_bits_per_character which enables developers
...
to choose how session ids are represented, regardless of the hash algorithm.
2003-01-16 07:21:49 +00:00
Sascha Schumann
f2f1f94e36
add INI setting session.hash_function
...
add support for creating session ids using SHA-1
source more entropy for session ids
2003-01-12 13:07:14 +00:00