Commit Graph

210 Commits

Author SHA1 Message Date
Greg Beaver
513cec31d3 fix compile warning in PHP < 6.0 2008-08-31 06:58:04 +00:00
Greg Beaver
c73badb3fd remove superfluous variable declarations, merge WS from pecl/phar 2008-08-31 06:51:49 +00:00
Greg Beaver
eec1cf5f0a merge from pecl/phar strlen optimizations 2008-08-31 06:47:38 +00:00
Greg Beaver
e30bf5af3b remove superfluous return statements, merge from pecl/phar 2008-08-31 06:42:46 +00:00
Greg Beaver
1c66670ee8 merge minor optimization removing strlen from pecl/phar 2008-08-31 06:38:09 +00:00
Greg Beaver
6dcdb77f7b remove unused variables, merge from pecl/phar 2008-08-31 06:31:53 +00:00
Greg Beaver
642f6aa673 remove superfluous double variable declaration, merge from pecl/phar 2008-08-31 06:28:01 +00:00
Greg Beaver
27cf27568d use %u instead of %d, merge from pecl/phar 2008-08-31 06:26:19 +00:00
Greg Beaver
f679e900dd remove orphaned code, merge from pecl/phar 2008-08-31 06:13:42 +00:00
Greg Beaver
5c3749021a remove unused variables, merge from pecl/phar 2008-08-31 06:09:37 +00:00
Greg Beaver
a7da5249e2 WS merge from pecl/phar 2008-08-31 06:04:38 +00:00
Greg Beaver
6ac2c92ede 2 fixes, merge minor fixes from pecl/phar. Merge in corrected fix from pecl/phar for is_tar setting of tar_type 2008-08-31 02:14:03 +00:00
Greg Beaver
046f8dba55 sync with pecl/phar, missed one line change 2008-08-30 23:50:31 +00:00
Greg Beaver
3ebb94f6a2 sync with pecl/phar, this does not change any functionality in PHP 5.3, but makes syncing easier. This commit is only functional changes, WS will be next 2008-08-30 23:47:55 +00:00
Greg Beaver
61b09ab834 fix OS-dependent order in test 2008-08-30 23:12:56 +00:00
Greg Beaver
c3e8485971 fix bug #45792: bz2 compressed files in zip failure 2008-08-21 05:17:28 +00:00
Greg Beaver
cfca5be40f fix windows build when building phar shared with native-ssl disabled (you can't use the symbols directly if openssl is built shared or is not built at all) 2008-08-18 14:58:03 +00:00
Antony Dovgal
6eb565a8b0 fix test 2008-08-16 10:48:29 +00:00
Dmitry Stogov
878946a34f Fixed bug #45613 Segfault when using is_file() on Apache-2.2.8 2008-08-14 13:01:28 +00:00
Felipe Pena
cf7384aa40 - MFH: Constness (Added const qualifier to several function parameters) 2008-08-12 17:20:25 +00:00
Marcus Boerger
bfb468c275 - Fix http://bugs.php.net/bug.php?id=45613 2008-08-12 14:56:52 +00:00
Greg Beaver
95a8499996 increase code coverage 2008-08-11 22:43:02 +00:00
Greg Beaver
8526b78286 increase code coverage 2008-08-11 03:53:57 +00:00
Steph Fox
f55d753d3e MFH Remove obsolete check (thanks Tony) 2008-08-02 15:38:46 +00:00
Dmitry Stogov
33f48b800c Fixed bug #44100 (Inconsistent handling of static array declarations with duplicate keys) 2008-08-01 14:22:48 +00:00
Steph Fox
4e5280a7a2 - ws/cs, macros, code that only affects other branches
- some unsynced changes need valgrind testing before they can go into this branch, see PECL/HEAD
2008-08-01 13:48:45 +00:00
Steph Fox
821bab83a3 - Merge ws/cs fixes to bring all branches into sync 2008-08-01 13:42:56 +00:00
Steph Fox
377ff97abd - MFH Bring phar tests into line across all branches 2008-08-01 13:38:48 +00:00
Marcus Boerger
152e4273d1 - Consistency rocks: Make all lines start with tabs for indentation
# Just as anythign else we do.
# Also saves about ~0.5k in phar.phar
2008-08-01 06:16:35 +00:00
Marcus Boerger
d29fba1678 - Fix pear PHP_Archive class file location 2008-08-01 05:43:09 +00:00
Antony Dovgal
57caabf653 don't segfault if given invalid/empty private key 2008-07-29 11:18:40 +00:00
Antony Dovgal
2543206105 don't free function name before calling the function 2008-07-29 11:09:00 +00:00
Antony Dovgal
b53da9cd80 fix folding 2008-07-29 10:52:08 +00:00
Marcus Boerger
fb5c092815 - Fix openssl check 2008-07-27 04:23:00 +00:00
Steph Fox
6895773aff - Utilize new UNIX_PATHS flag in SPL
- Fix tests

@Jani: hold back on the bunny-killing, HEAD will be in sync later today
2008-07-24 09:22:35 +00:00
Dmitry Stogov
c48c63f5e6 Improved webPhar speed (frontcontroller11.phar.phpt is disabled, should be removed) 2008-07-22 07:03:00 +00:00
Dmitry Stogov
68537af530 Fixed directory reanming/deletion 2008-07-20 14:42:34 +00:00
Dmitry Stogov
529ac539d0 Fixed access to freed memory 2008-07-18 09:35:51 +00:00
Dmitry Stogov
67b77b06e5 Fixed search on uninitialized data 2008-07-17 14:05:07 +00:00
Dmitry Stogov
5c631e8765 Fixed wrong arguments order 2008-07-17 13:22:32 +00:00
Dmitry Stogov
44557cf981 Improved support for opcode caches. Now some open() syscalls might be eliminated by caches. 2008-07-16 15:09:39 +00:00
Jani Taskinen
1e2b2bbeae - Some config*.m4 file cleanups: NO tabs in these! 2008-07-14 09:02:26 +00:00
Antony Dovgal
0be3a5dcd5 drop unused var 2008-07-11 09:11:18 +00:00
Antony Dovgal
120f19b6a6 fix function protos and is_link() wrapper 2008-07-11 08:53:43 +00:00
Dmitry Stogov
478234b235 Fixed wrong refcount updates 2008-07-10 16:16:15 +00:00
Dmitry Stogov
d82b5d59b4 Added tests that demonstrate serious PHAR errors
They cannot be easly fixed without algorithms modification
2008-07-10 14:27:21 +00:00
Dmitry Stogov
53bbf1238c Extensions MUST NOT manipulate with internal functions from EG(function_table) in run-time. It may cause problems with opcode caches and in multi-threaded environment. Now the same functions are overriden at MINIT and call original functions or PHAR ones dependent on flag setting. 2008-07-10 11:36:50 +00:00
Antony Dovgal
ae7eff10e8 add zero-terminator to the delimiter (and make valgrind happy) 2008-07-09 14:15:41 +00:00
Dmitry Stogov
1cfd92fc43 Fixed efree(NULL) 2008-07-09 08:47:05 +00:00
Etienne Kneuss
e53a9ca709 Fix filename/pathname/getpathinfo tests according to SPL fix 2008-07-09 08:39:42 +00:00
Steph Fox
27340e60fc - Fixed config.w32 to keep Elizabeth happy
- NB This whole lot still might disappear, OpenSSL patch review pending
2008-07-07 01:13:14 +00:00
Steph Fox
2c9df0990d - We forgot to check that the phar exists before trying to extract files from it :) 2008-07-07 01:11:07 +00:00
Steph Fox
5db08e7d1f Duplicate tests to accommodate parameter parsing fixes in 5_3 core
(NB the 5_2 tests will fail currently due to name changes, will fix tomorrow)
2008-07-07 01:09:21 +00:00
Greg Beaver
37c684ab3d in preparation for a performance optimization that involves
eliminating phar's interception of zend_compile in favor of a new to-be-added hook in PHP 5.3+,
allow "include 'phar:///path/to/my.phar';" to work as equivalent to
php /path/to/my.phar
this slight change in scripting still allows inclusion and execution of phar stub, but removes the need to
check and modify path in zend_compile, which allows us to play much nicer with external tools like
debuggers/opcode caches
2008-06-27 01:21:12 +00:00
Greg Beaver
8bf72978b3 fix several issues:
1) segfault in phar_buildfromdirectoryiterator8.phpt
2) tests failing because SKIPDOTS is default on 64 bit, not on 32
3) Marcus, you really need to add SKIPDOTS as a class constant, so we don't have to use 0x00001000
2008-06-24 01:11:27 +00:00
Steph Fox
b9e8695e75 - One solution for the openssl issues
- config.m4 needs bringing into line with config.w32, there may be broken behaviour under *nix until this is done
2008-06-23 19:18:01 +00:00
Steph Fox
019c586191 - Wrong SKIPIF message 2008-06-23 17:48:23 +00:00
Greg Beaver
10f6d9a556 true fix for potential segfault in phar_build 2008-06-23 04:00:23 +00:00
Greg Beaver
fb448c5c28 fix tar-related failures 2008-06-23 03:55:50 +00:00
Steph Fox
c68a82ac7d - Revert the two blocks of code that implement the phar_build optimization, causes segfaults under *nix
- Leave the new structure in place to make re-implementation trivial
2008-06-22 16:35:26 +00:00
Steph Fox
f3844ecd17 - Revert the tar.c part of the inode calculation fix
- All tests now pass under win32, please test under *nix/osx (4 known fails at present)
2008-06-22 14:46:10 +00:00
Steph Fox
332a185e08 - ws, typo fix 2008-06-22 13:10:03 +00:00
Greg Beaver
3a8b14f83f fix inode calculation, we need fname to be set for phar/tar formats prior to manifest parsing 2008-06-22 00:50:32 +00:00
Greg Beaver
0ad165e402 new tests for phar.cache_list 2008-06-22 00:49:54 +00:00
Steph Fox
0e5b3a3527 - Don't free stuff you still need 2008-06-21 21:37:39 +00:00
Steph Fox
35e0565a4b - Kill a couple of double frees and a memleak
@Greg: You may want to run valgrind over the filestat functions before release..
2008-06-21 20:47:35 +00:00
Steph Fox
ad20b9e6bb - pefree pemalloc'd filename 2008-06-21 20:14:43 +00:00
Steph Fox
22fb73c71e - Fix macro definition syntax
- Remove pre-existing workaround
2008-06-21 19:40:41 +00:00
Steph Fox
f43a2be8cd - fix for segfault in 5.2 (patch from Greg) 2008-06-21 19:15:46 +00:00
Steph Fox
b964ec6e5d - ws 2008-06-21 18:57:53 +00:00
Greg Beaver
4b77c2baa5 define ALLOC_PERMANENT_ZVAL for PHP 5.2 2008-06-21 17:05:32 +00:00
Greg Beaver
eb0a98939a PHP 5.2 fixes to direct include of compressed archives 2008-06-21 17:05:18 +00:00
Greg Beaver
baee4e6028 close stream on failure 2008-06-21 06:55:56 +00:00
Greg Beaver
529aa19cc7 82x(./profile2) speedup for buildFrom*() 2008-06-21 06:53:10 +00:00
Greg Beaver
14c26d05ba fix leak 2008-06-21 06:21:58 +00:00
Steph Fox
97cf2a15da - 5_2 compatibility stuff (so we can stay in sync with PECL) 2008-06-20 16:29:36 +00:00
Steph Fox
c88e99d9ea - Use SKIP_SLOW_TESTS where it's most useful 2008-06-20 14:42:04 +00:00
Steph Fox
6ef7aef1d4 - Kill the last compiler warning under 5.3 (release-only) 2008-06-20 14:40:53 +00:00
Steph Fox
fc08a7cc2f The only reason that particular 'real solution' wasn't applied in the first place was that it also breaks the shared build
Maybe we don't need to call a non-existent dtor if we're going to physically apply zend_hash_graceful_reverse_destroy()?
- This works on my box, please test under *nix/OSX
2008-06-20 12:21:32 +00:00
Johannes Schlüter
62726c967c - Fix ZTS build (not required on HEAD, patch by Uwe Pries) 2008-06-20 09:17:53 +00:00
Greg Beaver
aff3636d9c minor performance improvement 2008-06-20 06:37:14 +00:00
Greg Beaver
7cc6b9f3f5 making progress - up to 42/phar vs. 48/disk with these optimizations 2008-06-20 05:42:58 +00:00
Greg Beaver
5233505043 revert really bad solution to the zend_init_rsrc_list/zend_destroy_rsrc_list problem, replace with real solution 2008-06-20 04:50:11 +00:00
Steph Fox
5d4eed8f47 - inherited methods don't unixify paths along the way. Allow for it. 2008-06-18 16:48:18 +00:00
Steph Fox
aa694b8b51 - Kill 10 MSVC compiler warnings due to type conflict
- Make cached manifest test platform agnostic
- Comment out zend_(init|destroy)_rsrc_list() and associated references

@Greg: cached manifest test (now) passes here regardless, make of that what you will
2008-06-18 15:06:50 +00:00
Pierre Joye
e5e9be2d1a - really fix the windows builds, don't cast many times when only the hash function requires void **
- copy/paste evilness with TSRM_CC/DC
(tests still pass but would be nice to speed them up...)
2008-06-18 10:20:47 +00:00
Greg Beaver
cbe23b9f20 fix windows build and more performance jumps (these are minor)
implement real copy-on-write
use virtual_dirs for wrapper stat
2008-06-18 06:38:47 +00:00
Greg Beaver
d8d31bc591 remove unused variables in phar_fix_filepath
copy virtual_dirs to avoid segfault on multi-process
fix metadata reading for phar.cache_list
initialize manifest to exact size needed (performance increase)
fix freeing of signature on error to use the correct persist value (fixes segfault on error in cache.list)
reset EG(regular_list) so it is identical to how we found it
2008-06-16 04:10:53 +00:00
Greg Beaver
4e65a58146 fix hashtable creation for tar to be estimated size needed 2008-06-16 04:09:20 +00:00
Greg Beaver
03b9673ba2 fix hashtable creation for zip to be exact size needed, fix endian issue for loading manifest 2008-06-16 04:06:59 +00:00
Greg Beaver
c353e9277e minor performance improvement 2008-06-15 23:00:46 +00:00
Greg Beaver
5e3f592d88 fix memleak 2008-06-15 22:51:46 +00:00
Greg Beaver
4104786072 another optimization - move inode hash to initial manifest parsing, improves runtime perf of stat slightly 2008-06-15 21:42:20 +00:00
Greg Beaver
d8ed660a02 minor optimization 2008-06-15 21:15:29 +00:00
Greg Beaver
04e257a8e1 HUGE speed improvement, from 19 req/sec to 27 req/sec for phpMyAdmin - now speed with apc+phar.cache_list = on-disk speedcvs diff -u |less This is by generating a list of virtual directories and using those in stat calls instead of scanning the whole manifest hash table. on-disk phpMyAdmin = 28 req/sec 2008-06-15 18:15:48 +00:00
Felipe Pena
c772aca929 - Fix build (ZTS) 2008-06-13 22:28:55 +00:00
Greg Beaver
4f9daeed11 [DOC] implement full signature support for tar-based archives. By default, data archives do
not have a signature, but can have one set via setSignatureAlgorithm()
2008-06-13 22:07:44 +00:00
Greg Beaver
5ff4deaa53 full refactor of signatures complete - now to implement them for tar as a starting point 2008-06-13 20:15:19 +00:00
Greg Beaver
09e1f0249e PHP_5_2 compat - add pestrndup if undefined 2008-06-13 15:59:13 +00:00
Felipe Pena
d61f32d021 - Fix build (ZTS) 2008-06-13 13:06:46 +00:00