Greg Beaver
d9f4fd0757
slightly clearer error messages
2003-12-06 22:14:11 +00:00
Greg Beaver
9e361c0278
remove unnecessary experimental code
2003-12-06 21:52:20 +00:00
Greg Beaver
61bd893e0d
update phpdoc comment
2003-12-06 06:08:56 +00:00
Greg Beaver
33aa36fb8d
add todo for known issue that isn't yet critical but will be
2003-12-06 06:06:50 +00:00
Greg Beaver
29df86f2d1
improve error message, it was both terrible grammar and unclear.
2003-12-06 05:59:25 +00:00
Greg Beaver
d1770cc57f
fix error message - was printing an empty preferred state
2003-12-06 05:35:52 +00:00
Greg Beaver
5252f3faa9
merge downloader code into HEAD - it works
...
fix bug found in uninstall
2003-12-04 02:11:40 +00:00
Greg Beaver
07a0281d00
add helper methods needed - now it is 100% unit tested
2003-12-04 02:00:39 +00:00
Greg Beaver
e8468911ed
fixed minor bug
2003-12-04 01:35:45 +00:00
Greg Beaver
1558f748e3
fix bugs found in unit-testing, one BC issue also
2003-12-04 01:22:50 +00:00
Greg Beaver
2ab2d8263c
fix notice
2003-12-04 01:22:12 +00:00
Greg Beaver
577cf36f91
remove unnecessary notice generator in certain cases
2003-12-03 23:00:05 +00:00
Greg Beaver
35bdc2f7eb
duhhh...
2003-12-03 22:39:55 +00:00
Greg Beaver
cde3509868
2 bugs found here, added deprecation warning for those who have written their own PEAR application
2003-12-01 01:02:40 +00:00
Greg Beaver
3e60df640e
2 bugs found here
2003-12-01 01:00:57 +00:00
Greg Beaver
1b95c31c77
2 bugs found
2003-12-01 00:59:14 +00:00
Greg Beaver
2939c3539d
fix bug found by unit testing in package ordering
2003-12-01 00:15:53 +00:00
Greg Beaver
0b24e0a404
remove old holdover code that has no purpose
2003-11-30 22:01:22 +00:00
Greg Beaver
76e83f576c
...and with these changes, 100% BC is maintained.
2003-11-30 22:00:59 +00:00
Greg Beaver
c7c5d7689d
experimental code shuffling, moved download() into a new class, PEAR_Downloader.
...
Reasons:
- 7 parameters for a method with lots of pass by reference
implies the need to save state, i.e. use an object
- cleaner code. download() can be easily split into 4 separate but related methods
- Installer.php is now exclusively used for installation
- future extensibility: switching to channels or local package repositories from
using PEAR_Remote is easy. Simply extend the API for PEAR_Downloader:
no changes needed to the installer at all
to install for testing purposes, use
pear upgrade --force package-PEAR-new-Downloader.xml
to uninstall, use
pear upgrade --force package-PEAR.xml
2003-11-30 05:39:02 +00:00
Greg Beaver
24409dc035
fix some bugs found in the unit test
2003-11-29 19:42:19 +00:00
Greg Beaver
e57b75eff4
fix Bug #324 pear -G gives Fatal Error (PHP-GTK not installed, but error is at engine level)
2003-11-29 16:33:54 +00:00
Martin Jansen
6ff584e2fb
* Fix potential warning
2003-11-17 09:15:28 +00:00
Greg Beaver
137adbb708
necessary refinement
2003-11-17 06:07:15 +00:00
Greg Beaver
82bd0915f5
fix bug #248 , --force does not work as expected
2003-11-17 05:56:50 +00:00
Greg Beaver
c05dfddda4
fix bug #249
2003-11-17 05:45:49 +00:00
Greg Beaver
997db6551a
checkExtension() was a complete disaster, can't believe it didn't cause any problems before.
2003-11-01 05:06:27 +00:00
Greg Beaver
48bca64444
fix bug found by unit test
2003-11-01 03:31:52 +00:00
Greg Beaver
6d0360204d
better error messages, fix potential problems in the future
2003-10-31 22:53:20 +00:00
Greg Beaver
5d0cc08805
fix warning
2003-10-31 22:52:33 +00:00
Greg Beaver
5754cfe68c
deleted code says it all
2003-10-31 22:22:17 +00:00
Greg Beaver
25e1f920d1
major bug - "not" dependency check would completely fail. Guess nobody ever tried it before :)
2003-10-31 17:22:15 +00:00
Greg Beaver
f3102f9d6b
was checking the wrong parameter for a v. - should be checking version
2003-10-31 17:01:39 +00:00
Greg Beaver
8c77fbe743
phpdoc fix
2003-10-31 16:50:56 +00:00
Greg Beaver
5c76e88d0e
fix #171 , --alldeps with a rel="eq" should install the required version, if possible
2003-10-31 04:52:00 +00:00
Greg Beaver
76d66203f4
add some error control to analyzeSourceCode() for really rare cases - invalid PHP
2003-10-31 01:17:47 +00:00
Stig Bakken
5b89e67334
* array_merge is more ticklish in php5
2003-10-27 06:52:14 +00:00
Pierre Joye
64e499aaef
- Fix RPC call without proxy (silence warnings¬ices)
...
nota bene: the proxy codes should be cleaned, one day ;)
2003-10-16 18:16:38 +00:00
Tomas V.V.Cox
32bf69ea7a
Fix Bug #23221 Pear installer - extension re-install segfault
2003-10-10 17:13:37 +00:00
Tomas V.V.Cox
0e128d52bc
Partial rewrite of dowload() method:
...
- Full error checking and reporting
- Avoid downloads as possible
- Made the "force" option work correctly
# Please report any problem with pear install/upgrade
2003-10-10 16:55:38 +00:00
Tomas V.V.Cox
5ab54854a1
avoid chdir() calls
...
remove duplicated validation checks
(fix bug #66 contributed by Roman)
2003-10-10 12:22:59 +00:00
Tomas V.V.Cox
164b593d23
better version checks (contributed by Roman)
2003-10-06 15:15:56 +00:00
Tomas V.V.Cox
f46b5641b7
use realpath instead of chdir
...
(Roman Neuhauser <neuhauser@bellavista.cz>)
2003-10-05 19:10:56 +00:00
Martin Jansen
dd66cd587f
* Fixing #64
2003-10-05 16:42:18 +00:00
Tomas V.V.Cox
0c9f669cc5
Better fix #61
2003-10-04 17:16:35 +00:00
Tomas V.V.Cox
7630f962f1
Fix : #61 [NEW]: error with pear install in pear 1.3b1
...
by outputting a full error message plus some help
2003-10-04 16:17:31 +00:00
Tomas V.V.Cox
349c8a5581
Bug #25413 Add local installed packages to list-all
...
(thanks to Christian DickMann)
2003-10-04 12:57:34 +00:00
Greg Beaver
77c0beb143
fix warning in rare case (file doesn't exist in package.xml)
2003-10-04 03:58:00 +00:00
Tomas V.V.Cox
8b6d6cdc6e
Give more info about release states in list-upgrades
2003-09-30 15:22:42 +00:00
Greg Beaver
e898d7c25a
better fix for #45 .
...
Now, it will install the newest version that is preferred_state or stabler.
to request a specific state, append -state like pear install Net_NNTP-beta
2003-09-30 02:56:42 +00:00
Greg Beaver
f688e33454
Bug #45 preferred_state works incorrectly
2003-09-29 17:36:00 +00:00
Greg Beaver
0c9a167bea
fixed #39 commands that need LOCK_SH fail as non-root
2003-09-28 05:07:27 +00:00
Greg Beaver
1433d789a5
add rollback for installed_as
2003-09-18 04:32:56 +00:00
Greg Beaver
103bab81a3
unit testing finds another bug :)
...
another case that would cause an endless loop in installed_as file transaction
2003-09-18 03:59:22 +00:00
Greg Beaver
c71d1bc43d
oops - params are reversed, my bad
2003-09-17 03:22:55 +00:00
Greg Beaver
1b47706fff
bug in chmod file transaction operation error message
...
bug in chmod file transaction test - was testing the perms to see if they were a writable file
2003-09-17 03:19:47 +00:00
Greg Beaver
15c04ee52a
phpdoc error
2003-09-17 03:13:56 +00:00
Greg Beaver
13bf53b658
correct typo "committed"
...
add error checking to commitFileTransaction()
2003-09-17 00:00:40 +00:00
Greg Beaver
a5b67714ae
Document addFileOperation()
...
Add basic test for invalid input, since it is a public method
2003-09-16 23:42:16 +00:00
Greg Beaver
f4aaa7c4f0
tweak Tomas's patch for
...
$ pear install Package-v.tgz
which should work for local files first before checking to see if it can be downloaded
2003-09-16 03:27:55 +00:00
Greg Beaver
4f7eb73e87
fix regexps for package detection and download - should be case-insensitive
2003-09-16 03:26:05 +00:00
Greg Beaver
c65683653c
fix invalid replacements - add tests for bad pear-config/package-info replacements
2003-09-16 03:17:08 +00:00
Greg Beaver
9850aae5f3
file transactions used - but startFileTransaction() was never used
...
inline docs for install() were out of date
2003-09-16 02:42:44 +00:00
Greg Beaver
7811c07e23
pear install net_socket will work now - before it would only work with pear install Net_socket
2003-09-15 13:11:57 +00:00
Greg Beaver
3008135b91
Now empty directories are removed on uninstall, so uninstallation is complete and correct
2003-09-15 05:10:51 +00:00
Greg Beaver
4245451ccd
mistaken include_once 'Remote.php' - not sure why it worked at all
2003-09-15 03:36:02 +00:00
Greg Beaver
e4b848d766
move registration of installed location to post-commit
2003-09-15 03:29:12 +00:00
Greg Beaver
8c3b78aa1c
found bug in _installFile() thanks to unit testing.
...
- if a bad md5sum was found, and --force wasn't specified, the temporary file was never deleted
2003-09-14 20:17:24 +00:00
Tomas V.V.Cox
7c9e926f10
"pear -v install" is now more usefull
2003-09-11 14:57:10 +00:00
Tomas V.V.Cox
7d96f7884e
Be more nice when downloading files
2003-09-11 14:47:03 +00:00
Tomas V.V.Cox
dfcd61cef7
Fix bug of download tries when a local file is given
...
to install
2003-09-11 13:36:59 +00:00
Greg Beaver
546663f7cd
phpdoc correction (kind of serious error :)
2003-09-10 01:40:48 +00:00
Greg Beaver
fba7705c99
make error code helpful if no releases of a package exist at all
2003-09-06 02:37:15 +00:00
Greg Beaver
639029bf25
make error code helpful if no releases of a package in preferred-state exist
2003-09-06 02:34:11 +00:00
Greg Beaver
e7eb8127a8
remove debug code
2003-09-04 22:30:07 +00:00
Greg Beaver
0ad60ebf3b
fix bug in --force - $options was never passed to _installFile.
...
add PHPDoc
2003-09-04 22:29:21 +00:00
Greg Beaver
8a70f5c01c
fix bug in --force on windows
2003-09-04 22:21:33 +00:00
Greg Beaver
92341f79be
if a package.xml is passed to InfoFrom*(), and the package version is invalid, current CVS causes a whole bunch of xml parser warnings and craps out without telling the user why. Now it exits gracefully.
2003-09-02 03:15:27 +00:00
Greg Beaver
e472325918
fixes rather obvious problem. Try this with CVS before:
...
pear install package-PEAR.xml
It attempts to split on the - as if PEAR.xml were a version and package were the package name. Now, it doesn't do that if the $pkgfile is a local filename.
2003-09-02 03:10:57 +00:00
Greg Beaver
ceff58fb5e
typo
2003-08-31 18:54:38 +00:00
Greg Beaver
1cc2e637b2
Tomas say:
...
"I think you'd have to let the user still install the package with
--force."
I say, OK :)
2003-08-31 16:41:27 +00:00
Greg Beaver
39105b9927
This patch should fix all unintended upgrading/installation of packages less stable than preferred state
2003-08-31 06:53:46 +00:00
Greg Beaver
0e6f284a62
fix #25322
2003-08-31 06:08:41 +00:00
Greg Beaver
b9c71c7754
CS fix
2003-08-30 15:59:50 +00:00
Greg Beaver
dce4268282
fix optional dependencies in Dependency.php, remove ugly hack in Installer, add note about Cox's cool addition to pear install, remove noise of who did what from package.xml, fix #25008
2003-08-29 20:50:36 +00:00
Tomas V.V.Cox
e18e3a6edd
This patch allows:
...
pear install DB-1.2 -> specific version
pear install DB-stable -> latest stable version
(stable, beta, alpha, ..)
pear install DB-1.2.tar -> download in tar format
Currently only "install" and "upgrade" support this
more will come shortly.
2003-08-29 18:23:31 +00:00
Tomas V.V.Cox
26c90cc965
snapshot < devel (betterStates())
2003-08-29 14:02:20 +00:00
Greg Beaver
095efa09af
* added --alldeps --onlyreqdeps options for pear install/upgrade.
...
* added automatic dependency sorting, so the order of packages on command-line is unimportant for both install/uninstall
* added one more spaces in paths fix that was missed in PEAR_Common
2003-08-28 03:42:21 +00:00
Greg Beaver
3c87b23aa1
adding betterStates() for usage in automatic dependency resolution
2003-08-27 19:27:45 +00:00
Greg Beaver
d05514c794
reverting accidental commit of my fix for #25008 - we'll let Tomas review the patch I submitted (oops). The other stuff was good.
2003-08-17 18:12:43 +00:00
Greg Beaver
d1511aca30
fixed #25117 , updated package-PEAR.xml to the current release level
2003-08-17 18:01:39 +00:00
Derick Rethans
b5cb1cbadb
MFB: - Fix library path problems
2003-08-14 20:14:34 +00:00
Greg Beaver
baba5432c9
fix uninstall for optional dependencies, bug #25080
2003-08-13 21:16:31 +00:00
Greg Beaver
f7a70ccc13
fix optional dependencies in reading, validating, and writing of package.xml
2003-08-13 21:12:15 +00:00
Pierre Joye
827e482224
- Fix download with uncompress option
...
Nota Bene, we should think to use the same name for pearweb and pear cmd
2003-08-05 23:17:40 +00:00
Tomas V.V.Cox
b1ece0fb89
Avoid notice in bundle
2003-08-05 15:36:07 +00:00
Tomas V.V.Cox
dececbdb4c
Other fix to ws in path names fix
2003-08-05 15:35:17 +00:00
Tomas V.V.Cox
6c93b30165
Pass raw data to frontend (Christian Dickmann)
2003-08-05 14:38:29 +00:00
Tomas V.V.Cox
d3600ea63f
Better install report for C extensions
2003-08-05 14:31:15 +00:00
Tomas V.V.Cox
38ad5ff8d7
Better error handling on invalid .tgz packages
2003-08-05 13:51:33 +00:00