Commit Graph

1122 Commits

Author SHA1 Message Date
Xinchen Hui
c0d060f5c0 Bump year 2014-01-03 11:04:26 +08:00
Dmitry Stogov
03a37de9b3 Improved empty string handling. Now ZE uses an interned string instead of allocation new empty string each time. (Some extensions might need to be fixed using str_efree() instead of efree() to support interned strings). 2013-12-26 14:47:13 +04:00
Xinchen Hui
5eb8d9d700 Merge branch 'PHP-5.6' of https://git.php.net/push/php-src into PHP-5.6 2013-12-15 16:55:29 +08:00
Eric Stenson
330168a247 Fix tests expecting specific resource IDs
When Wincache or APC are installed, the resource IDs are not the same.
This is because Wincache takes a few resource objects for itself.  As a
result, these tests become false positives.

On Windows boxes, the microtime precision is not granular enough
to reliably register a difference if two calls to uniqid() are made
concurrently.  This is a fix to the uniqid() test to avoid the false
positive when run on Windows machines.  Also, added a test to exercise
the 'more_entropy' variant of uniqid().
2013-12-15 16:51:21 +08:00
Yasuo Ohgaki
09ed50fa44 Remove ini dependency in test 2013-08-30 11:46:16 +09:00
Christopher Jones
d9bfe06194 Merge branch 'PHP-5.5'
* PHP-5.5:
  Reduce compilation noise during normal compilation:     php-5.5/ext/session/session.c:836: warning: unused variable ‘struc’     php-5.5/ext/session/session.c:836: warning: unused variable ‘num_key’     php-5.5/ext/session/session.c:836: warning: unused variable ‘key_length’     php-5.5/ext/session/session.c:836: warning: unused variable ‘key’     php-5.5/ext/session/session.c:835: warning: unused variable ‘key_type’     php-5.5/ext/session/session.c:834: warning: unused variable ‘_ht’     php-5.5/ext/session/session.c:857: warning: unused variable ‘has_value’     php-5.5/ext/session/session.c:856: warning: unused variable ‘namelen’     php-5.5/ext/session/session.c:853: warning: unused variable ‘name’     php-5.5/ext/session/session.c:852: warning: unused variable ‘p’
2013-08-21 10:35:07 -07:00
Christopher Jones
d85827fb7f Reduce compilation noise during normal compilation:
php-5.5/ext/session/session.c:836: warning: unused variable ‘struc’
    php-5.5/ext/session/session.c:836: warning: unused variable ‘num_key’
    php-5.5/ext/session/session.c:836: warning: unused variable ‘key_length’
    php-5.5/ext/session/session.c:836: warning: unused variable ‘key’
    php-5.5/ext/session/session.c:835: warning: unused variable ‘key_type’
    php-5.5/ext/session/session.c:834: warning: unused variable ‘_ht’
    php-5.5/ext/session/session.c:857: warning: unused variable ‘has_value’
    php-5.5/ext/session/session.c:856: warning: unused variable ‘namelen’
    php-5.5/ext/session/session.c:853: warning: unused variable ‘name’
    php-5.5/ext/session/session.c:852: warning: unused variable ‘p’

    php-5.5/ext/session/mod_user.c:191: warning: unused variable ‘ret’
2013-08-21 10:34:09 -07:00
Yasuo Ohgaki
aaf95aa1b6 Merge branch 'PHP-5.5'
* PHP-5.5:
  Add php_serialize session.serialize_handler. This patch closes
2013-08-21 11:06:11 +09:00
Yasuo Ohgaki
c51f77fe83 Add php_serialize session.serialize_handler. This patch closes
Request #25630
  Request #43980
  Request #54383
  Bug #65359

and many others similar to these that are closed as "wont fix" or
"not a bug".

Current serializers have limitations due to register_globals support
that are no longer supported. Changing existing serializer may cause
compatibility issue. Therefore, new handler is needed to remove
needless limitations.

php_serialize does not have special characters and allow numerical
index in $_SESSION. $_SESSION can be used as ordinary array.
2013-08-21 10:51:51 +09:00
Yasuo Ohgaki
d2a99a7c31 Fixed Bug #65475 2013-08-21 08:12:11 +09:00
Yasuo Ohgaki
1641158644 Fixed Bug #65475 2013-08-21 08:11:59 +09:00
Christopher Jones
3c166c4758 Merge branch 'PHP-5.5'
* PHP-5.5:
  Reduce (some) compile noise of 'unused variable' and 'may be used uninitialized' warnings.

Conflicts:
	ext/gmp/gmp.c
2013-08-14 20:47:00 -07:00
Christopher Jones
39612afc72 Merge branch 'PHP-5.4' into PHP-5.5
* PHP-5.4:
  Reduce (some) compile noise of 'unused variable' and 'may be used uninitialized' warnings.

Conflicts:
	ext/dba/libinifile/inifile.c
2013-08-14 20:43:25 -07:00
Christopher Jones
9ad97cd489 Reduce (some) compile noise of 'unused variable' and 'may be used uninitialized' warnings. 2013-08-14 20:36:50 -07:00
Yasuo Ohgaki
0959475e11 Merge branch 'PHP-5.5'
* PHP-5.5:
  Fixed possible buffer overflow under Windows. Note: Not a security fix.
2013-08-11 06:44:01 +09:00
Yasuo Ohgaki
2df95b1354 Merge branch 'PHP-5.4' into PHP-5.5
* PHP-5.4:
  Fixed possible buffer overflow under Windows. Note: Not a security fix.
2013-08-11 06:43:37 +09:00
Yasuo Ohgaki
0ad81ac18a Fixed possible buffer overflow under Windows. Note: Not a security fix. 2013-08-11 06:43:01 +09:00
Yasuo Ohgaki
771b06f585 Merge branch 'PHP-5.5'
* PHP-5.5:
  Fixed Bug #62015 Changed session.auto_start to PHP_INI_PERDIR. It is simply wrong and never worked if the value is changed at runtime
2013-08-10 18:30:05 +09:00
Yasuo Ohgaki
9d95a1a7d1 Merge branch 'PHP-5.4' into PHP-5.5
* PHP-5.4:
  Fixed Bug #62015 Changed session.auto_start to PHP_INI_PERDIR. It is simply wrong and never worked if the value is changed at runtime
2013-08-10 18:29:29 +09:00
Yasuo Ohgaki
e9b128c1bf Fixed Bug #62015 Changed session.auto_start to PHP_INI_PERDIR. It is simply wrong and never worked if the value is changed at runtime 2013-08-10 18:29:13 +09:00
Yasuo Ohgaki
6941ce3583 Implemented Request #20421 (session_abort() and session_reset() function 2013-08-10 16:57:56 +09:00
Yasuo Ohgaki
54a42f0d0c Implemented Request #11100 (session_gc() function). 2013-08-10 15:20:24 +09:00
Yasuo Ohgaki
f2b5725115 Remove compile warning of commit 554021d21e 2013-08-10 14:35:30 +09:00
Yasuo Ohgaki
554021d21e Implemented Bug #17860 Suggestion: auto detect whether session changed 2013-08-10 13:56:32 +09:00
Yasuo Ohgaki
678ec30655 Implement Bug #54649 Create session_serializer_name() 2013-08-10 09:26:10 +09:00
Michael Wallner
7c3afd31f9 fix test 2013-08-09 13:30:29 +02:00
Yasuo Ohgaki
b6b425d2cf Fixed Bug #65315 session.hash_function silently fallback to default md5 2013-08-09 18:05:24 +09:00
Stanislav Malyshev
b80d73ce15 fix crash, enable session_id and fix test 2013-08-04 17:43:20 -07:00
Yasuo Ohgaki
82b0e8be99 Strict session. Detect session id collision 2013-08-04 16:36:53 -07:00
Yasuo Ohgaki
25e8fcc88f Strict session 2013-08-04 16:36:45 -07:00
Stanislav Malyshev
c793a65690 Merge branch 'PHP-5.4' into PHP-5.5
* PHP-5.4:
  non living code related typo fixes

Conflicts:
	Zend/zend_compile.c
2013-08-04 16:06:24 -07:00
Veres Lajos
8d86597d73 non living code related typo fixes 2013-08-04 16:05:36 -07:00
Veres Lajos
4749457a49 HASH_KEY_NON_EXISTANT fix 2013-07-21 20:09:53 -07:00
Arpad Ray
94ab37f06a Merge branch 'PHP-5.4' into PHP-5.5
* PHP-5.4:
  Fixed bug #50308 - session id not appended properly for empty anchor tags
2013-07-17 16:19:53 +01:00
Arpad Ray
e6ae977082 Fixed bug #50308 - session id not appended properly for empty anchor tags
The issue was actually because a lack of space before a "/" marking the tag
as empty. This was being swallowed in the rule for unquoted values. Fixed
by making that rule exclude quotes (as per spec anyway).
2013-07-17 16:07:26 +01:00
Arpad Ray
0d3d739bf7 Merge branch 'PHP-5.4' into PHP-5.5
* PHP-5.4:
  Fix bug #62129 - rfc1867 crashes php even though turned off
2013-07-17 11:05:23 +01:00
Arpad Ray
ba3234888d Fix bug #62129 - rfc1867 crashes php even though turned off
Patch by gxd305 at gmail dot com
2013-07-17 11:02:48 +01:00
Anatol Belski
54b740a7e1 Merge branch 'PHP-5.4' into PHP-5.5
* PHP-5.4:
  Fixed typo ensuring header str is \0 terminated
2013-07-16 00:15:29 +02:00
Anatol Belski
bcb39d9c6a Fixed typo ensuring header str is \0 terminated
This was obviously intended to send an empty header if
php_gmtime_r() fails. Currently it could send garbage.
2013-07-16 00:14:05 +02:00
Anatol Belski
904c5d7ba8 kick unused var 2013-07-15 17:23:16 +02:00
Veres Lajos
e9a95d78ef typo fixes 2013-07-15 00:23:03 -07:00
Veres Lajos
72085b0e5f typo fixes 2013-07-15 00:18:57 -07:00
Anatol Belski
1968fac697 Merge branch 'PHP-5.4' into PHP-5.5
* PHP-5.4:
  Fixed mysql tests parsing phpinfo()
  Update NEWS
  Fixed bug #35703: when session_name("123") consist only digits, should warning
  Fixed bug #49175: mod_files.sh does not support hash bits
2013-07-02 08:24:37 +02:00
Yasuo Ohgaki
87dda666c7 Fixed bug #35703: when session_name("123") consist only digits, should warning 2013-06-29 11:35:55 +09:00
Yasuo Ohgaki
ef63334fa6 Fixed bug #49175: mod_files.sh does not support hash bits 2013-06-29 11:35:55 +09:00
Yasuo Ohgaki
27b01cfcd7 Fixed bug #49175: mod_files.sh does not support hash bits 2013-06-29 09:09:23 +09:00
Arpad Ray
70ae67b5da Merge branch 'PHP-5.4' into PHP-5.5
* PHP-5.4:
  Fix bug #62535 - $_SESSION[$key]["cancel_upload"] doesn't work as documented
2013-06-27 19:12:46 +01:00
Arpad Ray
ce8c023910 Fix bug #62535 - $_SESSION[$key]["cancel_upload"] doesn't work as documented
When uploading multiple files, the array in the session where the progress
data is stored (and cancel_upload key is set) was overwritten whenever the
progress data was updated, so pending uploads would proceed anyway.
2013-06-27 19:05:23 +01:00
Arpad Ray
1e836cdd64 BC fix for PR 109 merge - create_sid() method in SessionHandler
Creates a new SessionIdInterface and moves create_sid() into it, so existing
handlers implementing SessionHandlerInterface don't require create_sid().
SessionHandler still includes the method so the default mod can be called, but
now implements both interfaces.

Also added several more tests for this feature.
2013-06-27 12:33:56 +01:00
Arpad Ray
b66c14b0c8 Merge PR 109 - Add create_sid to session_set_save_handler and SessionHandler
Allows user session handlers to create session IDs by adding an optional
7th argument to session_set_save_handler() and a create_sid() method
to SessionHandler.
2013-06-27 12:29:44 +01:00
Felipe Pena
ff292d619c Merge branch 'PHP-5.4' into PHP-5.5
* PHP-5.4:
  - Fixed bug #61594 (ext/session/mod_mm.c: missing free of ps_mm_instance) patch by: jlawall at hotmail dot com
  - BFN
2013-06-24 16:49:22 -03:00
Felipe Pena
982c11573d - Fixed bug #61594 (ext/session/mod_mm.c: missing free of ps_mm_instance) patch by: jlawall at hotmail dot com 2013-06-24 16:49:15 -03:00
Dmitry Stogov
731b4a3fa4 Merge branch 'PHP-5.4' into PHP-5.5
* PHP-5.4:
  Callback has to be restored in MSHUTDOWN
2013-06-10 12:34:08 +04:00
Dmitry Stogov
336a8e1943 Callback has to be restored in MSHUTDOWN 2013-06-10 12:32:53 +04:00
Stanislav Malyshev
748b37654d complete zts fix 2013-01-29 12:12:34 -08:00
Lars Strojny
ec2fff80e7 Bug #23955: allow specifiy max age for setcookie() 2013-01-06 03:22:44 +01:00
Xinchen Hui
a666285bc2 Happy New Year 2013-01-01 16:37:09 +08:00
Xinchen Hui
0a7395e009 Happy New Year 2013-01-01 16:28:54 +08:00
Xinchen Hui
2f7f57a407 Merge branch 'PHP-5.3' into PHP-5.4 2012-12-17 12:57:37 +08:00
Xinchen Hui
d2cc097049 Fix failed test 2012-12-17 12:56:55 +08:00
Rasmus Lerdorf
538d8338c0 Merge branch 'PHP-5.3' into PHP-5.4 2012-12-13 16:15:06 -08:00
Rasmus Lerdorf
eecdb4c254 Fix broken test
This was missing a %s for the path here
2012-12-13 16:13:37 -08:00
Arpad Ray
6566ea6173 Fix #63379 - Don't reset mod_user_is_open in destroy
The parent handler is still open so the reset here was in error.
2012-12-13 23:51:43 +00:00
Xinchen Hui
1b9e0de2cc Remove executable permission on inc 2012-10-10 10:44:34 +08:00
Xinchen Hui
610c7fbe7b Remove executable permission on phpt 2012-10-10 10:27:49 +08:00
Xinchen Hui
69a4301f6c Merge branch 'PHP-5.3' into PHP-5.4 2012-10-10 10:45:07 +08:00
Xinchen Hui
e081c55fb5 Merge branch 'PHP-5.3' into PHP-5.4 2012-10-10 10:31:31 +08:00
Xinchen Hui
1a527397cc better fix & this test pass now 2012-08-15 01:25:31 +08:00
Xinchen Hui
a5a409ebff Fixed bug (segfault due to retval is not initialized) 2012-08-15 00:44:47 +08:00
Xinchen Hui
9be55beb91 Attempt to fix segfault due to retval is not initialized 2012-08-15 00:31:57 +08:00
Xinchen Hui
b2fe342d04 improve the fix 2012-08-15 00:25:06 +08:00
Xinchen Hui
da3660a4c4 Fixed bug (segfault due to PS(mod_user_implemented) not be reseted when closing handler call exit) 2012-08-15 00:15:34 +08:00
Leigh
6809c388b5 Tests, fixes and optimisations
* Amended existing tests to cater for new functionality.
* Implemented fixes and optimisations recommended by NikiC
* Added create_sid to the registered interface. This was breaking
tests. It also now breaks BC for people implementing the interface
directly instead of extending the class.
2012-06-26 14:57:10 +01:00
Johannes Schlüter
5e23a047ac Merge branch 'PHP-5.3' into PHP-5.4
* PHP-5.3:
  Remove extra ;
2012-06-22 17:33:22 +02:00
Johannes Schlüter
a62d4e2c43 Remove extra ; 2012-06-22 17:32:46 +02:00
Leigh
59cf3a2404 Add create_sid to session_set_save_handler and SessionHandler
A lot of code already existed to allow a custom create_sid handler, but
lacked a specific implementation.

Therefore I have added a 7th (optional) argument
session_set_save_handler, to allow a user function to be supplied for
session id generation.

If a create_sid function is not supplied, the default function is
called in its absence to preserve backwards compatibility.

Likewise create_sid only added to SessionHandler class, and not the
interface to maintain backwards compatibility. If the result is not
overridden, the default is called.
2012-06-15 15:06:47 +01:00
Anatoliy Belsky
36836f147c Merge branch 'PHP-5.3' into PHP-5.4
* PHP-5.3:
  Fix bug 61870 ext\session\tests\bug42596.phpt fails
2012-04-30 12:10:43 +02:00
Anatoliy Belsky
680685127f Fix bug 61870 ext\session\tests\bug42596.phpt fails 2012-04-30 12:06:28 +02:00
Anatoliy Belsky
3dbe48762f Fix bug 61786 Failing tests in ext\session\tests\* 2012-04-26 15:39:45 +02:00
Xinchen Hui
ed09d26f94 change the bug summary 2012-04-16 19:23:12 +08:00
Xinchen Hui
3b42f184cd Fixed bug #61728 (php-fpm SIGSEGV running friendica on nginx) 2012-04-15 01:16:34 +08:00
Ilia Alshanetsky
ef61504b35 Fixed bug #60634 (Segmentation fault when trying to die() in SessionHandler::write()) 2012-03-08 03:31:46 +00:00
Ilia Alshanetsky
f005f36cd6 Fixed bug #60634 (Segmentation fault when trying to die() in SessionHandler::write()) 2012-03-08 03:31:46 +00:00
Felipe Pena
2cb820275d - Fixed bug #60860 (session.save_handler=user without defined function core dumps) 2012-01-28 21:02:09 +00:00
Felipe Pena
f78c9a9f4e - Fixed bug #60860 (session.save_handler=user without defined function core dumps) 2012-01-28 21:02:09 +00:00
Arpad Ray
e6ca31057e add more tests for #60634 (stems from #21306) and xfail them all for the moment 2012-01-04 11:44:05 +00:00
Arpad Ray
23ba6bb7fe add more tests for #60634 (stems from #21306) and xfail them all for the moment 2012-01-04 11:44:05 +00:00
Arpad Ray
08eb16f015 fix return values of inherited session handler to match user handlers - #60640 2012-01-04 01:31:30 +00:00
Arpad Ray
7486849b56 add SessionHandlerInterface for session_set_save_handler() - #60551 2012-01-04 01:16:45 +00:00
Arpad Ray
062b67ed06 add test for #60634 2012-01-03 21:47:16 +00:00
Arpad Ray
5f948f63ed add test for #60634 2012-01-03 21:47:16 +00:00
Felipe Pena
e4ca0ed09f - Year++ 2012-01-01 13:15:04 +00:00
Felipe Pena
4e19825281 - Year++ 2012-01-01 13:15:04 +00:00
Xinchen Hui
ae05ae7e92 C++ style comment 2011-11-21 05:57:45 +00:00
Felipe Pena
0c5bb1702b - Fixed bug #60339 (valgrind reports LEAK --with-mm)
patch by: yohgaki at ohgaki dot net
2011-11-19 18:50:49 +00:00
Felipe Pena
d3b20b4058 - Fixed bug #60339 (valgrind reports LEAK --with-mm)
patch by: yohgaki at ohgaki dot net
2011-11-19 18:50:49 +00:00
Arpad Ray
d39dbdee24 Fix hash key length in register/remove_user_shutdown_function 2011-11-11 14:42:18 +00:00
Arpad Ray
11d6fcdba0 fix calling user close func when it isn't open 2011-11-02 16:53:22 +00:00
Stanislav Malyshev
63b934b9c7 revert change, doesn't work 2011-10-16 02:43:50 +00:00
Stanislav Malyshev
1551cc62db fix openbasedir in test 2011-10-15 23:52:40 +00:00
Ferenc Kovacs
9c2f27a380 fix #49599, the eol-style is important here, as this is a regression test for #36459 2011-09-26 23:28:24 +00:00
Ferenc Kovacs
b2f1ae9673 fix #49599, the eol-style is important here, as this is a regression test for #36459 2011-09-26 23:28:24 +00:00
Christopher Jones
5ad03cd41a MFH to fix PHP_5_3 diffs shown on http://qa.php.net/reports/?version=5.3.9-dev 2011-09-26 20:31:11 +00:00
Arpad Ray
aaa86e2287 fix default session handler error message 2011-09-14 15:30:30 +00:00
Xinchen Hui
7e5307cc79 Fix tests 2011-09-14 06:48:26 +00:00
Xinchen Hui
5412b2885d Add test for bug #55688 2011-09-14 05:02:50 +00:00
Xinchen Hui
ed4251860a Fix bug #55688 (Crash when calling SessionHandler::gc())
Need arpad to review this change
2011-09-14 04:10:45 +00:00
Felipe Pena
b034032ae2 - Fixed memory leak when calling SessionHandler::open() several times 2011-09-14 01:45:57 +00:00
Arpad Ray
739151d388 fix session oo tests for windows 2011-09-14 01:16:19 +00:00
Arpad Ray
f8a943cc19 fix zts break in r316688 2011-09-13 23:07:08 +00:00
Arpad Ray
47cfae87eb Implement object-oriented session handlers (https://wiki.php.net/rfc/session-oo) 2011-09-13 22:28:15 +00:00
Ferenc Kovacs
6f39604ff3 I don't see why would be this a win only test. it works for me on linux, checked the history, find no explanation. 2011-09-13 21:06:06 +00:00
Ferenc Kovacs
6e998b4d0f I don't see why would be this a win only test. it works for me on linux, checked the history, find no explanation. 2011-09-13 21:06:06 +00:00
Ferenc Kovacs
e82139d2e0 fixing the tests, added the error_log= to the --INI-- so it should also pass for Stas 2011-09-13 19:56:42 +00:00
Dmitry Stogov
4a25a7740d Fixed ZE specific compile warnings (Bug #55629) 2011-09-13 13:29:35 +00:00
Stanislav Malyshev
334636fefb revert bad test change 2011-09-10 05:29:29 +00:00
Ferenc Kovacs
adb25ed261 passing an invalid session.upload_progress.freq always generates an additional startup error 2011-09-04 15:02:08 +00:00
Ferenc Kovacs
492daa5fa7 passing an invalid session.upload_progress.freq always generates an additional startup error 2011-09-04 14:28:52 +00:00
Arpad Ray
c8de01fef8 Expose session status via new function, session_status (Req #52982) 2011-08-29 21:29:26 +00:00
Hannes Magnusson
e481f05470 fixed bug #55267 - session_regenerate_id fails after header sent even if session.use_cookies = 0 2011-08-29 21:20:41 +00:00
Hannes Magnusson
7746cf83d9 fixed bug #55267 - session_regenerate_id fails after header sent even if session.use_cookies = 0 2011-08-29 21:20:41 +00:00
Felipe Pena
997f323e3a - Added ZEND_MOD_END macro to use in the end of zend_module_dep[] 2011-08-06 14:47:44 +00:00
Felipe Pena
707a8f70b8 - Added ZEND_MOD_END macro to use in the end of zend_module_dep[] 2011-08-06 14:47:44 +00:00
Stanislav Malyshev
1c83f5e04c fix tests 2011-08-01 03:42:02 +00:00
Felipe Pena
23e438594d - Make usage of new PHP_FE_END macro 2011-07-25 11:42:53 +00:00
Felipe Pena
4b30846b50 - Make usage of new PHP_FE_END macro 2011-07-25 11:35:02 +00:00
Pierre Joye
1717764476 - install extra headers 2011-06-16 01:21:01 +00:00
Pierre Joye
b498b5dfe5 - install extra headers 2011-06-16 01:21:01 +00:00
Shein Alexey
ae2e75a657 Fixed test. 2011-06-09 13:09:25 +00:00
Shein Alexey
4cd96965fb Removed tests checking old/removed functionality (session_register/session_unregister/session_is_registered/register_globals) 2011-06-09 08:54:47 +00:00
Shein Alexey
21fb2a42cc Changed session.save_path to /tmp to make test run. 2011-06-09 08:24:12 +00:00
Shein Alexey
b99e1ba2d8 Changed session.save_path to /tmp to make test run. 2011-06-09 08:24:12 +00:00
Shein Alexey
3b37e152c3 Skip reason is now printed if session.save_path is not writable. 2011-06-09 08:18:49 +00:00
Shein Alexey
060ceea06e Skip reason is now printed if session.save_path is not writable. 2011-06-09 08:18:49 +00:00
Shein Alexey
25adf56921 Fixed session test breakage due to serialize precision issue. 2011-06-09 07:44:10 +00:00
Shein Alexey
efb6757e16 Fixed session test breakage due to serialize precision issue. 2011-06-09 07:44:10 +00:00
Rasmus Lerdorf
75ec1fedc7 Add php_ignore_value() macro to suppress unused return value warnings
from gcc. There are times when we really don't care about the return
value and this will cleanly tell gcc.
2011-05-16 16:58:02 +00:00
Antony Dovgal
8f8a54ab37 fix tests 2011-05-04 08:44:14 +00:00
Antony Dovgal
bb2ccc96d3 fix tests 2011-05-04 08:44:14 +00:00
Pierre Joye
783285e62a - local redeclaration 2011-01-23 10:02:06 +00:00
Pierre Joye
88a1f3988c - local redeclaration 2011-01-23 10:02:06 +00:00
Felipe Pena
927bf09c29 - Year++ 2011-01-01 02:19:59 +00:00
Felipe Pena
0203cc3d44 - Year++ 2011-01-01 02:17:06 +00:00
Pierre Joye
aea6771d19 - add phpize support for windows, need a nmake install for now (nmake devel-pkg version is coming), works exactly the same as on unix, or should :) 2010-12-13 18:43:10 +00:00
Pierre Joye
4ee6b4dfbb -ws 2010-12-13 18:07:08 +00:00
Pierre Joye
a7ffa09e18 - add PHP_INSTALL_HEADERS to all parts (core&exts) exposing headers, generate the install-headers cmd 2010-12-11 22:18:10 +00:00
Felipe Pena
f11535e2ee - Fixed config.m4 to complete the fix for bug #53141 (thanks Johannes) 2010-11-02 20:51:02 +00:00
Felipe Pena
7b4cbadfce - Fixed config.m4 to complete the fix for bug #53141 (thanks Johannes) 2010-11-02 20:51:02 +00:00
Felipe Pena
477b8a6664 - Fixed bug #53141 (autoload misbehaves if called from closing session)
patch by: ladislav at marek dot su
2010-11-02 18:34:56 +00:00
Felipe Pena
7ded7577b2 - Fixed bug #53141 (autoload misbehaves if called from closing session)
patch by: ladislav at marek dot su
2010-11-02 18:34:56 +00:00
Ilia Alshanetsky
a12d2bf747 Fixed a compiler warning 2010-08-27 19:43:08 +00:00
Ilia Alshanetsky
9cad594085 Fixed a compiler warning 2010-08-27 19:43:08 +00:00
Kalle Sommer Nielsen
a448b6a72b MFB53: Changed deprecated ini options on startup from E_WARNING to E_DEPRECATED (Fixes #52570)
# Some of the updated tests were to make them sync with 5.3 although they don't run on trunk anymore
2010-08-11 21:41:30 +00:00
Kalle Sommer Nielsen
8deefa8780 Changed deprecated ini options on startup from E_WARNING to E_DEPRECATED (Fixes #52570)
# Trunk patch will follow shortly
2010-08-11 21:12:18 +00:00
Dmitry Stogov
f0c8366a9e - use interned strings for auto globals
- $GLOBALS became a JIT autoglobal, so it's initialized only if used (this may affect opcode caches)
2010-07-08 14:05:11 +00:00
Pierre Joye
9e5313fdca - [DOC] MFH: add session.entropy* support to windows 2010-06-08 22:30:16 +00:00
Pierre Joye
38d334f851 - [DOC] MFH: add session.entropy* support to windows 2010-06-08 22:30:16 +00:00
Pierre Joye
32447e4902 - restore previous setting 2010-06-08 22:27:14 +00:00
Pierre Joye
f8b17007e0 - [DOC] add session.entropy* support to windows 2010-06-08 13:46:19 +00:00
Pierre Joye
bfe51d3895 - [DOC] add session.entropy* support to windows 2010-06-08 13:46:19 +00:00
Pierre Joye
24ef65019f - silent warning 2010-06-02 19:20:04 +00:00
Pierre Joye
2fd5a6a188 - silent warning 2010-06-02 19:20:04 +00:00
Michael Wallner
11d24c1593 * implement new output API, fixing some bugs and implementing some feature
requests--let's see what I can dig out of the bugtracker for NEWS--
  and while crossing the road:
   * implemented new zlib API
   * fixed up ext/tidy (what was "s&" in zend_parse_parameters() supposed to do?)

Thanks to Jani and Felipe for pioneering.
2010-05-31 10:29:43 +00:00
Arnaud Le Blanc
4f3b619625 - code cleanups
- cleanup progress data from session vars as soon as all
   post data has been readden (upload_progress.cleanup
   ini setting allows to disable this)
2010-05-11 16:39:07 +00:00
Arnaud Le Blanc
6f3cea3870 Added session upload progress tests 2010-05-10 16:10:09 +00:00
Arnaud Le Blanc
da9448f3fd Added upload progress feedback in session data as describied
in RFC : http://wiki.php.net/rfc/session_upload_progress
2010-05-10 16:09:00 +00:00
Arnaud Le Blanc
d5a646480d Fix tests 2010-05-10 15:53:54 +00:00
Kalle Sommer Nielsen
dd8e59da8f Removed safe_mode
* Removed ini options, safe_mode*
 * Removed --enable-safe-mode --with-exec-dir configure options on Unix
 * Updated extensions, SAPI's and core
 * php_get_current_user() is now declared in main.c, thrus no need to include safe_mode.h anymore
2010-04-26 23:53:30 +00:00
Ilia Alshanetsky
64f372fae2 Fixed handling of session variable serialization on certain prefix characters. Reported by Stefan Esser 2010-04-26 18:35:54 +00:00
Ilia Alshanetsky
3c78ad763e Fixed handling of session variable serialization on certain prefix characters. Reported by Stefan Esser 2010-04-26 18:35:54 +00:00
Kalle Sommer Nielsen
e73a794105 Removed the session 4.2 bug compatibility mode 2010-04-22 01:07:48 +00:00
Kalle Sommer Nielsen
b8ada243fe Drop php_register_var(), Thanks Felipe 2010-04-21 23:16:56 +00:00
Kalle Sommer Nielsen
3f29144348 Removed session_is_registered(), session_register() and session_unregister().
-- They are no longer needed without register_globals
2010-04-21 23:03:16 +00:00
Kalle Sommer Nielsen
febee11285 Removed register_globals 2010-04-21 01:27:22 +00:00
Kalle Sommer Nielsen
a5304b138f Removed register_long_arrays ini option (and $HTTP_SESSION_VARS from ext/session) 2010-04-15 16:36:08 +00:00
Rasmus Lerdorf
9692a3619c Set session.entropy_file to /dev/urandom or /dev/arandom by
default if present at compile-time.  Addresses part of bug #51436
2010-03-31 18:03:17 +00:00
Ilia Alshanetsky
8a9364080b Added test for bug #51338 2010-03-23 11:51:38 +00:00
Ilia Alshanetsky
995d15ebcc Fixed bug #51338 (URL-Rewriter is still enabled if use_only_cookies is on). 2010-03-22 12:16:45 +00:00
Jani Taskinen
af49e58f51 - Reverted r296062 and r296065 2010-03-12 10:28:59 +00:00
Jani Taskinen
06f072cb5e MFH: Improved / fixed output buffering (Michael Wallner) 2010-03-11 10:24:29 +00:00
Ilia Alshanetsky
dff4e7fda1 Fixed a possible open_basedir/safe_mode bypass in session extension identified by Grzegorz Stachowiak. 2010-01-31 18:06:29 +00:00
Sebastian Bergmann
9ba1e81665 sed -i "s#1997-2009#1997-2010#g" **/*.c **/*.h **/*.php 2010-01-03 09:23:27 +00:00
Rasmus Lerdorf
e9b1ab57a4 Along with the valid char set, also add a length check to the
session id here to avoid a lower-level error on the open() 
later on in case we exceed MAX_PATH.  The lower level open()
error includes the session dir path in it, so this is a very
low-priority security fix.  People should not be running
production systems with display_errors turned on.
2009-12-26 23:38:25 +00:00
Dmitry Stogov
5ab649e65f Fixed compilation 2009-12-04 07:11:37 +00:00
Stanislav Malyshev
3e6ac4fb6b protect http_session_vars from interrupt corruption
improve save_path check
2009-12-04 01:21:32 +00:00
Guenter Knauf
824692fab8 removed now obsolete NetWare hack since I fixed this
with Novell some longer time ago in their SDK header.
2009-11-03 21:21:34 +00:00
Dmitry Stogov
7bfe056174 Fixed tests 2009-09-21 09:52:19 +00:00
Antony Dovgal
421b6e0f2c configure dependency has to be optional as well 2009-07-28 08:59:08 +00:00
Antony Dovgal
75fc702162 fix segfault in session/tests/031.phpt by adding optional extension
dependency (php_hash_hashtable has to be initialized when setting
session.hash_function)
2009-07-28 08:54:23 +00:00
Gwynne Raskind
2673b9be38 MFH: fix crash when session hash function generated long hashes with hash_bits_per_character larger than 4 2009-07-17 14:21:59 +00:00
Jani Taskinen
694566d6c4 fix test 2009-05-26 10:12:16 +00:00
Jani Taskinen
9ece649f7c MFH: ws + sync 2009-05-18 16:10:09 +00:00
Felipe Pena
d64db73483 - Fixed tests 2009-05-05 18:19:16 +00:00
Kalle Sommer Nielsen
5a6d3cc42b Added E_DEPRECATED startup notice (5.3 only) 2009-05-04 21:18:22 +00:00
Hannes Magnusson
e9c1d924b8 MFH: Add test for bug#42596 2009-04-06 12:12:37 +00:00
Hannes Magnusson
b8bc0f24b3 MFH: Fix segfault on invalid session.save_path 2009-04-06 11:48:49 +00:00
Hannes Magnusson
33aa4ac568 MFH: fix folding 2009-04-06 11:45:25 +00:00
Sebastian Bergmann
08659c2dcd MFH: Bump copyright year, 3 of 3. 2008-12-31 11:15:49 +00:00
Andrei Zmievski
cae97c3b8e MFH 2008-12-30 19:37:35 +00:00
Scott MacVicar
2ea6780873 MFH Fix bug #35975 - Session cookie expires date format isn't the most compatible. Sync to that of setcookie(). 2008-12-11 01:21:35 +00:00
Hannes Magnusson
76a17847c1 Deprecate session_register(), session_unregister() and
session_is_registered() (removed in HEAD)
2008-12-09 14:03:58 +00:00
Ant Phillips
ec1ee12281 Fix broken tests (thanks to Johannes for spotting these). 2008-12-02 10:20:56 +00:00
Ant Phillips
45e14cea18 Latest and greatest versions of these session tests - checked on 5.3 snap on Windows, Linux and Linux 64 bit. 2008-11-27 13:50:28 +00:00
Felipe Pena
fc2fb50d09 - MFH: Added 'static' into ZEND_BEGIN_ARG_INFO_EX macro 2008-11-17 11:28:01 +00:00
Felipe Pena
7a37fa2d6b - Revert ZEND_BEGIN_ARG_INFO change 2008-11-02 21:19:39 +00:00
Felipe Pena
df10005563 - MFH: Added 'static' into ZEND_BEGIN_ARG_INFO_EX macro 2008-10-24 14:35:40 +00:00
Jani Taskinen
6495909d16 - Revert idiotic patch (hint: Windows IS NOT the most important OS!) 2008-09-07 17:59:24 +00:00
Kalle Sommer Nielsen
1a1df46be2 MFH: Fix test on Windows 2008-09-07 00:42:40 +00:00
Alexey Zakhlestin
c9fab63584 remove special treatment of /tmp path 2008-08-31 14:49:58 +00:00
Alexey Zakhlestin
97e26d95b7 this test depends on session.hash_bits_per_character, but it was not explicitly set 2008-08-26 16:46:26 +00:00
Jani Taskinen
525f3c4793 MFH: General sync. WS / CS / etc. crap some people didn't bother to merge
MFH: before this commit..bunnies thank you all..
[DOC] - Added ext/hash support to ext/session's ID generator. (Sara)
[DOC] Ask Sara for explanation..
2008-08-06 05:53:31 +00:00
Jani Taskinen
927a84bdfb - nuketh period from error message 2008-08-05 23:04:31 +00:00
Jani Taskinen
9ad7800f52 - Nuke ending periods from error messages 2008-08-05 22:52:05 +00:00
Kalle Sommer Nielsen
874b456078 MFH: Fixes #45406 - Patch by oleg dot grenrus at dynamoid dot com 2008-08-04 06:21:55 +00:00
Felipe Pena
e304515ddb - MFH: Added parameter TSRMLS_DC in zend_is_callable() 2008-08-02 04:46:07 +00:00
Dmitry Stogov
833a2295d1 Support for closures 2008-07-17 09:53:42 +00:00
Jani Taskinen
cd913eb2d8 MFH:- Fix tests (do NOT assume things in php.ini always to be same...or sane) 2008-07-15 01:00:00 +00:00
Felipe Pena
ca0c2340fe - Added arginfo 2008-06-27 16:16:23 +00:00
Dmitry Stogov
9c3ebd10bb Fixed memory leaks 2008-06-24 06:47:45 +00:00
Felipe Pena
44fe6a6005 - Fixed tests 2008-06-22 19:16:44 +00:00
Felipe Pena
015f82d219 - New parameter parsing API 2008-06-21 15:27:34 +00:00
Ant Phillips
ad93b947a2 Fix session test failures as reported by Antony Dovgal.
These were caused by the tests assuming default values for some session
configuration settings, in particular session.save_path and session.name.
The tests now explicitly set these settings in the --INI-- section.
2008-04-30 15:20:18 +00:00
Ant Phillips
c55db17098 Fix session test failures as reported by Antony Dovgal.
These were caused by the tests assuming default values for some session
configuration settings, in particular session.save_path and session.name.
The tests now explicitly set these settings in the --INI-- section.
2008-04-30 09:28:02 +00:00
Ant Phillips
cdf5621b50 More session tests to improve code coverage for untested extension code 2008-04-29 09:24:19 +00:00
Ant Phillips
52af9124b5 More session tests to improve code coverage for untested extension code 2008-04-29 08:57:09 +00:00
Ant Phillips
57e0d2acec These tests were backported from the PHP 6.0 branch, which in turn were ported from this branch and then updated to remove any dependencies on register_globals. With register_globals removed they are useful tests to run against the 5.X branches. 2008-04-22 16:04:31 +00:00
Ant Phillips
79b73d1218 New set of session extension tests for PHP 5.3 branch.
These hopefully test a reasonable set of basic, error and variations for
the twenty or so session functions. Note however that they do not
test all the session configuration settings, nor do they test anything
with register_globals enabled.
2008-04-22 16:04:30 +00:00
Scott MacVicar
944061ba37 Fixed bug #44720 (Prevent infinite recursion within session_register) 2008-04-15 00:59:04 +00:00
Dmitry Stogov
1a08aadc9b Fixed memory corruption because of double free() 2008-03-11 09:36:41 +00:00
Felipe Pena
84a8bb038a MFH: New way for check void parameters 2008-03-10 22:15:36 +00:00
Felipe Pena
77af81b8c3 Fix test (thanks Scoates!) 2008-03-08 23:31:05 +00:00
Gwynne Raskind
8bbef4f940 Forgot one file in last commit 2008-03-07 23:20:54 +00:00
Gwynne Raskind
3e99d5cc5b MFH: fix bug #32330 (session_destroy, "Failed to initialize storage module", custom session handler) 2008-03-07 23:20:32 +00:00
Sebastian Bergmann
d1dded8751 MFH: Bump copyright year, 2 of 2. 2007-12-31 07:17:19 +00:00
Yiduo (David) Wang
4b4d634cb9 MFH: Added macros for managing zval refcounts and is_ref statuses 2007-10-07 05:22:07 +00:00
Dmitry Stogov
6c810b0d4c Improved memory usage by movig constants to read only memory. (Dmitry, Pierre) 2007-09-27 18:00:48 +00:00
Ilia Alshanetsky
ea6de20d86 Fixed Bug #42596 (session.save_path MODE option does not work). 2007-09-10 23:42:54 +00:00
Jani Taskinen
de85bf4060 MFH: ws + cs changes (sync to ease merging patches around!) 2007-08-23 12:23:59 +00:00
Jani Taskinen
19401951c0 MFH: sync 2007-08-23 11:42:21 +00:00
Ilia Alshanetsky
89c0ba1685 Fixed bug #37273 (Symlinks and mod_files session handler allow open_basedir
bypass).
2007-08-23 02:04:39 +00:00
Stanislav Malyshev
6b7f164803 correct fix for access control for save_path and .htaccess 2007-08-03 01:16:40 +00:00
Ilia Alshanetsky
3034092111 Fixed bug #42135 (Second call of session_start() causes creation of SID) 2007-07-29 14:43:30 +00:00
Stanislav Malyshev
143badba52 always check save_path (issue reported by Maksymilian Arciemowicz) 2007-07-10 17:40:41 +00:00
Ilia Alshanetsky
e2d606e18b Fixed compiler warning 2007-06-17 14:25:46 +00:00
Stefan Esser
df7bfe0a0f MFH 2007-06-16 07:48:07 +00:00
Stanislav Malyshev
70a8f9313b Disallow characters that Cookie RFC does not allow in unquoted cookies 2007-06-15 22:40:00 +00:00
Antony Dovgal
d042fd0675 MFH: php_gmtime_r() fixes 2007-06-07 08:59:00 +00:00
Ilia Alshanetsky
c38ad55e8e Fixed bug #41600 (url rewriter tags doesn't work with namespaced tags). 2007-06-06 00:00:28 +00:00
Antony Dovgal
ffd09c0961 fix tests 2007-05-18 11:29:55 +00:00
Stanislav Malyshev
69650d0ebf do not send cookie when session is passed in URL, same as it happens with GET/POST 2007-05-16 01:18:14 +00:00