Greg Beaver
d7f50ac2c4
fix PHP Bug #49938 : Phar::isBuffering() returns inverted value
2009-11-13 00:58:11 +00:00
David Coallier
10ca1684cf
- MFH: Added test for bug 49910 for phar
2009-11-12 17:47:17 +00:00
Greg Beaver
01d9f2c9ce
fix PHP Bug #49910 : no support for ././@LongLink for long filenames in phar tar support
2009-11-11 21:02:59 +00:00
Rasmus Lerdorf
315b9956b6
Fix bug #50129
2009-11-09 17:21:15 +00:00
Jani Taskinen
fc4352e2d8
- It is not const in PHP_5_2 but it is in HEAD and PHP_5_3
2009-10-19 15:34:50 +00:00
Dmitry Stogov
883b992ea7
Fixed tests (removed irrelevant check which makes test to fail from time to time)
2009-09-21 15:23:25 +00:00
Greg Beaver
93054e9b38
oops, released as beta instead of stable, Gwynne: svn rm tags/RELEASE_2_0_0 fails, perhaps this can be allowed?
2009-07-29 16:29:30 +00:00
Felipe Pena
9e253ac6e7
- Fixed memleak on Phar::mungServer()
2009-07-29 16:17:57 +00:00
Greg Beaver
e29bccaae2
make phar tests pass in php 5.2, prepare for release of pecl/phar 2.0.0, merge Gwynne's TSRM fix to phar_object.c to other branches
2009-07-29 10:14:04 +00:00
Greg Beaver
1d50248937
make cache_list tests pass in php 6
2009-07-26 03:07:23 +00:00
Greg Beaver
e8d80c8bfd
fix buildFromIterator with filesystem iterator in php 6
2009-07-26 02:43:14 +00:00
Greg Beaver
96dd763df4
fix generation of phar.phar in php 6, fix remaining tests broken by PHP 6 (and not by spl/other stuff in php6)
2009-07-26 02:18:50 +00:00
Greg Beaver
66908185b7
fix basic phar test issues, failing tests phar_oo_009.phpt and phar_buildfromiterator10.phpt are due to bugs in Spl
2009-07-26 01:24:12 +00:00
Greg Beaver
732f4af082
re-organize slightly, fix more php6-only compile warnings in php_stream_copy_to_mem
2009-07-26 01:03:47 +00:00
Greg Beaver
571dfc1e49
fix zip front controller tests for php6
2009-07-26 00:39:40 +00:00
Greg Beaver
39125fdd47
fix tar front controller tests for php6
2009-07-26 00:35:17 +00:00
Greg Beaver
7761a39314
fix more tests for php6
2009-07-26 00:28:50 +00:00
Greg Beaver
cfbd6d852f
more php6 fixes for phar, fix more tests
2009-07-25 23:45:45 +00:00
Greg Beaver
7d114c2e7f
merge from HEAD changes to test
2009-07-24 23:55:49 +00:00
Greg Beaver
e8756a3c3c
begin work on making phar php6-ready
2009-07-24 23:53:24 +00:00
Greg Beaver
aa65955c8c
update test to work in php 6
2009-07-24 22:09:36 +00:00
Greg Beaver
96740db9ab
fix PHAR_ARG_INFO #define to work with PHP major versions > 5
2009-07-24 21:27:51 +00:00
Greg Beaver
cd23986a7a
fix --CLEAN-- of all.phpt, remove unnecessary check in phar_convert_again.phpt, and fix signature generation and checking for zip to also include central directory up to the signature, implement better check for end-of-zip at signature verification
2009-07-24 19:40:41 +00:00
Greg Beaver
d68cc96ebd
merge unmerged changes between branches, remove unnecessary test for zip signature failure in badparameters.phpt
2009-07-24 17:07:05 +00:00
Greg Beaver
e1962da708
fix minor memory leak
2009-07-24 16:21:40 +00:00
Greg Beaver
42e0e5dfb7
fix signature generation/validation for zip archives by phar extension, fix a few edge cases where memory was leaked on error conditions by missing efree()
2009-07-24 15:42:17 +00:00
Greg Beaver
115e370d6e
fix PHP Bug #48377 : error message unclear on converting phar with existing file
2009-07-23 17:04:24 +00:00
Greg Beaver
09b8bbc97f
new phar test for zip with data descriptor in local file header
2009-07-23 16:40:47 +00:00
Greg Beaver
1723b16898
fix PHP bug #48791 : open office files always reported as corrupted
2009-07-23 16:30:27 +00:00
Greg Beaver
01659b8b7c
fix php bug #48783 : make install will fail saying phar file exists
2009-07-23 15:48:04 +00:00
Greg Beaver
3bf5d05047
fix PHP bug #48740 : PHAR install fails when INSTALL_ROOT is not the final install location
2009-07-23 15:40:10 +00:00
Greg Beaver
4744223055
fix Bug #49021 : phar tar signature algorithm reports as Unknown (0) in getSignature() call
2009-07-22 20:21:39 +00:00
Greg Beaver
667c59abd6
Fix Bug #49020 : phar misinterprets ustar long filename standard
2009-07-22 19:51:37 +00:00
Greg Beaver
fb3adb16fc
don't package up subversion directory in phar.phar
2009-07-22 18:37:32 +00:00
Greg Beaver
d967e29541
fix php bug #49018 (phar tar stores long filenames with prefix/name reversed)
2009-07-22 18:13:38 +00:00
Greg Beaver
5dd3306551
fixed bug #48681 (openssl signature verification for tar archives broken)
2009-06-30 14:49:12 +00:00
Greg Beaver
2c924e2848
fix slightly unclear error message in generation of phar.phar
2009-06-24 22:12:47 +00:00
Greg Beaver
645226d19b
fix EXPECT section of test
2009-06-18 18:12:04 +00:00
Greg Beaver
fb86c3f7a2
MFH: fixed isset() on sub-directories (isset("blah") if file "blah/foo.php" exists)
2009-06-05 04:46:49 +00:00
Greg Beaver
a8e7103bbe
MFPECL: fix security vulnerability in phar's handling of long tar filenames
2009-06-04 19:59:09 +00:00
Hannes Magnusson
2a257adda9
MFH: Fixed creating directory structure when extracting phars
2009-06-04 12:22:32 +00:00
Greg Beaver
1c30b43e50
MFH: fix potential segfault when converting phars with metadata to other formats, add test
2009-05-24 18:50:58 +00:00
Greg Beaver
475cf4d288
fix Bug #48257 : PharData throws exception with non-phar tar
2009-05-13 20:25:43 +00:00
Kalle Sommer Nielsen
18e7a82dd4
MFH: Nuke compiler warning
2009-05-13 15:55:12 +00:00
Kalle Sommer Nielsen
776a648f17
MFH: Fix conditional
2009-05-11 06:43:05 +00:00
Felipe Pena
937b429ad8
- Fixed tests
2009-05-11 01:51:07 +00:00
Greg Beaver
6f101e7c06
remove precautionary #ifdef - the problem was fixed by moving the efree inside the zend_try block
2009-05-05 01:41:51 +00:00
Greg Beaver
6eb6df3a20
disable cause of mysterious segfault in PHP 5.3 only (5.2 is fine)
2009-05-04 04:29:25 +00:00
Antony Dovgal
8594654160
fix test
2009-05-01 22:23:59 +00:00
Antony Dovgal
d3438bf9f5
initialize ext_len
2009-05-01 09:22:16 +00:00
Greg Beaver
6289c323d3
MFPECL fix PECL Bug #14646 : phar error message unclear with php stream wrappers (note: is there a standard way to list PECL bugs in NEWS?)
2009-04-30 04:43:10 +00:00
Greg Beaver
f21744809e
MFPECL: fix PECL bug #16338 , php_stream_copy_to_stream{,_ex}()
2009-04-29 03:24:27 +00:00
Greg Beaver
e9d2d08b3c
new test - test passes here, but the pear2coverage.phar.php segfaults in apache 2.2 sapi
2009-04-28 19:28:52 +00:00
Jani Taskinen
3d87ef8b21
MFH
2009-04-25 17:57:36 +00:00
Greg Beaver
4d92c7bffc
revert removal of openssl check, was confusion on my part
2009-03-01 07:20:26 +00:00
Greg Beaver
26ce51d6f1
add safeguard check for timestamp modification to phar_stub.phpt and phar_gzip.phpt
2009-03-01 07:16:46 +00:00
Greg Beaver
1ff3b85d74
fix hash support on windows in ext/phar (Kalle)
2009-03-01 07:07:05 +00:00
Greg Beaver
a51f628bd1
fix blog.phar for front.phar.phpt test
2009-03-01 07:00:13 +00:00
Greg Beaver
a6298331b5
update NEWS with phar enabling, fix swapping of time/date in timestamp saving for zip, which can cause crash on windows
2009-03-01 06:58:01 +00:00
Greg Beaver
79f5f7538c
fix SKIPIF, EXPECT in 2 tests
2009-03-01 06:50:26 +00:00
Greg Beaver
af84168de6
fix faulty logic in tests, needed to use ksort instead of asort and to sort output. These tests failed on some systems with non-case sensitive filesystem sorting
2009-02-21 03:15:47 +00:00
Greg Beaver
bd74089a4e
cosmetics: remove two unreachable return statements, removes warning in sun cc
2009-02-21 02:37:18 +00:00
Greg Beaver
7707318d61
cosmetics: fix warning (only affects suncc)
2009-02-21 02:32:16 +00:00
Greg Beaver
2344d80015
fix zip access to work in all compilers, present and future, and on all arches without potential for bus errors. This removes PHAR_ZIP_PACK in favor of a safer approach
2009-02-20 05:06:37 +00:00
Greg Beaver
c351b71f2b
fix memleaks on zip corruption
2009-02-16 18:55:06 +00:00
Greg Beaver
874d14b36f
re-enable ext/phar on big-endian systems, fixes verified as workign
2009-02-16 16:41:40 +00:00
Greg Beaver
5c6a25e750
fix the last remaining failing test (explicitly pass in SKIP_DOTS to directory iterator)
2009-02-15 21:43:39 +00:00
Greg Beaver
625eb9e0ec
fix remaining big-endian issues with phar
2009-02-15 20:29:13 +00:00
Greg Beaver
9221abd00e
fix getting/setting of all 16/32 values in zip
2009-02-15 19:22:42 +00:00
Greg Beaver
e8b7091c2c
revert accidental commit of config.m4, big-endian isn't ready quite yet
2009-02-15 18:53:22 +00:00
Greg Beaver
d3cea8b054
fix setting of 32-bit value on big-endian systems
2009-02-15 18:51:46 +00:00
Greg Beaver
fd5be66d13
fix bug #47085:rename() returns true even if the file in PHAR does not exist
2009-02-03 18:29:25 +00:00
Greg Beaver
b634bf4ce8
fix bug #47265 (generating phar.phar fails because of safe_mode)
2009-02-03 18:17:24 +00:00
Johannes Schlüter
80f6263bbc
Properly disable phar for the moment
2009-01-28 20:39:15 +00:00
Scott MacVicar
fd91a50b71
Disable Phar on big endian systems for beta 1.
2009-01-28 15:53:29 +00:00
Felipe Pena
c3631156fc
- Fixed tests
2009-01-25 16:53:07 +00:00
Ilia Alshanetsky
6ca15bfe0f
Fixed a possible crash when phar_create_signature() fails
2009-01-02 20:43:41 +00:00
Sebastian Bergmann
08659c2dcd
MFH: Bump copyright year, 3 of 3.
2008-12-31 11:15:49 +00:00
Sebastian Bergmann
3c1ed020c7
MFH: Bump copyright year, 2 of 3.
2008-12-31 11:13:54 +00:00
Marcus Boerger
fcf784502e
MFH Use ' -f' as requested
2008-12-13 14:49:39 +00:00
Hannes Magnusson
4bfd481076
MFH: fix test
2008-12-09 13:02:40 +00:00
Marcus Boerger
c727b68ca1
- MFH Only show switch -y if available
2008-12-08 00:16:05 +00:00
Marcus Boerger
43c7b7f679
- MFH When installing phar, make phar a link to phar.phar
2008-12-07 23:57:40 +00:00
Felipe Pena
fc2fb50d09
- MFH: Added 'static' into ZEND_BEGIN_ARG_INFO_EX macro
2008-11-17 11:28:01 +00:00
Marcus Boerger
6ca3ad3f41
- MFH We only rely on hash if it is built-in
2008-11-04 14:04:29 +00:00
Marcus Boerger
582cdf9a27
- MFH Add hash dependency at module source level
2008-11-04 13:33:15 +00:00
Marcus Boerger
e2ab5164ce
- MFH Fix dependency from Phar to hash
2008-11-04 01:27:52 +00:00
Felipe Pena
7a37fa2d6b
- Revert ZEND_BEGIN_ARG_INFO change
2008-11-02 21:19:39 +00:00
Greg Beaver
86f8d0a8e9
fix several errors found by valgrind
...
1 - entry metadata not properly processed or retrieved from cached phars
2 - copy on write was using a void return value instead of int, a dangerous oversight in phar_update_cached_entry
3 - metadata creation in entries for cached phars was causing an invalid read
2008-10-26 05:49:09 +00:00
Felipe Pena
df10005563
- MFH: Added 'static' into ZEND_BEGIN_ARG_INFO_EX macro
2008-10-24 14:35:40 +00:00
Alexey Zakhlestin
a4d609ab04
proper check for php-version
2008-10-21 12:59:45 +00:00
Alexey Zakhlestin
7ff4c359e6
fixed wrong check for version
2008-10-21 12:26:35 +00:00
Felipe Pena
e52fc53bc2
- MFH: Fixed bug #45726 (PHP_Archive / Archive.php missing)
2008-10-17 01:58:20 +00:00
Greg Beaver
347a58939d
last test for cached phar copy on write (forgot this one yesterday)
2008-10-14 00:38:01 +00:00
Greg Beaver
fdac2c9a12
increase code coverage
2008-10-13 04:50:37 +00:00
Greg Beaver
3a54017556
add complete tests verifying copy-on-write for cached phars
2008-10-13 04:21:09 +00:00
Greg Beaver
5bc1122056
fix faulty tests
2008-10-12 23:32:50 +00:00
Antony Dovgal
8b793f4274
MFH: fix ZTS build
2008-10-12 21:09:22 +00:00
Greg Beaver
114861e330
fix incorrect key for Phar destructor
2008-10-12 19:45:01 +00:00
Greg Beaver
e16636f069
add tests for copy-on-write support
...
- fix metadata handling with cached phars
- fix virtual_dirs with rmdir
- ensure that after copy-on-write, all existing Phar objects link to the newly copied phar data
2008-10-12 19:40:11 +00:00
Greg Beaver
eaf5d4c8b3
add missing --INI-- section
2008-10-12 18:54:00 +00:00
Greg Beaver
a2b4f65a0c
re-add as binary
2008-10-12 18:47:19 +00:00
Greg Beaver
da731473aa
oops, need to add as binary
2008-10-12 18:46:46 +00:00
Greg Beaver
15cac7f22f
add missing file for tests
2008-10-12 18:45:46 +00:00
Greg Beaver
261d300a0f
add new test for copy-on-write, fix copy-on-write for Phar/PharFileInfo methods
2008-10-12 06:53:32 +00:00
Greg Beaver
5a00c7baf0
re-add as binary
2008-10-12 06:41:27 +00:00
Greg Beaver
415a37bfae
stupid cvs added this as text
2008-10-12 06:41:01 +00:00
Greg Beaver
0182bbf76b
fix files for advanced include_path test
2008-10-12 06:40:36 +00:00
Greg Beaver
53e1428b06
increase code coverage
2008-10-12 05:41:22 +00:00
Greg Beaver
60969b5385
fix links for fseek as well
2008-10-11 22:20:57 +00:00
Greg Beaver
59379244ad
fix reading links from streams (works with PharFileInfo->getContent())
2008-10-11 22:12:07 +00:00
Greg Beaver
bf268a68f9
cosmetics/maintainability: reduce code redundancy on error conditions
2008-10-11 21:22:58 +00:00
Greg Beaver
eb41e0d64f
work around crap stream filter implementation, update tests for compressed aliases in zip-based phar so they actually test the compression
2008-10-11 20:57:08 +00:00
Greg Beaver
fffdf661c9
fix bug #45907 : undefined reference to PHP_SHA512Init
2008-10-09 00:50:47 +00:00
Greg Beaver
41c95a030d
fix test (thanks Tony)
2008-09-30 13:25:48 +00:00
Greg Beaver
dcc919c449
fix Bug #46194 : SIGSEGV when requested file is not found
2008-09-30 02:40:17 +00:00
Greg Beaver
e1d0a964da
fix 017.phpt in streams.c, and very dangerous intercepting of file functions in all cases introduced in multi-threaded fix
2008-09-26 23:34:57 +00:00
Greg Beaver
1847779210
fix bug #46178 : memory leak in ext/phar
2008-09-26 16:29:44 +00:00
Greg Beaver
f2ad965863
fix another memory leak
2008-09-26 04:54:08 +00:00
Greg Beaver
7a62dcaa5e
fix obvious memory leak
2008-09-26 04:41:22 +00:00
Greg Beaver
498ffbc84f
workaround for Bug #46147 for PHP < 5.2.7
2008-09-22 01:39:11 +00:00
Greg Beaver
1799136925
fix compile on IRIX with MIPSPro (Bug #46072 )
2008-09-14 06:47:08 +00:00
Greg Beaver
dd51a607e2
increase code coverage, fix bzip2-compressed alias in zip
2008-09-14 06:31:20 +00:00
Greg Beaver
9eb83b6ae9
fix minor issues found by ICC (unused variables and the like)
2008-09-13 22:30:55 +00:00
Greg Beaver
760172fcee
fix Bug #46060 : addEmptyDir() breaks
2008-09-13 20:57:09 +00:00
Arnaud Le Blanc
28c49938d3
MFH: make pharcommand.inc works without ereg
2008-09-12 16:09:01 +00:00
Antony Dovgal
f2d766b917
fix test
2008-09-11 13:38:15 +00:00
Greg Beaver
e7b6fe1b45
fix Bug #46032 : PharData::__construct wrong memory read
2008-09-11 03:29:15 +00:00
Steph Fox
8e972fcd7e
I hate not being able to test.
2008-09-01 16:32:55 +00:00
Steph Fox
94dcaa27fb
- Fix the fix (sorry, missed this until now)
2008-09-01 16:29:38 +00:00
Steph Fox
e36c24fc50
- Remove pre-made phar.phar
2008-09-01 15:44:48 +00:00
Steph Fox
318d5f98ff
- unnecessary ;
...
We are now 100% synched - let's keep it that way!
2008-08-31 21:02:55 +00:00
Steph Fox
7b74a7711c
- cs, update package files following RC1 (just to keep it all in sync)
2008-08-31 21:01:12 +00:00
Greg Beaver
2f2b08a286
move to 2.0.0-dev
2008-08-31 20:50:09 +00:00
Greg Beaver
cabf4c481e
use TAR_FILE instead of '0' and '\0' instead of 0
2008-08-31 20:24:04 +00:00
Greg Beaver
4b81bd61d8
temp bandaid on broken build system, revert when snapshot build is fixed in win32
2008-08-31 19:51:49 +00:00
Greg Beaver
b597a9c781
hadn't saved tar.c, use '\0' instead of 0 for char values, removes warning in intel compiler
2008-08-31 19:47:31 +00:00
Greg Beaver
28689c9c01
use '\0' instead of 0 for chars, removes intel warning
2008-08-31 19:46:35 +00:00
Greg Beaver
9397c4a5d1
remove unnecessary double variable declarations
2008-08-31 19:42:16 +00:00
Greg Beaver
b2efb50cfd
remove unnecessary ;
2008-08-31 19:38:40 +00:00
Steph Fox
e8be4d93c5
- Ensure that we're always checking for OpenSSL support, rather than just for ext/openssl being loaded
2008-08-31 19:18:35 +00:00
Greg Beaver
270964c193
use safer strlcpy, patch by Tony Dovgal
2008-08-31 07:15:25 +00:00
Greg Beaver
678db15b51
commit missing files for tests
2008-08-31 07:03:26 +00:00
Greg Beaver
513cec31d3
fix compile warning in PHP < 6.0
2008-08-31 06:58:04 +00:00
Greg Beaver
c73badb3fd
remove superfluous variable declarations, merge WS from pecl/phar
2008-08-31 06:51:49 +00:00
Greg Beaver
eec1cf5f0a
merge from pecl/phar strlen optimizations
2008-08-31 06:47:38 +00:00
Greg Beaver
e30bf5af3b
remove superfluous return statements, merge from pecl/phar
2008-08-31 06:42:46 +00:00
Greg Beaver
1c66670ee8
merge minor optimization removing strlen from pecl/phar
2008-08-31 06:38:09 +00:00
Greg Beaver
6dcdb77f7b
remove unused variables, merge from pecl/phar
2008-08-31 06:31:53 +00:00
Greg Beaver
642f6aa673
remove superfluous double variable declaration, merge from pecl/phar
2008-08-31 06:28:01 +00:00
Greg Beaver
27cf27568d
use %u instead of %d, merge from pecl/phar
2008-08-31 06:26:19 +00:00
Greg Beaver
f679e900dd
remove orphaned code, merge from pecl/phar
2008-08-31 06:13:42 +00:00
Greg Beaver
5c3749021a
remove unused variables, merge from pecl/phar
2008-08-31 06:09:37 +00:00
Greg Beaver
a7da5249e2
WS merge from pecl/phar
2008-08-31 06:04:38 +00:00
Greg Beaver
6ac2c92ede
2 fixes, merge minor fixes from pecl/phar. Merge in corrected fix from pecl/phar for is_tar setting of tar_type
2008-08-31 02:14:03 +00:00
Greg Beaver
046f8dba55
sync with pecl/phar, missed one line change
2008-08-30 23:50:31 +00:00
Greg Beaver
3ebb94f6a2
sync with pecl/phar, this does not change any functionality in PHP 5.3, but makes syncing easier. This commit is only functional changes, WS will be next
2008-08-30 23:47:55 +00:00
Greg Beaver
61b09ab834
fix OS-dependent order in test
2008-08-30 23:12:56 +00:00
Greg Beaver
c3e8485971
fix bug #45792 : bz2 compressed files in zip failure
2008-08-21 05:17:28 +00:00
Greg Beaver
cfca5be40f
fix windows build when building phar shared with native-ssl disabled (you can't use the symbols directly if openssl is built shared or is not built at all)
2008-08-18 14:58:03 +00:00
Antony Dovgal
6eb565a8b0
fix test
2008-08-16 10:48:29 +00:00
Dmitry Stogov
878946a34f
Fixed bug #45613 Segfault when using is_file() on Apache-2.2.8
2008-08-14 13:01:28 +00:00
Felipe Pena
cf7384aa40
- MFH: Constness (Added const qualifier to several function parameters)
2008-08-12 17:20:25 +00:00
Marcus Boerger
bfb468c275
- Fix http://bugs.php.net/bug.php?id=45613
2008-08-12 14:56:52 +00:00
Greg Beaver
95a8499996
increase code coverage
2008-08-11 22:43:02 +00:00
Greg Beaver
8526b78286
increase code coverage
2008-08-11 03:53:57 +00:00
Steph Fox
f55d753d3e
MFH Remove obsolete check (thanks Tony)
2008-08-02 15:38:46 +00:00
Dmitry Stogov
33f48b800c
Fixed bug #44100 (Inconsistent handling of static array declarations with duplicate keys)
2008-08-01 14:22:48 +00:00
Steph Fox
4e5280a7a2
- ws/cs, macros, code that only affects other branches
...
- some unsynced changes need valgrind testing before they can go into this branch, see PECL/HEAD
2008-08-01 13:48:45 +00:00
Steph Fox
821bab83a3
- Merge ws/cs fixes to bring all branches into sync
2008-08-01 13:42:56 +00:00
Steph Fox
377ff97abd
- MFH Bring phar tests into line across all branches
2008-08-01 13:38:48 +00:00
Marcus Boerger
152e4273d1
- Consistency rocks: Make all lines start with tabs for indentation
...
# Just as anythign else we do.
# Also saves about ~0.5k in phar.phar
2008-08-01 06:16:35 +00:00
Marcus Boerger
d29fba1678
- Fix pear PHP_Archive class file location
2008-08-01 05:43:09 +00:00
Antony Dovgal
57caabf653
don't segfault if given invalid/empty private key
2008-07-29 11:18:40 +00:00
Antony Dovgal
2543206105
don't free function name before calling the function
2008-07-29 11:09:00 +00:00
Antony Dovgal
b53da9cd80
fix folding
2008-07-29 10:52:08 +00:00
Marcus Boerger
fb5c092815
- Fix openssl check
2008-07-27 04:23:00 +00:00
Steph Fox
6895773aff
- Utilize new UNIX_PATHS flag in SPL
...
- Fix tests
@Jani: hold back on the bunny-killing, HEAD will be in sync later today
2008-07-24 09:22:35 +00:00
Dmitry Stogov
c48c63f5e6
Improved webPhar speed (frontcontroller11.phar.phpt is disabled, should be removed)
2008-07-22 07:03:00 +00:00
Dmitry Stogov
68537af530
Fixed directory reanming/deletion
2008-07-20 14:42:34 +00:00
Dmitry Stogov
529ac539d0
Fixed access to freed memory
2008-07-18 09:35:51 +00:00
Dmitry Stogov
67b77b06e5
Fixed search on uninitialized data
2008-07-17 14:05:07 +00:00
Dmitry Stogov
5c631e8765
Fixed wrong arguments order
2008-07-17 13:22:32 +00:00
Dmitry Stogov
44557cf981
Improved support for opcode caches. Now some open() syscalls might be eliminated by caches.
2008-07-16 15:09:39 +00:00
Jani Taskinen
1e2b2bbeae
- Some config*.m4 file cleanups: NO tabs in these!
2008-07-14 09:02:26 +00:00
Antony Dovgal
0be3a5dcd5
drop unused var
2008-07-11 09:11:18 +00:00
Antony Dovgal
120f19b6a6
fix function protos and is_link() wrapper
2008-07-11 08:53:43 +00:00
Dmitry Stogov
478234b235
Fixed wrong refcount updates
2008-07-10 16:16:15 +00:00
Dmitry Stogov
d82b5d59b4
Added tests that demonstrate serious PHAR errors
...
They cannot be easly fixed without algorithms modification
2008-07-10 14:27:21 +00:00
Dmitry Stogov
53bbf1238c
Extensions MUST NOT manipulate with internal functions from EG(function_table) in run-time. It may cause problems with opcode caches and in multi-threaded environment. Now the same functions are overriden at MINIT and call original functions or PHAR ones dependent on flag setting.
2008-07-10 11:36:50 +00:00
Antony Dovgal
ae7eff10e8
add zero-terminator to the delimiter (and make valgrind happy)
2008-07-09 14:15:41 +00:00
Dmitry Stogov
1cfd92fc43
Fixed efree(NULL)
2008-07-09 08:47:05 +00:00
Etienne Kneuss
e53a9ca709
Fix filename/pathname/getpathinfo tests according to SPL fix
2008-07-09 08:39:42 +00:00
Steph Fox
27340e60fc
- Fixed config.w32 to keep Elizabeth happy
...
- NB This whole lot still might disappear, OpenSSL patch review pending
2008-07-07 01:13:14 +00:00
Steph Fox
2c9df0990d
- We forgot to check that the phar exists before trying to extract files from it :)
2008-07-07 01:11:07 +00:00
Steph Fox
5db08e7d1f
Duplicate tests to accommodate parameter parsing fixes in 5_3 core
...
(NB the 5_2 tests will fail currently due to name changes, will fix tomorrow)
2008-07-07 01:09:21 +00:00
Greg Beaver
37c684ab3d
in preparation for a performance optimization that involves
...
eliminating phar's interception of zend_compile in favor of a new to-be-added hook in PHP 5.3+,
allow "include 'phar:///path/to/my.phar';" to work as equivalent to
php /path/to/my.phar
this slight change in scripting still allows inclusion and execution of phar stub, but removes the need to
check and modify path in zend_compile, which allows us to play much nicer with external tools like
debuggers/opcode caches
2008-06-27 01:21:12 +00:00
Greg Beaver
8bf72978b3
fix several issues:
...
1) segfault in phar_buildfromdirectoryiterator8.phpt
2) tests failing because SKIPDOTS is default on 64 bit, not on 32
3) Marcus, you really need to add SKIPDOTS as a class constant, so we don't have to use 0x00001000
2008-06-24 01:11:27 +00:00
Steph Fox
b9e8695e75
- One solution for the openssl issues
...
- config.m4 needs bringing into line with config.w32, there may be broken behaviour under *nix until this is done
2008-06-23 19:18:01 +00:00
Steph Fox
019c586191
- Wrong SKIPIF message
2008-06-23 17:48:23 +00:00
Greg Beaver
10f6d9a556
true fix for potential segfault in phar_build
2008-06-23 04:00:23 +00:00
Greg Beaver
fb448c5c28
fix tar-related failures
2008-06-23 03:55:50 +00:00
Steph Fox
c68a82ac7d
- Revert the two blocks of code that implement the phar_build optimization, causes segfaults under *nix
...
- Leave the new structure in place to make re-implementation trivial
2008-06-22 16:35:26 +00:00
Steph Fox
f3844ecd17
- Revert the tar.c part of the inode calculation fix
...
- All tests now pass under win32, please test under *nix/osx (4 known fails at present)
2008-06-22 14:46:10 +00:00
Steph Fox
332a185e08
- ws, typo fix
2008-06-22 13:10:03 +00:00
Greg Beaver
3a8b14f83f
fix inode calculation, we need fname to be set for phar/tar formats prior to manifest parsing
2008-06-22 00:50:32 +00:00
Greg Beaver
0ad165e402
new tests for phar.cache_list
2008-06-22 00:49:54 +00:00
Steph Fox
0e5b3a3527
- Don't free stuff you still need
2008-06-21 21:37:39 +00:00
Steph Fox
35e0565a4b
- Kill a couple of double frees and a memleak
...
@Greg: You may want to run valgrind over the filestat functions before release..
2008-06-21 20:47:35 +00:00
Steph Fox
ad20b9e6bb
- pefree pemalloc'd filename
2008-06-21 20:14:43 +00:00
Steph Fox
22fb73c71e
- Fix macro definition syntax
...
- Remove pre-existing workaround
2008-06-21 19:40:41 +00:00
Steph Fox
f43a2be8cd
- fix for segfault in 5.2 (patch from Greg)
2008-06-21 19:15:46 +00:00
Steph Fox
b964ec6e5d
- ws
2008-06-21 18:57:53 +00:00
Greg Beaver
4b77c2baa5
define ALLOC_PERMANENT_ZVAL for PHP 5.2
2008-06-21 17:05:32 +00:00
Greg Beaver
eb0a98939a
PHP 5.2 fixes to direct include of compressed archives
2008-06-21 17:05:18 +00:00
Greg Beaver
baee4e6028
close stream on failure
2008-06-21 06:55:56 +00:00
Greg Beaver
529aa19cc7
82x(./profile2) speedup for buildFrom*()
2008-06-21 06:53:10 +00:00
Greg Beaver
14c26d05ba
fix leak
2008-06-21 06:21:58 +00:00
Steph Fox
97cf2a15da
- 5_2 compatibility stuff (so we can stay in sync with PECL)
2008-06-20 16:29:36 +00:00
Steph Fox
c88e99d9ea
- Use SKIP_SLOW_TESTS where it's most useful
2008-06-20 14:42:04 +00:00
Steph Fox
6ef7aef1d4
- Kill the last compiler warning under 5.3 (release-only)
2008-06-20 14:40:53 +00:00
Steph Fox
fc08a7cc2f
The only reason that particular 'real solution' wasn't applied in the first place was that it also breaks the shared build
...
Maybe we don't need to call a non-existent dtor if we're going to physically apply zend_hash_graceful_reverse_destroy()?
- This works on my box, please test under *nix/OSX
2008-06-20 12:21:32 +00:00
Johannes Schlüter
62726c967c
- Fix ZTS build (not required on HEAD, patch by Uwe Pries)
2008-06-20 09:17:53 +00:00
Greg Beaver
aff3636d9c
minor performance improvement
2008-06-20 06:37:14 +00:00
Greg Beaver
7cc6b9f3f5
making progress - up to 42/phar vs. 48/disk with these optimizations
2008-06-20 05:42:58 +00:00
Greg Beaver
5233505043
revert really bad solution to the zend_init_rsrc_list/zend_destroy_rsrc_list problem, replace with real solution
2008-06-20 04:50:11 +00:00
Steph Fox
5d4eed8f47
- inherited methods don't unixify paths along the way. Allow for it.
2008-06-18 16:48:18 +00:00
Steph Fox
aa694b8b51
- Kill 10 MSVC compiler warnings due to type conflict
...
- Make cached manifest test platform agnostic
- Comment out zend_(init|destroy)_rsrc_list() and associated references
@Greg: cached manifest test (now) passes here regardless, make of that what you will
2008-06-18 15:06:50 +00:00
Pierre Joye
e5e9be2d1a
- really fix the windows builds, don't cast many times when only the hash function requires void **
...
- copy/paste evilness with TSRM_CC/DC
(tests still pass but would be nice to speed them up...)
2008-06-18 10:20:47 +00:00
Greg Beaver
cbe23b9f20
fix windows build and more performance jumps (these are minor)
...
implement real copy-on-write
use virtual_dirs for wrapper stat
2008-06-18 06:38:47 +00:00
Greg Beaver
d8d31bc591
remove unused variables in phar_fix_filepath
...
copy virtual_dirs to avoid segfault on multi-process
fix metadata reading for phar.cache_list
initialize manifest to exact size needed (performance increase)
fix freeing of signature on error to use the correct persist value (fixes segfault on error in cache.list)
reset EG(regular_list) so it is identical to how we found it
2008-06-16 04:10:53 +00:00
Greg Beaver
4e65a58146
fix hashtable creation for tar to be estimated size needed
2008-06-16 04:09:20 +00:00
Greg Beaver
03b9673ba2
fix hashtable creation for zip to be exact size needed, fix endian issue for loading manifest
2008-06-16 04:06:59 +00:00
Greg Beaver
c353e9277e
minor performance improvement
2008-06-15 23:00:46 +00:00
Greg Beaver
5e3f592d88
fix memleak
2008-06-15 22:51:46 +00:00
Greg Beaver
4104786072
another optimization - move inode hash to initial manifest parsing, improves runtime perf of stat slightly
2008-06-15 21:42:20 +00:00
Greg Beaver
d8ed660a02
minor optimization
2008-06-15 21:15:29 +00:00
Greg Beaver
04e257a8e1
HUGE speed improvement, from 19 req/sec to 27 req/sec for phpMyAdmin - now speed with apc+phar.cache_list = on-disk speedcvs diff -u |less This is by generating a list of virtual directories and using those in stat calls instead of scanning the whole manifest hash table. on-disk phpMyAdmin = 28 req/sec
2008-06-15 18:15:48 +00:00
Felipe Pena
c772aca929
- Fix build (ZTS)
2008-06-13 22:28:55 +00:00
Greg Beaver
4f9daeed11
[DOC] implement full signature support for tar-based archives. By default, data archives do
...
not have a signature, but can have one set via setSignatureAlgorithm()
2008-06-13 22:07:44 +00:00
Greg Beaver
5ff4deaa53
full refactor of signatures complete - now to implement them for tar as a starting point
2008-06-13 20:15:19 +00:00
Greg Beaver
09e1f0249e
PHP_5_2 compat - add pestrndup if undefined
2008-06-13 15:59:13 +00:00
Felipe Pena
d61f32d021
- Fix build (ZTS)
2008-06-13 13:06:46 +00:00
Greg Beaver
9c8d13fd6c
partial refactor - move signature verification into its own function, in preparation for tar/zip signature support.
...
next is signature creation
2008-06-13 06:34:41 +00:00
Greg Beaver
98f2dc2aca
[DOC] add phar.cache_list, a PATH_SEPARATOR-separated list of full paths to phar archives to cache
...
at startup. This caches the manifest, so that on first access to a phar archive, no file manifest parsing occurs.
This could use further tweaking. For instance, the full copy of the manifest into the current process may be unnecessary if refcounting could be external
to the manifest. This would be another significant gain. With APC, I measure a slight perf increase to 19 req/sec up from 16 req/sec, without it approaches
regular PHP at 3.8 req/sec (regular is 4 req/sec). This is benching phpMyAdmin
2008-06-12 18:56:23 +00:00
Greg Beaver
84eb9cc145
ensure we don't try to use an unitialized hash table
2008-06-12 18:46:58 +00:00
Antony Dovgal
ca3e7643a6
fix build (noticed by Alexey Zakhlestin)
2008-06-12 10:31:22 +00:00
Greg Beaver
279771dc4b
fix error messages
2008-06-12 04:57:24 +00:00
Greg Beaver
4a62db4e6c
new tests (forgot to add these earlier)
2008-06-10 19:23:09 +00:00
Greg Beaver
8b8a64a3e8
fix PHP Bug #45218 : PHAR archive built from directory limited by max open file handles
2008-06-10 19:20:33 +00:00
Greg Beaver
d0734964ca
fix memleak on error
2008-06-10 17:58:09 +00:00
Greg Beaver
eb77b80b9d
fix compile warnings if openssl is enabled statically. fix dangerous use of wrong length var in openssl signature verification
2008-06-09 16:07:18 +00:00
Marcus Boerger
332d83555c
- Make phar.phar building work for virtualized builds
2008-06-04 16:38:13 +00:00
Marcus Boerger
ad8eb0f672
- Make sure we are not trying to pack directories
2008-06-04 14:36:33 +00:00
Marcus Boerger
376ca12a21
- Update
2008-06-04 09:47:41 +00:00
Marcus Boerger
e8609b5199
- Use -n only for current built PHP
2008-06-04 09:47:17 +00:00
Marcus Boerger
350824478b
- Improve pear usage and PHP_Archive detection
2008-06-04 09:46:34 +00:00
Antony Dovgal
2ac1ba6254
fix tests
2008-06-04 07:38:10 +00:00
Marcus Boerger
c317ce0d67
- Prefer current CLI target to build phar.phar
...
- Use php -n
- Use shared phar, bz2, zlib automatically
2008-06-03 20:18:58 +00:00
Marcus Boerger
4e61f63d3f
- Remove checked-in or older version of phar.phar as we might not be able to open it
2008-06-02 15:50:42 +00:00
Marcus Boerger
159561e9da
- Need to use a proper inheritance check
2008-06-02 15:49:03 +00:00
Marcus Boerger
c60365e9b3
- Fix issue with -y parameter hanlding (fix typo)
2008-06-02 13:39:54 +00:00
Marcus Boerger
4f74e50c1b
- Fix issue with -y parameter hanlding
2008-06-02 13:33:45 +00:00
Marcus Boerger
cb0af1eeb8
- Fix issue with -y parameter hanlding
2008-06-02 13:24:15 +00:00
Marcus Boerger
678a38e9ba
- Make work with new API
2008-06-01 17:16:40 +00:00
Marcus Boerger
147eed53e2
- Fix signature handling (and remaining API change fixes)
2008-06-01 17:16:04 +00:00
Marcus Boerger
aaf6b216ed
- Fix docu
2008-06-01 17:14:48 +00:00
Marcus Boerger
c05c40cea4
- Add Openssl support
2008-06-01 07:39:06 +00:00
Greg Beaver
5fbeb235d2
add openssl signing support. This adds an extra parameter
...
for the contents of the exported private key to Phar->setSignatureAlgorithm, and expects the public key to be in
a file named blah.phar.pubkey in the same directory as the phar blah.phar. This works with openssl static or
shared and fails gracefully if openssl is not present without adding a dependency. config.w32 needs updating to match config.m4 [DOC]
2008-06-01 04:21:26 +00:00
Marcus Boerger
4c2e05a6e7
- MFH Simplify
2008-05-31 20:30:27 +00:00
Marcus Boerger
28dd1f5f5e
- MFH Add 'help commands' support
2008-05-31 20:24:34 +00:00
Marcus Boerger
631484e2c7
- Add phar command as installable command
2008-05-31 20:02:57 +00:00
Marcus Boerger
aa4e898fe5
- Add version comand
2008-05-31 18:40:05 +00:00
Marcus Boerger
1debfd2a15
- Add version comand
2008-05-31 16:40:55 +00:00
Marcus Boerger
8010892bf0
- MFH Fix function names after they have been refactored
2008-05-31 15:53:16 +00:00
Greg Beaver
83e491b2c3
fix corrupted zips, fix postprocess for compressed zip file
2008-05-30 22:49:33 +00:00
Greg Beaver
8b600a72dc
refactor function names for clarity. No functionality change
2008-05-30 22:38:46 +00:00
Greg Beaver
4cc79b39b4
fix PECL bug #13981 : Third-party zips fail entry interrogation
2008-05-29 17:34:50 +00:00
Stanislav Malyshev
370aafc62b
Fix code path in phar_open_compiled_file() that tries
...
to open not-yet-loaded phar and fails on compressed files
# By Gregory's request
# Sorry, can't find how to write test case for that - it reproduces
# for me only under bytecode-caching. Suggestions welcome.
2008-05-28 21:42:21 +00:00
Steph Fox
51967b91d5
"We shouldn't need a full path to the mount"
...
- Fixed under Windows, cleaned up test
2008-05-24 13:13:47 +00:00
Greg Beaver
4b035dae5f
major fixes
...
* found felipe's segfault in util.c and fixed the segfault (3 tests fail due to odd behavior of . and .. on this machine)
* fixed serious flaws in the setting/resetting of is_data - now it works properly. Assume
all new PharData are tar-based, and allow passing Phar::ZIP to PharData constructor to override this
* fix broken earlier commit, introduced segfault that broke 20 tests here
2008-05-22 06:33:09 +00:00
Felipe Pena
e1bfc452d3
- Fix build (ZTS)
2008-05-21 22:52:30 +00:00
Greg Beaver
1f661c81c4
fix offset detection in tar files
2008-05-21 22:00:43 +00:00
Greg Beaver
79ae1c7273
fix convertTo\*() for same-named archives with no files
2008-05-21 20:24:40 +00:00
Greg Beaver
07d6758c86
relax conversion, so that if a phar has no files, we can convert it to another format without changing the extension
2008-05-20 03:56:35 +00:00
Greg Beaver
0800b3b159
fix memleak, add test for previous segfault fix
2008-05-18 23:41:08 +00:00
Greg Beaver
b149e8c0fa
fix segfault, test coming shortly
2008-05-18 23:11:24 +00:00
Steph Fox
53fd21de33
- Keep 5_3 stub and creation files in sync with what I have in CVS HEAD
...
(MFB will likely be tomorrow now)
2008-05-18 20:52:34 +00:00
Greg Beaver
4aa4f1fabb
enable by default statically instead of shared
...
this is done by removing zlib/bz2 explicit dependencies because they are unnecessary
we only ever use the stream filter, and the check for existence has
been moved to runtime where it is after startup
2008-05-17 20:07:22 +00:00
Greg Beaver
d35f27b896
fix test (again)
2008-05-17 20:04:06 +00:00
Greg Beaver
57b3bba46e
cosmetics
2008-05-16 00:11:42 +00:00
Greg Beaver
a5ec4d5f2b
as discussed on internals, enable phar by default for testing purposes.
...
Phar is enabled as a shared extension by default in order to allow zlib/bz2 to be built shared. If phar is statically built,
both zlib and bz2 must be statically built in order for phar to use them, so default compile as shared is much more flexible
2008-05-16 00:01:56 +00:00
Greg Beaver
719beb79d4
add full metadata support for tar-based archives and test
2008-05-15 23:46:29 +00:00
Greg Beaver
de5aaaa74c
fix potentially major security hole: modification/creation of files in .phar directory enabled in many locations
...
which then allows easy creation of tar/zip-based phar archives with a simple rename even when phar.readonly=1. Plug the hole very tightly, allowing read access to
files, and also excluding them from opendir() output
2008-05-15 16:09:01 +00:00
Greg Beaver
8cc335a0da
make test OS-agnostic
2008-05-15 14:01:30 +00:00
Steph Fox
93183728d2
- Fix test, add a couple of new ones
...
@Greg: it seems we covered it already ;)
2008-05-15 12:37:45 +00:00
Steph Fox
6a0682d986
- MFH
...
- Make internal code forward-compatible. This included a binary cast in the default stub, hence test updates.
2008-05-14 21:29:51 +00:00
Felipe Pena
6552d91743
- Fixed tests (added default_charset=)
2008-05-13 19:17:17 +00:00
Greg Beaver
9b5b694c92
fix test
2008-05-13 18:06:55 +00:00
Felipe Pena
613f2d2afc
- Added SKIPIF
2008-05-13 14:49:06 +00:00