Commit Graph

802 Commits

Author SHA1 Message Date
Andrei Zmievski
cc34210c32 MFH 2009-03-12 16:13:17 +00:00
Johannes Schlüter
162aed0aed MFH: Fix #46542 Extending PDO class with a __call() function doesn't work
as expected
2009-02-17 14:42:26 +00:00
Felipe Pena
b66f9c0a87 - Missing "DROP TABLE" 2009-02-16 19:48:56 +00:00
Felipe Pena
d01257ffd9 - Added missing void param check and arginfo 2009-02-13 12:55:38 +00:00
Felipe Pena
f0a96595d0 MFH:
- Fixed bug #43831 ($this gets mangled when extending PDO with persistent connection)
- Fixed bug #45432 (PDO: persistent connection leak)
2009-02-13 02:18:57 +00:00
Felipe Pena
d33be91e72 - MFH: Fixed bug #47297 (pdo_033.phpt fails on PgSQL)
Patch by matteo at beccati dot com
2009-02-04 16:40:56 +00:00
Antony Dovgal
9b9cd5421d create temporary db in the current dir and cleanup on completion 2009-01-05 16:02:04 +00:00
Sebastian Bergmann
08659c2dcd MFH: Bump copyright year, 3 of 3. 2008-12-31 11:15:49 +00:00
Sebastian Bergmann
3c1ed020c7 MFH: Bump copyright year, 2 of 3. 2008-12-31 11:13:54 +00:00
Nuno Lopes
f2f7ed4987 we do not need the strndup() now that php_stream_printf() handles non-null terminated strings correctly 2008-12-12 23:46:05 +00:00
Ilia Alshanetsky
0594dd91d3 Fixed a possible corruption inside PDOStatement::debugDumpParams() 2008-12-11 15:32:24 +00:00
Antony Dovgal
b9653b8358 MFH 2008-12-03 10:18:42 +00:00
Matt Wilmas
fafa7f2709 Fixed error message typo 2008-12-03 00:10:17 +00:00
Dmitry Stogov
7d4fd3fd38 Fixed bug #46409 (__invoke method called outside of object context when using array_map) 2008-11-27 19:01:23 +00:00
Felipe Pena
fc2fb50d09 - MFH: Added 'static' into ZEND_BEGIN_ARG_INFO_EX macro 2008-11-17 11:28:01 +00:00
Felipe Pena
c29ebd8a23 - MFH: Better fix 2008-11-13 18:14:50 +00:00
Pierre Joye
c8103324bf - MFH: declaration goes first... 2008-11-13 14:40:06 +00:00
Felipe Pena
494dbdb1c1 - MFH: Fixed invalid reads 2008-11-13 13:08:12 +00:00
David Coallier
9334bbd650 - After readying Johannes's mail, the conclusion that a "smarter" system
to find out if the return_value had the correct number of elements was
  definitely needed. Simply added a difference to both dbh and stmt to
  make sure that the error info always has 3 elements.

- Bug #44154 (pdo->errorInfo doesn't always return three elements)
- Now pdo->errorInfo() AND stmt->errorInfo() return three elements.

- [DOC] Make sure that not only the pdo->errorInfo() is returning 3 elms, but
  also the PDOStatement object
2008-11-10 18:47:28 +00:00
Felipe Pena
a912d80adb MFH:
- Fixed wrong check
- Improved test
2008-11-05 23:40:38 +00:00
David Coallier
80e3ed5630 - MFH
- Bug #44154: [DOC] Return 3 elements at all times. If the dbh stmt doesn't have
  an error code we used to return an array with one element. For the sake
  of consistency and verification of returned values at userland we are now
  returning an array with 3 elements. Note the two last elements are null but
  present

- Bug #4413: [DOC] If the error code returned by the DBH is null, we return
  a null value. This is used in order to help with empty error codes.
2008-11-04 18:28:41 +00:00
Felipe Pena
a5e72fd696 - MFH: Improved fix 2008-11-03 23:44:38 +00:00
Felipe Pena
27965c932f MFH:
- Fixed endless loop in PDOStatement::debugDumpParams()
  patch by: Jonah H. Harris <jonah.harris at gmail dot com>
2008-11-03 20:48:51 +00:00
Felipe Pena
e0fededeba - MFH: Fixed bug #44327 (PDORow::queryString property & numeric offsets / Crash) 2008-11-03 15:33:23 +00:00
Felipe Pena
7a37fa2d6b - Revert ZEND_BEGIN_ARG_INFO change 2008-11-02 21:19:39 +00:00
Felipe Pena
df10005563 - MFH: Added 'static' into ZEND_BEGIN_ARG_INFO_EX macro 2008-10-24 14:35:40 +00:00
Felipe Pena
981a23fff3 - MFH: Fixed bug #43925 (Incorrect argument counter in prepared statements with pgsql) 2008-10-23 18:53:05 +00:00
Felipe Pena
84be2eb47b - MFH: Fixed bug #46292 (PDO::setFetchMode() shouldn't requires the 2nd arg when using FETCH_CLASSTYPE) 2008-10-14 17:36:02 +00:00
Felipe Pena
e90d487720 - Removed unnecessary strcmp call (thanks Tony) 2008-10-12 13:46:10 +00:00
Felipe Pena
d2d4e044c7 - Complete the fix for #46274, and tests 2008-10-12 13:01:31 +00:00
Kalle Sommer Nielsen
0c183be27f MFH:
Add missing zend_parse_paramters_none() in pdo_drivers()
2008-10-10 23:38:14 +00:00
Felipe Pena
86f0b45ef8 - MFH: Static'fication 2008-10-10 19:35:34 +00:00
Felipe Pena
a3c8772fd1 MFH:
- Fixed bug #46139 (PDOStatement->setFetchMode() forgets FETCH_PROPS_LATE)
  Initial patch by: chsc at peytz dot dk
2008-10-10 16:47:15 +00:00
Felipe Pena
1f54af9245 MFH:
- Fixed bug #44251 (Question mark and an escaped singel quote lead to an exception)
- Fixed bug #41125 (PDO mysql + quote() + prepare() can result in seg fault)
  Patch by: tsteiner at nerdclub dot net
2008-10-10 12:10:41 +00:00
Felipe Pena
8d03c0de19 - MFH: Fixed bug pecl#9641 (Unable to add driver specific methods to PDOStatement) (patch by Christopher Jones) 2008-10-09 13:00:58 +00:00
Felipe Pena
6bc9869ad9 - MFH: Fixed bug #46157 (PDOStatement::fetchObject prototype error) 2008-09-23 23:07:52 +00:00
Johannes Schlüter
2c98da2d17 MFH Fix #44425 (Extending PDO/MySQL class with a __call() function doesn't work) 2008-09-16 23:35:50 +00:00
Felipe Pena
cf7384aa40 - MFH: Constness (Added const qualifier to several function parameters) 2008-08-12 17:20:25 +00:00
Felipe Pena
e304515ddb - MFH: Added parameter TSRMLS_DC in zend_is_callable() 2008-08-02 04:46:07 +00:00
Jani Taskinen
281352fe02 MFH: Fix PDO configure dependancy: If --disable-pdo is used, disable all
MFH: enabled-by-default drivers. Also error out if you try to configure
MFH: a driver as static but pdo is disabled.
2008-07-25 13:46:24 +00:00
Dmitry Stogov
ac68c41f8d Fixed support for static methods 2008-07-25 09:44:47 +00:00
Antony Dovgal
a46319d86d fix typos 2008-07-25 08:45:09 +00:00
Dmitry Stogov
691d4a6999 Fixed uninitialised data 2008-07-25 08:23:07 +00:00
Pierre Joye
246d836a28 - MFH: force static for now, broken now 2008-07-24 16:05:34 +00:00
Johannes Schlüter
be0793d2e7 MFH: Add mysqlnd support for PDO_mysql, fixes at least bug#41997,#42499,
pecl#12794, pecl#12401

# Running the tests:
# (Note: Doesn't work currnetly on HEAD, see:
#  http://news.php.net/php.qa/64378)
#
#  PDO_MYSQL_TEST_DSN  - DSN
#    For example: mysql:dbname=test;host=localhost;port=3306
#
#  PDO_MYSQL_TEST_HOST    - database host
#  PDO_MYSQL_TEST_DB      - database (schema) name
#  PDO_MYSQL_TEST_SOCKET  - database server socket
#  PDO_MYSQL_TEST_ENGINE  - storage engine to use
#  PDO_MYSQL_TEST_USER    - database user
#  PDO_MYSQL_TEST_PASS    - database user password
#  PDO_MYSQL_TEST_CHARSET - database charset
#
#  NOTE: if any of PDO_MYSQL_TEST_[HOST|DB|SOCKET|ENGINE|CHARSET] is
#  part of PDO_MYSQL_TEST_DSN, the values must match. That is, for example,
#  for PDO_MYSQL_TEST_DSN = mysql:dbname=test you MUST set PDO_MYSQL_TEST_DB=test.
2008-07-21 13:09:28 +00:00
Felipe Pena
cb0d08699d - Added arginfo 2008-06-27 19:16:17 +00:00
Felipe Pena
f6cc283d46 - MFH: Add check for avoid segfault when trying instantiate PDORow manually 2008-05-14 12:32:21 +00:00
Ilia Alshanetsky
3bcf8a3d00 Added a warning message on pdo::exec() failure in the event of an empty query 2008-04-22 13:01:45 +00:00
Nuno Lopes
8dc8b63cca fix SKIPIFs
# Patch by Christian Hoffmann
2008-04-10 18:50:42 +00:00
Antony Dovgal
57f51ee9a4 remove ze1_compat leftovers 2008-03-18 14:44:35 +00:00
Nuno Lopes
25e6cd1a38 remove duplicated sections 2008-03-17 17:19:48 +00:00
Felipe Pena
84a8bb038a MFH: New way for check void parameters 2008-03-10 22:15:36 +00:00
Ilia Alshanetsky
1a3f7f6450 Fixed bug #44166 (Parameter handling flaw in PDO::getAvailableDrivers()) 2008-03-03 21:12:16 +00:00
Johannes Schlüter
1aa32afa8a MFH: Fix get_parent_class() of PDORow instances 2008-03-03 19:00:45 +00:00
Ilia Alshanetsky
43bcf759d3 Better fix for bug #44189 2008-02-26 00:13:57 +00:00
Ilia Alshanetsky
e0388c5549 Fixed bug #44200 (A crash in PDO when no bound targets exists and yet
bound parameters are present)
2008-02-24 16:08:32 +00:00
Felipe Pena
31ba224d90 Fix test 2008-02-22 02:15:42 +00:00
Ilia Alshanetsky
2fc9f5928e Fixed bug #44189 (PDO setAttribute() does not properly validate values for
native numeric options)
2008-02-21 13:37:21 +00:00
Ilia Alshanetsky
3101edfd18 Fixed bug #44171 (Invalid FETCH_COLUMN index does not raise an error) 2008-02-20 03:11:43 +00:00
Felipe Pena
eaed933e57 New test 2008-02-19 14:53:04 +00:00
Nuno Lopes
083f474a47 some BDs (e.g. firebird) dont support text, so replace it with varchar(255). 2008-02-19 14:46:20 +00:00
Felipe Pena
6e712e05ab MFB: Fixed Bug #44159 (Crash: $pdo->setAttribute(PDO::STATEMENT_ATTR_CLASS, NULL)) 2008-02-19 12:13:20 +00:00
Ilia Alshanetsky
353d1ea039 PDO is hardly experimental 2008-01-31 20:50:27 +00:00
Dmitry Stogov
240fa244c3 Improved PHP binary size and startup speed with GCC4 visibility control (Nuno) 2008-01-30 09:41:12 +00:00
Nuno Lopes
b89396b11e move about 3K of data to the const area. also reduce memory usage (~ -266 bytes :P) 2008-01-25 19:57:57 +00:00
Ilia Alshanetsky
40dc00410d Missing patch bit from the FETCH_GROUP fix 2008-01-14 18:41:31 +00:00
Ilia Alshanetsky
fa1e1d249b Fixed a bug with PDO::FETCH_COLUMN|PDO::FETCH_GROUP mode when a column # by
which to group by data is specified.
2008-01-11 01:47:18 +00:00
Ilia Alshanetsky
a4674c5ed7 Skip test for PostgreSQL driver since error is too dissimilar to other
drivers
2008-01-03 16:46:52 +00:00
Sebastian Bergmann
d1dded8751 MFH: Bump copyright year, 2 of 2. 2007-12-31 07:17:19 +00:00
Sebastian Bergmann
f8a8196d63 MFH: Bump copyright year, 1 of 2. 2007-12-31 07:15:43 +00:00
David Soria Parra
07487ad0e7 - Fixed bug #43663 (Extending PDO class with a __call() function doesn't work).
CVS
2007-12-30 17:51:35 +00:00
Antony Dovgal
2b856ff3c7 fix test 2007-11-27 11:14:33 +00:00
Antony Dovgal
da231136ce fix test 2007-11-27 06:44:16 +00:00
Ilia Alshanetsky
0c0456d275 Revert addition of - char support for bound param names 2007-11-26 21:09:50 +00:00
Jani Taskinen
dcd3b197e7 MFH:- Fixed bug #43365 (Several enums have trailing commas) 2007-11-26 10:59:04 +00:00
Ilia Alshanetsky
204f9e1a74 Adjusted fix for bug #42978 2007-11-20 23:12:17 +00:00
Ilia Alshanetsky
48878f2ecd Fixed bug #42978 (mismatch between number of bound params and values causes
a crash in pdo_pgsql)
2007-11-20 14:22:27 +00:00
Antony Dovgal
379e8a5970 fix test 2007-11-08 12:40:43 +00:00
Ilia Alshanetsky
d689a10f3a Fixed test 2007-11-04 16:12:13 +00:00
Ilia Alshanetsky
548c25ef1c Fixed bug #43139 PDO ignores ATTR_DEFAULT_FETCH_MODE in some cases with fetchAll() 2007-10-31 12:57:51 +00:00
Ilia Alshanetsky
84f0fba1a5 Test not relavent for sqlite that uses built-in bound syntax 2007-10-30 23:03:23 +00:00
Ilia Alshanetsky
c27a8a41c2 Fixed bug #43130 (Bound parameters cannot have - in their name) 2007-10-29 22:36:26 +00:00
Ilia Alshanetsky
3762dfc09f Fixed bug #42917 (PDO::FETCH_KEY_PAIR doesn't work with setFetchMode) 2007-10-11 20:54:41 +00:00
Yiduo (David) Wang
104290130e MFH: stmt->fetch.func.values is not a zval and should not be freed with FREE_ZVAL 2007-10-08 04:06:15 +00:00
Yiduo (David) Wang
4b4d634cb9 MFH: Added macros for managing zval refcounts and is_ref statuses 2007-10-07 05:22:07 +00:00
Dmitry Stogov
6c810b0d4c Improved memory usage by movig constants to read only memory. (Dmitry, Pierre) 2007-09-27 18:00:48 +00:00
Stanislav Malyshev
1f45d49a0c fix crash if stream is empty and reader function sets buffer as null 2007-09-12 21:21:18 +00:00
Ilia Alshanetsky
910850be51 Fixed bug #42643 (CLI segfaults if using ATTR_PERSISTENT). 2007-09-12 18:26:49 +00:00
Hannes Magnusson
2fc92c9172 - Fixed bug #42452 (PDO classes do not expose Reflection API information)
- Fixed tests
2007-08-30 14:06:12 +00:00
Ilia Alshanetsky
c72d39f763 Fixed bug #41971 (PDOStatement::fetch and PDOStatement::setFetchMode causes
unexpected behavior).
2007-07-31 22:48:42 +00:00
Ilia Alshanetsky
2600cf9c20 Already exists in PECL 2007-07-25 22:26:14 +00:00
Dmitry Stogov
7ec48cb37f Fixed bug #40757 (get_object_vars get nothing in child class)
Fixed bug #41929 (Foreach on object does not iterate over all visible properties)
2007-07-24 11:39:56 +00:00
Antony Dovgal
fe25997d44 fix test 2007-07-23 22:46:03 +00:00
Jani Taskinen
5b71d45eff MFH: sync 2007-07-23 11:53:58 +00:00
Ilia Alshanetsky
20c4198341 Added test for KEY_PAIR code and fixed KEY_PAIR detection code 2007-07-22 15:50:17 +00:00
Ilia Alshanetsky
285316fcff Fixed PDO_FETCH_KEY_PAIR implementation for fetchAll() 2007-07-22 15:14:21 +00:00
Ilia Alshanetsky
39c1705848 Fixed a possible crash inside the constructor 2007-07-16 18:00:18 +00:00
Ilia Alshanetsky
d34bfe5c37 When working with persistent connections re-initialize options on each
connection. Flags like error reporting may differ.
2007-06-28 19:22:52 +00:00
Ilia Alshanetsky
37d1bfed25 Added support for ATTR_TIMEOUT inside pdo_pgsql driver.
Fixed a bug inside PDO's "use persistent" connection detection mechanism
that would trigger connections on "" and "0" values
2007-06-28 03:13:29 +00:00
Ilia Alshanetsky
abffe87d42 Fixed a crash inside PDO when there is more then one instance of a
persistent connection inside a script and PDO object is extended by class
with a destructor
2007-06-27 02:02:18 +00:00
Ilia Alshanetsky
dc1c6f74c8 Fixed bug #41698 (float parameters truncated to integer in prepared
statements).
2007-06-26 01:24:10 +00:00
Ilia Alshanetsky
c084d1c829 Fixed bug #41596 (Fixed a crash inside pdo_pgsql on some non-well-formed
SQL queries).
2007-06-05 22:55:27 +00:00
Ilia Alshanetsky
489c2d739a Fixed test for PostgreSQL 2007-06-03 17:41:21 +00:00
Ilia Alshanetsky
2a6442190c Fixed test to work with postgresql 2007-05-19 15:28:37 +00:00
Hannes Magnusson
4ad45f6566 Fix paths for ext/sqlite 2007-05-17 13:40:12 +00:00
Ilia Alshanetsky
67032ecdf0 Make test work in sqlite 2007-05-16 21:03:46 +00:00
Antony Dovgal
5e7b464517 typofix 2007-05-16 20:04:32 +00:00
Ilia Alshanetsky
efd7846d34 [DOC] Added PDO::FETCH_KEY_PAIR mode that will fetch a 2 column result set
into an associated array.
2007-05-16 19:33:57 +00:00
Antony Dovgal
1f65545121 fix test names 2007-05-07 18:03:01 +00:00
Ilia Alshanetsky
7810fc89fa Fixed bug #41215 (setAttribute return code reversed). 2007-04-29 14:47:34 +00:00
Antony Dovgal
9ab23a7e53 fix leaks in row_get_properties()
thanks to Kellen Bombardier for noticing
2007-04-17 17:00:16 +00:00
Antony Dovgal
c73225ab61 MFH: fix #40727 (segfault in PDO when failed to bind parameters) 2007-03-07 09:03:07 +00:00
Ilia Alshanetsky
ff3e825083 Fixed bug #40417 (Allow multiple instances of the same named PDO token in
prepared statement emulation code).
2007-03-06 00:52:55 +00:00
Ilia Alshanetsky
a8c006235c Better generated parser 2007-02-02 00:03:33 +00:00
Ilia Alshanetsky
79dfb302b1 Fixed test mixup 2007-02-02 00:00:33 +00:00
Ilia Alshanetsky
c219c6f4a8 Fixed bug #40285 (The PDO prepare parser goes into an infinite loop in
some instances).
2007-02-01 00:12:39 +00:00
Antony Dovgal
58e96c4c10 nullify param.parameter and avoid destroying it twice 2007-01-27 21:53:26 +00:00
Nuno Lopes
b6dff166bf MFH: fix infinite cycle
#this was the infinite cycle that was bugging me in the gcov machine...
2007-01-03 22:05:24 +00:00
Sebastian Bergmann
4223aa4d5e MFH: Bump year. 2007-01-01 09:36:18 +00:00
Ilia Alshanetsky
b8590f954d Fixed test 2006-12-09 16:41:24 +00:00
Ilia Alshanetsky
b7b0f4d988 Fixed bug #39759 (Can't use stored procedures fetching multiple result
sets in pdo_mysql).
2006-12-08 19:50:40 +00:00
Ilia Alshanetsky
e5ad7bf299 Fixed bug #36798 (Error parsing named parameters with queries containing
high-ascii chars).
2006-12-05 18:04:59 +00:00
Hannes Magnusson
a41e70782b Fix test 2006-12-05 15:55:55 +00:00
Ilia Alshanetsky
8e907392b3 Fixed test (user is a reserved keyword in pgsql) 2006-12-04 17:55:46 +00:00
Ilia Alshanetsky
7fb3715d43 Fixed bug #38319 (Remove bogus warnings from persistent PDO connections). 2006-12-04 03:07:44 +00:00
Ilia Alshanetsky
44045f8cb1 Fixed bug #38252 (Incorrect PDO error message on invalid default fetch mode). 2006-12-04 02:40:08 +00:00
Ilia Alshanetsky
4356aad0ae Fixed bug #39483 (Problem with handling of \ char in prepared statements). 2006-12-04 00:38:46 +00:00
Ilia Alshanetsky
44baca5aed Added missing check for mismatching number of tokens & bound params in
prepared statement emulation.
2006-12-03 23:27:44 +00:00
Ilia Alshanetsky
916673a345 Fixed bug #39527 (Failure to retrieve results when multiple unbuffered,
prepared statements are used in pdo_mysql).
2006-12-02 17:53:44 +00:00
Antony Dovgal
bb30875db6 add test 2006-11-28 16:55:05 +00:00
Ilia Alshanetsky
2d4b8e19e2 Fixed bug #39656 (crash when calling fetch() on a PDO statment object
after closeCursor()).
2006-11-28 16:27:53 +00:00
Ilia Alshanetsky
af16066603 Fixed a possible crash 2006-11-23 14:41:35 +00:00
Ilia Alshanetsky
6e9c7c4aa9 Fixed generated file 2006-11-12 17:55:44 +00:00
Ilia Alshanetsky
c32ed59e4e Fixed a memory leak when named & positional params are being used in the
same query.
2006-11-12 17:49:19 +00:00
Ilia Alshanetsky
887b3484f7 Fixed bug #39398 (Booleans are not automatically translated to integers). 2006-11-07 17:57:17 +00:00
Hannes Magnusson
8104df0547 Remove bogus ini entry 2006-10-14 15:06:11 +00:00
Antony Dovgal
5e34f6cf9e MFH 2006-09-28 23:27:59 +00:00
Antony Dovgal
d6eb64344d MFH 2006-09-28 23:03:56 +00:00
Ilia Alshanetsky
2332e4f9fc Fixed bug #37870 (pgo_pgsql tries to de-allocate unused statements).
Fixed bug #36681 (pdo_pgsql driver incorrectly ignored some errors).
Fixed test for bug #38253 not to use faulty SQL that generates errors in
PostgreSQL
2006-09-19 15:45:22 +00:00
Antony Dovgal
a5bb290f28 it's not a PEAR only issue 2006-08-24 16:00:43 +00:00
Antony Dovgal
b7f2d8f17e MFH: fix possible crash in free_statement() 2006-08-23 19:15:57 +00:00
Antony Dovgal
36dffb8e3b typo 2006-08-21 17:12:02 +00:00
Ilia Alshanetsky
8d770ee2ef Fixed bug #38535 (memory corruption in pdo_pgsql driver on error retrieval
inside a failed query executed via query() method).
2006-08-21 16:53:50 +00:00
Ilia Alshanetsky
3d87be2674 Added skip condition for sqlite2 driver, that uses more forgiving emulated
prepared statements.
2006-08-16 14:09:56 +00:00
Ilia Alshanetsky
43fca8a3f8 Fixed bug #38394 (PDO fails to recover from failed prepared statement
execution).
2006-08-09 14:45:00 +00:00
Ilia Alshanetsky
194b309d2d Fixed memory leak with persistent connections 2006-08-07 17:32:13 +00:00
Ilia Alshanetsky
2b5a53d6b6 Fixed memory leak on unused bound name parameters. 2006-08-01 15:06:01 +00:00
Ilia Alshanetsky
c6ace95236 Fixed bug #37445 (Fixed crash in pdo_mysql resulting from premature object
destruction).
2006-07-31 20:18:11 +00:00
Antony Dovgal
168f53b72b fix bug #38253 (PDO produces segfault with default fetch mode)
add test
2006-07-30 11:19:56 +00:00
Antony Dovgal
97ef557b97 initialize var 2006-07-27 08:00:54 +00:00
Dmitry Stogov
b6d2c54059 Destructors call order is changed (Fixed bug #36759 - Objects destructors are invoked in wrong order when script is finished) 2006-07-12 07:55:17 +00:00
Antony Dovgal
3aaf62d159 there is no Unicode in 5_2 2006-07-11 12:15:11 +00:00
Hartmut Holzgraefe
c1b67d83cc (MFH) "transaction" tests should test commit, too, not only rollback 2006-07-10 16:29:50 +00:00
Hartmut Holzgraefe
836e74ebee MFH 2006-07-10 14:06:13 +00:00
Hartmut Holzgraefe
098d3d2b02 MFH 2006-07-10 07:39:35 +00:00
Antony Dovgal
3ff986ecf7 init vatiables 2006-06-20 13:26:01 +00:00
Dmitry Stogov
1dbaae2795 Added automatic module globals management 2006-06-15 18:33:09 +00:00
Rasmus Lerdorf
76bff5194c Put the TODO back 2006-06-07 21:14:04 +00:00
Rasmus Lerdorf
658762a0b5 Get rid of useless function calls 2006-06-07 21:09:52 +00:00
Ilia Alshanetsky
a9c6e4be1e Fixed bug #37709 (Possible crash in PDO::errorCode()). 2006-06-07 03:33:16 +00:00
Antony Dovgal
e5c8f8c59b yet another dummy clone_obj handler to fix problems created by ze1 compat mode 2006-06-06 22:05:56 +00:00
Antony Dovgal
1b602e85d1 fix leak appearing on phpinfo() when there are no PDO modules available 2006-06-05 22:08:16 +00:00
Antony Dovgal
e4a3732c91 no need to call zend_is_callable() if callable is known to be invalid
free fname on failure and plug possible leak
2006-05-30 09:46:59 +00:00
Antony Dovgal
e2afb33e87 fix skip reason 2006-05-17 10:12:36 +00:00
Marcus Boerger
7bbab02633 - MFH
. Fix iterator based access
  . Add new attribute ATTR_DEFAULT_FETCH_MODE: $bdh->setAttribute()
  . Add new fetch mode: FETCH_PROPS_LATE, this fills object member
    variables after calling the constructor (fixes #36428).
2006-05-11 22:43:44 +00:00
Marcus Boerger
bf9f762b4d - MFH: add new test 2006-05-11 22:17:42 +00:00
Marcus Boerger
11f26c2c2a - Tweak version check 2006-05-09 23:54:48 +00:00
Sara Golemon
7e6beb9f28 Note addition of new class constants 2006-05-04 00:21:51 +00:00
Sara Golemon
91999f1175 mfh(r-1.129) Expose PARAM_EVT_* constants 2006-05-03 21:58:38 +00:00
Wez Furlong
7614368f8a prep for pecl release 2006-05-02 02:32:40 +00:00
Antony Dovgal
ea53739d30 MFB: don't segfault if an exception has been thrown from the fetch handler 2006-04-22 19:10:53 +00:00
Wez Furlong
687e6ffc58 Add "ATTR_EMULATE_PREPARES" general attribute to replace the custom
attributes employed by mysql and postgres drivers.
No functional change.
2006-04-09 08:05:01 +00:00
Antony Dovgal
08e6fded56 prevent possible NULL dereference 2006-03-28 20:19:44 +00:00
Wez Furlong
6387d83a05 add a test case for bug 35671 2006-03-28 16:47:35 +00:00
Wez Furlong
fb7d5bd780 The fix for #35332 caused #35671 (and thus PECL #6504).
Partially back out that fix and introduce an extra optional step for drivers to
canonicalize the "name" that is used for registering parameters.
2006-03-27 20:51:01 +00:00
Antony Dovgal
1ad4dd8795 return FALSE if driver doesn't support quoting (this is what docu says)
also fixed PECL bug #6365
2006-03-23 19:01:46 +00:00
Ilia Alshanetsky
3b1cb0e500 Added myself to PDO and PDO_MySQL credits
Added Wez to PDO_MySQL credits
Added Tony to Q&A team credits
Regenerated the credits file
2006-03-23 18:36:47 +00:00
Ilia Alshanetsky
4ccd89d147 Properly calculate the size of the result array. 2006-03-19 17:35:36 +00:00
Antony Dovgal
5c7c11c41d MFH: check stream for NULL before writing to it
remove unnecessary semicolons
2006-03-18 22:24:05 +00:00
Ilia Alshanetsky
92ba7cccad Fixed memory leak on unused bind var. 2006-03-15 15:25:50 +00:00
Marcus Boerger
6e93f3eb8f - MFH Proto fixes 2006-03-06 10:00:59 +00:00
Ilia Alshanetsky
6f66a63cda Fixed bug #36222 (errorInfo in PDOException is always NULL). 2006-01-31 17:20:32 +00:00
Ilia Alshanetsky
8fde2249c3 Properly rewrite queries where a bound parameter appears more then once. 2006-01-25 16:35:23 +00:00
Marcus Boerger
1d461a6bcc - MFH 2006-01-22 23:57:41 +00:00
Marcus Boerger
813a5651c1 - MFH Update test 2006-01-22 22:07:43 +00:00
Ilia Alshanetsky
64a7e46506 Fixed bug #35797 (segfault on PDOStatement::execute() with
zend.ze1_compatibility_mode = On).
2006-01-01 20:07:41 +00:00
foobar
5bd93221a8 bump year and license version 2006-01-01 12:51:34 +00:00
foobar
e3fd31503b bump the year and license version 2006-01-01 12:26:08 +00:00
Ilia Alshanetsky
2e50763315 Fixed memory corruption that affected pdo_sqlite2. 2005-12-24 17:41:04 +00:00
foobar
93d339bede touch with re2c 0.9.11 2005-12-18 20:01:22 +00:00
Ilia Alshanetsky
b83a0eb10c Fixed memory corruption when FETCH_LAZY mode is being used. 2005-12-17 20:00:00 +00:00
Ilia Alshanetsky
bdf9c4d15c Fixed bug #35694 (Improved error message for invalid fetch mode). 2005-12-15 22:33:02 +00:00
Marcus Boerger
9bb52c750c - MFH 2005-12-11 15:29:14 +00:00
Ilia Alshanetsky
24af85dfe9 Fixed memory leak 2005-12-07 01:29:14 +00:00
foobar
3e669bc950 MFH: nuke php3 legacy 2005-12-06 02:28:41 +00:00
foobar
f58f7f4e67 MFH: fix typo 2005-12-05 22:41:10 +00:00
foobar
66832decc5 MFH 2005-12-05 22:39:03 +00:00
Wez Furlong
17683295e4 switch to package2.xml 2005-12-04 22:34:26 +00:00
Antony Dovgal
d72347f7bc MFH: fix #35543 (php crash when calling non existing method of a class that extends PDO) 2005-12-04 11:41:13 +00:00
Antony Dovgal
06c57b7d55 tweak fix a bit
(by request of Wez)
2005-12-01 20:39:12 +00:00
foobar
b935f6f13a - Fix paths for --enable-gcov usage
# re2c -b -o ext/pdo/pdo_sql_parser.c ext/pdo/pdo_sql_parser.re
2005-12-01 20:28:27 +00:00
Antony Dovgal
59087fee52 MFH: fix #35508 (PDO fails when unknown fetch mode specified) 2005-12-01 19:59:58 +00:00
Wez Furlong
b15e33f85a prep for release 2005-11-28 06:39:53 +00:00
Wez Furlong
d0ea27b802 API for connection dependent objects to add/del refs to dbh's. 2005-11-28 05:23:22 +00:00
Wez Furlong
b4dd85ff46 update changelog here too 2005-11-27 21:18:24 +00:00
Wez Furlong
63dae4ee74 Fix #35431; LAZY fetch and fetchAll == crash.
Lazy makes no sense with fetchAll; disallow it.
2005-11-27 21:01:58 +00:00
Antony Dovgal
6543134dea MFH: fix #35430 (PDO crashes on incorrect FETCH_FUNC use) 2005-11-27 21:01:02 +00:00
Wez Furlong
ef08c58664 update the todo list 2005-11-26 21:29:31 +00:00
Wez Furlong
ab6a675131 going to release 1.0.1 2005-11-26 21:22:49 +00:00
Wez Furlong
426fb96cc9 Doh, need to canonicalize parameter names (by prefixing with :) before
attempting to remap them to positional args.
2005-11-26 21:20:52 +00:00
Wez Furlong
85ad81736c set to 1.0 stable. 2005-11-26 20:50:08 +00:00
foobar
366832fbd2 MFH: Fixed wrong usage of ZEND_EXTENSION_API_NO (these are not Zend exts :) 2005-11-25 16:01:41 +00:00
Wez Furlong
7107105429 Update the TODO list. 2005-11-25 07:23:55 +00:00
Wez Furlong
17f504a0ec actually, bytea is not required for LOBs in postgres; good! 2005-11-25 03:37:01 +00:00
Wez Furlong
2256ec00ef PDO support for LOBs in the postgres driver currently assumes bytea columns. 2005-11-25 03:24:32 +00:00
Wez Furlong
2618322506 Bug: when stringify fetch mode is on, and the driver returns a string instead
of a stream for a LOB parameter, PDO would incorrectly return NULL for that
column.
2005-11-25 03:23:17 +00:00
Wez Furlong
c2d53719c2 Fix for #35332.
The problem is caused by the user mixing positional and named parameters.
PDO was blindly adding the parameters, unaware that the same parameters were
already allocated by position.

What we do now is register the parameter with the driver before adding it to
any hash.  This gives the driver an opportunity to normalize the name and
parameter number.  PDO can then ensure that only one entry is occupied in the
hash for a given parameter.
2005-11-25 00:29:04 +00:00
Wez Furlong
bb2f034eff well, what do you know, it does do something. 2005-11-25 00:20:12 +00:00
Wez Furlong
94ab6069b8 prep for release 2005-11-24 22:25:37 +00:00
Wez Furlong
dfdd1e4caf CLASSTYPE is an internal flag.
Closes PECL #5640.
2005-11-24 21:46:56 +00:00
Wez Furlong
2814b749ec Fix PECL Bug #6014; config fails on PHP 5.0.3 2005-11-24 21:38:09 +00:00
Ilia Alshanetsky
8e49bacf95 Fixed bug #35358 (Incorrect error messages for PDO class constants). 2005-11-24 16:21:43 +00:00
Ilia Alshanetsky
4020933726 Fixed bug #35303 (PDO prepare() crashes with invalid parameters). 2005-11-20 20:06:28 +00:00
Antony Dovgal
493c9fcf93 MFH: fix #35293 (PDO segfaults when using persistent connections) 2005-11-19 16:41:08 +00:00
Wez Furlong
0bd9518f8c Closes PECL #5944; binding an invalid parameter can lead to segfaults.
Modified patch provided by curt@php.net.
2005-11-16 06:32:33 +00:00
Ilia Alshanetsky
8e2de517bb Fixed bug #35135 (PDOStatment without related PDO object may crash). 2005-11-07 16:53:15 +00:00
Wez Furlong
58a14f225d Prep for PECL release 2005-11-01 02:44:11 +00:00
Marcus Boerger
24a80c3ebf - Fix remaining memleaks
# all tests pass for me now for the first time in:
# pgsql, mysql, sqlite, sqlite2
2005-10-31 07:47:40 +00:00
Wez Furlong
b74698f135 fix misinterpretation of data when overriding types via bindColumn.
Very slightly modified patch from Marcus.
2005-10-31 03:23:38 +00:00
Wez Furlong
40c24a65c4 improve test portability.
improve infrastructure for LOB support.
2005-10-31 02:07:38 +00:00
Marcus Boerger
e7494a7e9e - Fix memleak 2005-10-30 22:17:52 +00:00
Wez Furlong
0139cd0e53 Closes PECL Bug #5772; FETCH_FUNC broken for mixed case function names 2005-10-29 03:11:46 +00:00
Wez Furlong
7af8089096 Closes PECL #5809; PDOStatement::execute(array(...)) would modify its args.
It should behave like bindValue() not bindParam().
2005-10-29 03:01:19 +00:00
Wez Furlong
588d88960c clean up the test2 table that some tests create 2005-10-29 02:58:24 +00:00
Antony Dovgal
a9cac89541 MFH: commit forgotten part 2005-10-27 19:39:38 +00:00
Wez Furlong
dcd7879556 fixes PECL Bug #5589 2005-10-27 03:51:23 +00:00
Dan Scott
97ec02ce81 Test PDO::ATTR_CASE attribute. 2005-10-26 23:09:06 +00:00
Dan Scott
f987de46b4 Correct non-standard SQL. Standard SQL would define "DEFAULT NULL" -- but
that is the default value if the DEFAULT clause is omitted anyways.
2005-10-26 06:23:12 +00:00
Antony Dovgal
2af3190a3d use correct enum type for the arg 2005-10-25 16:02:33 +00:00
Ilia Alshanetsky
6b46a441cd Fixed compiler warning 2005-10-25 03:53:25 +00:00
Wez Furlong
ea544cf38f Closes PECL Bug #5750; uri: dsn is not handled correctly.
Patch from curt@php.net
2005-10-23 04:10:20 +00:00
Marcus Boerger
001f506533 - MFH SPL example was changed, so change PDO test accordingly 2005-10-13 19:49:59 +00:00
Marcus Boerger
491674bea6 - Do not try to autoload the class, use internal only 2005-10-13 18:37:19 +00:00
Ilia Alshanetsky
a5fe9808aa MFH: Fixed bug #34809 (FETCH_INTO in PDO crashes without a destination object). 2005-10-10 14:44:16 +00:00
Marcus Boerger
470da4e960 - MFH Add new test 2005-10-07 23:23:44 +00:00
Antony Dovgal
b33c2d9b17 nuke unused variable 2005-10-05 22:17:38 +00:00
Derick Rethans
3abc925a8a - Committing some changes that make PDO+SPL not crash anymore. These are done
by Marcus. and I'm committing them in order to actually use PHP 5.1 without
segfaulting when apache starts. This is not necessary the best solution.
2005-10-05 13:51:46 +00:00
Marcus Boerger
0a50368580 - Add optional dep for SPL under windows too 2005-10-04 07:47:11 +00:00
Marcus Boerger
4d631ec31b - Add optional dependency to SPL 2005-10-04 07:44:56 +00:00
Antony Dovgal
ffe605f2ed free cls_methods correctly and fix segfault on shutdown
(no bug entry and MFB, though..)
2005-10-03 23:27:26 +00:00