Do NOT allow install packages with errors in its description file

This commit is contained in:
Tomas V.V.Cox 2002-06-19 22:51:29 +00:00
parent 010e5e60ac
commit fa2ee37313

View File

@ -182,7 +182,8 @@ class PEAR_Installer extends PEAR_Common
$this->source_files++;
return;
default:
break;
// Files with no role will end in "/"
return $this->raiseError("Invalid role `$atts[role]' for file $file");
}
if (!empty($atts['baseinstalldir'])) {
$dest_dir .= DIRECTORY_SEPARATOR . $atts['baseinstalldir'];
@ -394,6 +395,12 @@ class PEAR_Installer extends PEAR_Common
if (PEAR::isError($pkginfo)) {
return $pkginfo;
}
$this->validatePackageInfo($pkginfo, $errors, $warnings);
// XXX We allow warnings, have we to do it?
if (count($errors)) {
return $this->raiseError("The following errors where found:\n".
implode("\n", $errors));
}
$pkgname = $pkginfo['package'];