clones/php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2024-09-22 02:17:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixed bug #29821 (Fixed possible crashes in convert_uudecode() on invalid

Browse Source 
data).
This commit is contained in:
Ilia Alshanetsky 2004-08-24 15:25:48 +00:00
parent 53d0c7a753
commit f95c1df583
1 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
ext/standard/uuencode.c
View File

@ -136,9 +136,18 @@ PHPAPI int php_uudecode(char *src, int src_len, char **dest)
if ((len = PHP_UU_DEC(*s++)) <= 0) {
break;
}
/* sanity check */
if (len > src_len) {
goto err;
}
total_len += len;
ee = s + (len == 45 ? 60 : (int) floor(len * 1.33));
/* sanity check */
if (ee > e) {
goto err;
}
while (s < ee) {
*p++ = PHP_UU_DEC(*s) << 2 | PHP_UU_DEC(*(s + 1)) >> 4;
@ -168,6 +177,10 @@ PHPAPI int php_uudecode(char *src, int src_len, char **dest)
*(*dest + total_len) = '\0';
return total_len;
err:
efree(*dest);
return -1;
}
/* {{{ proto string uuencode(string data)
@ -199,6 +212,10 @@ PHP_FUNCTION(convert_uudecode)
}
dst_len = php_uudecode(src, src_len, &dst);
if (dst_len < 0) {
php_error_docref(NULL TSRMLS_CC, E_WARNING, "The given parameter is not a valid uuencoded string.");
RETURN_FALSE;
}
RETURN_STRINGL(dst, dst_len, 0);
}