clones/php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2024-09-21 09:57:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

[skip ci] Improve inheritance checked comment

Browse Source 
zend_can_early_bind() might have already detected that the methods are
incompatible. In that case the class is still early bound, but must compile
error when inheritance is performed. Thus it is only safe to skip compatibility
checks when zend_can_early_bind() has succeeded.
This commit is contained in:
Ilija Tovilo 2023-06-29 09:34:03 +02:00
parent 5723fa2275
commit ee4ebab5a9
No known key found for this signature in database
GPG Key ID: A4F5D403F118200A
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
Zend/zend_inheritance.c
View File

@ -1066,9 +1066,8 @@ static void perform_delayable_implementation_check(
}
/**
* @param check_only Set to false to throw compile errors on incompatible methods, or true to return
* INHERITANCE_ERROR.
* @param checked Whether the compatibility check has already been performed by zend_can_early_bind().
* @param check_only Set to false to throw compile errors on incompatible methods, or true to return INHERITANCE_ERROR.
* @param checked Whether the compatibility check has already succeeded in zend_can_early_bind().
*/
static zend_always_inline inheritance_status do_inheritance_check_on_method_ex(
zend_function *child, zend_class_entry *child_scope,