clones/php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2024-10-01 14:56:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge branch 'PHP-5.5' into PHP-5.6

Browse Source
This commit is contained in:
Xinchen Hui 2015-02-15 22:55:42 +08:00
commit edd16831b1
2 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
ext/readline/readline.c
View File

@ -400,12 +400,13 @@ PHP_FUNCTION(readline_read_history)
return;
}
if (php_check_open_basedir(arg TSRMLS_CC)) {
if (arg && php_check_open_basedir(arg TSRMLS_CC)) {
RETURN_FALSE;
}
/* XXX from & to NYI */
if (read_history(arg)) {
/* If filename is NULL, then read from `~/.history' */
RETURN_FALSE;
} else {
RETURN_TRUE;
@ -424,7 +425,7 @@ PHP_FUNCTION(readline_write_history)
return;
}
if (php_check_open_basedir(arg TSRMLS_CC)) {
if (arg && php_check_open_basedir(arg TSRMLS_CC)) {
RETURN_FALSE;
}

11
ext/readline/tests/bug69054.phpt Normal file
View File

@ -0,0 +1,11 @@
--TEST--
Bug #69054 (Null dereference in readline_(read|write)_history() without parameters)
--SKIPIF--
<?php if (!extension_loaded("readline") || !function_exists('readline_add_history')) die("skip"); ?>
--INI--
open_basedir=/tmp
--FILE--
<?php readline_read_history(); ?>
==DONE==
--EXPECT--
==DONE==