mirror of
https://github.com/php/php-src.git
synced 2024-09-21 09:57:23 +00:00
Don't skip tests which are supposed to fail; mark them as xfail (#15472)
Especially regarding buggy server behavior, we should not skip those tests, because it is unlikely that fixes to the server's behavior will even be noticed. Instead we mark these tests as xfail, so we get a warning if the test succeeds, and can act appropriately.
This commit is contained in:
parent
7a9120e5f3
commit
ed2b45603c
@ -5,8 +5,9 @@ mysqli
|
||||
--SKIPIF--
|
||||
<?php
|
||||
require_once 'skipifconnectfailure.inc';
|
||||
die("skip - is the server still buggy?");
|
||||
?>
|
||||
--XFAIL--
|
||||
The server is still buggy
|
||||
--INI--
|
||||
max_execution_time=240
|
||||
--FILE--
|
||||
|
@ -5,8 +5,9 @@ mysqli
|
||||
--SKIPIF--
|
||||
<?php
|
||||
require_once 'skipifconnectfailure.inc';
|
||||
die("skip - is the server still buggy?");
|
||||
?>
|
||||
--XFAIL--
|
||||
The server is still buggy
|
||||
--FILE--
|
||||
<?php
|
||||
require_once 'connect.inc';
|
||||
|
@ -5,8 +5,9 @@ mysqli
|
||||
--SKIPIF--
|
||||
<?php
|
||||
require_once 'skipifconnectfailure.inc';
|
||||
die("SKIP: prefetch isn't supported at the moment");
|
||||
?>
|
||||
--XFAIL--
|
||||
prefetch isn't supported at the moment
|
||||
--FILE--
|
||||
<?php
|
||||
require 'table.inc';
|
||||
|
@ -5,9 +5,9 @@ mysqli
|
||||
--SKIPIF--
|
||||
<?php
|
||||
require_once 'skipifconnectfailure.inc';
|
||||
|
||||
die("skip Check again when the Klingons visit earth - http://bugs.mysql.com/bug.php?id=42490");
|
||||
?>
|
||||
--XFAIL--
|
||||
http://bugs.mysql.com/bug.php?id=42490
|
||||
--FILE--
|
||||
<?php
|
||||
require 'table.inc';
|
||||
|
Loading…
Reference in New Issue
Block a user