From 768c34e7cd4a7d9f7290825e887cb90fa0b137cc Mon Sep 17 00:00:00 2001 From: Christopher Jones Date: Fri, 23 Aug 2013 08:13:59 -0700 Subject: [PATCH 1/2] Update NEWS --- NEWS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/NEWS b/NEWS index 1218c5069ab..d73cf3e997f 100644 --- a/NEWS +++ b/NEWS @@ -3,6 +3,8 @@ PHP NEWS ?? ??? 2013, PHP 5.4.20 - Core: + . Fixed bug #65490 (Duplicate calls to get lineno & filename for + DTRACE_FUNCTION_*). (Chris Jones) . Fixed bug #65481 (shutdown segfault due to serialize) (Mike) . Fixed bug #65470 (Segmentation fault in zend_error() with --enable-dtrace). (Chris Jones, Kris Van Hees) From 3f9af558e78c9904f72933dfb3c735a9d2119b52 Mon Sep 17 00:00:00 2001 From: Michael M Slusarz Date: Tue, 20 Aug 2013 01:07:26 -0600 Subject: [PATCH 2/2] Fix #65483: quoted-printable encode stream filter incorrectly encoding spaces --- NEWS | 2 ++ ext/standard/filters.c | 4 +++- ext/standard/tests/streams/bug65483.phpt | 19 +++++++++++++++++++ 3 files changed, 24 insertions(+), 1 deletion(-) create mode 100644 ext/standard/tests/streams/bug65483.phpt diff --git a/NEWS b/NEWS index d73cf3e997f..ef046fd7944 100644 --- a/NEWS +++ b/NEWS @@ -5,6 +5,8 @@ PHP NEWS - Core: . Fixed bug #65490 (Duplicate calls to get lineno & filename for DTRACE_FUNCTION_*). (Chris Jones) + . Fixed bug #65483 (quoted-printable encode stream filter incorrectly encoding + spaces). (Michael M Slusarz) . Fixed bug #65481 (shutdown segfault due to serialize) (Mike) . Fixed bug #65470 (Segmentation fault in zend_error() with --enable-dtrace). (Chris Jones, Kris Van Hees) diff --git a/ext/standard/filters.c b/ext/standard/filters.c index 0a590396358..15dae1bee69 100644 --- a/ext/standard/filters.c +++ b/ext/standard/filters.c @@ -951,7 +951,9 @@ static php_conv_err_t php_conv_qprint_encode_convert(php_conv_qprint_encode *ins *(pd++) = qp_digits[(c & 0x0f)]; ocnt -= 3; line_ccnt -= 3; - trail_ws--; + if (trail_ws > 0) { + trail_ws--; + } CONSUME_CHAR(ps, icnt, lb_ptr, lb_cnt); } } diff --git a/ext/standard/tests/streams/bug65483.phpt b/ext/standard/tests/streams/bug65483.phpt new file mode 100644 index 00000000000..d214bbbbcc4 --- /dev/null +++ b/ext/standard/tests/streams/bug65483.phpt @@ -0,0 +1,19 @@ +--TEST-- +Bug #65483: quoted-printable encode stream filter incorrectly encoding spaces +--FILE-- + +--EXPECT-- +string(9) "a b=3Dc d"