clones/php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2024-09-22 10:27:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix php cli (-S option) inconsistent port parsing

Browse Source 
Add port range verification of listening port with -S option for the php cli.
This fixes inconsistent listening port due to unverified cast from long to short
with htons(3).
This commit is contained in:
nil0x42 2014-07-11 19:48:03 +02:00 committed by Stanislav Malyshev
parent f75da60b18
commit a87300241f
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
sapi/cli/php_cli_server.c
View File

@ -2257,7 +2257,7 @@ static int php_cli_server_ctor(php_cli_server *server, const char *addr, const c
*p++ = '\0';
if (*p == ':') {
port = strtol(p + 1, &p, 10);
if (port <= 0) {
if (port <= 0 || port > 65535) {
p = NULL;
}
} else if (*p != '\0') {
@ -2273,7 +2273,7 @@ static int php_cli_server_ctor(php_cli_server *server, const char *addr, const c
if (p) {
*p++ = '\0';
port = strtol(p, &p, 10);
if (port <= 0) {
if (port <= 0 || port > 65535) {
p = NULL;
}
}