clones/php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2024-09-21 01:47:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

Upload callgrind profile to GA (#12212)

Browse Source
This commit is contained in:
Ilija Tovilo 2023-09-14 19:52:31 +02:00 committed by GitHub
parent e5252a3f4d
commit 6349b293e7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 22 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
.github/workflows/push.yml vendored
View File

@ -288,3 +288,8 @@ jobs:
${{ github.sha }} \
$(git merge-base ${{ github.event.pull_request.base.sha }} ${{ github.sha }}) \
> $GITHUB_STEP_SUMMARY
- uses: actions/upload-artifact@v3
with:
name: profiles
path: ${{ github.workspace }}/benchmark/profiles
retention-days: 30

1
benchmark/.gitignore vendored
View File

@ -1 +1,2 @@
/profiles
/repos

20
benchmark/benchmark.php
View File

@ -12,6 +12,11 @@ if (!file_exists($phpCgi)) {
function main() {
global $storeResult;
$profilesDir = __DIR__ . '/profiles';
if (!is_dir($profilesDir)) {
mkdir($profilesDir, 0755, true);
}
$data = [];
if (false !== $branch = getenv('GITHUB_REF_NAME')) {
$data['branch'] = $branch;
@ -50,7 +55,7 @@ function getPhpSrcCommitHash(): string {
}
function runBench(bool $jit): array {
return runValgrindPhpCgiCommand([dirname(__DIR__) . '/Zend/bench.php'], jit: $jit);
return runValgrindPhpCgiCommand('bench', [dirname(__DIR__) . '/Zend/bench.php'], jit: $jit);
}
function runSymfonyDemo(bool $jit): array {
@ -58,7 +63,7 @@ function runSymfonyDemo(bool $jit): array {
cloneRepo($dir, 'https://github.com/php/benchmarking-symfony-demo-2.2.3.git');
runPhpCommand([$dir . '/bin/console', 'cache:clear']);
runPhpCommand([$dir . '/bin/console', 'cache:warmup']);
return runValgrindPhpCgiCommand([$dir . '/public/index.php'], cwd: $dir, jit: $jit, warmup: 50, repeat: 50);
return runValgrindPhpCgiCommand('symfony-demo', [$dir . '/public/index.php'], cwd: $dir, jit: $jit, warmup: 50, repeat: 50);
}
function runWordpress(bool $jit): array {
@ -81,7 +86,7 @@ function runWordpress(bool $jit): array {
// Warmup
runPhpCommand([$dir . '/index.php'], $dir);
return runValgrindPhpCgiCommand([$dir . '/index.php'], cwd: $dir, jit: $jit, warmup: 50, repeat: 50);
return runValgrindPhpCgiCommand('wordpress', [$dir . '/index.php'], cwd: $dir, jit: $jit, warmup: 50, repeat: 50);
}
function runPhpCommand(array $args, ?string $cwd = null): ProcessResult {
@ -89,6 +94,7 @@ function runPhpCommand(array $args, ?string $cwd = null): ProcessResult {
}
function runValgrindPhpCgiCommand(
string $name,
array $args,
?string $cwd = null,
bool $jit = false,
@ -96,11 +102,17 @@ function runValgrindPhpCgiCommand(
int $repeat = 1,
): array {
global $phpCgi;
$profileOut = __DIR__ . "/profiles/callgrind.out.$name";
if ($jit) {
$profileOut .= '.jit';
}
$process = runCommand([
'valgrind',
'--tool=callgrind',
'--dump-instr=yes',
'--callgrind-out-file=/dev/null',
"--callgrind-out-file=$profileOut",
'--',
$phpCgi,
'-T' . ($warmup ? $warmup . ',' : '') . $repeat,