clones/php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2024-09-22 10:27:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix shift UB in hash_snefru

Browse Source
This commit is contained in:
Nikita Popov 2019-06-19 15:55:56 +02:00
parent 88b603768f
commit 555d68be10
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ext/hash/hash_snefru.c
View File

@ -123,8 +123,8 @@ static inline void SnefruTransform(PHP_SNEFRU_CTX *context, const unsigned char
int i, j;
for (i = 0, j = 0; i < 32; i += 4, ++j) {
context->state[8+j] = ((input[i] & 0xff) << 24) | ((input[i+1] & 0xff) << 16) |
((input[i+2] & 0xff) << 8) | (input[i+3] & 0xff);
context->state[8+j] = ((unsigned)input[i] << 24) | ((unsigned)input[i+1] << 16) |
((unsigned)input[i+2] << 8) | (unsigned)input[i+3];
}
Snefru(context->state);
ZEND_SECURE_ZERO(&context->state[8], sizeof(uint32_t) * 8);