clones/php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2024-09-21 09:57:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

standard: Stop using php_combined_lcg() in uniqid() (#15217)

Browse Source 
Fall back to the fallback generator if the CSPRNG fails instead. This removes
the last internal user of `php_combined_lcg()`.
This commit is contained in:
Tim Düsterhus 2024-08-04 18:26:40 +02:00 committed by GitHub
parent 6910167c48
commit 49d0d7bcd7
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
ext/standard/uniqid.c
View File

@ -75,10 +75,9 @@ PHP_FUNCTION(uniqid)
uint32_t bytes;
double seed;
if (php_random_bytes_silent(&bytes, sizeof(uint32_t)) == FAILURE) {
seed = php_combined_lcg() * 10;
} else {
seed = ((double) bytes / UINT32_MAX) * 10.0;
bytes = php_random_generate_fallback_seed();
}
seed = ((double) bytes / UINT32_MAX) * 10.0;
uniqid = strpprintf(0, "%s%08x%05x%.8F", prefix, sec, usec, seed);
} else {
uniqid = strpprintf(0, "%s%08x%05x", prefix, sec, usec);