mirror of
https://github.com/php/php-src.git
synced 2024-09-21 01:47:25 +00:00
Fix GH-15901: phpdbg: Assertion failure on i funcs
New hash tables are not automatically packed, so we must not treat them as such. Therefore we guard the foreach appropriately. Closes GH-15929.
This commit is contained in:
parent
b26e610777
commit
422aa17b9b
3
NEWS
3
NEWS
@ -12,6 +12,9 @@ PHP NEWS
|
||||
. Fixed regression where signs after the first one were ignored while parsing
|
||||
a signed integer, with the DateTimeInterface::modify() function. (Derick)
|
||||
|
||||
- PHPDBG:
|
||||
. Fixed bug GH-15901 (phpdbg: Assertion failure on i funcs). (cmb)
|
||||
|
||||
- SimpleXML:
|
||||
. Fixed bug GH-15837 (Segmentation fault in ext/simplexml/simplexml.c).
|
||||
(nielsdos)
|
||||
|
@ -399,27 +399,29 @@ PHPDBG_INFO(classes) /* {{{ */
|
||||
phpdbg_notice("User Classes (%d)", zend_hash_num_elements(&classes));
|
||||
|
||||
/* once added, assume that classes are stable... until shutdown. */
|
||||
ZEND_HASH_PACKED_FOREACH_PTR(&classes, ce) {
|
||||
phpdbg_print_class_name(ce);
|
||||
if (HT_IS_INITIALIZED(&classes)) {
|
||||
ZEND_HASH_PACKED_FOREACH_PTR(&classes, ce) {
|
||||
phpdbg_print_class_name(ce);
|
||||
|
||||
if (ce->parent) {
|
||||
if (ce->ce_flags & ZEND_ACC_LINKED) {
|
||||
zend_class_entry *pce = ce->parent;
|
||||
do {
|
||||
phpdbg_out("|-------- ");
|
||||
phpdbg_print_class_name(pce);
|
||||
} while ((pce = pce->parent));
|
||||
} else {
|
||||
phpdbg_writeln("|-------- User Class %s (not yet linked because declaration for parent was not encountered when declaring the class)", ZSTR_VAL(ce->parent_name));
|
||||
if (ce->parent) {
|
||||
if (ce->ce_flags & ZEND_ACC_LINKED) {
|
||||
zend_class_entry *pce = ce->parent;
|
||||
do {
|
||||
phpdbg_out("|-------- ");
|
||||
phpdbg_print_class_name(pce);
|
||||
} while ((pce = pce->parent));
|
||||
} else {
|
||||
phpdbg_writeln("|-------- User Class %s (not yet linked because declaration for parent was not encountered when declaring the class)", ZSTR_VAL(ce->parent_name));
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
if (ce->info.user.filename) {
|
||||
phpdbg_writeln("|---- in %s on line %u", ZSTR_VAL(ce->info.user.filename), ce->info.user.line_start);
|
||||
} else {
|
||||
phpdbg_writeln("|---- no source code");
|
||||
}
|
||||
} ZEND_HASH_FOREACH_END();
|
||||
if (ce->info.user.filename) {
|
||||
phpdbg_writeln("|---- in %s on line %u", ZSTR_VAL(ce->info.user.filename), ce->info.user.line_start);
|
||||
} else {
|
||||
phpdbg_writeln("|---- no source code");
|
||||
}
|
||||
} ZEND_HASH_FOREACH_END();
|
||||
}
|
||||
|
||||
zend_hash_destroy(&classes);
|
||||
|
||||
@ -445,17 +447,19 @@ PHPDBG_INFO(funcs) /* {{{ */
|
||||
|
||||
phpdbg_notice("User Functions (%d)", zend_hash_num_elements(&functions));
|
||||
|
||||
ZEND_HASH_PACKED_FOREACH_PTR(&functions, zf) {
|
||||
zend_op_array *op_array = &zf->op_array;
|
||||
if (HT_IS_INITIALIZED(&functions)) {
|
||||
ZEND_HASH_PACKED_FOREACH_PTR(&functions, zf) {
|
||||
zend_op_array *op_array = &zf->op_array;
|
||||
|
||||
phpdbg_write("|-------- %s", op_array->function_name ? ZSTR_VAL(op_array->function_name) : "{main}");
|
||||
phpdbg_write("|-------- %s", op_array->function_name ? ZSTR_VAL(op_array->function_name) : "{main}");
|
||||
|
||||
if (op_array->filename) {
|
||||
phpdbg_writeln(" in %s on line %d", ZSTR_VAL(op_array->filename), op_array->line_start);
|
||||
} else {
|
||||
phpdbg_writeln(" (no source code)");
|
||||
}
|
||||
} ZEND_HASH_FOREACH_END();
|
||||
if (op_array->filename) {
|
||||
phpdbg_writeln(" in %s on line %d", ZSTR_VAL(op_array->filename), op_array->line_start);
|
||||
} else {
|
||||
phpdbg_writeln(" (no source code)");
|
||||
}
|
||||
} ZEND_HASH_FOREACH_END();
|
||||
}
|
||||
|
||||
zend_hash_destroy(&functions);
|
||||
|
||||
|
10
sapi/phpdbg/tests/gh15901.phpt
Normal file
10
sapi/phpdbg/tests/gh15901.phpt
Normal file
@ -0,0 +1,10 @@
|
||||
--TEST--
|
||||
GH-15901 (phpdbg: Assertion failure on `i funcs`)
|
||||
--PHPDBG--
|
||||
i funcs
|
||||
i classes
|
||||
--EXPECT--
|
||||
prompt> [User Functions (0)]
|
||||
prompt> [User Classes (0)]
|
||||
prompt> [User Classes (0)]
|
||||
prompt>
|
Loading…
Reference in New Issue
Block a user