mirror of
https://github.com/librenms/librenms.git
synced 2024-09-22 02:48:37 +00:00
1f19eb2146
* Update cisco-sla.inc.php Fix SQL error during discovery of cisco-sla. This error points to /opt/librenms/includes/discovery/cisco-sla.inc.php(80). LOG ERROR: [2019-06-18 07:07:01] production.ERROR: SQLSTATE[HY093]: Invalid parameter number: mixed named and positional parameters (SQL: UPDATE slas set device_id=39,sla_nr=1,owner=,tag=xxx.xxx.xxx.xxx,rtt_type=echo,status=1,opstatus=0,deleted=0 WHERE sla_id = 5) (SQL: UPDATE slas set device_id=39,sla_nr=1,owner=,tag=xxx.xxx.xxx.xxx,rtt_type=echo,status=1,opstatus=0,deleted=0 WHERE sla_id = 5)#0 /opt/librenms/includes/discover y/cisco-sla.inc.php(80): dbUpdate(Array, ‘slas’, ’sla_id = :sla…’, Array) #1 /opt/librenms/includes/discovery/functions.inc.php(179): include(’/opt/librenms/i…’) #2 /opt/librenms/discovery.php(120): discover_device(Array, false) #3 {main} I suggest to change this lines of code in cisco-sla.inc.php to avoid this error: line 80: dbUpdate($data, ‘slas’, ’sla_id = :sla_id’, array(‘sla_id’ => $sla_id)); change to: dbUpdate($data, ‘slas’, ’sla_id = ?’, array($sla_id)); line 87: dbUpdate(array(‘deleted’ => 1), ‘slas’, ’sla_id = :sla_id’, array(‘sla_id’ => $existing_sla)); change to: dbUpdate(array(‘deleted’ => 1), ‘slas’, ’sla_id = ?’, array($existing_sla)); * Fix quotes * Missed one
93 lines
3.2 KiB
PHP
93 lines
3.2 KiB
PHP
<?php
|
|
|
|
use LibreNMS\Config;
|
|
use LibreNMS\Util\IP;
|
|
|
|
if (Config::get('enable_sla') && $device['os_group'] == 'cisco') {
|
|
$slas = snmp_walk($device, 'ciscoRttMonMIB.ciscoRttMonObjects.rttMonCtrl', '-Osq', '+CISCO-RTTMON-MIB');
|
|
|
|
$sla_table = array();
|
|
foreach (explode("\n", $slas) as $sla) {
|
|
$key_val = explode(' ', $sla, 2);
|
|
if (count($key_val) != 2) {
|
|
$key_val[] = '';
|
|
}
|
|
|
|
$key = $key_val[0];
|
|
$value = $key_val[1];
|
|
|
|
$prop_id = explode('.', $key);
|
|
if ((count($prop_id) != 2) || !ctype_digit($prop_id[1])) {
|
|
continue;
|
|
}
|
|
|
|
$property = $prop_id[0];
|
|
$id = intval($prop_id[1]);
|
|
|
|
$sla_table[$id][$property] = trim($value);
|
|
}
|
|
|
|
// var_dump($sla_table);
|
|
// Get existing SLAs
|
|
$existing_slas = dbFetchColumn('SELECT `sla_id` FROM `slas` WHERE `device_id` = :device_id AND `deleted` = 0', array('device_id' => $device['device_id']));
|
|
|
|
foreach ($sla_table as $sla_nr => $sla_config) {
|
|
$query_data = array(
|
|
'device_id' => $device['device_id'],
|
|
'sla_nr' => $sla_nr,
|
|
);
|
|
$sla_id = dbFetchCell('SELECT `sla_id` FROM `slas` WHERE `device_id` = :device_id AND `sla_nr` = :sla_nr', $query_data);
|
|
|
|
$data = array(
|
|
'device_id' => $device['device_id'],
|
|
'sla_nr' => $sla_nr,
|
|
'owner' => $sla_config['rttMonCtrlAdminOwner'],
|
|
'tag' => $sla_config['rttMonCtrlAdminTag'],
|
|
'rtt_type' => $sla_config['rttMonCtrlAdminRttType'],
|
|
'status' => ($sla_config['rttMonCtrlAdminStatus'] == 'active') ? 1 : 0,
|
|
'opstatus' => ($sla_config['rttMonLatestRttOperSense'] == 'ok') ? 0 : 2,
|
|
'deleted' => 0,
|
|
);
|
|
|
|
// Some fallbacks for when the tag is empty
|
|
if (!$data['tag']) {
|
|
switch ($data['rtt_type']) {
|
|
case 'http':
|
|
$data['tag'] = $sla_config['rttMonEchoAdminURL'];
|
|
break;
|
|
|
|
case 'dns':
|
|
$data['tag'] = $sla_config['rttMonEchoAdminTargetAddressString'];
|
|
break;
|
|
|
|
case 'echo':
|
|
$data['tag'] = IP::fromHexString($sla_config['rttMonEchoAdminTargetAddress'], true);
|
|
break;
|
|
|
|
case 'jitter':
|
|
$data['tag'] = $sla_config['rttMonEchoAdminCodecType'] ." (". preg_replace('/milliseconds/', 'ms', $sla_config['rttMonEchoAdminCodecInterval']) .")";
|
|
break;
|
|
}//end switch
|
|
}//end if
|
|
|
|
if (!$sla_id) {
|
|
$sla_id = dbInsert($data, 'slas');
|
|
echo '+';
|
|
} else {
|
|
// Remove from the list
|
|
$existing_slas = array_diff($existing_slas, array($sla_id));
|
|
|
|
dbUpdate($data, 'slas', 'sla_id = ?', [$sla_id]);
|
|
echo '.';
|
|
}
|
|
}//end foreach
|
|
|
|
// Mark all remaining SLAs as deleted
|
|
foreach ($existing_slas as $existing_sla) {
|
|
dbUpdate(['deleted' => 1], 'slas', 'sla_id = ?', [$existing_sla]);
|
|
echo '-';
|
|
}
|
|
|
|
echo "\n";
|
|
}
|