mirror of
https://github.com/librenms/librenms.git
synced 2024-09-22 02:48:37 +00:00
df16de9d2f
* Datastores to object oriented code, using the Laravel IoC container Change instantiation better DI move OpenTSDB Small re-orgs remove unused stuff Fix graphs and other scripts Use DI for all except rrd fix up connection error handling Add tests, fix up a "few" things Add Config::forget() Style fixes Don't reference legacy code remove accidental code paste Add datastores phpunit groups some tests * rebase fixes * some test fixes * shorter tests * shorter tests * Don't except when rrdtool can't be started. * restore tests * fix rrd tests * fix iterable change upstream * fix isValidDataset * fix invalid data bug * fix mysql incorrect ds * fix issue with data that is too long * use regular data_update() * Use log facade * OpenTSDB mis-ordered arguments fix * Making a singleton with different options makes different singletons. Just use the global config settings to disable datastores. * only filter tags for datastores that won't it don't modify the tags permanently * Update copyrights to include original authors. * Stats for all datastores * Fix mysql sends different rrd / other ds names * fix snmp last stats not initialized remove unused function * remove unused function and move single use function closer to its use * InfluxDB does not need to update null or U values. Skip write if all fields are empty * Fix smart value checks * fix style issues * Make sure port data is stored the same way as before for Graphite and OpenTSDB Add ifIndex tag to all to be compatible * Missed rrdtool_tune() call * Test update WIP * OpenTSDB now includes tags * fix style
111 lines
3.9 KiB
PHP
111 lines
3.9 KiB
PHP
<?php
|
|
/**
|
|
* RrdtoolTest.php
|
|
*
|
|
* Tests functionality of our rrdtool wrapper
|
|
*
|
|
* This program is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*
|
|
* @package LibreNMS
|
|
* @link http://librenms.org
|
|
* @copyright 2016 Tony Murray
|
|
* @author Tony Murray <murraytony@gmail.com>
|
|
*/
|
|
|
|
namespace LibreNMS\Tests;
|
|
|
|
use LibreNMS\Config;
|
|
use LibreNMS\Data\Store\Rrd;
|
|
|
|
class RrdtoolTest extends TestCase
|
|
{
|
|
|
|
public function testBuildCommandLocal()
|
|
{
|
|
Config::set('rrdcached', '');
|
|
Config::set('rrdtool_version', '1.4');
|
|
Config::set('rrd_dir', '/opt/librenms/rrd');
|
|
|
|
$cmd = $this->buildCommandProxy('create', '/opt/librenms/rrd/f', 'o');
|
|
$this->assertEquals('create /opt/librenms/rrd/f o', $cmd);
|
|
|
|
$cmd = $this->buildCommandProxy('tune', '/opt/librenms/rrd/f', 'o');
|
|
$this->assertEquals('tune /opt/librenms/rrd/f o', $cmd);
|
|
|
|
$cmd = $this->buildCommandProxy('update', '/opt/librenms/rrd/f', 'o');
|
|
$this->assertEquals('update /opt/librenms/rrd/f o', $cmd);
|
|
|
|
|
|
$this->app->forgetInstance(Rrd::class);
|
|
Config::set('rrdtool_version', '1.6');
|
|
|
|
$cmd = $this->buildCommandProxy('create', '/opt/librenms/rrd/f', 'o');
|
|
$this->assertEquals('create /opt/librenms/rrd/f o -O', $cmd);
|
|
|
|
$cmd = $this->buildCommandProxy('tune', '/opt/librenms/rrd/f', 'o');
|
|
$this->assertEquals('tune /opt/librenms/rrd/f o', $cmd);
|
|
|
|
$cmd = $this->buildCommandProxy('update', '/opt/librenms/rrd/f', 'o');
|
|
$this->assertEquals('update /opt/librenms/rrd/f o', $cmd);
|
|
}
|
|
|
|
public function testBuildCommandRemote()
|
|
{
|
|
Config::set('rrdcached', 'server:42217');
|
|
Config::set('rrdtool_version', '1.4');
|
|
Config::set('rrd_dir', '/opt/librenms/rrd');
|
|
|
|
$cmd = $this->buildCommandProxy('create', '/opt/librenms/rrd/f', 'o');
|
|
$this->assertEquals('create /opt/librenms/rrd/f o', $cmd);
|
|
|
|
$cmd = $this->buildCommandProxy('tune', '/opt/librenms/rrd/f', 'o');
|
|
$this->assertEquals('tune /opt/librenms/rrd/f o', $cmd);
|
|
|
|
$cmd = $this->buildCommandProxy('update', '/opt/librenms/rrd/f', 'o');
|
|
$this->assertEquals('update f o --daemon server:42217', $cmd);
|
|
|
|
$this->app->forgetInstance(Rrd::class);
|
|
Config::set('rrdtool_version', '1.6');
|
|
|
|
$cmd = $this->buildCommandProxy('create', '/opt/librenms/rrd/f', 'o');
|
|
$this->assertEquals('create f o -O --daemon server:42217', $cmd);
|
|
|
|
$cmd = $this->buildCommandProxy('tune', '/opt/librenms/rrd/f', 'o');
|
|
$this->assertEquals('tune f o --daemon server:42217', $cmd);
|
|
|
|
$cmd = $this->buildCommandProxy('update', '/opt/librenms/rrd/f', 'o');
|
|
$this->assertEquals('update f o --daemon server:42217', $cmd);
|
|
}
|
|
|
|
public function testBuildCommandException()
|
|
{
|
|
Config::set('rrdcached', '');
|
|
Config::set('rrdtool_version', '1.4');
|
|
|
|
$this->expectException('LibreNMS\Exceptions\FileExistsException');
|
|
// use this file, since it is guaranteed to exist
|
|
$this->buildCommandProxy('create', __FILE__, 'o');
|
|
}
|
|
|
|
private function buildCommandProxy($command, $filename, $options)
|
|
{
|
|
// todo better tests
|
|
$reflection = new \ReflectionClass(Rrd::class);
|
|
$method = $reflection->getMethod('buildCommand');
|
|
$method->setAccessible(true);
|
|
|
|
return $method->invokeArgs($this->app->make(Rrd::class), func_get_args());
|
|
}
|
|
}
|