librenms/database/migrations/2022_07_19_081224_plugins_unique_index.php
Tony Murray 9320e6cd06
Prevent duplicate plugin table entries (#14120)
* Prevent duplicate plugin table entries
Some sort of race condition.
Add a unique index, this will cause the create query to fail when it tries to add a new entry for an existing plugin.

* Add index
2022-07-20 15:25:45 +02:00

46 lines
1.3 KiB
PHP

<?php
use Illuminate\Database\Migrations\Migration;
use Illuminate\Database\Schema\Blueprint;
use Illuminate\Support\Facades\Schema;
class PluginsUniqueIndex extends Migration
{
/**
* Run the migrations.
*
* @return void
*/
public function up()
{
// cleanup duplicates
$plugins = DB::table('plugins')->groupBy(['version', 'plugin_name'])->select(['version', 'plugin_name'])->get();
$valid_plugins = [];
foreach ($plugins as $plugin) {
// find the newest id with settings
$valid_plugins[] = DB::table('plugins')
->where(['version' => $plugin->version, 'plugin_name' => $plugin->plugin_name])
->orderBy('settings', 'DESC')
->orderBy('plugin_id', 'DESC')
->value('plugin_id');
}
DB::table('plugins')->whereNotIn('plugin_id', $valid_plugins)->delete();
Schema::table('plugins', function (Blueprint $table) {
$table->unique(['version', 'plugin_name']);
});
}
/**
* Reverse the migrations.
*
* @return void
*/
public function down()
{
Schema::table('plugins', function (Blueprint $table) {
$table->dropUnique('plugins_version_plugin_name_unique');
});
}
}