Commit Graph

39 Commits

Author SHA1 Message Date
Tony Murray
465fa3986a
Fix Undefined variable/key warnings (#14134)
* Fix Undefined variable/key warnings

* massage for test data

* restore set_numeric, only generates noise

* Fix ucd storage used (apparently free is not stored in discovery...)
2022-08-21 16:23:43 -05:00
Tony Murray
f2f169ae78
Modernize mempools (#12282)
* mempools to modern module
quick hacky hrstorage port

* port ucd-snmp-mib to Mempools

* Populate DB for ucd
Prep for yaml

* initial yaml attempt

* more complex conversions
fixes to YamlDiscovery, make leading $ optional and allow mib::oid format

* walk full tables and skip values
normalize percentages above 100

* handle precent only ones (specify total as 100)

* Move default polling out of YamlMempoolsDiscovery

* fixes

* Update test data hrstorage should be correct.

* perc_warn for hrstorage

* Host Resources, record buffer, cached, and shared

* Host Resources is always better, don't do both HR and UCD

* fix unix, include warning levels

* variable size

* consolidate skip_values

* define mempools schema

* number instead of integer

* more schema refactor

* one more skip_values reference

* throw error for invalid oid translation
aos6

* a*  and Cisco

* updated test data

* update almost all hrstorage data files

* b*

* c* with test data
use standard cache for hrStorage

* use cache for storage module too

* hand bsnmp properly

* bdcom

* exclude total oid from yaml so it is not polled
May add a way to ignore this behavior and poll it, but I don't know if that is needed.

* automatically handle percent only values

* ciscowlc

* only poll used or free if we have used, free, and total.

* fix skipping

* the dlinkoning
fix find value when value "name" is numeric

* support numeric oids

* dnos/ftos attempt

* I guess we can't filter on total > 0

* edgecos

* e*

* f WIP

* f*

* gwd (aka g*)

* h* + procurve

* i*

* j*

* m*

* support 0% used memory (however unlikely)

* n*

* CISCO-PROCESS-MIB memory, share cache with processors module

* ignore mempools with invalid total

* p*

* quanta

* r*
fix raisecom mibs terribly broken

* s-z

* style fixes

* Move VRP back to PHP and make it actually work

* fix zynos

* update schema

* Update Cisco processor data for description bug fixes

* fix comware processors

* comware mempools with memory size
default precision to 1

* sophos-xg updated data

* hrstorage use ram size for buffers, cache, and shared

* Show memory available instead of free in device overview

* UCD, use same rrd format, store available instead of free in the db.

* Calculate availability for HOST-RESOURCES-MIB

* Convert UCD to standard polling

* rename old rrd files

* initial graph work

* graph WIP

* Graph looking decent

* Graph looking decent for hr

* remove old ucd_graph code

* handle availability mempool
more graph cleanup

* color adjustments

* remove accidental free calculation

* Update test data and fix corner cases

* fis pfsense

* update schema

* add default value for mempool_class

* fix whitespace

* update schema

* update schema correctly

* one more time

* fortigate_1500d-sensors missing oids

* Update docs.

* fix indent

* add implements MempoolsDiscovery explicitly to OS

* remove ucd_memory graph references
remove unused device_memory graph

* remove unused functions

* set devices with mempools to rediscover to prevent/minimize gaps

* use a subquery

* add overview graph

* port health mempools table

* Update device mempool

* only show overview if multiple

* Don't override user set warn percentages in discovery

* fix missed usage

* fix style

* Safety check to not rename rrd files incorrectly if migration has not been run.

* Fix overview percent bar and represent available and used on the bar

* missed an item to convert to mempool_class

* percent on the wrong side
2020-11-23 15:35:35 -06:00
Jellyfrog
2fc3a21211
Apply fixes from StyleCI (#12121) 2020-09-21 15:43:38 +02:00
Tony Murray
020c5fd7e1
Remove legacy code and fix missing device graphs (#11950)
* removing $graphs global

* remove unused things

* fix some additional graphs

* Fix graphs persisting too soon

* correct name for poller module performance graph

* only one type of graph is used here
2020-07-23 09:57:22 -05:00
SourceDoctor
d32273decd
Graph CPU Steal and IO Wait (#11235) 2020-03-03 13:17:42 +01:00
Tony Murray
fad0bffc43 Escape SNMP & IPMI shell commands (#9537)
hopefully doesn't break anything
Mostly issues with snmp oids and options containing spaces.  Try to remove all of those.

DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`.  If there are schema changes, you can ask on discord how to revert.
2018-12-16 13:42:50 +00:00
István Sárándi
78e3df4dd2 Change UCD max load from 5000 to 50000 (#8769)
* Change max load from 5000 to 50000

Perhaps a load value of 50000% seems excessive, however it can happen. (Example: a heavily loaded compute node with 48 CPU cores that produces loads of ~15000%, printed as 150 by tools htop).

* Remove maximum value for load averages
2018-06-10 21:06:51 +01:00
Neil Lathwood
fad5aca1b7 feature: Allow customisation of rrd step/heartbeat when creating new rrd files (#5947)
* feature: Allow customisation of rrd step/heartbeat when creating new rrd files

* revert defaults

* added docs + webui config option

* Move RrdDefinition to an Object to make them easier to create and remove the possibility of typos.

* Fix style/lint issues and missing use statements

* 3 more missing use statements

* updated doc + moved schema file
2017-02-23 22:45:50 +00:00
Tony Murray
9284bc60ff Update code in includes to be PSR-2 compliant (#4220)
refactor: Update code in /includes to be psr2 compliant #4220
2016-08-28 18:32:58 +01:00
Tony Murray
57650e4ffc Remove nfs requirement for distributed poller (with rrdtool 1.5+)
Use data_update instead of rrd_update/rrd_create and influx_update
Centralize rrd file check so we can check against a remote rrdcached server too
Use rrd_name() to generate rrd file names
2016-07-07 21:10:06 -05:00
laf
7b14aada4e Rebased 2015-10-26 11:08:19 +00:00
f0o
7d95e94954
Fix rrd creation parameters 2015-09-28 08:24:57 +00:00
laf
433562d351 More updates for influx 2015-08-19 20:58:02 +00:00
laf
987634e463 Updated rrdtool_update() to use new array format 2015-08-18 16:26:55 +00:00
Job Snijders
d8693f05ae Fix coding style part 2 2015-07-15 11:04:22 +02:00
Alexander Sosna
5a7988e2e4 chmod 0644 to php files not directly executed 2015-04-28 22:58:03 +02:00
Adam Amstrong
b273e04241 /// -> //
git-svn-id: http://www.observium.org/svn/observer/trunk@3240 61d68cd4-352d-0410-923a-c4978735b2b8
2012-05-25 12:24:34 +00:00
Adam Amstrong
cacf913a55 # -> / for phpdoc
git-svn-id: http://www.observium.org/svn/observer/trunk@3239 61d68cd4-352d-0410-923a-c4978735b2b8
2012-05-25 11:29:53 +00:00
Adam Amstrong
29c70aaefa fix some rrdtool_graph calls to use arrays. add NRG printer support.
git-svn-id: http://www.observium.org/svn/observer/trunk@3187 61d68cd4-352d-0410-923a-c4978735b2b8
2012-05-15 16:50:36 +00:00
Adam Amstrong
2b8178bb5b move all RRA decisions to config. switch mempool/storage to new rrds (sorry, data lost, the old rrds sucked). added some more apps pages.
git-svn-id: http://www.observium.org/svn/observer/trunk@3068 61d68cd4-352d-0410-923a-c4978735b2b8
2012-04-20 17:37:58 +00:00
Adam Amstrong
bd243db6dc potentially break all cisco versioning :P
git-svn-id: http://www.observium.org/svn/observer/trunk@2912 61d68cd4-352d-0410-923a-c4978735b2b8
2012-03-20 16:50:16 +00:00
Adam Amstrong
2383cd1dfe fix adding/removal of graphs (DUH). fix UCD-MIB. (also switch to /new/ format graphs soon? :))
git-svn-id: http://www.observium.org/svn/observer/trunk@2267 61d68cd4-352d-0410-923a-c4978735b2b8
2011-05-08 00:13:58 +00:00
Adam Amstrong
aa29010658 unset lots of things in ucd-mib
git-svn-id: http://www.observium.org/svn/observer/trunk@2214 61d68cd4-352d-0410-923a-c4978735b2b8
2011-05-01 17:33:43 +00:00
Tom Laermans
7bd37c5b06 change from unsalted md5 to salted md5 passwords, migrating passwords as authentication succeeds
git-svn-id: http://www.observium.org/svn/observer/trunk@1936 61d68cd4-352d-0410-923a-c4978735b2b8
2011-03-19 20:23:23 +00:00
Geert Hauwaerts
5b405190e1 - Remove " in sysContact.
- Fix error in ucd-mib polling.


git-svn-id: http://www.observium.org/svn/observer/trunk@1920 61d68cd4-352d-0410-923a-c4978735b2b8
2011-03-18 11:37:50 +00:00
Tom Laermans
ecbcd1db43 clean up polling source files, remove dead code
git-svn-id: http://www.observium.org/svn/observer/trunk@1865 61d68cd4-352d-0410-923a-c4978735b2b8
2011-03-16 01:11:27 +00:00
Tom Laermans
a6c269b206 fix snmp_get_multi calls for ucd-mib
git-svn-id: http://www.observium.org/svn/observer/trunk@1822 61d68cd4-352d-0410-923a-c4978735b2b8
2011-03-11 18:54:51 +00:00
Tom Laermans
b1d60eafd0 git-svn-id: http://www.observium.org/svn/observer/trunk@1817 61d68cd4-352d-0410-923a-c4978735b2b8 2011-03-10 16:00:37 +00:00
Tom Laermans
a199070100 convert more to internal snmp,
polling/os/unix: switch to snmp_get(), reindent, add ARM processors, patch by Corentin Chary

git-svn-id: http://www.observium.org/svn/observer/trunk@1813 61d68cd4-352d-0410-923a-c4978735b2b8
2011-03-10 15:31:57 +00:00
Adam Amstrong
0db6ad08ff vastly improved entity-sensors and cisco-entity-sensors speed. improved entity-mib inventory. removed device_id element from oid caches. add min/max ranges to sensor graphs.
git-svn-id: http://www.observium.org/svn/observer/trunk@1669 61d68cd4-352d-0410-923a-c4978735b2b8
2010-08-11 17:08:56 +00:00
Adam Amstrong
f29e7b755b redesigned graph defining system (still seems a bit batshit, but nevermind). lots of improvements to various pollers, only writing RRDs if valid data is returned, etc.
git-svn-id: http://www.observium.org/svn/observer/trunk@1506 61d68cd4-352d-0410-923a-c4978735b2b8
2010-07-28 19:43:02 +00:00
Adam Amstrong
51098b42b7 improving windows support
git-svn-id: http://www.observium.org/svn/observer/trunk@1465 61d68cd4-352d-0410-923a-c4978735b2b8
2010-07-23 17:43:38 +00:00
Adam Amstrong
e220114f4c add some mibs, update snmp functions
git-svn-id: http://www.observium.org/svn/observer/trunk@1458 61d68cd4-352d-0410-923a-c4978735b2b8
2010-07-22 21:58:49 +00:00
Adam Amstrong
0d0e32159b sexytime updated UCD-MIB collector, and some moving around of graphing code
git-svn-id: http://www.observium.org/svn/observer/trunk@1453 61d68cd4-352d-0410-923a-c4978735b2b8
2010-07-21 02:43:47 +00:00
Adam Amstrong
c22e8493f7 migrate all SNMP calls to use $config['mibdir']. automatically generated from install_dir if not present
git-svn-id: http://www.observium.org/svn/observer/trunk@1284 61d68cd4-352d-0410-923a-c4978735b2b8
2010-07-02 19:58:13 +00:00
Adam Amstrong
8692b82e7a clear $array at the start of each device. ignore fake cpus from net-snmpd. syslog additions.
git-svn-id: http://www.observium.org/svn/observer/trunk@886 61d68cd4-352d-0410-923a-c4978735b2b8
2010-02-19 23:57:50 +00:00
Adam Amstrong
3c11291488 add generic device, hackeryfix hr-mib memory
git-svn-id: http://www.observium.org/svn/observer/trunk@882 61d68cd4-352d-0410-923a-c4978735b2b8
2010-02-17 18:54:34 +00:00
Adam Amstrong
1ab6f3cded updates additions
git-svn-id: http://www.observium.org/svn/observer/trunk@505 61d68cd4-352d-0410-923a-c4978735b2b8
2009-11-09 15:52:04 +00:00
Adam Amstrong
f263850092 add missing files
git-svn-id: http://www.observium.org/svn/observer/trunk@504 61d68cd4-352d-0410-923a-c4978735b2b8
2009-11-09 11:38:13 +00:00