Commit Graph

30 Commits

Author SHA1 Message Date
Jellyfrog
82f43cb98d
Apply fixes from StyleCI (#12120) 2020-09-21 15:40:17 +02:00
CirnoT
b4f03808db Ignore empty IPv4 addresses in discovery on buggy devices (#10198)
* Ignore empty IPv4 addresses in discovery on buggy devices

* Styling fixes for codeclimate

* Use try/catch block instead
2019-05-09 06:39:57 -05:00
CirnoT
33a51bc592 Store IPv4 networks as network address and fix address search page showing networks not addresses (#10144)
* Store IPv4 networks as network address, not device address

* Properly display addresses, not networks on address search page
2019-04-29 11:52:32 -05:00
Tony Murray
1d777693e1 feature: New IP parsing classes. Removes usage of Pear Net_IPv4 and Net_IPv6. (#7106)
* Refactor remove use of pear Net_IPv4 and Net_IPv6

Caution, I added tests to test the functionality of the new functions, but I'm not 100% certain the replaced usages match 100%.  Please test.

Left usage in generate-iplist.php because I'm not sure the use of that script, so I didn't want to implement additional functionality to support it.

Add support for ipv6 fo ipInNetwork() function

Add phpdocs to functions
Remove accidental inclusion

Use binary operations instead of string for networKFromIp()
Tidy up binary operations in ipInNetwork()

tidy parsing cidr network

Change to a class based implementation.

Update phpdocs.
Fully catch exceptions for hex parsing.

Fix mistake.

support older phpunit versions

Fix php shifting to negative with php 5

* Fix graph authorization. Uncaught exception and checking an ipv4 against an ipv6 network == fail.

* Also remove colons from hex strings.

* Fix typo in bgp polling
Two passes of removing invalid characters from hex strings. (That way we don't mangle valid IPs)
2017-08-08 14:14:58 -05:00
Neil Lathwood
66b7077a01 fix: Updated ipv4/ipv6 discovery to exclude IPs with invalid port_ids (#6495)
* fix: Updated ipv4/ipv6 discovery to exclude IPs with invalid port_ids

* Update the valid IP sql queries to include addresses without a port

* Fix arp-table too.
2017-04-25 21:28:25 +01:00
Neil Lathwood
da5783d917 feature: Add mysql failed query logging + fixed queries that break ONLY_FULL_GROUP_BY (#5327)
* feature: Add mysql failed query logging + fixed queries that break ONLY_FULL_GROUP_BY

* fix all schema errors and update system
2017-01-07 11:32:38 -06:00
Tony Murray
9284bc60ff Update code in includes to be PSR-2 compliant (#4220)
refactor: Update code in /includes to be psr2 compliant #4220
2016-08-28 18:32:58 +01:00
laf
558dfb2344 Pretty up the discovery process output 2016-06-21 00:59:43 +01:00
HenocKA
8a3d14f9e2 Correct data duplication on discovering cisco vrf lite 2016-02-02 12:21:45 +01:00
HenocKA
08658e34ae Syntax update 2016-01-26 15:46:03 +01:00
HenocKA
724ad08d76 discoverying and polling VRF 2016-01-26 15:42:59 +01:00
HenocKA
21d2b45742 Syntax update 2016-01-26 15:27:50 +01:00
HenocKA
0ac8f584b2 discoverying and polling VRF 2016-01-26 15:22:49 +01:00
Job Snijders
d8693f05ae Fix coding style part 2 2015-07-15 11:04:22 +02:00
Alexander Sosna
5a7988e2e4 chmod 0644 to php files not directly executed 2015-04-28 22:58:03 +02:00
laf
96346e91b8 Added missing backtick :( 2014-06-24 02:02:56 +01:00
laf
38918c9348 Fixes for dbInsert / dbUpdate queries 2014-06-10 22:21:10 +01:00
laf
02792176fa Updated most files to use dbFacile 2014-03-12 22:21:33 +00:00
Adam Amstrong
4db1454e92 move from port_id to interface_id. make ports discovery only discover. add some cleaner functions. add a tiny bit of alerting infrastructure.
git-svn-id: http://www.observium.org/svn/observer/trunk@3195 61d68cd4-352d-0410-923a-c4978735b2b8
2012-05-16 13:25:50 +00:00
Tom Laermans
40d96200e5 other workaround for broken v4 address devices
git-svn-id: http://www.observium.org/svn/observer/trunk@3011 61d68cd4-352d-0410-923a-c4978735b2b8
2012-04-09 17:59:58 +00:00
Tom Laermans
4667d17f96 fix v4 address discovery retardness
git-svn-id: http://www.observium.org/svn/observer/trunk@3010 61d68cd4-352d-0410-923a-c4978735b2b8
2012-04-09 17:53:22 +00:00
Tom Laermans
9cea534c1b don't try to add bogus addresses then remove them again + small fixes and REMOVE DEBUG PRINT_R
git-svn-id: http://www.observium.org/svn/observer/trunk@3007 61d68cd4-352d-0410-923a-c4978735b2b8
2012-04-09 14:23:16 +00:00
Tom Laermans
f55a30f744 some formatting cleanups, introduce some more FIXMEs to look at, plus replace mysql_fetch_array by mysql_fetch_assoc, for great justice
git-svn-id: http://www.observium.org/svn/observer/trunk@2029 61d68cd4-352d-0410-923a-c4978735b2b8
2011-04-06 13:54:50 +00:00
Tom Laermans
31b2092041 more trailing spaces hunted down and shot, then shot again
git-svn-id: http://www.observium.org/svn/observer/trunk@1880 61d68cd4-352d-0410-923a-c4978735b2b8
2011-03-16 17:53:20 +00:00
Tom Laermans
12fbf7430c more cleanup/reindent, yay
git-svn-id: http://www.observium.org/svn/observer/trunk@1839 61d68cd4-352d-0410-923a-c4978735b2b8
2011-03-15 11:24:35 +00:00
Tom Laermans
694b31fcad Clean up ipv4 discovery by changing to Net_IPv4 instead of ipcalc
git-svn-id: http://www.observium.org/svn/observer/trunk@1808 61d68cd4-352d-0410-923a-c4978735b2b8
2011-03-08 18:01:54 +00:00
Tom Laermans
73135beb95 small fixes
git-svn-id: http://www.observium.org/svn/observer/trunk@1755 61d68cd4-352d-0410-923a-c4978735b2b8
2010-12-03 15:56:57 +00:00
Tom Laermans
d3d2ef5f67 Delta UPS support, also by generalising rfc1628 support; recognize some more hardware
git-svn-id: http://www.observium.org/svn/observer/trunk@1562 61d68cd4-352d-0410-923a-c4978735b2b8
2010-07-30 22:25:07 +00:00
Adam Amstrong
c22e8493f7 migrate all SNMP calls to use $config['mibdir']. automatically generated from install_dir if not present
git-svn-id: http://www.observium.org/svn/observer/trunk@1284 61d68cd4-352d-0410-923a-c4978735b2b8
2010-07-02 19:58:13 +00:00
Adam Amstrong
caab3ee1c4 rename discovery include scripts and update discovery.php
git-svn-id: http://www.observium.org/svn/observer/trunk@890 61d68cd4-352d-0410-923a-c4978735b2b8
2010-02-20 17:29:47 +00:00