Commit Graph

24 Commits

Author SHA1 Message Date
Adam Bishop
42d7fae9aa
Make IPv6 discovery work on JunOS
Although JunOS populates ipAddressIfIndex.ipv6, it does not add prefix lengths or other metadata. This means that IPv6 discovery fails.

This change removes OIDs from the list when there is incomplete data. If the list is empty after IP-MIB is walked, it then tries IPv6 MIB.

It's not a great fix, but I'm not confident I can fix the underlying issue without a complete re-write of this module.
2020-06-15 01:29:02 +01:00
Tony Murray
fad0bffc43 Escape SNMP & IPMI shell commands (#9537)
hopefully doesn't break anything
Mostly issues with snmp oids and options containing spaces.  Try to remove all of those.

DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`.  If there are schema changes, you can ask on discord how to revert.
2018-12-16 13:42:50 +00:00
Neil Lathwood
66b7077a01 fix: Updated ipv4/ipv6 discovery to exclude IPs with invalid port_ids (#6495)
* fix: Updated ipv4/ipv6 discovery to exclude IPs with invalid port_ids

* Update the valid IP sql queries to include addresses without a port

* Fix arp-table too.
2017-04-25 21:28:25 +01:00
Neil Lathwood
da5783d917 feature: Add mysql failed query logging + fixed queries that break ONLY_FULL_GROUP_BY (#5327)
* feature: Add mysql failed query logging + fixed queries that break ONLY_FULL_GROUP_BY

* fix all schema errors and update system
2017-01-07 11:32:38 -06:00
Tony Murray
9284bc60ff Update code in includes to be PSR-2 compliant (#4220)
refactor: Update code in /includes to be psr2 compliant #4220
2016-08-28 18:32:58 +01:00
laf
558dfb2344 Pretty up the discovery process output 2016-06-21 00:59:43 +01:00
HenocKA
8a3d14f9e2 Correct data duplication on discovering cisco vrf lite 2016-02-02 12:21:45 +01:00
HenocKA
21d2b45742 Syntax update 2016-01-26 15:27:50 +01:00
HenocKA
0ac8f584b2 discoverying and polling VRF 2016-01-26 15:22:49 +01:00
Job Snijders
d8693f05ae Fix coding style part 2 2015-07-15 11:04:22 +02:00
laf
02792176fa Updated most files to use dbFacile 2014-03-12 22:21:33 +00:00
Adam Amstrong
4db1454e92 move from port_id to interface_id. make ports discovery only discover. add some cleaner functions. add a tiny bit of alerting infrastructure.
git-svn-id: http://www.observium.org/svn/observer/trunk@3195 61d68cd4-352d-0410-923a-c4978735b2b8
2012-05-16 13:25:50 +00:00
Adam Amstrong
b3bd336515 fix ipv6-addresses discovery
git-svn-id: http://www.observium.org/svn/observer/trunk@2235 61d68cd4-352d-0410-923a-c4978735b2b8
2011-05-04 10:45:38 +00:00
Adam Amstrong
57e292907a fix globals in discovery modules
git-svn-id: http://www.observium.org/svn/observer/trunk@2234 61d68cd4-352d-0410-923a-c4978735b2b8
2011-05-04 09:13:32 +00:00
Tom Laermans
b5a3895ba3 unbreak IPV6-MIB support
git-svn-id: http://www.observium.org/svn/observer/trunk@2134 61d68cd4-352d-0410-923a-c4978735b2b8
2011-04-21 16:46:06 +00:00
Tom Laermans
4bc15529d4 eradicate split() in favour of explode()
git-svn-id: http://www.observium.org/svn/observer/trunk@2054 61d68cd4-352d-0410-923a-c4978735b2b8
2011-04-11 09:22:12 +00:00
Tom Laermans
f55a30f744 some formatting cleanups, introduce some more FIXMEs to look at, plus replace mysql_fetch_array by mysql_fetch_assoc, for great justice
git-svn-id: http://www.observium.org/svn/observer/trunk@2029 61d68cd4-352d-0410-923a-c4978735b2b8
2011-04-06 13:54:50 +00:00
Tom Laermans
bb4746d4d0 cleanups, small fixes and remove test-*php from the root
git-svn-id: http://www.observium.org/svn/observer/trunk@1998 61d68cd4-352d-0410-923a-c4978735b2b8
2011-03-31 10:51:02 +00:00
Tom Laermans
d077282444 Reindent/cleanup, remove dead files
git-svn-id: http://www.observium.org/svn/observer/trunk@1858 61d68cd4-352d-0410-923a-c4978735b2b8
2011-03-15 15:39:57 +00:00
Tom Laermans
12fbf7430c more cleanup/reindent, yay
git-svn-id: http://www.observium.org/svn/observer/trunk@1839 61d68cd4-352d-0410-923a-c4978735b2b8
2011-03-15 11:24:35 +00:00
Tom Laermans
694b31fcad Clean up ipv4 discovery by changing to Net_IPv4 instead of ipcalc
git-svn-id: http://www.observium.org/svn/observer/trunk@1808 61d68cd4-352d-0410-923a-c4978735b2b8
2011-03-08 18:01:54 +00:00
Tom Laermans
802573cfd3 discovery/ipv6: use snmp_xxx() functions and fix some bugs, patch by Corentin Chary
git-svn-id: http://www.observium.org/svn/observer/trunk@1799 61d68cd4-352d-0410-923a-c4978735b2b8
2011-03-08 16:24:13 +00:00
Adam Amstrong
c22e8493f7 migrate all SNMP calls to use $config['mibdir']. automatically generated from install_dir if not present
git-svn-id: http://www.observium.org/svn/observer/trunk@1284 61d68cd4-352d-0410-923a-c4978735b2b8
2010-07-02 19:58:13 +00:00
Adam Amstrong
caab3ee1c4 rename discovery include scripts and update discovery.php
git-svn-id: http://www.observium.org/svn/observer/trunk@890 61d68cd4-352d-0410-923a-c4978735b2b8
2010-02-20 17:29:47 +00:00