* added new OS - sensatronics-em1
* #9960 - added logo, icon, and update skip_values
* #9960 - fixed over: value
* #9960 - updated icon, logo, and updated descr: from static to table names
* Always boot Laravel
That way we can depend on it being available.
Saves us crashes if some code accidentally uses something that isn't booted and a lot of silly if/elses.
* ignore init php errors
* Corrected active_count for Alert icon color
* Corrected active_count for Alert icon color
* Corrected active_count for Alert icon color
* Laravel version
* Laravel version check status worse and better for isActive
* cleanup
* Reorganize trap tests
* Testing db DRIVER to prevent .env from interfering
* New code to detect if Laravel is booted. Hopefully more reliable.
* WIP external test process
* revert module test helper
* Use .env in Eloquent::boot()
* Fix test database settings loading
* fix undefined classes
(didn't find the one I needed)
* Fix incorrect Config usages
And RrdDefinition return type
* fix .env loading
* use the right DB
* slightly more accurate isConnected
* Move db_name to DBSetupTest specifically
* restore $_SERVER in AuthSSOTest
* missed item
* WIP
* tear down in the correct order.
* some testing cleanups
* remove check for duplicate event listener, it's not working right
* Don't need this change anymore
* Implement Log::event to replace legacy function log_event()
* fix port tests
* fix up tests
* remove pointless TrapTestCase class
* fix style
* Fix db config not being merged...
* skip env check for tests
* defer database operations until after Laravel is booted.
* don't include dbFaciale...
* redundant use
* Reorganize trap tests
* Testing db DRIVER to prevent .env from interfering
* New code to detect if Laravel is booted. Hopefully more reliable.
* WIP external test process
* revert module test helper
* Use .env in Eloquent::boot()
* Fix test database settings loading
* fix undefined classes
(didn't find the one I needed)
* Fix incorrect Config usages
And RrdDefinition return type
* fix .env loading
* use the right DB
* slightly more accurate isConnected
* Move db_name to DBSetupTest specifically
* restore $_SERVER in AuthSSOTest
* missed item
* WIP
* tear down in the correct order.
* some testing cleanups
* remove check for duplicate event listener, it's not working right
* Don't need this change anymore
* Implement Log::event to replace legacy function log_event()
* fix port tests
* fix up tests
* remove pointless TrapTestCase class
* fix style
* Improvements for infinera groove
- add support for 3.0.1 and prior versions
- add support for subports and fibre-channel
- fix bug relating to OS version detection
- updated unit test snmprec
* adding paper tray status and error states
* adding paper tray test data
* Create jetdirect_papertray.json
* Store printer supply type
* Update json data
* fix style
* Added an additional color in 'mixed' because of the mysql display using mixed[7] and failing because the array didn't have enough elements
* Moved color to the end of the array to not make other colors change
* Dantel WebMon Support
Webmon tep discovery changes
Fix Code Climate Issues
* WebMon - Move MIB to folder and create json reference
* Minor changes to Webmon polling
* accessing in YAML each part of the index in case oid has more than one
* accessing in YAML each part of the index in case oid has more than one
* accessing in YAML each part of the index in case oid has more than one
* accessing in YAML each part of the index in case oid has more than one
* accessing in YAML each part of the index in case oid has more than one
* accessing in YAML each part of the index in case oid has more than one
* accessing in YAML each part of the index in case oid has more than one
* Codeclimate
* Initialisation + comments
* Like this
* Cisco Sat Receiver
* Formatting Fixes
* Code Climate Fixes
* Add $entry field in the last array.
* Formatting Fixes
* Updated to correct S/N was grabbing wrong OID.
* Update test data for missing serial #
* Updated Serial # test data
* Add data scrubbing state to Synology RAID status
Adds a new state translation to Synology DSM RAID status sensor, so it displays "DataScrubbing" while the operation is running. Previously it would just show "# 13".
* Update Synology RAID MIB
Downloaded from
https://global.download.synology.com/download/Document/MIBGuide/Synology_MIB_File.zip
* refactor: advanced sensor states
mark create_state_index($state_name) as E_USER_DEPRECATED?
* fix: minor corrections
* fix: mib has partialSync(9) and incompatibleVersion(8)
* fix: corrected netagent2upsstate - Sleeping(5)
* fix: NetAgent2 upsThreePhaseUPSStatusInverterOperating correction
* refactor: array() be gone
* Refactoring includes/discovery/sensors/state/extendair.inc.php with arrays
And tidying up array formatting in other files
* fix: minor typo
* standardising array item names
removed redundant "if ($state_index_id !== null) {"
* workaround: procurve & serverscheck
a sensor is causing create_state_index($state) to return null.
The updated code doesn't allow for this and thus a hybrid is being used.
* standardised naming of state info. Caused a typo $state_name instead of $status_name
$state_name is the standard
* converted compas to square arrays
* Converted APC states using preg_match to new create_state_index() call
* Update boss.inc.php
* Fix icon finding
Also fix os suggest not loading all OS.
* Fix os that would have missing icon under the new code (and one under the old code)
* forgot icon
* newdevice: Added support for Alpha Comp@s
http://www.alphainnovations.eu/compas
* fix: Updated state values
state values persist in database, even after deletion of devices.
Not a 100% how to purge them.
create_state_index($state_name, $states) doesn't update the database, if the states have changed
* refactor: comp@s OS state sensor now updated to latest format
* Sync Git to Master
* OS Support for Perle Terminal Servers. Added via /scripts/new-os.php. Tested on two devices
* There was an existing Perle OS, updated it to include the Perle IOLAN SCS model .1.3.6.1.4.1.1966.12. Removed Files the script created that were no longer needed
* There was an existing Perle OS, updated it to include the Perle IOLAN SCS model .1.3.6.1.4.1.1966.12. Removed Files the script created that were no longer needed. Round 2
* Update exiting includes/definitions/perle.yaml to catch all device by Perle. Removed the .gitignore files from the branch
* Git Add includes/definitions/perle.yaml helps
* Empty file not allowed in YAML verification
* restore missing files
* restore missing files
* restore missing files
* Restore the sysDescr
The existing testdata relies on this, as sysObjectID is not collected
* Migration script and data feeding
* Adding the columns in the GUI
* build schema
* update FDB test data
* Use of timestamps()
* ignore created_at and updated_at in tests, and regenerate test impacted
* daily.sh does the cleaning
* space cleaning codeclimate
* Use carbon instead of str-val
* handle when $fdb_entry->updated_at and created at are null
* handle when $fdb_entry->updated_at and created at are null (force travis rerun)
* Doc update
* Doc update
* Fixes for SZ detection
* Ruckuswireless devices
* remove registered mibs
* Code Climate Fixes
* updated test data for zd1100 & zd1200
* Updated database test data
* trying to fix smartzone test data
* updating zd test data
* more code climate fixes
* Update ruckuswireless-unleashed.yaml
* hide total clients if 1 ssid
* fixing smartzone ap status
* smartzone ap count fixes
* fixes because of git
* fix zd ap counts
* Update ruckuswireless-sz.json
* Update ZD1200 test Data
* Update ruckuswireless-sz.snmprec
* Update Database test data
* Update zd1200 database data
* Update ruckuswireless_zd1100.snmprec
* Update ruckuswireless_zd1100.json
* Update ruckuswireless_zd1100.json
* Update ruckuswireless_zd1100.json
* Code Climate Fixes
* Code Climate Fixes
* Update Ruckuswireless.php
* Code Format Fixes
* Removed legacy transports and templates code
* Add notification
* abstract LnmsCommand
* Only issue alerts "legacy" alerts to mail for default contacts, etc.
* Prevent no contacts error when default contact is not specified, or there are no contacts for other reasons.
* remove eval \o/
* Update notifications.rss
* add mibs,first commit
* adds support for Nokia ISAM Plattform
* remove some comments
* change os polling to multi oid
* Restore file headers
* Fix discovery by sysObjectID
* first deactivate checks against IHUB (timos), It not necessary so long we can not provide more thatn one snmp community per device
* move snmp state and temperature from pre-cache
* Update os_schema.json
* EDS support
* EDS support
* EDS support
* EDS support
* EDS support (tests)
* EDS support
* EDS support
* Adding DS18B20 sensors
* Adding DS18B20 sensors
* read tables separatly in precache instead
PR #9546 has resulted in Platform being detected as
"Juniper Virtual Chassis Switch" when a set of devices
is stacked. Hence, no more possibility to see whether
it is for example an EX2300 or EX3400 virtual-chassis.
This commit falls back to using rewrite_junos_hardware()
if the "Juniper Virtual Chassis Switch" string is detected
in boxDescr, resulting in usable hardware data.
Caveat - it's possible to build a virtual-chassis of
multiple switch models, but only for higher end hardware:
https://www.juniper.net/documentation/en_US/junos/topics/concept/virtual-chassis-ex4200-overview.html#jd0e75
Example SNMP output:
mschmidt@nlrtm1-librenms1:~$ snmpwalk -v2c -cremoved -m JUNIPER-MIB -M /opt/librenms/mibs hostname jnxBoxDescr
JUNIPER-MIB::jnxBoxDescr.0 = STRING: Juniper Virtual Chassis Switch
Also reported previously via the community forums:
https://community.librenms.org/t/pr-9546-results-in-junos-platform-detection-quirks-in-combination-with-virtual-chassis/6537
* update some mibs
* extend snmpwalk_cache_twopart_oid function
* add raisecom dbm and temperature sensors
* add test data
* add some more sensors
* Update raisecom.inc.php
* Update raisecom.inc.php
* Port RIPE whois to Laravel
* remove netcmd.php and port to laravel.
Escape CLI and set it to stream output live.
* fix browser buffer bust on a few browsers.
* device: support for Alcatel OmniPCX Server
* device: support for Alcatel OmniPCX Server - add test data
* rename
* Add a new versatile type of sensor, without unit - doc extension
* tests data updated for omnipcx
* new count test after funny rebase
* clean
* tests
* index in yaml file ...
* Update omnipcx.json
* try to add pbx state
* Change function snmpwalk_cache_oid to allow snmpvalue without index
* testdata
* Adapt the discovery_schema (to allow a non_indexed oid)
* Update snmp.inc.php
* Updated DataDomain MIB, Added DataDomain Storage poller and discovery
* Fixed issues pre-commit issues
* Removed extra blank lines
* Make polling less redudant
* Remove blank line
* Remove device os detection since it's not needed. Add test data for DataDomain
* For better compatibility, we will check if the $index is null prior to adding the storage
* Fix: is undefined...
* Update datadomain.inc.php
* Update datadomain.inc.php
* Fix Sentry3 voltage sensor discovery
Previous fix broke voltage sensor discovery with superfluous .1 in the SNMP OID. I have fixed my install with this patch but other testing should probably be done.
* Update sentry3.json
* Eltek Valere more sensors
* Fix runtime, temperature and format runtime
* remove "runtime" sensor
* Don't need the pre-cache
* Parenthesis
* match previous indentation
* Adding Sonicwall SMA 400 support
* Added metric clients for use in SSL VPN client alerting
* Support for specifying multiple sensors for clients metric
* RAM info supported
* CPU info supported
* Added test data
* Dashes in graph aren't really useful
* Updated test data with script from upstream (#10)
* Fix style errors (#11)
* Now 8 spaces on line 56
* port clients sensor to count
Some sensor cleanups (move all icon definitions to one spot)
* update port data
* add sensor test data. Make a guess at userLicense output since it is missing.
* cleanup missed items
* typo
* Updating test data
* Fixed missing CPU info
* Recreated test data
* Recreate test data after rebase
* Test data without ignore statements in config
* Fix some comment and documentation typos.
* Fix various entphysical page display issues.
- Resolve flickering during loading (missing liClosed for nested items).
- Clicking a sensor actually takes you to the matching graph now.
* Add a few nicecase() calls to clean up html page display.
* Create discover_entity_physical() function
- Add discover_entity_physical() function into includes/discovery/functions.inc.php
- This allows for an easy implementation of OS-specific entity-physical discovery.
- Update includes/discovery/entity-physical/entity-physical.inc.php to use the new function.
* Add power_consumed and power_factor sensors.
* Two new icons, make more entPhysical data visible.
* Pre-commit fix: blank line found at end of control structure.
* Add Schleifenbauer OS support.
* Now really fix the comment typo.
* Fix parsing mistakes.
* Add a generic count sensor.
* Make the Schleifenbauer discovery use count instead of state sensors.
* Don't place count sensor at the top, add sane limits for Schleifenbauer
* Finetuning the rrd_options, changing Schleifenbauer sensor names.
* Update schleifenbauer.svg
* optimize logo too
* add test data
* fix sensor value display (spaces break it)
* update entPhysicalIndex
* Refactor FDB Tables to Laravel
Hopefully much better performance with large tables.
Better dns resolution (limit to 4 IPs tried per MAC)
* update style
* de-duplicate IPs
* fixed column width for mac and vlan
* Make DNS column visibility control whether or not we send the dns query.
Hide that column by default.
* fix_if_discover
* Update ports.inc.php
* Fixed overwriting IfDescr and IfAlias overwriting
* removed whitespace
* added ifname, ifalias and ifdescr copy if it is emtpy or null
* removed ifAlias from update to prevent overwrite
* removed ifName and ifDescr from update to prevent overwrite
* added is_port_valid before doing copy actions between ifDescr,ifAlias&ifName also added back ifDescr&ifName update
* Update ports.inc.php
* Update functions.php
* Update ports.inc.php
* Update exa_e7-2.json
* Update fortigate.json
* Merge ethernetprobe2 into akcp and improve akcp
Use higher resolution temperature values if available
Properly hand F/C temperature scales (LibreNMS always uses C)
Add current, voltage, airflow (no test data)
Move humidity to yaml
* Update akcp.snmprec
* Update akcp-serverprobe8.json
* Add group
* Update test data
remove old MIB
* add group to sensor initial discovery and use dynamic_discovery_get_value template syntax on them
* spaces
* switching to YamlDiscovery::replaceValues
* testdata from ibmc
* testdata from nxos
* testdata from omnitron-iconverter
* testdata from vrp
* adapt discovery_schema to accept variables
* remove pattern
* Update discovery_schema.json
* Add migrations and seeds
* Fix spacing validation issues
* Fix linting
* Update tabs to spaces
* Update daily and install process
* Make build-base.php use the new migrations if empty or at dbschema 1000.
Seed 1000 into the database.
Temp fix for the route table index length (this table basically isn't used...)
* Fix typo in seed.
Hard code legacy schema checks to version 1000 (999 would have worked as is)
* Port association table no longer exists
* Make database validate again
* DB schema, remove as many DB::statement as possible
* update migrations
add librenms cli entry point (artisan)
update validate to check laravel migrations
* remove statements from users migration
* Fix up daily.sh and the 1000 migration
* Update migrations to current state
Take advantage of environment variables to set DB credentials.
* Fix style issues
* Update schema
* fix test db collation
* Fix migration table definition
* update db migrations
* Update migrations
* Update stats callback. Just count the total migrations applied.
* Update 1000.sql.
* update migrations
* remove the graph type seeder, it is no longer needed
* update docs
* fix whitespace
* remove extra schema
* update tests
* fix sort
* add message
* dbSchema should actually be 1000
* add character set to db create
* Fix some artisan issues
* Update schema
Improves visual identification for sensors
- [x] Docs
DO NOT DELETE THIS TEXT
#### Please note
> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.
- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)
#### Testers
If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`. If there are schema changes, you can ask on discord how to revert.
Discovers 2 of 6 found in the test data then updates it to not match.
Setting the wrong oid.
Tracking two specific macs on a single AP that don't match the label.
If they roam it won't change until next discovery.
If this is wanted, it should be written in the wireless section.
* Fix Zynos temp warn limit
And others, but this seems to be the only one that uses
remove some odd limit restriction in the poller
* More consistent rounding for sensor limits
* round all numeric limits to 10 digits
* update test data
* Remove complex calculation as negative limit values are already swapped as needed.
* Eventlog updates
remove host from eventlog table, retain in api
allow most fields nullable
* updated schema
* revert auth for legacy log_event function
safer check in the model
* add function modifiers
* Add librenms command
Hook up to artisan. Hide dev commands and most other commands if app environment is production.
Register all commands for php artisan or when not in production.
* remove dead end line
* Console application name and version.
Had to shift some stuff from legacy code, but deferred others as it was too extensive of a change.
* switch check order
* always get local version now
* update array format
* whitepace
* fix style
* Remove graph_types from DB.
This is silly since defining them in definitions.inc.php already does the same thing.
Adds missing ones in definitions.inc.php and rewrites others since I already wrote them before I realized they were duplicates.
* remove dead table
* Remove graph_types inserts from schema files.
* update db_schema.yaml
* ZyXEL XGS4600-32F
- Added mib for diagnostics
- CPU/Mem
- Temp/Fan/Voltage
- Updated zyxel group mempools
- Updated test data
- snmprec
- json
- Altered ZyWall
- To exclude XGS switches
* Defined ZYXEL-HW-MONITOR-MIB at the top of file
* Removed .MIB
* add AlertSchedule model and relationships
change table structure to match the expected layout
* Update maint schedule map ui
* better index name
* Laravel queries
fix some issues with the ui: restricting start incorrectly and loading empty days error
* handle date limiting properly
* Another attempt add schedule constraints
* use Auth
* Update WorldMap widget to use check isUnderMaintenance
* Rename 275.sql to 276.sql
* Rename 276.sql to 277.sql
* initial work done to FreeBSD NFS pollers for JSON support
* minor formatting cleanup and no longer pass update_application a array for the second argument
* add test data and snmprec(minus legacy)
* use variables from the data part of the JSON in the metrics
* add the legacy snmprec file for fbsdnfsserver
* add the most of the test stuff for FreeBSD NFS
* add the legacy SNMP data for FreeBSD NFS client
* add the missing "applications": {
* properly rename the tests to match the appname
* correct the appname stuff in the tests
* make a chunk of the json properly a array item
* correct this to the actual value
* change 0 to 0.0 for one and make quote data
* hmm... RdirPlus is becoming Rdirplus
* whoops, revert that... should be RdirPlus as that is what is returned
* add test data for the ups-apcups app
* add ups-apcups SNMP test data
* update for both legacy and JSON
* update the docs for the new extend
* add a comment so git sees this file as updated
* add missing "applications": {
* regen the json version
* properly regen the test json
* test fix
* fix the v1 tests json for ups-apcups
* regen post fixing json-app-tool
* regen the json again after more tweaks to the json-app-tool
* see if it does not like .0 for numbers that would otherwise be integers
* data is not a constant
* ...wow... missed that $json_return was mis-spelled twice :(
* re-add the .0s to some test data
* update some mibs
* add virtual router ports
* coding style
* refactor
* some refactoring
* some typos
* add snmprec
* Fix capturing VRF entries with no ports
* updated test data
* manually fix test data
Not going to try to fix the data capture for backslashes at this time.
* Revert "manually fix test data"
This reverts commit 2c98450706.
* timos data for net-snmp 5.7.3 ?????
* RouterOS wireless sensors update (#9401)
* bug-fix and new features
Fixed incorrect OID for rate, renamed rate to TX-Rate as per update from mikrotik.
Added support for link distance
* Fixed indent issue
* Added support for using Transport name in templates (#9411)
* Added ability to sort alert schedules by status (#9257)
Signed-off-by: Rémy Jacquin <remy@remyj.fr>
* Converted Polling From Ports to New Module (cisco-nac)
* Converted Polling From Ports to New Module (cisco-nac)
* Fixed alert util (#9428)
DO NOT DELETE THIS TEXT
#### Please note
> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.
- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)
#### Testers
If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`. If there are schema changes, you can ask on discord how to revert.
* Fixed AlertUtil - again (#9429)
* Update BEGEMOT-HAST-MIB (#9427)
FIX:
Due to a missing import and the uppercase after some SYNTAX this mib is not bein compiled correctly everywhere.
For example the one from Horizon OpenNMS fails with some errors
ERROR: Cannot find symbol UNSIGNED32, Source: BEGEMOT-HAST-MIB.txt, Row: 321, Col: 17
The proposed change prevent the errors.
DO NOT DELETE THIS TEXT
#### Please note
> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.
- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)
#### Testers
If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`. If there are schema changes, you can ask on discord how to revert.
* Fixing Travis CI and Code Climate Issues
* Fixing Travis CI and Code Climate Issues
* Fixing Travis CI and Code Climate More Issues
* Fixing Travis CI and Code Climate More Issues
* Fixes delta calculation for bgpPeers_cbgp metrics (#9431)
The values in the $peer['c_update'][$oid] array are set only if they have
changed. If the value has not changed, then zero is substituted for real
values, which leads to incorrect calculation of delta values and records
in the database:
SELECT AcceptedPrefixes,AcceptedPrefixes_prev,AcceptedPrefixes_delta
FROM bgpPeers_cbgp
WHERE device_id=115;
| AcceptedPrefixes | AcceptedPrefixes_prev | AcceptedPrefixes_delta |
|------------------|-----------------------|------------------------|
| 21 | 21 | -21 |
DO NOT DELETE THIS TEXT
#### Please note
> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.
- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)
#### Testers
If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`. If there are schema changes, you can ask on discord how to revert.
* Improve Junos state sensor discovery (#9426)
DO NOT DELETE THIS TEXT
#### Please note
> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.
- [X] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)
#### Testers
If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`. If there are schema changes, you can ask on discord how to revert.
Tested on MX and EX series, works fine.
Skip slots that are empty and pull all sensors in jnxFruTable, data from old code is preserved.
* Added alerts schedule notes into device notes (#9258)
* Add alerts schedule notes into device notes
Signed-off-by: Rémy Jacquin <remy@remyj.fr>
* Update preferences.inc.php
* Show port description and dns name in FDB table (#9370)
- Added Port Description field to FDB Table
- Added DNS Name field to FDB Table
- Fixed sorting by port in FDB Table
DO NOT DELETE THIS TEXT
#### Please note
> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.
- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)
#### Testers
If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`. If there are schema changes, you can ask on discord how to revert.
* Update draytek.inc.php (#9432)
* Removed unnecessary model checks in HiveOS Wireless (#9409)
DO NOT DELETE THIS TEXT
#### Please note
> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.
- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)
#### Testers
If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`. If there are schema changes, you can ask on discord how to revert.
* Added format field to Telegram Messages (#9404)
* Add format field to Telegram Messages
Added Telegram field to send formatted messages as Mardown or HTML
* Update Telegram.php
* Correct Mistypo.
* Correct mistypo
* Correct Mistypo
* Correct mistypo
* Update Transports.md
* Add Format field on Telegram Examples
* Change Telegram Format field to type select
* Add "blank" option to Format field
* Update Telegram.php
* Update Telegram.php
* Update Telegram.php
* Disable page refresh on health sensors pages, autorefresh most tables (#9386)
* Disable page refresh on health sensors pages
Refresh all bootgrid tables every 5 minutes
* Update legacy_index.php
* Update librenmsv1.blade.php
* Style cleanup in hiveos file (#9440)
Fix code style check for https://github.com/librenms/librenms/pull/9438
DO NOT DELETE THIS TEXT
#### Please note
> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.
- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)
#### Testers
If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`. If there are schema changes, you can ask on discord how to revert.
* Ensure the checks for ASA context devices are strict (#9441)
* Show visually in webui + cli when using deprecated templates or transports (#9413)
* Show visually in webui + cli when using deprecated templates or transports
* Fixed query
* Added Bing geocode lookup support (#9434)
DO NOT DELETE THIS TEXT
#### Please note
> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.
- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)
#### Testers
If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`. If there are schema changes, you can ask on discord how to revert.
* Added ScreenOS Syslog Hook (#9438)
* Add ScreenOS Syslog Hook
Adds Syslog Hook for ScreenOS
https://community.librenms.org/t/juniper-screenos-syslog-hook/6146
* Update Syslog.md
* Update syslog-notify-oxidized.php
* Discovery YAML. Do not implicitly append $index (#9315)
Require it explicitly. Makes it easier to understand and matches the style of other values
Questionable YAML changes (either broken before or now broken):
secureplatform: haStatCode
ptp600: receiveModulationMode
DO NOT DELETE THIS TEXT
#### Please note
> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.
- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)
#### Testers
If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`. If there are schema changes, you can ask on discord how to revert.
* Update Syslog.md (#9443)
Fixed the screenOS output added in #9438 which was confusing mkdocs output. Refer to the docs currently https://docs.librenms.org/Extensions/Syslog/ - It's all mashed up at the bottom
DO NOT DELETE THIS TEXT
#### Please note
> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.
- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)
#### Testers
If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`. If there are schema changes, you can ask on discord how to revert.
* Fix ping.php poller groups setting
confusion between dispatch(new PingCheck($groups)) and PingCheck::dispatch($groups)
* Replaced Other to Disabled on Metod Column
* Replaced Other to Disabled on Metod Column
* Removed Extra Character < on Authz Icon
* Removed Extra Character < on Authz Icon
* Created sql-schema (261)
* Created sql-schema (261)
* Update docs for virtual images (#9456)
* Added Traffic to the Windows OS overlib graph (#9445)
WebUI: added Traffic to the Windows OS overlib graph
DO NOT DELETE THIS TEXT
#### Please note
> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.
- [X] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)
#### Testers
If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`. If there are schema changes, you can ask on discord how to revert.
* Update World-Map.md to include pros/cons (#9442)
DO NOT DELETE THIS TEXT
#### Please note
> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.
- [ ] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)
#### Testers
If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`. If there are schema changes, you can ask on discord how to revert.
* Added allow ipv6 address localhost nginx-status docs (#9458)
Following the modification of the SNMP Nginx agent (e0dcd4a064), linux distributions make requests in IPV6, so you must allow ::1
DO NOT DELETE THIS TEXT
#### Please note
> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.
- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)
#### Testers
If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`. If there are schema changes, you can ask on discord how to revert.
* Fixed altering transport mapping in rules clearing all mappings (#9455)
* Change unpolled devices toast to be based on rrd step (#9391)
* Change unpolled devices toast to be based on rrd step
* Update message
Change it back to 3x
* Added resources/links and devices/hostname/links API calls for xDP (#9444)
* api: Add list_links and get_link api calls
Signed-off-by: Misha Komarovskiy <zombah@gmail.com>
* api: Add get_links api call
Signed-off-by: Misha Komarovskiy <zombah@gmail.com>
* Update detection for Allied and Radlan OS (#9454)
"1.3.6.1.4.1.207.1.4.128" is currently reporting as allied, when it should be reporting as radlan.
Refer to https://community.librenms.org/t/allied-telesis-discovery/6189/8
DO NOT DELETE THIS TEXT
#### Please note
> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.
- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)
#### Testers
If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`. If there are schema changes, you can ask on discord how to revert.
* Updated HiveOS wireless detection (#9459)
* Added ability to record traceroutes for devices down due to ICMP (#9457)
* Added ability to record traceroutes for devices down due to ICMP
* Update Templates.md
* Updated schema
* Update dev-overview-data.inc.php
* Filter email options based on backend in Alert settings (#9461)
DO NOT DELETE THIS TEXT
#### Please note
> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.
- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)
#### Testers
If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`. If there are schema changes, you can ask on discord how to revert.
* Update Configuration.md
* Updated detection for AKCP devices (#9460)
* Updated support for Avocent devices (#9462)
* Updated support for Avocent devices
* Add ACS8048 hardware to json
* Update avocent.inc.php
* Update avocent_8000.json
* Syslog name translation (#9463)
* Check to see if a host exists in a lookup table to translate received name to what LibreNMS knows
* Added some documentation on how this is configured
* Use \LibreNMS\Config instead of accessing $config directly
* Fix codeclimate finding: Additional blank lines after USE statement
* murrant suggested a much cleaner way of doing this!
* fix snmp engine time (#9470)
* Added more sensors for IRD (PBI Digital Decoder) (#9339)
* added over bitrate graph
* added bitrate
* added more state sensors
* Update ird.snmprec
* Update ird.json
* Update Ird.php
* Update Ird.php
* Update Ird.php
* Update ird.json
* Updated json test data
* Update ird.snmprec
* Updated json data
* fix test value
* fix num_oid
* Add new sysDescr string for AlliedWare Plus products. (#9430)
* Add new sysDescr string for AlliedWare Plus products.
Release 5.4.8-2.1 of AlliedWare Plus will change the format of the
sysDescr string. This patch updates Allied Telesis yaml files to work with
this change.
Signed-off-by: Luuk Paulussen <luuk.paulussen@alliedtelesis.co.nz>
* save-test-data.php: Use correct variable for 'os' argument.
Signed-off-by: Luuk Paulussen <luuk.paulussen@alliedtelesis.co.nz>
* Create awplus_5.4.8-2.json
* Update awplus_5.4.8-2.json
* add a tool for working with JSON apps (#9084)
* add initial work on script for working with json apps
* finish the code portion
* -h now done
* rename it to be slightly more accurate
* make hash key strings
* exit if -a is not present
* now exit after checking the file if -s or -t is given
* now properly add the applications key
* snmp_max_oid per Os support and snmpv1 multi_oid fix (#9343)
* Added snmp_max_oid config at Os level.
* Added check for snmpv1 on multi_oid requests.
* Check device_oid_limit on multi get
* Use array_chunk
* Update snmp.inc.php
* remove dump, unused variable and extra plodes
* per device settings should take priority over OS
* Update Settings.md
* don't discard the data :P
* fixing option to let user pick saved test data filename, exit if ther… (#9242)
* fixing option to let user pick saved test data filename, exit if there are many os/variant combination for a single output filename
* fixing style issues
* Update save-test-data.php
* Update save-test-data.php
* Add support for Firebrick Hardware (#9403)
* Added support for Firebrick devices
* Added support for Firebrick devices
* Update firebrick.inc.php
* Update firebrick.inc.php
* Update firebrick.svg
* Update firebrick.svg
* Added SNMP Check
* Added SVG View Box
* Display XML in config tab
* Update firebrick.svg
* Update firebrick.yaml
* Update showconfig.inc.php
* Create firebrick.json
* Check sysDescr for JunOS version. (#9247)
* Cisco: change notKnown status to unknown and not warning (#9222)
* Cisco: change notKnown status to unknown and not warning
* Update cisco.inc.php
* Improve the Logical Checking if Data Exist on DB
* Improve the Logical Checking if Data Exist on DB
* Update SQL-Schema File Name
* Update SQL-Schema File Name
* add app for getting status of TCP connections for specified services (#8090)
* add the poller for portactivity
* add the ability to get monitor ports for portactivity
* add the graphs for displaying stuff for the portactivity app
* add the portactivity app page
* update the docs for Portactivity
* remove extra line
* minor doc update for Portactivity
* add update_application line
* convert to use json_app_get
* convert curly brackets to square
* style fix
* remote error, errorString, and version after they stop being important so they are not processed
* add alert rule examples
* add the poller for portactivity
* add the ability to get monitor ports for portactivity
* add the graphs for displaying stuff for the portactivity app
* add the portactivity app page
* update the docs for Portactivity
* remove extra line
* minor doc update for Portactivity
* add update_application line
* convert to use json_app_get
* convert curly brackets to square
* style fix
* remote error, errorString, and version after they stop being important so they are not processed
* add alert rule examples
* remove dump of get_portactivity_ports function added during rebase
* update to the current json_app_get
* add portactivity snmprec
* add the portactivity test data
* whoops bad merge when rebasing... fix
* minor formatting cleanup and add a missing comma
* fix some odditities with what one of the tests is doing
* whoops... include the use for the exception
* set the response to okay
* attempt to make snmpsim array check happy again
* the json now lints
* more making metric testing happy
* one more update to make travis-ci happy
* now flattens arrays also add array_flatten
* rename array_flatten to data_flatten as pre-commit chokes on it as laravel has something similarly named
* go through and properly add all the metrics
* tested with the newest one and it works
* whoops, clean up json and remove prototype that was used when putting it together
* doh! make it happy with laravel now
* see if a minor changing in formatting for the numbers makes the polling unit test happy
* order them properly
* remove a comma
* a few more minor fixes
* Replace dbFetchRows to dbFetchRow on Some Exist Checks
* Replace dbFetchRows to dbFetchRow on Some Exist Checks
* Fix Some Code Climate Issues
* Fix Some Code Climate Issues
* Fixed More Code Climate Issues
* Fixed More Code Climate Issues
* Fix do not include template text in HTML page (#9476)
* Fixed $speed lenght in port parser when > 32 characters (#9479)
* Fix global read check for demo account (#9482)
* Improve documentation for service plugins (#9414)
* Begin adding preinstalled plugin documentation.
Also add information about how the titles of the plugins are displayed and detected.
Make page visible on the websites Table of Contents.
* Add note about plugin loading based on file name.
* Added all monitoring-plugins URLs.
* Format URLs on the service plugin docs list.
* Correct a URL on the plugins list.
* Removed leftover text from plugin list docs.
* Add pkg-nagios-plugins-contrib plugins to docs.
* Add DSA pkg-nagios-plugins-contrib plugins to docs
* Added a few missing lines of pkg-nagios-plugins-contrib text.
* Remove links plugins we dont have URL for.
Add a few more pkg-nagios-plugins-contrib ones.
* Remove list. Point to the main sources directly.
* order by sensor_descr aswell (#9478)
Sort sensors by sensor_descr
* Fix os additional information for some that were broke (#9466)
* Fix os additional information for several OS.
$poll_device is not available, use $device
* fix draytek test data
* Fixed Procera ports ifIndex and ports added by the poller (#9384)
DO NOT DELETE THIS TEXT
#### Please note
> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.
- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)
#### Testers
If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`. If there are schema changes, you can ask on discord how to revert.
* Change group owner for php/session for CentOS 7 nginx install (#9393)
By default on CentOS 7, /var/lib/php/session is root:root.
DO NOT DELETE THIS TEXT
#### Please note
> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.
- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)
#### Testers
If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`. If there are schema changes, you can ask on discord how to revert.
* Refactored and update Location Geocoding (#9359)
- Fix location so it is a regular database relation (this allows multiple devices to be accurately linked to one location and saves api calls)
- Parse coordinates from the location more consistently
- Add settings to webui
- ~~Used [PHP Geocoder](http://geocoder-php.org/), which has lots of backends and is well tested. (also includes reverse and geoip)~~
- Google Maps, Bing, Mapquest, and OpenStreetMap supported initially.
- Default to OpenStreetMap, which doesn't require a key. They will liberally hand out bans if you exceed 1 query per second though.
- All other Geocoding APIs require an API key. (Google requires a credit card on file, but seems to be the most accurate)
- Update all (I think) sql queries to handle the new structure
- Remove final vestiges of override_sysLocation as a device attribute
- Update existing device groups and rules in DB
- Tested all APIs with good/bad location, no/bad/good key, and no connection.
- Cannot fix advanced queries that use location
This blocks #8868
DO NOT DELETE THIS TEXT
#### Please note
> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.
- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)
#### Testers
If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`. If there are schema changes, you can ask on discord how to revert.
* Added Aprisa support (#9435)
* Created 4RF Aprisa XE support
* Made requesed change by @laf
* cleanup
* Fix sensor index and add test data
* Added support for Waystream products (#9481)
DO NOT DELETE THIS TEXT
#### Please note
> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.
- [X ] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)
#### Testers
If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`. If there are schema changes, you can ask on discord how to revert.
This has been running in two production networks for > 3 months without any issues.
* Marathon detection
* support for Marathon based UPSs
* added Marathon Power logo
* testing marathon ups
* Fix for #9485 (#9486)
* Fix for #9485
* Update ajax_search.php
* Testing Maraton ups device type
* Fix issues cause by new location and other misc (#9490)
* Fix issues cause by new location and other misc
fix some queries so we return devices with null locations
remove unnecessary query of all ports on ports page lists
make locations menu available to non-admins for the legacy menu
fix a few issues with the old network-map
* fix graphs
* fix oxidized query
* added rfc1628 compat and removed discovery file
* small changes to verbiage
* Changes to display
* Fixed test on over section
* Removed Current graph. Not available from this device.
* Locations UI and editing (#9480)
* Better handling of errors
Mapquest seems to return the center of the US on error.......
* Editable locations WIP
* Change to bootgrid ajax table WIP
* Graphs working, using handlebars
update js libs
add current location button
* remove sql query, change icon
* Add the map to the device view, only when gps is expanded.
Allow edit on device page, share js code
* fix chevron rotation, improve click area
* extra warning
* fix overview layout (remove containers)
* fix style
* fix html divs, change collapse ui a bit
move css, update css/js versions
* start zoomed out on new locations
* don't double load scripts, zoom to 17
* fix php-md errors, remove unused use statement
* improve non-admin experience
* Move locations page to Laravel
More functions in Url and Html util classes
reduce code duplication
* translation buttons too
* fix whitespace
* move formatters to the frontend
* small changes
* disable traffic for locations with no devices
* change down 0 to green from gray
* missing "
* Fix paginate all
* working fix for paginate all
* allow sort by counts
* fix down sort
* a little safety
* Don't call the function twice
* btn-xs
* Added json test data
* Fix locations page search (#9501)
* Add bing layer to leaflet (#9497)
Also, polyfill for IE used by both bing and google maps
* Change locations default sort order (#9502)
* changed variable name to resolve issue with Gitlab transport
* removed else to satisfy codeclimate checks
* changed tabs to spaces
* added CISCO-NAC-TC-MIB
* added CISCO-NAC-TC-MIB
* Added changelog for 1.46 release (#9510)
* Add additional composite index to speed up display of pages where a device has a lot of syslogs. In our environment, this took page loads for some devices from over 60 seconds to nearly instant
* Forgot to add db_schema.yaml in previous commit
* Update cucs mib to fix warnings (#9517)
* Added HPE Comware temperature limit (#9518)
Changed the Temperature High threshold for a HPE Comware Switch to the values provided by snmp.
This means the actual threshold configured in the switch is used over any predefined/auto calculated thresholds by LibreNMS.
DO NOT DELETE THIS TEXT
#### Please note
> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.
- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)
#### Testers
If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`. If there are schema changes, you can ask on discord how to revert.
* Added Comtrol device detection (#9491)
DO NOT DELETE THIS TEXT
#### Please note
> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.
- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)
#### Testers
If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`. If there are schema changes, you can ask on discord how to revert.
* Fixed integers fields in alert rules to be string (#9496)
DO NOT DELETE THIS TEXT
#### Please note
> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.
- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)
#### Testers
If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`. If there are schema changes, you can ask on discord how to revert.
* Focus and select location on override (#9503)
* Focus and select location on override
* Submit location on enter key
* SAF CFM wireless device support (#9450)
* Added support for SAF CFM L4 wireless device
* Added copyright statement according to LibreNMS documentation
* Added snmp test data and excluded some discover modules from os definition
* Style issue fixed
* More descriptive function
* MIB file rename
* Rename MIB file and change other files accordingly
* Added test data
* Removed debug statement
* Last checks
* Style changes
* Style changes
* Style changes
* Style changes
* Code restructure to make it more readable
* Fixed error in foreach
* Style issues
* Formatting of states within Yaml changed to make it more readable
* Omit default arguments
* Better code and modules only in CFM-M4P-MUX
* Chaged cfml4 to cfm
* Update Sensor.php
* Update Sensor.php
* Better handling of scientific numbers
* Better handling of scientific numbers
* New test data
* Correction on handling trailing zeros
* Different way of cleaning the numbers based on Tony's input
* Audiocodes initial support (#9508)
* Create audiocodes family with very basic sensors
* audiocode polling php and test files
* audiocode polling php and test files
* audiocode test files
* audiocode cleaning
* tests with selective polling disabled
* GitHub test script updates (#9507)
* GitHub test script updates
add --reject to apply so it will skip binary files since GitHub does not create diffs for them correctly
Add new directories to the removal cleanup. Remove non-existant ones.
* Cleaner way to apply skip png files explicitly.
That way patches are still atomic.
* [UI] Fix last column of table (#9506)
* [UI] Fix last column of table
* move td outside of if and remove else
* Add Device Dragonwave Harmony Enhanced (#9499)
* Add Dragonwave Harmony Enhanced MC Device
* Remove single quote from null and 10 divisor
* Update and rename HarmonyEnhancedMc.php to HarmonyEnhanced.php
* Rename harmony-enhanced-mc.yaml to harmony-enhanced.yaml
* Update and rename harmony-enhanced-mc.yaml to harmony-enhanced.yaml
* Rename harmony-enhanced-mc.inc.php to harmony-enhanced.inc.php
* Rename harmony-enhanced-mc.snmprec to harmony-enhanced.snmprec
* Update HarmonyEnhanced.php
* Update HarmonyEnhanced.php
* Update HarmonyEnhanced.php
* Update HarmonyEnhanced.php
* More Code Climate Fixes
* Create harmony-enhanced.json
* Dynamic_discovery_get_value in can_skip_sensor to use all oids in skip_values (#9495)
* Use of dynamic_discovery_get_value in can_skip_sensor in order to use all available oids in skip_values
* Use LibreNMS\Device\YamlDiscovery code instead of keeping duplicated function can_skip_sensor
* Fix Travis errors
* Device management fall back to http if https isn't available.
Adds a slight delay on management clicking, may be blocked by popup blocker...
* Updated harmony OS poller to use multi get (#9525)
* docs: fix images doc (#9527)
There is no capital I in the password...
* fix error when location is missing from the DB (#9523)
* get geolocation at first poll (#9522)
* get geolocation at first poll
based on the logic of code, we will have to wait 2 days from adding new device for lat and lng to be updated
* Update Location.php
* Update Location.php
* Fixed Typo in YamlDiscovery.php (#9530)
Hi,
As far as I understand the code, it seems that array_reduce should be array_replace in this line, isn't it ?
PipoCanaja
DO NOT DELETE THIS TEXT
#### Please note
> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.
- [X] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)
#### Testers
If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`. If there are schema changes, you can ask on discord how to revert.
* Fixed alert log showing only green instead of all by default (#9529)
DO NOT DELETE THIS TEXT
#### Please note
> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.
- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)
#### Testers
If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`. If there are schema changes, you can ask on discord how to revert.
By default, when you access Alert History it was showing only OK (Green) ones instead of all. You had to hit filter to show them.
* Fixed customers page (#9521)
move customers table backend to Laravel
DO NOT DELETE THIS TEXT
#### Please note
> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.
- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)
#### Testers
If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`. If there are schema changes, you can ask on discord how to revert.
* Added detection if this is a git based install or not. (#9379)
Not sure about the warning or text.
DO NOT DELETE THIS TEXT
#### Please note
> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.
- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)
#### Testers
If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`. If there are schema changes, you can ask on discord how to revert.
* Change snmp-scan heading (#9492)
* Fixed plugins using d_echo (#9498)
Move d_echo to helpers.php and include in autoload
Don't remove from common.php yet to be extra safe.
* Use Eloquent for DB access
Move print-nac into nac.inc.php
Rename module to generic nac, If implemented for other OS later this can be extended but the name should be the same
Add items required for testing
* Use Eloquent for DB access
Move print-nac into nac.inc.php
Rename module to generic nac, If implemented for other OS later this can be extended but the name should be the same
Add items required for testing
* test github
* test github
* test git
* test git
* Added Network Access Control polling and store on DB
* Added Network Access Control polling and store on DB
* Added NAC tab on device page
* Added NAC tab on device page
* Added NAC tab page on device main page
* Added NAC tab page on device main page
* Fixed Auth ID data parsing
* Fixed Auth ID data parsing
* Filter Device ID on NAC Tab page
* Filter Device ID on NAC Tab page
* Converted IP Address form HEX to DEC format
* Converted IP Address form HEX to DEC format
* Formated grid on NAC print page
* Formated grid on NAC print page
* Added AuthC status
* Added AuthC status
* removed useless lines
* removed useless lines
* Fix some typos
* Fix some typos
* Fix Code Climate Issues
* Fix Code Climate Issues
* Fixed more Code Climate Issues
* Fixed more Code Climate Issues
* Fixed more Code Climate Issues
* Fixed more Code Climate Issues
* converted dbQuery() to dbUpdate()
* converted dbQuery() to dbUpdate()
* Fixed more Code Climate Issues
* Fixed more Code Climate Issues
* Removed Hex to Dec test codes
* Removed Hex to Dec test codes
* removed unused classes
* removed unused classes
* Change my own IP Hex to Dec conversion to IP::fromHexString Class
* Change my own IP Hex to Dec conversion to IP::fromHexString Class
* CLA Signature
* CLA Signature
* Merge all dbUpdate on only one call
* Merge all dbUpdate on only one call
* Replaced Table to Bootgrid
* Replaced Table to Bootgrid
* Converted Polling From Ports to New Module (cisco-nac)
* Converted Polling From Ports to New Module (cisco-nac)
* Fixing Travis CI and Code Climate Issues
* Fixing Travis CI and Code Climate Issues
* Fixing Travis CI and Code Climate More Issues
* Fixing Travis CI and Code Climate More Issues
* Replaced Other to Disabled on Metod Column
* Replaced Other to Disabled on Metod Column
* Removed Extra Character < on Authz Icon
* Removed Extra Character < on Authz Icon
* Improve the Logical Checking if Data Exist on DB
* Improve the Logical Checking if Data Exist on DB
* Replace dbFetchRows to dbFetchRow on Some Exist Checks
* Replace dbFetchRows to dbFetchRow on Some Exist Checks
* Fix Some Code Climate Issues
* Fix Some Code Climate Issues
* Fixed More Code Climate Issues
* Fixed More Code Climate Issues
* added CISCO-NAC-TC-MIB
* added CISCO-NAC-TC-MIB
* Use Eloquent for DB access
Move print-nac into nac.inc.php
Rename module to generic nac, If implemented for other OS later this can be extended but the name should be the same
Add items required for testing
* Use Eloquent for DB access
Move print-nac into nac.inc.php
Rename module to generic nac, If implemented for other OS later this can be extended but the name should be the same
Add items required for testing
* no way to set device attrib and no need...
* no way to set device attrib and no need...
* add db schema
* add db schema
* fix link in device page, links for ports
* fix link in device page, links for ports
* Use ajax for table
* Use ajax for table
* fix tests
* fix tests
* change the columns to find existing entries to port_id and PortAuthSessionDomain
* change the columns to find existing entries to port_id and PortAuthSessionDomain
* Update 274.sql
* Update 274.sql
* Reorder Columns on NAC Page to Better Presentation
* Reorder Columns on NAC Page to Better Presentation
* rename database columns and update schema
* rename database columns and update schema
* add iftype to test data, rename variable
* add iftype to test data, rename variable
* correct types...
* correct types...
* Update 274.sql
* Update 274.sql
* order capture output
* Add model observer for nicer discovery output
* Add copyright to poller module
* Handle multiAuth, multiDomain and normal modes seperatly for determining unique entries.
* Use mac_address as the unique identifier
* update index
* Improve the data variety a bit
* remove accidental schema
* Updated dlink support with additional health,mempools and processors
* Update dlink.inc.php
* Update dlink.inc.php
* Added test data
* add tests/data/dlink_dgs-1510-28.json
* actual data for the new items
Implemented in Laravel
Doesn't use legacy PHP session
Several widgets have new features and settings, for example:
- Multiple ports in one graph
- Maps settings are configurable and override system settings but default to system settings
- Graylog stream and/or device selection
- Much improved graph widget selection
- Many more
DO NOT DELETE THIS TEXT
#### Please note
> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.
- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)
#### Testers
If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`. If there are schema changes, you can ask on discord how to revert.
hopefully doesn't break anything
Mostly issues with snmp oids and options containing spaces. Try to remove all of those.
DO NOT DELETE THIS TEXT
#### Please note
> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.
- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)
#### Testers
If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`. If there are schema changes, you can ask on discord how to revert.
This will make the poller try to get the hardware platform from jnxBoxDescr.0, which gives a nice string without going to rewrites. As a fallback if that oid returns nothing, the rewrites.php file and related MIB have been updated with almost 300 other Juniper devices.
For example...
Before change: Juniper jnxProductQFX520032C32Q
After change: Juniper QFX5200-32C-32Q Switch
Fallback: Juniper QFX5200-32C-32Q
DO NOT DELETE THIS TEXT
#### Please note
> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.
- [ ] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)
#### Testers
If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`. If there are schema changes, you can ask on discord how to revert.
* Added Fortigate state sensors
* Added snmprec file
* Update fortigate.json
* Fix "awesome" ifHighSpeed implementation...
* Update fortigate.json
* better MAX_INT ifHighSpeed fix
* update for new ifType changes
* ifDescr is not used correctly like most fortinets
* Adding ifType to base_oids
* Improve discovery (update ifType) and polling (save ifType)
* Updated test data
* Updated json test data
* vlan isn't filtered by default :P
* With default ignored ports
* Update newer test data
* Update to Added support for HeliOS 10Ghz failover to 5Ghz state sensor
Converted /includes/discovery/sensors/state/helios.inc.php to yaml
Test units included
CLA has been signed
* Added support for CeraOS TX Mute Status state sensor, NTP Client Lock Status state sensor.
Updated CeraOS temperature sensor, now called from includes/definitions/discovery/ceraos.yaml - removed includes/discovery/sensors/temperature/ceraos.inc.php
Corrected issue with CeraOS temperature reverting to zero after polling (added a trailing . to the num_oid)
Amended includes/definitions/discovery/helios.yaml with changes as advised by Neil Lathwood and Tony Murray
* Added unit test data and corrected ceraos.yaml validation error
* Added support for Ceraos Wireless Sensors (php)
Cross Polar Interference
Wireless Frequency
Added Ceraos state sensors (yaml)
NTP Client Lock Status
Tx Mute Status
Radio Operational Status
Remote Radio Operational Status
IDU Temperature
Power Amplifier Temperature
* Fix up tests, etc
* remove helios changes, fix style
Not sure about the warning or text.
DO NOT DELETE THIS TEXT
#### Please note
> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.
- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)
#### Testers
If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`. If there are schema changes, you can ask on discord how to revert.
move customers table backend to Laravel
DO NOT DELETE THIS TEXT
#### Please note
> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.
- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)
#### Testers
If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`. If there are schema changes, you can ask on discord how to revert.
* Use of dynamic_discovery_get_value in can_skip_sensor in order to use all available oids in skip_values
* Use LibreNMS\Device\YamlDiscovery code instead of keeping duplicated function can_skip_sensor
* Fix Travis errors
* Create audiocodes family with very basic sensors
* audiocode polling php and test files
* audiocode polling php and test files
* audiocode test files
* audiocode cleaning
* tests with selective polling disabled
* Added support for SAF CFM L4 wireless device
* Added copyright statement according to LibreNMS documentation
* Added snmp test data and excluded some discover modules from os definition
* Style issue fixed
* More descriptive function
* MIB file rename
* Rename MIB file and change other files accordingly
* Added test data
* Removed debug statement
* Last checks
* Style changes
* Style changes
* Style changes
* Style changes
* Code restructure to make it more readable
* Fixed error in foreach
* Style issues
* Formatting of states within Yaml changed to make it more readable
* Omit default arguments
* Better code and modules only in CFM-M4P-MUX
* Chaged cfml4 to cfm
* Update Sensor.php
* Update Sensor.php
* Better handling of scientific numbers
* Better handling of scientific numbers
* New test data
* Correction on handling trailing zeros
* Different way of cleaning the numbers based on Tony's input
DO NOT DELETE THIS TEXT
#### Please note
> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.
- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)
#### Testers
If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`. If there are schema changes, you can ask on discord how to revert.
Changed the Temperature High threshold for a HPE Comware Switch to the values provided by snmp.
This means the actual threshold configured in the switch is used over any predefined/auto calculated thresholds by LibreNMS.
DO NOT DELETE THIS TEXT
#### Please note
> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.
- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)
#### Testers
If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`. If there are schema changes, you can ask on discord how to revert.
* Fix issues cause by new location and other misc
fix some queries so we return devices with null locations
remove unnecessary query of all ports on ports page lists
make locations menu available to non-admins for the legacy menu
fix a few issues with the old network-map
* fix graphs
* fix oxidized query
DO NOT DELETE THIS TEXT
#### Please note
> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.
- [X ] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)
#### Testers
If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`. If there are schema changes, you can ask on discord how to revert.
This has been running in two production networks for > 3 months without any issues.
- Fix location so it is a regular database relation (this allows multiple devices to be accurately linked to one location and saves api calls)
- Parse coordinates from the location more consistently
- Add settings to webui
- ~~Used [PHP Geocoder](http://geocoder-php.org/), which has lots of backends and is well tested. (also includes reverse and geoip)~~
- Google Maps, Bing, Mapquest, and OpenStreetMap supported initially.
- Default to OpenStreetMap, which doesn't require a key. They will liberally hand out bans if you exceed 1 query per second though.
- All other Geocoding APIs require an API key. (Google requires a credit card on file, but seems to be the most accurate)
- Update all (I think) sql queries to handle the new structure
- Remove final vestiges of override_sysLocation as a device attribute
- Update existing device groups and rules in DB
- Tested all APIs with good/bad location, no/bad/good key, and no connection.
- Cannot fix advanced queries that use location
This blocks #8868
DO NOT DELETE THIS TEXT
#### Please note
> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.
- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)
#### Testers
If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`. If there are schema changes, you can ask on discord how to revert.
DO NOT DELETE THIS TEXT
#### Please note
> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.
- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)
#### Testers
If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`. If there are schema changes, you can ask on discord how to revert.
* add the poller for portactivity
* add the ability to get monitor ports for portactivity
* add the graphs for displaying stuff for the portactivity app
* add the portactivity app page
* update the docs for Portactivity
* remove extra line
* minor doc update for Portactivity
* add update_application line
* convert to use json_app_get
* convert curly brackets to square
* style fix
* remote error, errorString, and version after they stop being important so they are not processed
* add alert rule examples
* add the poller for portactivity
* add the ability to get monitor ports for portactivity
* add the graphs for displaying stuff for the portactivity app
* add the portactivity app page
* update the docs for Portactivity
* remove extra line
* minor doc update for Portactivity
* add update_application line
* convert to use json_app_get
* convert curly brackets to square
* style fix
* remote error, errorString, and version after they stop being important so they are not processed
* add alert rule examples
* remove dump of get_portactivity_ports function added during rebase
* update to the current json_app_get
* add portactivity snmprec
* add the portactivity test data
* whoops bad merge when rebasing... fix
* minor formatting cleanup and add a missing comma
* fix some odditities with what one of the tests is doing
* whoops... include the use for the exception
* set the response to okay
* attempt to make snmpsim array check happy again
* the json now lints
* more making metric testing happy
* one more update to make travis-ci happy
* now flattens arrays also add array_flatten
* rename array_flatten to data_flatten as pre-commit chokes on it as laravel has something similarly named
* go through and properly add all the metrics
* tested with the newest one and it works
* whoops, clean up json and remove prototype that was used when putting it together
* doh! make it happy with laravel now
* see if a minor changing in formatting for the numbers makes the polling unit test happy
* order them properly
* remove a comma
* a few more minor fixes
* Added snmp_max_oid config at Os level.
* Added check for snmpv1 on multi_oid requests.
* Check device_oid_limit on multi get
* Use array_chunk
* Update snmp.inc.php
* remove dump, unused variable and extra plodes
* per device settings should take priority over OS
* Update Settings.md
* don't discard the data :P
* Add new sysDescr string for AlliedWare Plus products.
Release 5.4.8-2.1 of AlliedWare Plus will change the format of the
sysDescr string. This patch updates Allied Telesis yaml files to work with
this change.
Signed-off-by: Luuk Paulussen <luuk.paulussen@alliedtelesis.co.nz>
* save-test-data.php: Use correct variable for 'os' argument.
Signed-off-by: Luuk Paulussen <luuk.paulussen@alliedtelesis.co.nz>
* Create awplus_5.4.8-2.json
* Update awplus_5.4.8-2.json
* Check to see if a host exists in a lookup table to translate received name to what LibreNMS knows
* Added some documentation on how this is configured
* Use \LibreNMS\Config instead of accessing $config directly
* Fix codeclimate finding: Additional blank lines after USE statement
* murrant suggested a much cleaner way of doing this!
"1.3.6.1.4.1.207.1.4.128" is currently reporting as allied, when it should be reporting as radlan.
Refer to https://community.librenms.org/t/allied-telesis-discovery/6189/8
DO NOT DELETE THIS TEXT
#### Please note
> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.
- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)
#### Testers
If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`. If there are schema changes, you can ask on discord how to revert.
WebUI: added Traffic to the Windows OS overlib graph
DO NOT DELETE THIS TEXT
#### Please note
> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.
- [X] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)
#### Testers
If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`. If there are schema changes, you can ask on discord how to revert.
Require it explicitly. Makes it easier to understand and matches the style of other values
Questionable YAML changes (either broken before or now broken):
secureplatform: haStatCode
ptp600: receiveModulationMode
DO NOT DELETE THIS TEXT
#### Please note
> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.
- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)
#### Testers
If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`. If there are schema changes, you can ask on discord how to revert.
DO NOT DELETE THIS TEXT
#### Please note
> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.
- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)
#### Testers
If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`. If there are schema changes, you can ask on discord how to revert.
Fix code style check for https://github.com/librenms/librenms/pull/9438
DO NOT DELETE THIS TEXT
#### Please note
> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.
- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)
#### Testers
If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`. If there are schema changes, you can ask on discord how to revert.
DO NOT DELETE THIS TEXT
#### Please note
> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.
- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)
#### Testers
If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`. If there are schema changes, you can ask on discord how to revert.
DO NOT DELETE THIS TEXT
#### Please note
> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.
- [X] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)
#### Testers
If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`. If there are schema changes, you can ask on discord how to revert.
Tested on MX and EX series, works fine.
Skip slots that are empty and pull all sensors in jnxFruTable, data from old code is preserved.
The values in the $peer['c_update'][$oid] array are set only if they have
changed. If the value has not changed, then zero is substituted for real
values, which leads to incorrect calculation of delta values and records
in the database:
SELECT AcceptedPrefixes,AcceptedPrefixes_prev,AcceptedPrefixes_delta
FROM bgpPeers_cbgp
WHERE device_id=115;
| AcceptedPrefixes | AcceptedPrefixes_prev | AcceptedPrefixes_delta |
|------------------|-----------------------|------------------------|
| 21 | 21 | -21 |
DO NOT DELETE THIS TEXT
#### Please note
> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.
- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)
#### Testers
If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`. If there are schema changes, you can ask on discord how to revert.
