Commit Graph

5338 Commits

Author SHA1 Message Date
Tony Murray
00cd32f725 Device management fall back to http if https isn't available.
Adds a slight delay on management clicking, may be blocked by popup blocker...
2018-12-05 13:52:07 -06:00
Arjit Chaudhary
7788f93a57 [UI] Fix last column of table (#9506)
* [UI] Fix last column of table

* move td outside of if and remove else
2018-12-05 10:49:25 -06:00
PipoCanaja
3fc5ae6a24 Audiocodes initial support (#9508)
* Create audiocodes family with very basic sensors

* audiocode polling php and test files

* audiocode polling php and test files

* audiocode test files

* audiocode cleaning

* tests with selective polling disabled
2018-12-05 10:43:45 -06:00
Tony Murray
fc54718a5e
Focus and select location on override (#9503)
* Focus and select location on override

* Submit location on enter key
2018-12-05 07:33:32 -06:00
RobbFromIT
a0d7666b90 Added Comtrol device detection (#9491)
DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`.  If there are schema changes, you can ask on discord how to revert.
2018-12-05 11:16:52 +00:00
Tony Murray
095a4a024a
Add bing layer to leaflet (#9497)
Also, polyfill for IE used by both bing and google maps
2018-11-30 14:36:52 -06:00
Tony Murray
957ecc2441
Locations UI and editing (#9480)
* Better handling of errors
Mapquest seems to return the center of the US on error.......

* Editable locations WIP

* Change to bootgrid ajax table WIP

* Graphs working, using handlebars
update js libs
add current location button

* remove sql query, change icon

* Add the map to the device view, only when gps is expanded.
Allow edit on device page, share js code

* fix chevron rotation, improve click area

* extra warning

* fix overview layout (remove containers)

* fix style

* fix html divs, change collapse ui a bit
move css, update css/js versions

* start zoomed out on new locations

* don't double load scripts, zoom to 17

* fix php-md errors, remove unused use statement

* improve non-admin experience

* Move locations page to Laravel
More functions in Url and Html util classes
reduce code duplication

* translation buttons too

* fix whitespace

* move formatters to the frontend

* small changes

* disable traffic for locations with no devices

* change down 0 to green from gray

* missing "

* Fix paginate all

* working fix for paginate all

* allow sort by counts

* fix down sort

* a little safety

* Don't call the function twice

* btn-xs
2018-11-29 19:23:40 -06:00
Tony Murray
7c4fac489a
Fix issues cause by new location and other misc (#9490)
* Fix issues cause by new location and other misc
fix some queries so we return devices with null locations
remove unnecessary query of all ports on ports page lists
make locations menu available to non-admins for the legacy menu
fix a few issues with the old network-map

* fix graphs

* fix oxidized query
2018-11-29 13:04:11 -06:00
Peter Hansen
8509c94ebf Fix for #9485 (#9486)
* Fix for #9485

* Update ajax_search.php
2018-11-29 08:58:01 +00:00
Anders Lowinger
edcafadf22 Added support for Waystream products (#9481)
DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [X ] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`.  If there are schema changes, you can ask on discord how to revert.

This has been running in two production networks for > 3 months without any issues.
2018-11-28 23:12:11 +00:00
Maikel de Boer
db1fa8c33e Added Aprisa support (#9435)
* Created 4RF Aprisa XE support

* Made requesed change by @laf

* cleanup

* Fix sensor index and add test data
2018-11-28 23:09:02 +00:00
Tony Murray
3e35ee0e7d Refactored and update Location Geocoding (#9359)
- Fix location so it is a regular database relation (this allows multiple devices to be accurately linked to one location and saves api calls)
- Parse coordinates from the location more consistently
- Add settings to webui
- ~~Used [PHP Geocoder](http://geocoder-php.org/), which has lots of backends and is well tested. (also includes reverse and geoip)~~
- Google Maps, Bing, Mapquest, and OpenStreetMap supported initially.
- Default to OpenStreetMap, which doesn't require a key.  They will liberally hand out bans if you exceed 1 query per second though.
- All other Geocoding APIs require an API key. (Google requires a credit card on file, but seems to be the most accurate)
- Update all (I think) sql queries to handle the new structure
- Remove final vestiges of override_sysLocation as a device attribute
- Update existing device groups and rules in DB
- Tested all APIs with good/bad location, no/bad/good key, and no connection.
- Cannot fix advanced queries that use location

This blocks #8868

DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`.  If there are schema changes, you can ask on discord how to revert.
2018-11-28 22:49:18 +00:00
Arjit Chaudhary
9a5ac514a5 order by sensor_descr aswell (#9478)
Sort sensors by sensor_descr
2018-11-27 21:30:08 -06:00
Anders Lowinger
36ea8a043e Fix do not include template text in HTML page (#9476) 2018-11-26 09:52:18 -06:00
VVelox
c5bb60907c add app for getting status of TCP connections for specified services (#8090)
* add the poller for portactivity

* add the ability to get monitor ports for portactivity

* add the graphs for displaying stuff for the portactivity app

* add the portactivity app page

* update the docs for Portactivity

* remove extra line

* minor doc update for Portactivity

* add update_application line

* convert to use json_app_get

* convert curly brackets to square

* style fix

* remote error, errorString, and version after they stop being important so they are not processed

* add alert rule examples

* add the poller for portactivity

* add the ability to get monitor ports for portactivity

* add the graphs for displaying stuff for the portactivity app

* add the portactivity app page

* update the docs for Portactivity

* remove extra line

* minor doc update for Portactivity

* add update_application line

* convert to use json_app_get

* convert curly brackets to square

* style fix

* remote error, errorString, and version after they stop being important so they are not processed

* add alert rule examples

* remove dump of get_portactivity_ports function added during rebase

* update to the current json_app_get

* add portactivity snmprec

* add the portactivity test data

* whoops bad merge when rebasing... fix

* minor formatting cleanup and add a missing comma

* fix some odditities with what one of the tests is doing

* whoops... include the use for the exception

* set the response to okay

* attempt to make snmpsim array check happy again

* the json now lints

* more making metric testing happy

* one more update to make travis-ci happy

* now flattens arrays also add array_flatten

* rename array_flatten to data_flatten as pre-commit chokes on it as laravel has something similarly named

* go through and properly add all the metrics

* tested with the newest one and it works

* whoops, clean up json and remove prototype that was used when putting it together

* doh! make it happy with laravel now

* see if a minor changing in formatting for the numbers makes the polling unit test happy

* order them properly

* remove a comma

* a few more minor fixes
2018-11-22 09:05:38 -06:00
lewisvive
f3eb778db2 Add support for Firebrick Hardware (#9403)
* Added support for Firebrick devices

* Added support for Firebrick devices

* Update firebrick.inc.php

* Update firebrick.inc.php

* Update firebrick.svg

* Update firebrick.svg

* Added SNMP Check

* Added SVG View Box

* Display XML in config tab

* Update firebrick.svg

* Update firebrick.yaml

* Update showconfig.inc.php

* Create firebrick.json
2018-11-21 13:53:16 -06:00
Tony Murray
ec69150099 Filter email options based on backend in Alert settings (#9461)
DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`.  If there are schema changes, you can ask on discord how to revert.
2018-11-19 21:04:33 +00:00
Neil Lathwood
ceea9d4981 Added ability to record traceroutes for devices down due to ICMP (#9457)
* Added ability to record traceroutes for devices down due to ICMP

* Update Templates.md

* Updated schema

* Update dev-overview-data.inc.php
2018-11-19 09:58:59 -06:00
Misha Komarovskiy
4efb95e059 Added resources/links and devices/hostname/links API calls for xDP (#9444)
* api: Add list_links and get_link api calls

Signed-off-by: Misha Komarovskiy <zombah@gmail.com>

* api: Add get_links api call

Signed-off-by: Misha Komarovskiy <zombah@gmail.com>
2018-11-19 14:36:23 +00:00
Neil Lathwood
93433ce4b1 Fixed altering transport mapping in rules clearing all mappings (#9455) 2018-11-18 22:41:52 -06:00
Neil Lathwood
b93e66efbe
Show visually in webui + cli when using deprecated templates or transports (#9413)
* Show visually in webui + cli when using deprecated templates or transports

* Fixed query
2018-11-10 21:06:51 +00:00
Tony Murray
f439eb4f1d Disable page refresh on health sensors pages, autorefresh most tables (#9386)
* Disable page refresh on health sensors pages
Refresh all bootgrid tables every 5 minutes

* Update legacy_index.php

* Update librenmsv1.blade.php
2018-11-08 22:29:20 +00:00
Jellyfrog
40a84b5131 Show port description and dns name in FDB table (#9370)
- Added Port Description field to FDB Table
- Added DNS Name field to FDB Table
- Fixed sorting by port in FDB Table

DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`.  If there are schema changes, you can ask on discord how to revert.
2018-11-08 22:08:39 +00:00
Rémy Jacquin
d736adc289 Added alerts schedule notes into device notes (#9258)
* Add alerts schedule notes into device notes

Signed-off-by: Rémy Jacquin <remy@remyj.fr>

* Update preferences.inc.php
2018-11-08 22:01:45 +00:00
Rémy Jacquin
4e8acdd894 Added ability to sort alert schedules by status (#9257)
Signed-off-by: Rémy Jacquin <remy@remyj.fr>
2018-11-05 08:10:27 +00:00
Neil Lathwood
4bdfc8e241
Fix edit user (#9402)
DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`.  If there are schema changes, you can ask on discord how to revert.
2018-10-30 23:30:39 +00:00
VirTechSystems
b8cf24c30e Allow 6 or 12 icons across on server stats widget (#9408)
DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [ ] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`.  If there are schema changes, you can ask on discord how to revert.
2018-10-30 23:17:23 +00:00
PipoCanaja
3a5d64e268 Updated edituser page with new Auth system (#9313)
* Edit users in AD auth

* Edit users in AD auth

* Edit users in AD auth

* Edit users in AD auth

* changes as suggested
2018-10-29 20:41:50 +00:00
Tony Murray
0ec8f18459 Graph of overall poller performance (#9381)
* Graph definitions

* Stacked.

* Add display

* remove old poll-log, add redirect

* Handle undefined data in graphs

* Standard pollers

* Change doc to send to the global poller module page.

* remove test code :)

* Link parent menu
2018-10-26 21:04:30 +01:00
JohnSPeach
03e8bd743e Allow F5 APM graphs to display automatically (#9377)
* Update f5.inc.php

RRD file needs to be named bigip_apm_sessions for the graph to automatically appear.

* Update and rename bigip_apm_curr_sessions.inc.php to bigip_apm_sessions.inc.php

It seems that both this file and the RRD file need to be named bigip_apm_sessions for the graphs to appear automatically

* Create 270.sql

Missed this from the original pull request - the graph has to be named bigip_apm_sessions to automatically display
2018-10-25 15:39:45 -05:00
CrazyMax
00b752a862 Redesign alert template modal (#9364)
* Redesign alert template modal

* Check if alert is used in an other template

* Fix selectbox while creating new template

* Use 'pre' font family for alert template textarea

* Remove limit

* Remove and try to mimic bootstrap-select with select2 lib
2018-10-25 15:31:12 -05:00
Jellyfrog
a31f477290 Show device "features" in correct column (#9366) 2018-10-25 05:58:04 -05:00
Jellyfrog
ef13cd24e8 Optimize images for Webui (#9369)
DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`.  If there are schema changes, you can ask on discord how to revert.
2018-10-23 22:29:45 +01:00
Tony Murray
1d4607f33f
Fix ray raster image in svg (#9371)
* fix-ray-image

* Include svg tests in os group

* update test data
2018-10-23 11:32:44 -05:00
jozefrebjak
d111bd95f9 Improved support for Racom Ray radios (#9279)
* update os polling for ray

I changed hardware detection, because in old format i got a hostname instead of hardware. I added features tab also.

* Added wireless rate sensors

I added sensors for Netbitrate and Maxbirate

* deleted old ray.png

* added better resolution logo for ray

* Update Ray.php

* Delete ray.png

* Add files via upload

* Delete ray.svg

* added ray.svg logo

* update ray.snmprec

* Update Ray.php

* Updated json test data

* added state support for RAy Radios

* Update ray.snmprec
2018-10-22 17:26:19 -05:00
VirTechSystems
3fcf51d177 Added support for ip to sysName option in csv export and graphs (#9352)
* Update html/includes/common/server-stats.inc.php

allow 6 icons wide on server stats

* sysname to ip config following

follow ip to sysname config option on csv export and graphs

* Revert "Update html/includes/common/server-stats.inc.php"

This reverts commit db10e46f04.

* formatting

* syntax fix

too many brackets

* Update html/includes/graphs/multiport/bits_separate.inc.php

bad tab

* format_hostname

Use format_hostname to resolve the sysname.

* Update bits_separate.inc.php
2018-10-22 21:58:36 +01:00
TheGreatDoc
f8ec6c51b6
Merge pull request #9354 from laf/alert-settings-reorg
Reorg the alert settings page to show what options are deprecated
2018-10-21 21:30:02 +02:00
angryp
0cf11b02d3 Removed redundant grouping from SQL query in FDB Search (#9338) 2018-10-21 20:03:35 +01:00
Neil Lathwood
654411aae2
Update alerting.inc.php 2018-10-21 20:00:05 +01:00
laf
1d207ec943 Renamed section from Transport -> options 2018-10-19 22:13:11 +01:00
laf
e7ed9b7d35 Reorg the alert settings page to show what options are deprecated 2018-10-19 22:01:35 +01:00
Tony Murray
607a567090
Don't check file permissions on every request, handle failures (#9264)
* Don't check file permissions on every request, handle failures
Improve error page visually

* only print minimal mkdir

* invert file_exists check, whoops

* docblock

* revert accidental changes

* rename variable

* Change database errors to use the new layout

* Add support url to the default layout

* Replaced \n for && in fix for user perms

* fix web output
2018-10-18 21:08:46 -05:00
Andy Rosen
4e5a0fa4d7 Added Twilio SMS as an Alerting Transport (#9305)
DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`.  If there are schema changes, you can ask on discord how to revert.
2018-10-17 17:19:28 +01:00
JohnSPeach
001d7d7643 Added F5 APM current sessions graphing (#9334)
DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [ ] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`.  If there are schema changes, you can ask on discord how to revert.

While this creates the graphs under Apm for the F5s, there is no data. I can pull the data manually. Maybe I have the definition incorrect in includes/polling/os/f5.inc.php?

snmpget -m /opt/librenms/mibs/f5/F5-BIGIP-APM-MIB -v 3 -u <user> -l authPriv -a SHA -A  <password> -x AES -X <password> <server>  apmAccessStatCurrentActiveSessions.0
F5-BIGIP-APM-MIB::apmAccessStatCurrentActiveSessions.0 = Wrong Type (should be Counter64): Gauge32: 1245

or maybe it's because the OID has the incorrect type in it, although the result is actually correct.
2018-10-17 17:16:52 +01:00
PipoCanaja
417e518ae2 Oxidized list now checks device permission based on user (#9331)
* webui: display only devices that the user is allowed to view in oxidized node list, and explain why some devices known in oxidized are not displayed because unknown in LibreNMS

* webui: display only devices that the user is allowed to view in oxidized node list, and explain why some devices known in oxidized are not displayed because unknown in LibreNMS (CodeClimate)
2018-10-17 17:12:24 +01:00
Tony Murray
10432b1764 Escape services commands properly. (#9269)
* Attempt to escape services commands properly.

* Add LC_NUMERIC="C" back

* Updated create-service to only faily if a dbUpdate fails
2018-10-17 16:46:07 +01:00
TheGreatDoc
4a23f8dddd Fixed search & device eventlog (#9329)
DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`.  If there are schema changes, you can ask on discord how to revert.

In #9252 search box and inside device eventlog where broken.

Noticed in https://community.librenms.org/t/bug-set-filter-in-device-eventlog-shows-filtered-events-from-all-devices/5633

I hope my fix does the job :)
2018-10-17 08:44:04 +01:00
TheGreatDoc
1dfa7975c9 Added support for Glass Way EYDFA WDM Optical Amplifier (#9125)
DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`

NOTE: Those devices come all with same `sysName` so `$config['allow_duplicate_sysName'] = true;` is needed to have more than 1 working.
2018-10-12 22:37:08 +01:00
cchance27
dd39a1ab03 Allow zoom to be decimal and switch zoomSnap to 0.1 for World map (#9259)
Allow 1 decimal place for initial zoom and lower zoom snap interval to improve initial zoom in widgets.

DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`.  If there are schema changes, you can ask on discord how to revert.
2018-10-06 23:08:11 +01:00
Tony Murray
7c09f698a4 Don't call to legacy auth to get dashboards. (#9297)
Can cause a lot of ldap calls for example.
Should improve dashboard page load time on certain auth methods.

DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`.  If there are schema changes, you can ask on discord how to revert.
2018-10-06 22:56:22 +01:00